From: Sarah Hoffmann Date: Sun, 19 Aug 2018 16:09:03 +0000 (+0200) Subject: Merge remote-tracking branch 'upstream/master' X-Git-Tag: deploy~312 X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/6f383d6073b68409e8da243356eccf5e2847f264?hp=141b32f4192819579adbc1388a90ba92d47485e6 Merge remote-tracking branch 'upstream/master' --- diff --git a/lib/ReverseGeocode.php b/lib/ReverseGeocode.php index 0500df93..681403a1 100644 --- a/lib/ReverseGeocode.php +++ b/lib/ReverseGeocode.php @@ -117,7 +117,7 @@ class ReverseGeocode $sSQL .= ' AND class = \'place\' AND type != \'postcode\''; $sSQL .= ' AND name IS NOT NULL '; $sSQL .= ' and indexed_status = 0 and linked_place_id is null'; - $sSQL .= ' AND ST_DWithin('.$sPointSQL.', geometry, 5.0)) p '; + $sSQL .= ' AND ST_DWithin('.$sPointSQL.', geometry, 1.8)) p '; $sSQL .= 'WHERE distance <= reverse_place_diameter(rank_search)'; $sSQL .= ' ORDER BY rank_search DESC, distance ASC'; $sSQL .= ' LIMIT 1'; diff --git a/osm2pgsql b/osm2pgsql index 759657e1..93b73e5f 160000 --- a/osm2pgsql +++ b/osm2pgsql @@ -1 +1 @@ -Subproject commit 759657e11bbf10bbd305102f659ce8288ee04e7d +Subproject commit 93b73e5f5c3b20e80027ecf272f553d26f49f2e8 diff --git a/test/php/Nominatim/SearchContextTest.php b/test/php/Nominatim/SearchContextTest.php index 2a74dc41..db0b2dee 100644 --- a/test/php/Nominatim/SearchContextTest.php +++ b/test/php/Nominatim/SearchContextTest.php @@ -50,4 +50,34 @@ class SearchContextTest extends \PHPUnit_Framework_TestCase $this->oCtx->distanceSQL('foo') ); } + + public function testSetViewboxFromBox() + { + $viewbox = array(30, 20, 40, 50); + $this->oCtx->setViewboxFromBox($viewbox, true); + $this->assertEquals( + 'ST_SetSRID(ST_MakeBox2D(ST_Point(30.000000,20.000000),ST_Point(40.000000,50.000000)),4326)', + $this->oCtx->sqlViewboxSmall + ); + // height: 10 + // width: 30 + $this->assertEquals( + 'ST_SetSRID(ST_MakeBox2D(ST_Point(50.000000,80.000000),ST_Point(20.000000,-10.000000)),4326)', + $this->oCtx->sqlViewboxLarge + ); + + + $viewbox = array(-1.5, -2, 1.5, 2); + $this->oCtx->setViewboxFromBox($viewbox, true); + $this->assertEquals( + 'ST_SetSRID(ST_MakeBox2D(ST_Point(-1.500000,-2.000000),ST_Point(1.500000,2.000000)),4326)', + $this->oCtx->sqlViewboxSmall + ); + // height: 3 + // width: 4 + $this->assertEquals( + 'ST_SetSRID(ST_MakeBox2D(ST_Point(4.500000,6.000000),ST_Point(-4.500000,-6.000000)),4326)', + $this->oCtx->sqlViewboxLarge + ); + } }