From: Sarah Hoffmann <lonvia@denofr.de>
Date: Tue, 4 Oct 2016 18:34:34 +0000 (+0200)
Subject: Merge remote-tracking branch 'upstream/master'
X-Git-Tag: deploy~420
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/84b976f9063129728ca12a5537900bdbf97fafa1?ds=inline;hp=-c

Merge remote-tracking branch 'upstream/master'
---

84b976f9063129728ca12a5537900bdbf97fafa1
diff --combined lib/Geocode.php
index 54e738ff,cf05df12..4ed90dc2
--- a/lib/Geocode.php
+++ b/lib/Geocode.php
@@@ -24,7 -24,7 +24,7 @@@ class Geocod
  
      protected $aExcludePlaceIDs = array();
      protected $bDeDupe = true;
 -    protected $bReverseInPlan = false;
 +    protected $bReverseInPlan = true;
  
      protected $iLimit = 20;
      protected $iFinalLimit = 10;
@@@ -252,7 -252,7 +252,7 @@@
                      $aCountries[] = strtolower($sCountryCode);
                  }
              }
-             if (isset($aCountryCodes))
+             if (isset($aCountries))
                  $this->aCountryCodes = $aCountries;
          }
  
@@@ -1152,20 -1152,19 +1152,20 @@@
                          // TODO: filter out the pointless search terms (2 letter name tokens and less)
                          // they might be right - but they are just too darned expensive to run
                          if (sizeof($aSearch['aName'])) $aTerms[] = "name_vector @> ARRAY[".join($aSearch['aName'], ",")."]";
 -                        if (sizeof($aSearch['aNameNonSearch'])) $aTerms[] = "array_cat(name_vector,ARRAY[]::integer[]) @> ARRAY[".join($aSearch['aNameNonSearch'], ",")."]";
 +                        //if (sizeof($aSearch['aNameNonSearch'])) $aTerms[] = "array_cat(name_vector,ARRAY[]::integer[]) @> ARRAY[".join($aSearch['aNameNonSearch'], ",")."]";
                          if (sizeof($aSearch['aAddress']) && $aSearch['aName'] != $aSearch['aAddress']) {
                              // For infrequent name terms disable index usage for address
                              if (CONST_Search_NameOnlySearchFrequencyThreshold
                                  && sizeof($aSearch['aName']) == 1
                                  && $aWordFrequencyScores[$aSearch['aName'][reset($aSearch['aName'])]] < CONST_Search_NameOnlySearchFrequencyThreshold
                              ) {
 -                                $aTerms[] = "array_cat(nameaddress_vector,ARRAY[]::integer[]) @> ARRAY[".join(array_merge($aSearch['aAddress'], $aSearch['aAddressNonSearch']), ",")."]";
 +                                //$aTerms[] = "array_cat(nameaddress_vector,ARRAY[]::integer[]) @> ARRAY[".join(array_merge($aSearch['aAddress'], $aSearch['aAddressNonSearch']), ",")."]";
 +                                $aTerms[] = "array_cat(nameaddress_vector,ARRAY[]::integer[]) @> ARRAY[".join($aSearch['aAddress'],",")."]";
                              } else {
                                  $aTerms[] = "nameaddress_vector @> ARRAY[".join($aSearch['aAddress'], ",")."]";
 -                                if (sizeof($aSearch['aAddressNonSearch'])) {
 +                                /*if (sizeof($aSearch['aAddressNonSearch'])) {
                                      $aTerms[] = "array_cat(nameaddress_vector,ARRAY[]::integer[]) @> ARRAY[".join($aSearch['aAddressNonSearch'], ",")."]";
 -                                }
 +                                }*/
                              }
                          }
                          if ($aSearch['sCountryCode']) $aTerms[] = "country_code = '".pg_escape_string($aSearch['sCountryCode'])."'";
diff --combined sql/functions.sql
index 609d46c9,949e4cae..b086786a
--- a/sql/functions.sql
+++ b/sql/functions.sql
@@@ -2343,7 -2343,7 +2343,7 @@@ BEGI
  
    IF for_place_id IS NULL THEN
      select parent_place_id, calculated_country_code, housenumber, rank_search, postcode, name, class, type from placex 
-       WHERE place_id = in_place_id and rank_address = 30 
+       WHERE place_id = in_place_id and  rank_search > 27
        INTO for_place_id, searchcountrycode, searchhousenumber, searchrankaddress, searchpostcode, searchhousename, searchclass, searchtype;
    END IF;
  
@@@ -2399,7 -2399,7 +2399,7 @@@
        CASE WHEN class = 'place' and type = 'postcode' THEN hstore('name', postcode) ELSE name END as name,
        CASE WHEN extratags ? 'place' THEN 'place' ELSE class END as class,
        CASE WHEN extratags ? 'place' THEN extratags->'place' ELSE type END as type,
 -      admin_level, fromarea, isaddress,
 +      admin_level, fromarea, isaddress and linked_place_id is NULL as isaddress,
        CASE WHEN address_place_id = for_place_id AND rank_address = 0 THEN 100 WHEN rank_address = 11 THEN 5 ELSE rank_address END as rank_address,
        distance,calculated_country_code,postcode
        from place_addressline join placex on (address_place_id = placex.place_id) 
diff --combined tests/features/api/regression.feature
index ba8cca9b,34603aec..5b7f10ad
--- a/tests/features/api/regression.feature
+++ b/tests/features/api/regression.feature
@@@ -178,7 -178,7 +178,7 @@@ Feature: API regression test
       Scenario: trac #5238
          Given the request parameters
           | bounded | viewbox
 -         | 1       | 0,0,-1,-1
 +         | 1       | 0,0,1,-1
          When sending json search query "sy"
          Then exactly 0 results are returned
  
@@@ -207,3 -207,11 +207,11 @@@
           | osm_type   | osm_id     | latlon
           | node       | 257363453  | 35.8404121,128.5586643 +-100m
  
+     Scenario: trac #5427
+         Given the request parameters
+          | countrycodes |
+          | DE           |
+         When sending json search query "12345" with address
+         Then result addresses contain
+          | country_code |
+          | de           |