From: Sarah Hoffmann <lonvia@denofr.de>
Date: Wed, 6 Jul 2022 09:33:07 +0000 (+0200)
Subject: remove analyze() from PlaceInfo class
X-Git-Tag: v4.1.0~15^2
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/856925d19bcf01b0f29a99afc4f673eadd09a143?hp=-c

remove analyze() from PlaceInfo class

The function creates circular dependencies.
---

856925d19bcf01b0f29a99afc4f673eadd09a143
diff --git a/nominatim/data/place_info.py b/nominatim/data/place_info.py
index 87ecb731..d2ba3979 100644
--- a/nominatim/data/place_info.py
+++ b/nominatim/data/place_info.py
@@ -9,8 +9,6 @@ Wrapper around place information the indexer gets from the database and hands to
 the tokenizer.
 """
 
-import psycopg2.extras
-
 class PlaceInfo:
     """ Data class containing all information the tokenizer gets about a
         place it should process the names for.
@@ -20,13 +18,6 @@ class PlaceInfo:
         self._info = info
 
 
-    def analyze(self, analyzer):
-        """ Process this place with the given tokenizer and return the
-            result in psycopg2-compatible Json.
-        """
-        return psycopg2.extras.Json(analyzer.process_place(self))
-
-
     @property
     def name(self):
         """ A dictionary with the names of the place or None if the place
diff --git a/nominatim/indexer/runners.py b/nominatim/indexer/runners.py
index 21b6a44d..c8495ee4 100644
--- a/nominatim/indexer/runners.py
+++ b/nominatim/indexer/runners.py
@@ -11,6 +11,7 @@ tasks.
 import functools
 
 from psycopg2 import sql as pysql
+import psycopg2.extras
 
 from nominatim.data.place_info import PlaceInfo
 
@@ -19,6 +20,8 @@ from nominatim.data.place_info import PlaceInfo
 def _mk_valuelist(template, num):
     return pysql.SQL(',').join([pysql.SQL(template)] * num)
 
+def _analyze_place(place, analyzer):
+    return psycopg2.extras.Json(analyzer.process_place(PlaceInfo(place)))
 
 class AbstractPlacexRunner:
     """ Returns SQL commands for indexing of the placex table.
@@ -56,7 +59,7 @@ class AbstractPlacexRunner:
         for place in places:
             for field in ('place_id', 'name', 'address', 'linked_place_id'):
                 values.append(place[field])
-            values.append(PlaceInfo(place).analyze(self.analyzer))
+            values.append(_analyze_place(place, self.analyzer))
 
         worker.perform(self._index_sql(len(places)), values)
 
@@ -150,7 +153,7 @@ class InterpolationRunner:
         values = []
         for place in places:
             values.extend((place[x] for x in ('place_id', 'address')))
-            values.append(PlaceInfo(place).analyze(self.analyzer))
+            values.append(_analyze_place(place, self.analyzer))
 
         worker.perform(self._index_sql(len(places)), values)
 
diff --git a/nominatim/tools/tiger_data.py b/nominatim/tools/tiger_data.py
index 9903ea2b..e78dcd8f 100644
--- a/nominatim/tools/tiger_data.py
+++ b/nominatim/tools/tiger_data.py
@@ -13,6 +13,8 @@ import logging
 import os
 import tarfile
 
+from psycopg2.extras import Json
+
 from nominatim.db.connection import connect
 from nominatim.db.async_connection import WorkerPool
 from nominatim.db.sql_preprocessor import SQLPreprocessor
@@ -87,7 +89,7 @@ def handle_threaded_sql_statements(pool, fd, analyzer):
             address = dict(street=row['street'], postcode=row['postcode'])
             args = ('SRID=4326;' + row['geometry'],
                     int(row['from']), int(row['to']), row['interpolation'],
-                    PlaceInfo({'address': address}).analyze(analyzer),
+                    Json(analyzer.process_place(PlaceInfo({'address': address}))),
                     analyzer.normalize_postcode(row['postcode']))
         except ValueError:
             continue