From: marc tobias <mtmail@gmx.net>
Date: Mon, 4 Jul 2022 21:52:36 +0000 (+0200)
Subject: In tests for PHP 8 disable Just-in-time, it conflicts with tools that determine coverage
X-Git-Tag: v4.1.0~13^2
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/c70ca7f57bb40c2807e0149156be9b305c743321?hp=a6dab5e300de9c5664f714eb2c9290d18f01067f

In tests for PHP 8 disable Just-in-time, it conflicts with tools that determine coverage
---

diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml
index e3a01aa0..53b76a03 100644
--- a/.github/workflows/ci-tests.yml
+++ b/.github/workflows/ci-tests.yml
@@ -70,6 +70,7 @@ jobs:
               with:
                   php-version: ${{ matrix.php }}
                   tools: phpunit, phpcs, composer
+                  ini-values: opcache.jit=disable
 
             - uses: actions/setup-python@v2
               with:
diff --git a/test/python/tools/test_exec_utils.py b/test/python/tools/test_exec_utils.py
index 78650180..26ea92b2 100644
--- a/test/python/tools/test_exec_utils.py
+++ b/test/python/tools/test_exec_utils.py
@@ -122,7 +122,13 @@ class TestRunApiScript:
 
     @staticmethod
     def test_fail_on_error_output(tmp_path):
-        (tmp_path / 'website' / 'bad.php').write_text("<?php\nfwrite(STDERR, 'WARNING'.PHP_EOL);")
+        # Starting PHP 8 the PHP CLI no longer has STDERR defined as constant
+        php = """
+        <?php
+        if(!defined('STDERR')) define('STDERR', fopen('php://stderr', 'wb'));
+        fwrite(STDERR, 'WARNING'.PHP_EOL);
+        """
+        (tmp_path / 'website' / 'bad.php').write_text(php)
 
         assert exec_utils.run_api_script('bad', tmp_path) == 1