From: Sarah Hoffmann Date: Fri, 23 Feb 2018 20:59:42 +0000 (+0100) Subject: Merge pull request #940 from mtmail/phpcs-deep-levels X-Git-Tag: v3.2.0~124 X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/c8359181237a3b145ac48b5e58098b36674cd89f?hp=ff2a40b109f7431c810610c2c350881d07e358e4 Merge pull request #940 from mtmail/phpcs-deep-levels phpcs deep levels --- diff --git a/.travis.yml b/.travis.yml index 5efc9f08..c67f155e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,7 +22,7 @@ script: - if [[ $TEST_SUITE == "monaco" ]]; then ./utils/specialphrases.php --wiki-import | psql -d test_api_nominatim >/dev/null; fi - cd $TRAVIS_BUILD_DIR/test/php - if [[ $TEST_SUITE == "tests" ]]; then phpunit ./ ; fi - - if [[ $TEST_SUITE == "tests" ]]; then phpcs --report-width=120 */**.php ; fi + - if [[ $TEST_SUITE == "tests" ]]; then phpcs --report-width=120 . ; fi - cd $TRAVIS_BUILD_DIR/test/bdd - # behave --format=progress3 api - if [[ $TEST_SUITE == "tests" ]]; then behave --format=progress3 db ; fi diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a00d0ed3..dc5be190 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -82,7 +82,7 @@ are in process of consolodating the style. The following rules apply: The coding style is enforced with PHPCS and can be tested with: ``` - phpcs --report-width=120 --colors */**.php + phpcs --report-width=120 --colors . ``` ## Testing diff --git a/lib/template/address-json.php b/lib/template/address-json.php index 93abb601..cea87745 100644 --- a/lib/template/address-json.php +++ b/lib/template/address-json.php @@ -2,20 +2,15 @@ $aFilteredPlaces = array(); -if (!sizeof($aPlace)) -{ +if (!sizeof($aPlace)) { if (isset($sError)) $aFilteredPlaces['error'] = $sError; - else - $aFilteredPlaces['error'] = 'Unable to geocode'; -} -else -{ + else $aFilteredPlaces['error'] = 'Unable to geocode'; +} else { if (isset($aPlace['place_id'])) $aFilteredPlaces['place_id'] = $aPlace['place_id']; - $aFilteredPlaces['licence'] = "Data © OpenStreetMap contributors, ODbL 1.0. https://osm.org/copyright"; + $aFilteredPlaces['licence'] = 'Data © OpenStreetMap contributors, ODbL 1.0. https://osm.org/copyright'; $sOSMType = formatOSMType($aPlace['osm_type']); - if ($sOSMType) - { + if ($sOSMType) { $aFilteredPlaces['osm_type'] = $sOSMType; $aFilteredPlaces['osm_id'] = $aPlace['osm_id']; } @@ -26,31 +21,25 @@ else if (isset($aPlace['sExtraTags'])) $aFilteredPlaces['extratags'] = $aPlace['sExtraTags']; if (isset($aPlace['sNameDetails'])) $aFilteredPlaces['namedetails'] = $aPlace['sNameDetails']; - if (isset($aPlace['aBoundingBox'])) - { + if (isset($aPlace['aBoundingBox'])) { $aFilteredPlaces['boundingbox'] = $aPlace['aBoundingBox']; } - if (isset($aPlace['asgeojson'])) - { + if (isset($aPlace['asgeojson'])) { $aFilteredPlaces['geojson'] = json_decode($aPlace['asgeojson']); } - if (isset($aPlace['assvg'])) - { + if (isset($aPlace['assvg'])) { $aFilteredPlaces['svg'] = $aPlace['assvg']; } - if (isset($aPlace['astext'])) - { + if (isset($aPlace['astext'])) { $aFilteredPlaces['geotext'] = $aPlace['astext']; } - if (isset($aPlace['askml'])) - { + if (isset($aPlace['askml'])) { $aFilteredPlaces['geokml'] = $aPlace['askml']; } } javascript_renderData($aFilteredPlaces); - diff --git a/lib/template/address-jsonv2.php b/lib/template/address-jsonv2.php index 229303be..399c978f 100644 --- a/lib/template/address-jsonv2.php +++ b/lib/template/address-jsonv2.php @@ -2,20 +2,15 @@ $aFilteredPlaces = array(); -if (!sizeof($aPlace)) -{ +if (!sizeof($aPlace)) { if (isset($sError)) $aFilteredPlaces['error'] = $sError; - else - $aFilteredPlaces['error'] = 'Unable to geocode'; -} -else -{ + else $aFilteredPlaces['error'] = 'Unable to geocode'; +} else { if ($aPlace['place_id']) $aFilteredPlaces['place_id'] = $aPlace['place_id']; - $aFilteredPlaces['licence'] = "Data © OpenStreetMap contributors, ODbL 1.0. https://osm.org/copyright"; + $aFilteredPlaces['licence'] = 'Data © OpenStreetMap contributors, ODbL 1.0. https://osm.org/copyright'; $sOSMType = formatOSMType($aPlace['osm_type']); - if ($sOSMType) - { + if ($sOSMType) { $aFilteredPlaces['osm_type'] = $sOSMType; $aFilteredPlaces['osm_id'] = $aPlace['osm_id']; } @@ -38,31 +33,25 @@ else if (isset($aPlace['sExtraTags'])) $aFilteredPlaces['extratags'] = $aPlace['sExtraTags']; if (isset($aPlace['sNameDetails'])) $aFilteredPlaces['namedetails'] = $aPlace['sNameDetails']; - if (isset($aPlace['aBoundingBox'])) - { + if (isset($aPlace['aBoundingBox'])) { $aFilteredPlaces['boundingbox'] = $aPlace['aBoundingBox']; } - if (isset($aPlace['asgeojson'])) - { + if (isset($aPlace['asgeojson'])) { $aFilteredPlaces['geojson'] = json_decode($aPlace['asgeojson']); } - if (isset($aPlace['assvg'])) - { + if (isset($aPlace['assvg'])) { $aFilteredPlaces['svg'] = $aPlace['assvg']; } - if (isset($aPlace['astext'])) - { + if (isset($aPlace['astext'])) { $aFilteredPlaces['geotext'] = $aPlace['astext']; } - if (isset($aPlace['askml'])) - { + if (isset($aPlace['askml'])) { $aFilteredPlaces['geokml'] = $aPlace['askml']; } - } javascript_renderData($aFilteredPlaces); diff --git a/lib/template/address-xml.php b/lib/template/address-xml.php index d3db2edd..6183b284 100644 --- a/lib/template/address-xml.php +++ b/lib/template/address-xml.php @@ -1,103 +1,87 @@ \n"; -echo "\n"; -if (!sizeof($aPlace)) -{ +if (!sizeof($aPlace)) { if (isset($sError)) echo "$sError"; - else - echo "Unable to geocode"; -} -else -{ - echo "Unable to geocode'; +} else { + echo '".htmlspecialchars($aPlace['langaddress']).""; + echo '>'.htmlspecialchars($aPlace['langaddress']).''; - if (isset($aPlace['aAddress'])) - { - echo ""; - foreach($aPlace['aAddress'] as $sKey => $sValue) - { - $sKey = str_replace(' ','_',$sKey); + if (isset($aPlace['aAddress'])) { + echo ''; + foreach ($aPlace['aAddress'] as $sKey => $sValue) { + $sKey = str_replace(' ', '_', $sKey); echo "<$sKey>"; echo htmlspecialchars($sValue); echo ""; } - echo ""; + echo ''; } - if (isset($aPlace['sExtraTags'])) - { - echo ""; - foreach ($aPlace['sExtraTags'] as $sKey => $sValue) - { + if (isset($aPlace['sExtraTags'])) { + echo ''; + foreach ($aPlace['sExtraTags'] as $sKey => $sValue) { echo ''; } - echo ""; + echo ''; } - if (isset($aPlace['sNameDetails'])) - { - echo ""; - foreach ($aPlace['sNameDetails'] as $sKey => $sValue) - { + if (isset($aPlace['sNameDetails'])) { + echo ''; + foreach ($aPlace['sNameDetails'] as $sKey => $sValue) { echo ''; echo htmlspecialchars($sValue); - echo ""; + echo ''; } - echo ""; + echo ''; } - if (isset($aPlace['askml'])) - { + if (isset($aPlace['askml'])) { echo "\n"; echo $aPlace['askml']; - echo ""; + echo ''; } - } -echo ""; +echo ''; diff --git a/lib/template/search-batch-json.php b/lib/template/search-batch-json.php index a3ced45b..09ea48b6 100644 --- a/lib/template/search-batch-json.php +++ b/lib/template/search-batch-json.php @@ -1,42 +1,37 @@ $aPointDetails) - { + foreach ($aSearchResults as $iResNum => $aPointDetails) { $aPlace = array( - 'place_id'=>$aPointDetails['place_id'], - ); + 'place_id'=>$aPointDetails['place_id'], + ); $sOSMType = formatOSMType($aPointDetails['osm_type']); - if ($sOSMType) - { + if ($sOSMType) { $aPlace['osm_type'] = $sOSMType; $aPlace['osm_id'] = $aPointDetails['osm_id']; } - if (isset($aPointDetails['aBoundingBox'])) - { + if (isset($aPointDetails['aBoundingBox'])) { $aPlace['boundingbox'] = array( - $aPointDetails['aBoundingBox'][0], - $aPointDetails['aBoundingBox'][1], - $aPointDetails['aBoundingBox'][2], - $aPointDetails['aBoundingBox'][3]); + $aPointDetails['aBoundingBox'][0], + $aPointDetails['aBoundingBox'][1], + $aPointDetails['aBoundingBox'][2], + $aPointDetails['aBoundingBox'][3] + ); - if (isset($aPointDetails['aPolyPoints']) && $bShowPolygons) - { + if (isset($aPointDetails['aPolyPoints']) && $bShowPolygons) { $aPlace['polygonpoints'] = $aPointDetails['aPolyPoints']; } } - if (isset($aPointDetails['zoom'])) - { + if (isset($aPointDetails['zoom'])) { $aPlace['zoom'] = $aPointDetails['zoom']; } @@ -50,33 +45,27 @@ foreach($aBatchResults as $aSearchResults) $aPlace['importance'] = $aPointDetails['importance']; - if (isset($aPointDetails['icon'])) - { + if (isset($aPointDetails['icon'])) { $aPlace['icon'] = $aPointDetails['icon']; } - if (isset($aPointDetails['address']) && sizeof($aPointDetails['address'])>0) - { + if (isset($aPointDetails['address']) && sizeof($aPointDetails['address'])>0) { $aPlace['address'] = $aPointDetails['address']; } - if (isset($aPointDetails['asgeojson'])) - { + if (isset($aPointDetails['asgeojson'])) { $aPlace['geojson'] = json_decode($aPointDetails['asgeojson']); } - if (isset($aPointDetails['assvg'])) - { + if (isset($aPointDetails['assvg'])) { $aPlace['svg'] = $aPointDetails['assvg']; } - if (isset($aPointDetails['astext'])) - { + if (isset($aPointDetails['astext'])) { $aPlace['geotext'] = $aPointDetails['astext']; } - if (isset($aPointDetails['askml'])) - { + if (isset($aPointDetails['askml'])) { $aPlace['geokml'] = $aPointDetails['askml']; } diff --git a/lib/template/search-json.php b/lib/template/search-json.php index 846d654c..b997f6d9 100644 --- a/lib/template/search-json.php +++ b/lib/template/search-json.php @@ -1,33 +1,28 @@ $aPointDetails) -{ +foreach ($aSearchResults as $iResNum => $aPointDetails) { $aPlace = array( - 'place_id'=>$aPointDetails['place_id'], - 'licence'=>"Data © OpenStreetMap contributors, ODbL 1.0. https://www.openstreetmap.org/copyright", - ); + 'place_id'=>$aPointDetails['place_id'], + 'licence'=>'Data © OpenStreetMap contributors, ODbL 1.0. https://www.openstreetmap.org/copyright', + ); $sOSMType = formatOSMType($aPointDetails['osm_type']); - if ($sOSMType) - { + if ($sOSMType) { $aPlace['osm_type'] = $sOSMType; $aPlace['osm_id'] = $aPointDetails['osm_id']; } - if (isset($aPointDetails['aBoundingBox'])) - { + if (isset($aPointDetails['aBoundingBox'])) { $aPlace['boundingbox'] = $aPointDetails['aBoundingBox']; - if (isset($aPointDetails['aPolyPoints'])) - { + if (isset($aPointDetails['aPolyPoints'])) { $aPlace['polygonpoints'] = $aPointDetails['aPolyPoints']; } } - if (isset($aPointDetails['zoom'])) - { + if (isset($aPointDetails['zoom'])) { $aPlace['zoom'] = $aPointDetails['zoom']; } @@ -40,33 +35,27 @@ foreach($aSearchResults as $iResNum => $aPointDetails) $aPlace['importance'] = $aPointDetails['importance']; - if (isset($aPointDetails['icon']) && $aPointDetails['icon']) - { + if (isset($aPointDetails['icon']) && $aPointDetails['icon']) { $aPlace['icon'] = $aPointDetails['icon']; } - if (isset($aPointDetails['address'])) - { + if (isset($aPointDetails['address'])) { $aPlace['address'] = $aPointDetails['address']; } - if (isset($aPointDetails['asgeojson'])) - { + if (isset($aPointDetails['asgeojson'])) { $aPlace['geojson'] = json_decode($aPointDetails['asgeojson']); } - if (isset($aPointDetails['assvg'])) - { + if (isset($aPointDetails['assvg'])) { $aPlace['svg'] = $aPointDetails['assvg']; } - if (isset($aPointDetails['astext'])) - { + if (isset($aPointDetails['astext'])) { $aPlace['geotext'] = $aPointDetails['astext']; } - if (isset($aPointDetails['askml'])) - { + if (isset($aPointDetails['askml'])) { $aPlace['geokml'] = $aPointDetails['askml']; } diff --git a/lib/template/search-jsonv2.php b/lib/template/search-jsonv2.php index 5d2802af..76103304 100644 --- a/lib/template/search-jsonv2.php +++ b/lib/template/search-jsonv2.php @@ -1,32 +1,27 @@ $aPointDetails) -{ +foreach ($aSearchResults as $iResNum => $aPointDetails) { $aPlace = array( - 'place_id'=>$aPointDetails['place_id'], - 'licence'=>"Data © OpenStreetMap contributors, ODbL 1.0. https://osm.org/copyright", - ); + 'place_id'=>$aPointDetails['place_id'], + 'licence'=>'Data © OpenStreetMap contributors, ODbL 1.0. https://osm.org/copyright', + ); $sOSMType = formatOSMType($aPointDetails['osm_type']); - if ($sOSMType) - { + if ($sOSMType) { $aPlace['osm_type'] = $sOSMType; $aPlace['osm_id'] = $aPointDetails['osm_id']; } - if (isset($aPointDetails['aBoundingBox'])) - { + if (isset($aPointDetails['aBoundingBox'])) { $aPlace['boundingbox'] = $aPointDetails['aBoundingBox']; - if (isset($aPointDetails['aPolyPoints'])) - { + if (isset($aPointDetails['aPolyPoints'])) { $aPlace['polygonpoints'] = $aPointDetails['aPolyPoints']; } } - if (isset($aPointDetails['zoom'])) - { + if (isset($aPointDetails['zoom'])) { $aPlace['zoom'] = $aPointDetails['zoom']; } @@ -40,33 +35,27 @@ foreach($aSearchResults as $iResNum => $aPointDetails) $aPlace['importance'] = $aPointDetails['importance']; - if (isset($aPointDetails['icon'])) - { + if (isset($aPointDetails['icon'])) { $aPlace['icon'] = $aPointDetails['icon']; } - if (isset($aPointDetails['address']) && sizeof($aPointDetails['address'])>0) - { + if (isset($aPointDetails['address']) && sizeof($aPointDetails['address'])>0) { $aPlace['address'] = $aPointDetails['address']; } - if (isset($aPointDetails['asgeojson'])) - { + if (isset($aPointDetails['asgeojson'])) { $aPlace['geojson'] = json_decode($aPointDetails['asgeojson']); } - if (isset($aPointDetails['assvg'])) - { + if (isset($aPointDetails['assvg'])) { $aPlace['svg'] = $aPointDetails['assvg']; } - if (isset($aPointDetails['astext'])) - { + if (isset($aPointDetails['astext'])) { $aPlace['geotext'] = $aPointDetails['astext']; } - if (isset($aPointDetails['askml'])) - { + if (isset($aPointDetails['askml'])) { $aPlace['geokml'] = $aPointDetails['askml']; } diff --git a/lib/template/search-xml.php b/lib/template/search-xml.php index 80414fce..94bb7ec9 100644 --- a/lib/template/search-xml.php +++ b/lib/template/search-xml.php @@ -1,72 +1,63 @@ \n"; -echo "<"; +echo '<'; echo (isset($sXmlRootTag)?$sXmlRootTag:'searchresults'); echo " timestamp='".date(DATE_RFC822)."'"; echo " attribution='Data © OpenStreetMap contributors, ODbL 1.0. http://www.openstreetmap.org/copyright'"; echo " querystring='".htmlspecialchars($sQuery, ENT_QUOTES)."'"; if (isset($aMoreParams['viewbox'])) echo " viewbox='".htmlspecialchars($aMoreParams['viewbox'], ENT_QUOTES)."'"; echo " polygon='".(isset($aMoreParams['polygon'])?'true':'false')."'"; -if (isset($aMoreParams['exclude_place_ids'])) -{ +if (isset($aMoreParams['exclude_place_ids'])) { echo " exclude_place_ids='".htmlspecialchars($aMoreParams['exclude_place_ids'])."'"; } echo " more_url='".htmlspecialchars($sMoreURL)."'"; echo ">\n"; -foreach($aSearchResults as $iResNum => $aResult) -{ +foreach ($aSearchResults as $iResNum => $aResult) { echo " $aResult) echo " class='".htmlspecialchars($aResult['class'])."'"; echo " type='".htmlspecialchars($aResult['type'], ENT_QUOTES)."'"; echo " importance='".htmlspecialchars($aResult['importance'])."'"; - if (isset($aResult['icon']) && $aResult['icon']) - { + if (isset($aResult['icon']) && $aResult['icon']) { echo " icon='".htmlspecialchars($aResult['icon'], ENT_QUOTES)."'"; } $bHasDelim = false; - if (isset($aResult['askml'])) - { - if (!$bHasDelim) - { + if (isset($aResult['askml'])) { + if (!$bHasDelim) { $bHasDelim = true; - echo ">"; + echo '>'; } echo "\n"; echo $aResult['askml']; - echo ""; + echo ''; } - if (isset($aResult['sExtraTags'])) - { - if (!$bHasDelim) - { + if (isset($aResult['sExtraTags'])) { + if (!$bHasDelim) { $bHasDelim = true; - echo ">"; + echo '>'; } echo "\n"; - foreach ($aResult['sExtraTags'] as $sKey => $sValue) - { + foreach ($aResult['sExtraTags'] as $sKey => $sValue) { echo ''; } - echo ""; + echo ''; } - if (isset($aResult['sNameDetails'])) - { - if (!$bHasDelim) - { + if (isset($aResult['sNameDetails'])) { + if (!$bHasDelim) { $bHasDelim = true; - echo ">"; + echo '>'; } echo "\n"; - foreach ($aResult['sNameDetails'] as $sKey => $sValue) - { + foreach ($aResult['sNameDetails'] as $sKey => $sValue) { echo ''; echo htmlspecialchars($sValue); - echo ""; + echo ''; } - echo ""; + echo ''; } - if (isset($aResult['address'])) - { - if (!$bHasDelim) - { + if (isset($aResult['address'])) { + if (!$bHasDelim) { $bHasDelim = true; - echo ">"; + echo '>'; } echo "\n"; - foreach($aResult['address'] as $sKey => $sValue) - { - $sKey = str_replace(' ','_',$sKey); + foreach ($aResult['address'] as $sKey => $sValue) { + $sKey = str_replace(' ', '_', $sKey); echo "<$sKey>"; echo htmlspecialchars($sValue); echo ""; } } - if ($bHasDelim) - { - echo ""; - } - else - { - echo "/>"; + if ($bHasDelim) { + echo ''; + } else { + echo '/>'; } } -echo ""; +echo ''; diff --git a/phpcs.xml b/phpcs.xml index 8f92f7c9..dd71c5b8 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -8,6 +8,12 @@ + ./lib/template/*html* + ./lib/template/includes/ + ./module/ + ./website/css + ./website/js + diff --git a/test/bdd/steps/cgi-with-coverage.php b/test/bdd/steps/cgi-with-coverage.php index 165a1b0c..47d3cc9a 100644 --- a/test/bdd/steps/cgi-with-coverage.php +++ b/test/bdd/steps/cgi-with-coverage.php @@ -1,6 +1,7 @@ stop(); @@ -16,5 +17,3 @@ $coverage->start($_SERVER['COV_TEST_NAME']); register_shutdown_function('coverage_shutdown', $coverage); include $_SERVER['COV_SCRIPT_FILENAME']; - - diff --git a/test/php/Nominatim/PhraseTest.php b/test/php/Nominatim/PhraseTest.php index db8d8b50..b5e6c1bf 100644 --- a/test/php/Nominatim/PhraseTest.php +++ b/test/php/Nominatim/PhraseTest.php @@ -6,6 +6,8 @@ require_once '../../lib/Phrase.php'; class PhraseTest extends \PHPUnit_Framework_TestCase { + + private function serializeSets($aSets) { $aParts = array(); diff --git a/test/php/Nominatim/SearchContextTest.php b/test/php/Nominatim/SearchContextTest.php index a40d0716..2a74dc41 100644 --- a/test/php/Nominatim/SearchContextTest.php +++ b/test/php/Nominatim/SearchContextTest.php @@ -10,6 +10,7 @@ class SearchContextTest extends \PHPUnit_Framework_TestCase { private $oCtx; + protected function setUp() { $this->oCtx = new SearchContext();