From: Sarah Hoffmann <lonvia@denofr.de>
Date: Sun, 3 Jan 2021 20:04:59 +0000 (+0100)
Subject: Merge pull request #2124 from lonvia/remove-nose
X-Git-Tag: v3.7.0~63
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/cba2d252c8b105444553051ac443e3517e84f844?hp=2ecec19df0687196d0df96f4f40c1e097fba5e15

Merge pull request #2124 from lonvia/remove-nose

Remove nose dependency for tests
---

diff --git a/utils/check_import_finished.php b/utils/check_import_finished.php
index e28053be..bd5d7a00 100755
--- a/utils/check_import_finished.php
+++ b/utils/check_import_finished.php
@@ -28,6 +28,13 @@ function isReverseOnlyInstallation()
     return !$oDB->tableExists('search_name');
 }
 
+// Check (guess) if the setup.php included --drop
+function isNoUpdateInstallation()
+{
+    global $oDB;
+    return $oDB->tableExists('placex') && !$oDB->tableExists('planet_osm_rels') ;
+}
+
 
 echo 'Checking database got created ... ';
 if ($oDB->checkConnection()) {
@@ -63,27 +70,28 @@ END;
     exit(1);
 }
 
-echo 'Checking place table ... ';
-if ($oDB->tableExists('place')) {
-    $print_success();
-} else {
-    $print_fail();
-    echo <<< END
-    * The import didn't finish.
-    Hints:
-    * Check the output of the utils/setup.php you ran.
-    Usually the osm2pgsql step failed. Check for errors related to
-    * the file you imported not containing any places
-    * harddrive full
-    * out of memory (RAM)
-    * osm2pgsql killed by other scripts, for consuming to much memory
-
-END;
-    exit(1);
+if (!isNoUpdateInstallation()) {
+    echo 'Checking place table ... ';
+    if ($oDB->tableExists('place')) {
+        $print_success();
+    } else {
+        $print_fail();
+        echo <<< END
+        * The import didn't finish.
+        Hints:
+        * Check the output of the utils/setup.php you ran.
+        Usually the osm2pgsql step failed. Check for errors related to
+        * the file you imported not containing any places
+        * harddrive full
+        * out of memory (RAM)
+        * osm2pgsql killed by other scripts, for consuming to much memory
+
+    END;
+        exit(1);
+    }
 }
 
 
-
 echo 'Checking indexing status ... ';
 $iUnindexed = $oDB->getOne('SELECT count(*) FROM placex WHERE indexed_status > 0');
 if ($iUnindexed == 0) {
@@ -106,14 +114,11 @@ $aExpectedIndices = array(
     'idx_place_addressline_address_place_id',
     'idx_placex_rank_search',
     'idx_placex_rank_address',
-    'idx_placex_pendingsector',
     'idx_placex_parent_place_id',
     'idx_placex_geometry_reverse_lookuppolygon',
     'idx_placex_geometry_reverse_placenode',
-    'idx_location_area_country_place_id',
     'idx_osmline_parent_place_id',
     'idx_osmline_parent_osm_id',
-    'idx_place_osm_unique',
     'idx_postcode_id',
     'idx_postcode_postcode'
 );
@@ -125,6 +130,13 @@ if (!isReverseOnlyInstallation()) {
         'idx_search_name_centroid'
     ));
 }
+if (!isNoUpdateInstallation()) {
+    $aExpectedIndices = array_merge($aExpectedIndices, array(
+        'idx_placex_pendingsector',
+        'idx_location_area_country_place_id',
+        'idx_place_osm_unique',
+    ));
+}
 
 foreach ($aExpectedIndices as $sExpectedIndex) {
     echo "Checking index $sExpectedIndex ... ";
diff --git a/vagrant/Install-on-Ubuntu-18.sh b/vagrant/Install-on-Ubuntu-18.sh
index bdf30056..e7233114 100755
--- a/vagrant/Install-on-Ubuntu-18.sh
+++ b/vagrant/Install-on-Ubuntu-18.sh
@@ -29,7 +29,7 @@ export DEBIAN_FRONTEND=noninteractive #DOCS:
                         libbz2-dev libpq-dev libproj-dev \
                         postgresql-server-dev-10 postgresql-10-postgis-2.4 \
                         postgresql-contrib-10 postgresql-10-postgis-scripts \
-                        php php-pgsql php-intl \
+                        php php-pgsql php-intl php-symfony-dotenv \
                         python3-psycopg2 git
 
 
diff --git a/vagrant/Install-on-Ubuntu-20.sh b/vagrant/Install-on-Ubuntu-20.sh
index a05cc9fe..292714e9 100644
--- a/vagrant/Install-on-Ubuntu-20.sh
+++ b/vagrant/Install-on-Ubuntu-20.sh
@@ -32,7 +32,7 @@ export DEBIAN_FRONTEND=noninteractive #DOCS:
                         libbz2-dev libpq-dev libproj-dev \
                         postgresql-server-dev-12 postgresql-12-postgis-3 \
                         postgresql-contrib-12 postgresql-12-postgis-3-scripts \
-                        php php-pgsql php-intl \
+                        php php-pgsql php-intl php-symfony-dotenv \
                         python3-psycopg2 git
 
 #