From: Sarah Hoffmann <lonvia@denofr.de>
Date: Thu, 22 Oct 2020 11:43:50 +0000 (+0200)
Subject: Merge remote-tracking branch 'upstream/master'
X-Git-Tag: deploy~201
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/e6a81e8deceae44211ba9d12096edb99efc4a015?ds=inline;hp=-c

Merge remote-tracking branch 'upstream/master'
---

e6a81e8deceae44211ba9d12096edb99efc4a015
diff --combined lib/Geocode.php
index 7ab53d97,b07d1ade..8e71d761
--- a/lib/Geocode.php
+++ b/lib/Geocode.php
@@@ -18,7 -18,7 +18,7 @@@ class Geocod
      protected $aLangPrefOrder = array();
  
      protected $aExcludePlaceIDs = array();
 -    protected $bReverseInPlan = false;
 +    protected $bReverseInPlan = true;
  
      protected $iLimit = 20;
      protected $iFinalLimit = 10;
@@@ -917,21 -917,14 +917,14 @@@
                      $aResult['lon'],
                      $aResult['lat']
                  );
-                 // Adjust importance for the number of exact string matches in the result
-                 $iCountWords = 0;
-                 $sAddress = $aResult['langaddress'];
-                 foreach ($aRecheckWords as $i => $sWord) {
-                     if (stripos($sAddress, $sWord)!==false) {
-                         $iCountWords++;
-                         if (preg_match('/(^|,)\s*'.preg_quote($sWord, '/').'\s*(,|$)/', $sAddress)) $iCountWords += 0.1;
-                     }
-                 }
- 
-                 $aResult['importance'] = $aResult['importance'] + ($iCountWords*0.1); // 0.1 is a completely arbitrary number but something in the range 0.1 to 0.5 would seem right
  
                  // secondary ordering (for results with same importance (the smaller the better):
                  // - approximate importance of address parts
-                 $aResult['foundorder'] = -$aResult['addressimportance']/10;
+                 if (isset($aResult['addressimportance']) && $aResult['addressimportance']) {
+                     $aResult['foundorder'] = -$aResult['addressimportance']/10;
+                 } else {
+                     $aResult['foundorder'] = -$aResult['importance'];
+                 }
                  // - number of exact matches from the query
                  $aResult['foundorder'] -= $aResults[$aResult['place_id']]->iExactMatches;
                  // - importance of the class/type
@@@ -941,6 -934,19 +934,19 @@@
                  } else {
                      $aResult['foundorder'] += 0.01;
                  }
+ 
+                 // Adjust importance for the number of exact string matches in the result
+                 $iCountWords = 0;
+                 $sAddress = $aResult['langaddress'];
+                 foreach ($aRecheckWords as $i => $sWord) {
+                     if (stripos($sAddress, $sWord)!==false) {
+                         $iCountWords++;
+                         if (preg_match('/(^|,)\s*'.preg_quote($sWord, '/').'\s*(,|$)/', $sAddress)) $iCountWords += 0.1;
+                     }
+                 }
+ 
+                 // 0.1 is a completely arbitrary number but something in the range 0.1 to 0.5 would seem right
+                 $aResult['importance'] = $aResult['importance'] + ($iCountWords*0.1);
              }
              $aSearchResults[$iIdx] = $aResult;
          }