From: Sarah Hoffmann <lonvia@denofr.de>
Date: Wed, 23 Sep 2020 07:20:35 +0000 (+0200)
Subject: Merge pull request #1971 from lonvia/drop-support-for-isin
X-Git-Tag: v3.6.0~68
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/f2ff351da4f961734d47e027ca1f27758e6b2c81?ds=sidebyside;hp=-c

Merge pull request #1971 from lonvia/drop-support-for-isin

Drop support for is_in tag
---

f2ff351da4f961734d47e027ca1f27758e6b2c81
diff --combined settings/import-full.style
index 86600901,c587a45c..6728bd57
--- a/settings/import-full.style
+++ b/settings/import-full.style
@@@ -211,7 -211,7 +211,7 @@@
      }
  },
  {
-     "keys" : ["addr:*", "is_in:*", "tiger:county", "is_in"],
+     "keys" : ["addr:*", "is_in:*", "tiger:county"],
      "values" : {
          "" : "address"
      }
@@@ -237,8 -237,7 +237,8 @@@
                "population", "description", "image", "attribution", "fax",
                "email", "url", "website", "phone", "real_ale", "smoking",
                "food", "camera", "brewery", "locality", "wikipedia",
 -              "wikipedia:*", "access:*", "contact:*", "drink:*", "toll:*"],
 +              "wikipedia:*", "access:*", "contact:*", "drink:*", "toll:*",
 +              "area"],
      "values" : {
          "" : "extra"
      }
diff --combined sql/functions/placex_triggers.sql
index 0faa8020,f494b612..2bc7efad
--- a/sql/functions/placex_triggers.sql
+++ b/sql/functions/placex_triggers.sql
@@@ -290,23 -290,6 +290,6 @@@ BEGI
          END IF;
        END IF;
      END LOOP;
- 
-     IF address ? 'is_in' THEN
-       -- is_in items need splitting
-       isin := regexp_split_to_array(address->'is_in', E'[;,]');
-       IF array_upper(isin, 1) IS NOT NULL THEN
-         FOR i IN 1..array_upper(isin, 1) LOOP
-           isin_tokens := array_merge(isin_tokens,
-                                      word_ids_from_name(isin[i]));
- 
-           -- merge word into address vector
-           IF NOT %REVERSE-ONLY% THEN
-             nameaddress_vector := array_merge(nameaddress_vector,
-                                               addr_ids_from_name(isin[i]));
-           END IF;
-         END LOOP;
-       END IF;
-     END IF;
    END IF;
    IF NOT %REVERSE-ONLY% THEN
      nameaddress_vector := array_merge(nameaddress_vector, isin_tokens);
@@@ -426,12 -409,7 +409,12 @@@ BEGI
  
        NEW.name := hstore('ref', NEW.address->'postcode');
  
 -    ELSEIF NEW.class = 'boundary' AND NOT is_area THEN
 +    ELSEIF NEW.class = 'highway' AND is_area AND NEW.name is null
 +           AND NEW.extratags ? 'area' AND NEW.extratags->'area' = 'yes'
 +    THEN
 +        RETURN NULL;
 +    ELSEIF NEW.class = 'boundary' AND NOT is_area
 +    THEN
          RETURN NULL;
      ELSEIF NEW.class = 'boundary' AND NEW.type = 'administrative'
             AND NEW.admin_level <= 4 AND NEW.osm_type = 'W'