From: Sarah Hoffmann <lonvia@denofr.de>
Date: Wed, 23 Sep 2020 07:20:35 +0000 (+0200)
Subject: Merge pull request #1971 from lonvia/drop-support-for-isin
X-Git-Tag: v3.6.0~68
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/f2ff351da4f961734d47e027ca1f27758e6b2c81?hp=c5c242d19392ce2253ec0249d18976f49f33bebb

Merge pull request #1971 from lonvia/drop-support-for-isin

Drop support for is_in tag
---

diff --git a/settings/import-extratags.style b/settings/import-extratags.style
index b90a07b1..63c4a7ae 100644
--- a/settings/import-extratags.style
+++ b/settings/import-extratags.style
@@ -211,7 +211,7 @@
     }
 },
 {
-    "keys" : ["addr:*", "is_in:*", "tiger:county", "is_in"],
+    "keys" : ["addr:*", "is_in:*", "tiger:county"],
     "values" : {
         "" : "address"
     }
diff --git a/settings/import-full.style b/settings/import-full.style
index 86600901..6728bd57 100644
--- a/settings/import-full.style
+++ b/settings/import-full.style
@@ -211,7 +211,7 @@
     }
 },
 {
-    "keys" : ["addr:*", "is_in:*", "tiger:county", "is_in"],
+    "keys" : ["addr:*", "is_in:*", "tiger:county"],
     "values" : {
         "" : "address"
     }
diff --git a/sql/functions/placex_triggers.sql b/sql/functions/placex_triggers.sql
index 0faa8020..2bc7efad 100644
--- a/sql/functions/placex_triggers.sql
+++ b/sql/functions/placex_triggers.sql
@@ -290,23 +290,6 @@ BEGIN
         END IF;
       END IF;
     END LOOP;
-
-    IF address ? 'is_in' THEN
-      -- is_in items need splitting
-      isin := regexp_split_to_array(address->'is_in', E'[;,]');
-      IF array_upper(isin, 1) IS NOT NULL THEN
-        FOR i IN 1..array_upper(isin, 1) LOOP
-          isin_tokens := array_merge(isin_tokens,
-                                     word_ids_from_name(isin[i]));
-
-          -- merge word into address vector
-          IF NOT %REVERSE-ONLY% THEN
-            nameaddress_vector := array_merge(nameaddress_vector,
-                                              addr_ids_from_name(isin[i]));
-          END IF;
-        END LOOP;
-      END IF;
-    END IF;
   END IF;
   IF NOT %REVERSE-ONLY% THEN
     nameaddress_vector := array_merge(nameaddress_vector, isin_tokens);
diff --git a/test/bdd/db/import/search_name.feature b/test/bdd/db/import/search_name.feature
index 14cf3769..3fda7ae8 100644
--- a/test/bdd/db/import/search_name.feature
+++ b/test/bdd/db/import/search_name.feature
@@ -223,21 +223,6 @@ Feature: Creation of search terms
          | object | nameaddress_vector |
          | W1     | 12345 |
 
-    Scenario: is_in is split and added to the address search terms
-        Given the scene roads-with-pois
-        And the places
-         | osm | class   | type        | name     | geometry |
-         | N1  | place   | state       | new york | 80 80 |
-         | N2  | place   | city        | bonn     | 81 81 |
-         | N3  | place   | suburb      | smalltown| 80 81 |
-        And the named places
-         | osm | class   | type    | addr+is_in                | geometry |
-         | W1  | highway | service | bonn, New York, Smalltown | :w-north |
-        When importing
-        Then search_name contains
-         | object | nameaddress_vector |
-         | W1     | bonn, new york, smalltown |
-
     Scenario: a linked place does not show up in search name
         Given the named places
          | osm  | class    | type           | admin | geometry |