]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
12 months agoMerge pull request #3262 from lonvia/fix-category-search
Sarah Hoffmann [Tue, 28 Nov 2023 19:02:36 +0000 (20:02 +0100)]
Merge pull request #3262 from lonvia/fix-category-search

Fix use of category parameter for search() function

12 months agocorrectly exclude streets with housenumber searches
Sarah Hoffmann [Tue, 28 Nov 2023 16:53:37 +0000 (17:53 +0100)]
correctly exclude streets with housenumber searches

Street result are not subject to the full filtering in the SQL
query, so recheck.

12 months agoadd tests for interaction of category parameter with category terms
Sarah Hoffmann [Tue, 28 Nov 2023 15:56:08 +0000 (16:56 +0100)]
add tests for interaction of category parameter with category terms

12 months agorename use of category as POI search to near_item
Sarah Hoffmann [Tue, 28 Nov 2023 15:27:05 +0000 (16:27 +0100)]
rename use of category as POI search to near_item

Use the term category only as a short-cut for "tuple of key and value".

12 months agothe category parameter in search should result in a qualifier
Sarah Hoffmann [Tue, 28 Nov 2023 11:01:49 +0000 (12:01 +0100)]
the category parameter in search should result in a qualifier

13 months agoMerge pull request #3260 from lonvia/improve-catgeory-search
Sarah Hoffmann [Mon, 27 Nov 2023 11:02:11 +0000 (12:02 +0100)]
Merge pull request #3260 from lonvia/improve-catgeory-search

Various improvements to search with special phrases for Python frontend

13 months agodrop category tokens when they make up a full phrase
Sarah Hoffmann [Sun, 26 Nov 2023 19:58:50 +0000 (20:58 +0100)]
drop category tokens when they make up a full phrase

13 months agorestrict base results in near search by rank
Sarah Hoffmann [Sun, 26 Nov 2023 16:41:29 +0000 (17:41 +0100)]
restrict base results in near search by rank

This avoids in particular that roads or POIs are used as base
for the near search when a place result is present.

13 months agodeduplicate categories/qualifiers
Sarah Hoffmann [Sun, 26 Nov 2023 16:11:15 +0000 (17:11 +0100)]
deduplicate categories/qualifiers

13 months agoorder near searches by distance instead of importance
Sarah Hoffmann [Sun, 26 Nov 2023 15:48:04 +0000 (16:48 +0100)]
order near searches by distance instead of importance

13 months agoavoid duplicate lines during category search
Sarah Hoffmann [Sun, 26 Nov 2023 08:50:59 +0000 (09:50 +0100)]
avoid duplicate lines during category search

13 months agofix polygon selection for classtable lookups
Sarah Hoffmann [Sat, 25 Nov 2023 20:01:27 +0000 (21:01 +0100)]
fix polygon selection for classtable lookups

Polygons should be used preferably with higher address ranks
where the areas are smaller.

13 months agoMerge pull request #3257 from lonvia/slow-queries
Sarah Hoffmann [Thu, 23 Nov 2023 11:05:50 +0000 (12:05 +0100)]
Merge pull request #3257 from lonvia/slow-queries

Performance tweaks for search

13 months agoincrease penalty for one-letter words
Sarah Hoffmann [Thu, 23 Nov 2023 09:51:58 +0000 (10:51 +0100)]
increase penalty for one-letter words

13 months agomore preference for name-only queries in search
Sarah Hoffmann [Wed, 22 Nov 2023 22:57:23 +0000 (23:57 +0100)]
more preference for name-only queries in search

13 months agoavoid index use when filtering by layer
Sarah Hoffmann [Wed, 22 Nov 2023 19:54:04 +0000 (20:54 +0100)]
avoid index use when filtering by layer

13 months agoadd timestamps to text logging
Sarah Hoffmann [Wed, 22 Nov 2023 16:38:32 +0000 (17:38 +0100)]
add timestamps to text logging

13 months agoavoid index on rank_address in near search
Sarah Hoffmann [Wed, 22 Nov 2023 16:33:17 +0000 (17:33 +0100)]
avoid index on rank_address in near search

13 months agoexclude country-level searches with non-address layers
Sarah Hoffmann [Wed, 22 Nov 2023 16:01:41 +0000 (17:01 +0100)]
exclude country-level searches with non-address layers

13 months agoMerge pull request #3252 from kumarUjjawal/patch-1
Sarah Hoffmann [Wed, 22 Nov 2023 11:51:37 +0000 (12:51 +0100)]
Merge pull request #3252 from kumarUjjawal/patch-1

minor typo fix

13 months agominor typo fix
Kumar Ujjawal [Mon, 20 Nov 2023 11:53:42 +0000 (17:23 +0530)]
minor typo fix

fixed a minor typo, from 'wit' to 'with'.

13 months agoadd report on newest vulnerability
Sarah Hoffmann [Mon, 20 Nov 2023 09:44:48 +0000 (10:44 +0100)]
add report on newest vulnerability

13 months agoimprove code to collect the PostGIS version
Sarah Hoffmann [Thu, 16 Nov 2023 10:02:25 +0000 (11:02 +0100)]
improve code to collect the PostGIS version

The SQL contained an unchecked string literal, which may in theory be
used to attack the database.

13 months agoMerge pull request #3248 from lonvia/fix-postcode-area-computation
Sarah Hoffmann [Wed, 15 Nov 2023 21:10:21 +0000 (22:10 +0100)]
Merge pull request #3248 from lonvia/fix-postcode-area-computation

PHP frontent: fix postcode area computation for address points

13 months agoadapt typing to newest version of SQLAlchemy
Sarah Hoffmann [Wed, 15 Nov 2023 18:59:26 +0000 (19:59 +0100)]
adapt typing to newest version of SQLAlchemy

13 months agophp frontend: fix on-the-fly lookup of postcode areas
Sarah Hoffmann [Wed, 15 Nov 2023 16:45:12 +0000 (17:45 +0100)]
php frontend: fix on-the-fly lookup of postcode areas

13 months agoremove now unnecessary type igonre comment
Sarah Hoffmann [Wed, 1 Nov 2023 10:57:57 +0000 (11:57 +0100)]
remove now unnecessary type igonre comment

13 months agofix assertion on address list, it may be empty
Sarah Hoffmann [Tue, 31 Oct 2023 20:10:23 +0000 (21:10 +0100)]
fix assertion on address list, it may be empty

Fixes #3237.

14 months agoMerge pull request #3235 from lonvia/fix-python-deploy
Sarah Hoffmann [Wed, 25 Oct 2023 12:54:13 +0000 (14:54 +0200)]
Merge pull request #3235 from lonvia/fix-python-deploy

Python frontend deployment: add systemd service for the socket

14 months agopython deployment: add systemd service for the socket
Sarah Hoffmann [Wed, 25 Oct 2023 09:21:40 +0000 (11:21 +0200)]
python deployment: add systemd service for the socket

14 months agoMerge pull request #3234 from lonvia/reduce-admin-style
Sarah Hoffmann [Wed, 25 Oct 2023 07:38:17 +0000 (09:38 +0200)]
Merge pull request #3234 from lonvia/reduce-admin-style

Streamline admin style

14 months agoMerge pull request #3233 from lonvia/support-for-sqlite
Sarah Hoffmann [Tue, 24 Oct 2023 09:54:35 +0000 (11:54 +0200)]
Merge pull request #3233 from lonvia/support-for-sqlite

Add support for SQLite DBs in frontend: reverse

14 months agofurther reduce admin style import to admin-only objects
Sarah Hoffmann [Tue, 24 Oct 2023 07:50:43 +0000 (09:50 +0200)]
further reduce admin style import to admin-only objects

14 months agorestrict geometry size for SQLite
Sarah Hoffmann [Thu, 19 Oct 2023 19:24:53 +0000 (21:24 +0200)]
restrict geometry size for SQLite

14 months agoconvert sqlite: add index on parent_place_id
Sarah Hoffmann [Tue, 17 Oct 2023 08:59:47 +0000 (10:59 +0200)]
convert sqlite: add index on parent_place_id

14 months agoremove type info from SQLALchemy condition functions
Sarah Hoffmann [Tue, 17 Oct 2023 08:57:52 +0000 (10:57 +0200)]
remove type info from SQLALchemy condition functions

A boolean type makes the SQLite dialect produce a costruct like
'func() = 1' in WHERE condition. While syntactically correct, it tends
to confuse the query planer.

14 months agomake code work with Spatialite 4.3
Sarah Hoffmann [Mon, 16 Oct 2023 14:57:13 +0000 (16:57 +0200)]
make code work with Spatialite 4.3

Transfer is_address_point into SQLAlchemy function, so that
json.has_key() can use the older json_extract() function.
And work around broken Distance function.

14 months agoenable BDD tests for sqlite databases
Sarah Hoffmann [Fri, 13 Oct 2023 19:32:03 +0000 (21:32 +0200)]
enable BDD tests for sqlite databases

The database must currently be created by hand and the name handed
in via -DAPI_TEST_DB='sqlite:...'.

14 months agotrim all coordinate output to 7 digits
Sarah Hoffmann [Fri, 13 Oct 2023 12:09:11 +0000 (14:09 +0200)]
trim all coordinate output to 7 digits

14 months agoadd indexing support for DWithin and intersects for sqlite
Sarah Hoffmann [Fri, 13 Oct 2023 09:38:36 +0000 (11:38 +0200)]
add indexing support for DWithin and intersects for sqlite

14 months agomake reverse API work with sqlite
Sarah Hoffmann [Fri, 13 Oct 2023 09:03:13 +0000 (11:03 +0200)]
make reverse API work with sqlite

14 months agoactions: enable sqlite testing
Sarah Hoffmann [Thu, 12 Oct 2023 14:00:28 +0000 (16:00 +0200)]
actions: enable sqlite testing

14 months agotry future annotations to resolve Generics compatibility
Sarah Hoffmann [Thu, 12 Oct 2023 14:19:12 +0000 (16:19 +0200)]
try future annotations to resolve Generics compatibility

14 months agomake status API work with sqlite incl. unit tests
Sarah Hoffmann [Thu, 12 Oct 2023 14:17:16 +0000 (16:17 +0200)]
make status API work with sqlite incl. unit tests

14 months agomake details API work with sqlite incl. unit tests
Sarah Hoffmann [Thu, 12 Oct 2023 13:31:20 +0000 (15:31 +0200)]
make details API work with sqlite incl. unit tests

14 months agomake lookup call work with sqlite
Sarah Hoffmann [Thu, 12 Oct 2023 11:51:10 +0000 (13:51 +0200)]
make lookup call work with sqlite

Includes porting unit tests.

14 months agoadd exporting of SQLite table
Sarah Hoffmann [Thu, 12 Oct 2023 08:45:12 +0000 (10:45 +0200)]
add exporting of SQLite table

14 months agoadd skeleton code for convert function
Sarah Hoffmann [Wed, 11 Oct 2023 20:35:18 +0000 (22:35 +0200)]
add skeleton code for convert function

14 months agostreamline SQLAlchemy DB schema
Sarah Hoffmann [Wed, 11 Oct 2023 09:30:42 +0000 (11:30 +0200)]
streamline SQLAlchemy DB schema

Remove all information not strictly used by the frontend as well as
any index information. This will make it easier to create a SQLite
database from the schema.

14 months agoremove unused code
Sarah Hoffmann [Mon, 23 Oct 2023 09:55:18 +0000 (11:55 +0200)]
remove unused code

14 months agoMerge branch 'clean-deleted-relations' of https://github.com/lujoh/Nominatim into...
Sarah Hoffmann [Mon, 23 Oct 2023 08:47:31 +0000 (10:47 +0200)]
Merge branch 'clean-deleted-relations' of https://github.com/lujoh/Nominatim into lujoh-clean-deleted-relations

14 months agoMerge pull request #3228 from pawel-wroniszewski/fix/postcode-validation
Sarah Hoffmann [Mon, 23 Oct 2023 08:35:42 +0000 (10:35 +0200)]
Merge pull request #3228 from pawel-wroniszewski/fix/postcode-validation

Properly validate postcodes with country code

14 months agomade age a required argument for the -clean-deleted command
lujoh [Fri, 20 Oct 2023 19:31:55 +0000 (15:31 -0400)]
made age a required argument for the -clean-deleted command

14 months agoRevert country settings
Paweł Wroniszewski [Fri, 20 Oct 2023 10:39:47 +0000 (12:39 +0200)]
Revert country settings

14 months agoadded --clean deleted command to the documentation
lujoh [Wed, 18 Oct 2023 06:03:17 +0000 (02:03 -0400)]
added --clean deleted command to the documentation

14 months agoadjusted tests for --clean-deleted-relations command
lujoh [Wed, 18 Oct 2023 03:03:37 +0000 (23:03 -0400)]
adjusted tests for --clean-deleted-relations command

14 months agomoved sql function flush_deleted_places() to utils
lujoh [Tue, 17 Oct 2023 22:22:27 +0000 (18:22 -0400)]
moved sql function flush_deleted_places() to utils

14 months agoProperly validate postcodes with country code
Paweł Wroniszewski [Mon, 16 Oct 2023 22:44:24 +0000 (00:44 +0200)]
Properly validate postcodes with country code

Include postcode pattern in postcode normalisation regex, instead of
removing it from postcode pattern in config.

It properly handles postcode validation and normalization when country code
is part of the postcode, e.g. for Isle of Man, Jersey, Anguilla, Andorra,
Cayman Islands and more.

Fixes #3227.

14 months agoadded subcommand to clean deleted relations for issue # 2444
lujoh [Fri, 13 Oct 2023 02:00:43 +0000 (22:00 -0400)]
added subcommand to clean deleted relations for issue # 2444

14 months agoadapt typing for newer version of mypy
Sarah Hoffmann [Mon, 16 Oct 2023 15:03:48 +0000 (17:03 +0200)]
adapt typing for newer version of mypy

14 months agoMerge pull request #3222 from lonvia/fix-river-output
Sarah Hoffmann [Tue, 10 Oct 2023 09:20:12 +0000 (11:20 +0200)]
Merge pull request #3222 from lonvia/fix-river-output

Make sure the place name always comes first in output

14 months agoreduce influence of viewbox
Sarah Hoffmann [Sat, 7 Oct 2023 15:30:01 +0000 (17:30 +0200)]
reduce influence of viewbox

Perfectly matching city names should still get priority.

14 months agomake sure the place name always comes first in output
Sarah Hoffmann [Wed, 4 Oct 2023 12:41:19 +0000 (14:41 +0200)]
make sure the place name always comes first in output

Also deleted some now unused code.

14 months agoMerge pull request #3212 from lonvia/more-tests
Sarah Hoffmann [Thu, 5 Oct 2023 14:36:53 +0000 (16:36 +0200)]
Merge pull request #3212 from lonvia/more-tests

Add more unit tests for search

14 months agoswitch back meaning of reverse and search in warm
Sarah Hoffmann [Wed, 4 Oct 2023 13:19:24 +0000 (15:19 +0200)]
switch back meaning of reverse and search in warm

Also do'n try to warm up searches on reverse-only databases.

Fixes #3213.

15 months agomore unit tests for search
Sarah Hoffmann [Tue, 26 Sep 2023 07:40:30 +0000 (09:40 +0200)]
more unit tests for search

15 months agoMerge pull request #3211 from lonvia/replace-get-addressdata
Sarah Hoffmann [Tue, 26 Sep 2023 19:29:15 +0000 (21:29 +0200)]
Merge pull request #3211 from lonvia/replace-get-addressdata

Move get_addressdata() implementation to Python

15 months agomove get_addressdata() implementation to Python
Sarah Hoffmann [Sat, 23 Sep 2023 08:44:37 +0000 (10:44 +0200)]
move get_addressdata() implementation to Python

The pgsql function get_addressdata() does a lookup of a lot of data
that is already available in Python.

15 months agoMerge pull request #3206 from lonvia/rerank-by-locale
Sarah Hoffmann [Thu, 21 Sep 2023 07:24:18 +0000 (09:24 +0200)]
Merge pull request #3206 from lonvia/rerank-by-locale

Reintroduce result reranking

15 months agoadapt tests to improved search
Sarah Hoffmann [Wed, 20 Sep 2023 12:48:00 +0000 (14:48 +0200)]
adapt tests to improved search

15 months agofilter duplicate results after DB query
Sarah Hoffmann [Wed, 20 Sep 2023 09:39:18 +0000 (11:39 +0200)]
filter duplicate results after DB query

15 months agorerank results by query
Sarah Hoffmann [Tue, 19 Sep 2023 14:18:09 +0000 (16:18 +0200)]
rerank results by query

The algorithm is similar to the PHP reranking and uses the terms from
the display name to check against the query terms. However instead of
exact matching it uses a per-word-edit-distance, so that it is less
strict when it comes to mismatching accents or other one letter
differences.

Country names get a higher penalty because they don't receive a
penalty during token matching right now.

This will work badly with the legacy tokenizer. Given that it is
marked for removal, it is simply not worth optimising for it.

15 months agomove localization into add_result_details
Sarah Hoffmann [Tue, 19 Sep 2023 09:17:04 +0000 (11:17 +0200)]
move localization into add_result_details

This means that the locale now needs to be handed in into the search
functions already. At least search needs them for reranking.

15 months agoMerge pull request #3201 from lonvia/tweak-expected-count
Sarah Hoffmann [Sun, 17 Sep 2023 15:04:27 +0000 (17:04 +0200)]
Merge pull request #3201 from lonvia/tweak-expected-count

Reduce expected count for multi-part words

15 months ago'fix' issues with recent changes to psycopg2 typing
Sarah Hoffmann [Sun, 17 Sep 2023 13:09:34 +0000 (15:09 +0200)]
'fix' issues with recent changes to psycopg2 typing

Some of the changes just make the warnings go away. The typing info
is still incorrect on the stub side, as far as I can determine.

15 months agoreduce expected count for multi-part words
Sarah Hoffmann [Mon, 11 Sep 2023 15:45:34 +0000 (17:45 +0200)]
reduce expected count for multi-part words

Fixes #3196.

15 months agoadd changelog for 4.2.3 v4.3.0
Sarah Hoffmann [Thu, 7 Sep 2023 08:07:16 +0000 (10:07 +0200)]
add changelog for 4.2.3

15 months agoprepare release 4.3.0
Sarah Hoffmann [Wed, 6 Sep 2023 18:08:28 +0000 (20:08 +0200)]
prepare release 4.3.0

15 months agoreenable logging of details calls
Sarah Hoffmann [Wed, 6 Sep 2023 09:35:53 +0000 (11:35 +0200)]
reenable logging of details calls

15 months agorestrict deduplication to results from placex
Sarah Hoffmann [Wed, 6 Sep 2023 08:43:55 +0000 (10:43 +0200)]
restrict deduplication to results from placex

All other sources do not have deduplicatable entries.

15 months agoadd bbox output to lookup results
Sarah Hoffmann [Wed, 6 Sep 2023 08:27:03 +0000 (10:27 +0200)]
add bbox output to lookup results

Fixes #3149.

15 months agodocumentation: fix a broken link, typos
marc tobias [Wed, 30 Aug 2023 23:11:54 +0000 (01:11 +0200)]
documentation: fix a broken link, typos

15 months agoMerge pull request #3190 from lonvia/fix-internal-server-errors
Sarah Hoffmann [Tue, 5 Sep 2023 15:00:31 +0000 (17:00 +0200)]
Merge pull request #3190 from lonvia/fix-internal-server-errors

Fix more failing queries

15 months agoMerge pull request #3189 from lonvia/add-country-area-restriction
Sarah Hoffmann [Tue, 5 Sep 2023 12:29:44 +0000 (14:29 +0200)]
Merge pull request #3189 from lonvia/add-country-area-restriction

Implement NOMINATIM_SEARCH_WITHIN_COUNTRIES for Python frontend

15 months agoactions: update to checkout v4
Sarah Hoffmann [Tue, 5 Sep 2023 09:44:12 +0000 (11:44 +0200)]
actions: update to checkout v4

15 months agorestrict range for interpolated housenumbers
Sarah Hoffmann [Tue, 5 Sep 2023 09:41:41 +0000 (11:41 +0200)]
restrict range for interpolated housenumbers

Interpolations are only supported up to 2^32 by the database.
Limit to 8 digits, which is still more than should be needed.

15 months agoavoid interpreting integral numbers as coordinates
Sarah Hoffmann [Tue, 5 Sep 2023 09:26:47 +0000 (11:26 +0200)]
avoid interpreting integral numbers as coordinates

There are addresses of type '123 W 345 N, Reigh', where 'W 345 N' is
the actual name of the street.

15 months agoMerge pull request #3188 from lonvia/update-osm2pgsql
Sarah Hoffmann [Tue, 5 Sep 2023 08:44:32 +0000 (10:44 +0200)]
Merge pull request #3188 from lonvia/update-osm2pgsql

Update osm2pgsql to 1.9.2

15 months agoupdate osm2pgsql to 1.9.2
Sarah Hoffmann [Mon, 4 Sep 2023 12:53:46 +0000 (14:53 +0200)]
update osm2pgsql to 1.9.2

15 months agoallow lower case OSM types in lookup query
Sarah Hoffmann [Mon, 4 Sep 2023 12:39:35 +0000 (14:39 +0200)]
allow lower case OSM types in lookup query

15 months agoMerge pull request #3186 from lonvia/tablespaces-for-flex
Sarah Hoffmann [Mon, 4 Sep 2023 12:25:45 +0000 (14:25 +0200)]
Merge pull request #3186 from lonvia/tablespaces-for-flex

Make tablespace arguments work again for flex tables

15 months agoimplement NOMINATIM_SEARCH_WITHIN_COUNTRIES setting
Sarah Hoffmann [Mon, 4 Sep 2023 12:10:36 +0000 (14:10 +0200)]
implement NOMINATIM_SEARCH_WITHIN_COUNTRIES setting

15 months agoreenable tablespace arguments for flex tables
Sarah Hoffmann [Mon, 4 Sep 2023 08:45:52 +0000 (10:45 +0200)]
reenable tablespace arguments for flex tables

15 months agoadd a shutdown handler for falcon server closing DB connections
Sarah Hoffmann [Thu, 31 Aug 2023 07:40:56 +0000 (09:40 +0200)]
add a shutdown handler for falcon server closing DB connections

15 months agoremove alias where it does not work with lambdas
Sarah Hoffmann [Wed, 30 Aug 2023 19:52:51 +0000 (21:52 +0200)]
remove alias where it does not work with lambdas

Fixes #3177.

15 months agofix parameter name for layer filter
Sarah Hoffmann [Wed, 30 Aug 2023 07:54:50 +0000 (09:54 +0200)]
fix parameter name for layer filter

15 months agoMerge pull request #3178 from lonvia/library-documentation
Sarah Hoffmann [Wed, 30 Aug 2023 07:17:24 +0000 (09:17 +0200)]
Merge pull request #3178 from lonvia/library-documentation

Update documentation for new Python frontend

15 months agofix typos and grammar issues
Sarah Hoffmann [Tue, 29 Aug 2023 10:14:44 +0000 (12:14 +0200)]
fix typos and grammar issues

16 months agorename documentation to 'Nominatim Manual'
Sarah Hoffmann [Mon, 28 Aug 2023 08:59:26 +0000 (10:59 +0200)]
rename documentation to 'Nominatim Manual'

16 months agoadapt installation instruction for different frontends
Sarah Hoffmann [Mon, 28 Aug 2023 08:48:34 +0000 (10:48 +0200)]
adapt installation instruction for different frontends