]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
14 months agoremove type info from SQLALchemy condition functions
Sarah Hoffmann [Tue, 17 Oct 2023 08:57:52 +0000 (10:57 +0200)]
remove type info from SQLALchemy condition functions

A boolean type makes the SQLite dialect produce a costruct like
'func() = 1' in WHERE condition. While syntactically correct, it tends
to confuse the query planer.

14 months agomake code work with Spatialite 4.3
Sarah Hoffmann [Mon, 16 Oct 2023 14:57:13 +0000 (16:57 +0200)]
make code work with Spatialite 4.3

Transfer is_address_point into SQLAlchemy function, so that
json.has_key() can use the older json_extract() function.
And work around broken Distance function.

14 months agoenable BDD tests for sqlite databases
Sarah Hoffmann [Fri, 13 Oct 2023 19:32:03 +0000 (21:32 +0200)]
enable BDD tests for sqlite databases

The database must currently be created by hand and the name handed
in via -DAPI_TEST_DB='sqlite:...'.

14 months agotrim all coordinate output to 7 digits
Sarah Hoffmann [Fri, 13 Oct 2023 12:09:11 +0000 (14:09 +0200)]
trim all coordinate output to 7 digits

14 months agoadd indexing support for DWithin and intersects for sqlite
Sarah Hoffmann [Fri, 13 Oct 2023 09:38:36 +0000 (11:38 +0200)]
add indexing support for DWithin and intersects for sqlite

14 months agomake reverse API work with sqlite
Sarah Hoffmann [Fri, 13 Oct 2023 09:03:13 +0000 (11:03 +0200)]
make reverse API work with sqlite

14 months agoactions: enable sqlite testing
Sarah Hoffmann [Thu, 12 Oct 2023 14:00:28 +0000 (16:00 +0200)]
actions: enable sqlite testing

14 months agotry future annotations to resolve Generics compatibility
Sarah Hoffmann [Thu, 12 Oct 2023 14:19:12 +0000 (16:19 +0200)]
try future annotations to resolve Generics compatibility

14 months agomake status API work with sqlite incl. unit tests
Sarah Hoffmann [Thu, 12 Oct 2023 14:17:16 +0000 (16:17 +0200)]
make status API work with sqlite incl. unit tests

14 months agomake details API work with sqlite incl. unit tests
Sarah Hoffmann [Thu, 12 Oct 2023 13:31:20 +0000 (15:31 +0200)]
make details API work with sqlite incl. unit tests

14 months agomake lookup call work with sqlite
Sarah Hoffmann [Thu, 12 Oct 2023 11:51:10 +0000 (13:51 +0200)]
make lookup call work with sqlite

Includes porting unit tests.

14 months agoadd exporting of SQLite table
Sarah Hoffmann [Thu, 12 Oct 2023 08:45:12 +0000 (10:45 +0200)]
add exporting of SQLite table

14 months agoadd skeleton code for convert function
Sarah Hoffmann [Wed, 11 Oct 2023 20:35:18 +0000 (22:35 +0200)]
add skeleton code for convert function

14 months agostreamline SQLAlchemy DB schema
Sarah Hoffmann [Wed, 11 Oct 2023 09:30:42 +0000 (11:30 +0200)]
streamline SQLAlchemy DB schema

Remove all information not strictly used by the frontend as well as
any index information. This will make it easier to create a SQLite
database from the schema.

14 months agoremove unused code
Sarah Hoffmann [Mon, 23 Oct 2023 09:55:18 +0000 (11:55 +0200)]
remove unused code

14 months agoMerge branch 'clean-deleted-relations' of https://github.com/lujoh/Nominatim into...
Sarah Hoffmann [Mon, 23 Oct 2023 08:47:31 +0000 (10:47 +0200)]
Merge branch 'clean-deleted-relations' of https://github.com/lujoh/Nominatim into lujoh-clean-deleted-relations

14 months agoMerge pull request #3228 from pawel-wroniszewski/fix/postcode-validation
Sarah Hoffmann [Mon, 23 Oct 2023 08:35:42 +0000 (10:35 +0200)]
Merge pull request #3228 from pawel-wroniszewski/fix/postcode-validation

Properly validate postcodes with country code

14 months agomade age a required argument for the -clean-deleted command
lujoh [Fri, 20 Oct 2023 19:31:55 +0000 (15:31 -0400)]
made age a required argument for the -clean-deleted command

14 months agoRevert country settings
Paweł Wroniszewski [Fri, 20 Oct 2023 10:39:47 +0000 (12:39 +0200)]
Revert country settings

14 months agoadded --clean deleted command to the documentation
lujoh [Wed, 18 Oct 2023 06:03:17 +0000 (02:03 -0400)]
added --clean deleted command to the documentation

14 months agoadjusted tests for --clean-deleted-relations command
lujoh [Wed, 18 Oct 2023 03:03:37 +0000 (23:03 -0400)]
adjusted tests for --clean-deleted-relations command

14 months agomoved sql function flush_deleted_places() to utils
lujoh [Tue, 17 Oct 2023 22:22:27 +0000 (18:22 -0400)]
moved sql function flush_deleted_places() to utils

14 months agoProperly validate postcodes with country code
Paweł Wroniszewski [Mon, 16 Oct 2023 22:44:24 +0000 (00:44 +0200)]
Properly validate postcodes with country code

Include postcode pattern in postcode normalisation regex, instead of
removing it from postcode pattern in config.

It properly handles postcode validation and normalization when country code
is part of the postcode, e.g. for Isle of Man, Jersey, Anguilla, Andorra,
Cayman Islands and more.

Fixes #3227.

14 months agoadded subcommand to clean deleted relations for issue # 2444
lujoh [Fri, 13 Oct 2023 02:00:43 +0000 (22:00 -0400)]
added subcommand to clean deleted relations for issue # 2444

14 months agoadapt typing for newer version of mypy
Sarah Hoffmann [Mon, 16 Oct 2023 15:03:48 +0000 (17:03 +0200)]
adapt typing for newer version of mypy

14 months agoMerge pull request #3222 from lonvia/fix-river-output
Sarah Hoffmann [Tue, 10 Oct 2023 09:20:12 +0000 (11:20 +0200)]
Merge pull request #3222 from lonvia/fix-river-output

Make sure the place name always comes first in output

14 months agoreduce influence of viewbox
Sarah Hoffmann [Sat, 7 Oct 2023 15:30:01 +0000 (17:30 +0200)]
reduce influence of viewbox

Perfectly matching city names should still get priority.

14 months agomake sure the place name always comes first in output
Sarah Hoffmann [Wed, 4 Oct 2023 12:41:19 +0000 (14:41 +0200)]
make sure the place name always comes first in output

Also deleted some now unused code.

14 months agoMerge pull request #3212 from lonvia/more-tests
Sarah Hoffmann [Thu, 5 Oct 2023 14:36:53 +0000 (16:36 +0200)]
Merge pull request #3212 from lonvia/more-tests

Add more unit tests for search

14 months agoswitch back meaning of reverse and search in warm
Sarah Hoffmann [Wed, 4 Oct 2023 13:19:24 +0000 (15:19 +0200)]
switch back meaning of reverse and search in warm

Also do'n try to warm up searches on reverse-only databases.

Fixes #3213.

15 months agomore unit tests for search
Sarah Hoffmann [Tue, 26 Sep 2023 07:40:30 +0000 (09:40 +0200)]
more unit tests for search

15 months agoMerge pull request #3211 from lonvia/replace-get-addressdata
Sarah Hoffmann [Tue, 26 Sep 2023 19:29:15 +0000 (21:29 +0200)]
Merge pull request #3211 from lonvia/replace-get-addressdata

Move get_addressdata() implementation to Python

15 months agomove get_addressdata() implementation to Python
Sarah Hoffmann [Sat, 23 Sep 2023 08:44:37 +0000 (10:44 +0200)]
move get_addressdata() implementation to Python

The pgsql function get_addressdata() does a lookup of a lot of data
that is already available in Python.

15 months agoMerge pull request #3206 from lonvia/rerank-by-locale
Sarah Hoffmann [Thu, 21 Sep 2023 07:24:18 +0000 (09:24 +0200)]
Merge pull request #3206 from lonvia/rerank-by-locale

Reintroduce result reranking

15 months agoadapt tests to improved search
Sarah Hoffmann [Wed, 20 Sep 2023 12:48:00 +0000 (14:48 +0200)]
adapt tests to improved search

15 months agofilter duplicate results after DB query
Sarah Hoffmann [Wed, 20 Sep 2023 09:39:18 +0000 (11:39 +0200)]
filter duplicate results after DB query

15 months agorerank results by query
Sarah Hoffmann [Tue, 19 Sep 2023 14:18:09 +0000 (16:18 +0200)]
rerank results by query

The algorithm is similar to the PHP reranking and uses the terms from
the display name to check against the query terms. However instead of
exact matching it uses a per-word-edit-distance, so that it is less
strict when it comes to mismatching accents or other one letter
differences.

Country names get a higher penalty because they don't receive a
penalty during token matching right now.

This will work badly with the legacy tokenizer. Given that it is
marked for removal, it is simply not worth optimising for it.

15 months agomove localization into add_result_details
Sarah Hoffmann [Tue, 19 Sep 2023 09:17:04 +0000 (11:17 +0200)]
move localization into add_result_details

This means that the locale now needs to be handed in into the search
functions already. At least search needs them for reranking.

15 months agoMerge pull request #3201 from lonvia/tweak-expected-count
Sarah Hoffmann [Sun, 17 Sep 2023 15:04:27 +0000 (17:04 +0200)]
Merge pull request #3201 from lonvia/tweak-expected-count

Reduce expected count for multi-part words

15 months ago'fix' issues with recent changes to psycopg2 typing
Sarah Hoffmann [Sun, 17 Sep 2023 13:09:34 +0000 (15:09 +0200)]
'fix' issues with recent changes to psycopg2 typing

Some of the changes just make the warnings go away. The typing info
is still incorrect on the stub side, as far as I can determine.

15 months agoreduce expected count for multi-part words
Sarah Hoffmann [Mon, 11 Sep 2023 15:45:34 +0000 (17:45 +0200)]
reduce expected count for multi-part words

Fixes #3196.

15 months agoadd changelog for 4.2.3 v4.3.0
Sarah Hoffmann [Thu, 7 Sep 2023 08:07:16 +0000 (10:07 +0200)]
add changelog for 4.2.3

15 months agoprepare release 4.3.0
Sarah Hoffmann [Wed, 6 Sep 2023 18:08:28 +0000 (20:08 +0200)]
prepare release 4.3.0

15 months agoreenable logging of details calls
Sarah Hoffmann [Wed, 6 Sep 2023 09:35:53 +0000 (11:35 +0200)]
reenable logging of details calls

15 months agorestrict deduplication to results from placex
Sarah Hoffmann [Wed, 6 Sep 2023 08:43:55 +0000 (10:43 +0200)]
restrict deduplication to results from placex

All other sources do not have deduplicatable entries.

15 months agoadd bbox output to lookup results
Sarah Hoffmann [Wed, 6 Sep 2023 08:27:03 +0000 (10:27 +0200)]
add bbox output to lookup results

Fixes #3149.

15 months agodocumentation: fix a broken link, typos
marc tobias [Wed, 30 Aug 2023 23:11:54 +0000 (01:11 +0200)]
documentation: fix a broken link, typos

15 months agoMerge pull request #3190 from lonvia/fix-internal-server-errors
Sarah Hoffmann [Tue, 5 Sep 2023 15:00:31 +0000 (17:00 +0200)]
Merge pull request #3190 from lonvia/fix-internal-server-errors

Fix more failing queries

15 months agoMerge pull request #3189 from lonvia/add-country-area-restriction
Sarah Hoffmann [Tue, 5 Sep 2023 12:29:44 +0000 (14:29 +0200)]
Merge pull request #3189 from lonvia/add-country-area-restriction

Implement NOMINATIM_SEARCH_WITHIN_COUNTRIES for Python frontend

15 months agoactions: update to checkout v4
Sarah Hoffmann [Tue, 5 Sep 2023 09:44:12 +0000 (11:44 +0200)]
actions: update to checkout v4

15 months agorestrict range for interpolated housenumbers
Sarah Hoffmann [Tue, 5 Sep 2023 09:41:41 +0000 (11:41 +0200)]
restrict range for interpolated housenumbers

Interpolations are only supported up to 2^32 by the database.
Limit to 8 digits, which is still more than should be needed.

15 months agoavoid interpreting integral numbers as coordinates
Sarah Hoffmann [Tue, 5 Sep 2023 09:26:47 +0000 (11:26 +0200)]
avoid interpreting integral numbers as coordinates

There are addresses of type '123 W 345 N, Reigh', where 'W 345 N' is
the actual name of the street.

15 months agoMerge pull request #3188 from lonvia/update-osm2pgsql
Sarah Hoffmann [Tue, 5 Sep 2023 08:44:32 +0000 (10:44 +0200)]
Merge pull request #3188 from lonvia/update-osm2pgsql

Update osm2pgsql to 1.9.2

15 months agoupdate osm2pgsql to 1.9.2
Sarah Hoffmann [Mon, 4 Sep 2023 12:53:46 +0000 (14:53 +0200)]
update osm2pgsql to 1.9.2

15 months agoallow lower case OSM types in lookup query
Sarah Hoffmann [Mon, 4 Sep 2023 12:39:35 +0000 (14:39 +0200)]
allow lower case OSM types in lookup query

15 months agoMerge pull request #3186 from lonvia/tablespaces-for-flex
Sarah Hoffmann [Mon, 4 Sep 2023 12:25:45 +0000 (14:25 +0200)]
Merge pull request #3186 from lonvia/tablespaces-for-flex

Make tablespace arguments work again for flex tables

15 months agoimplement NOMINATIM_SEARCH_WITHIN_COUNTRIES setting
Sarah Hoffmann [Mon, 4 Sep 2023 12:10:36 +0000 (14:10 +0200)]
implement NOMINATIM_SEARCH_WITHIN_COUNTRIES setting

15 months agoreenable tablespace arguments for flex tables
Sarah Hoffmann [Mon, 4 Sep 2023 08:45:52 +0000 (10:45 +0200)]
reenable tablespace arguments for flex tables

15 months agoadd a shutdown handler for falcon server closing DB connections
Sarah Hoffmann [Thu, 31 Aug 2023 07:40:56 +0000 (09:40 +0200)]
add a shutdown handler for falcon server closing DB connections

15 months agoremove alias where it does not work with lambdas
Sarah Hoffmann [Wed, 30 Aug 2023 19:52:51 +0000 (21:52 +0200)]
remove alias where it does not work with lambdas

Fixes #3177.

15 months agofix parameter name for layer filter
Sarah Hoffmann [Wed, 30 Aug 2023 07:54:50 +0000 (09:54 +0200)]
fix parameter name for layer filter

15 months agoMerge pull request #3178 from lonvia/library-documentation
Sarah Hoffmann [Wed, 30 Aug 2023 07:17:24 +0000 (09:17 +0200)]
Merge pull request #3178 from lonvia/library-documentation

Update documentation for new Python frontend

16 months agofix typos and grammar issues
Sarah Hoffmann [Tue, 29 Aug 2023 10:14:44 +0000 (12:14 +0200)]
fix typos and grammar issues

16 months agorename documentation to 'Nominatim Manual'
Sarah Hoffmann [Mon, 28 Aug 2023 08:59:26 +0000 (10:59 +0200)]
rename documentation to 'Nominatim Manual'

16 months agoadapt installation instruction for different frontends
Sarah Hoffmann [Mon, 28 Aug 2023 08:48:34 +0000 (10:48 +0200)]
adapt installation instruction for different frontends

16 months agoupdate API documentation
Sarah Hoffmann [Mon, 28 Aug 2023 08:31:58 +0000 (10:31 +0200)]
update API documentation

16 months agoadd deployment documentation for Python frontend
Sarah Hoffmann [Sun, 27 Aug 2023 19:27:16 +0000 (21:27 +0200)]
add deployment documentation for Python frontend

16 months agoupdate documentation for configuration
Sarah Hoffmann [Sun, 27 Aug 2023 14:08:06 +0000 (16:08 +0200)]
update documentation for configuration

16 months agoadd getting started section for library docs
Sarah Hoffmann [Sun, 27 Aug 2023 12:42:04 +0000 (14:42 +0200)]
add getting started section for library docs

16 months agoswitch to material theme
Sarah Hoffmann [Fri, 25 Aug 2023 20:47:07 +0000 (22:47 +0200)]
switch to material theme

Needed for tabbed code blocks.

16 months agopreliminary library reference finished
Sarah Hoffmann [Wed, 23 Aug 2023 13:34:07 +0000 (15:34 +0200)]
preliminary library reference finished

16 months agomore library documentation
Sarah Hoffmann [Tue, 22 Aug 2023 22:23:40 +0000 (00:23 +0200)]
more library documentation

16 months agofinish configuration section
Sarah Hoffmann [Tue, 22 Aug 2023 20:16:34 +0000 (22:16 +0200)]
finish configuration section

16 months agorestructure library documentation
Sarah Hoffmann [Tue, 22 Aug 2023 19:46:10 +0000 (21:46 +0200)]
restructure library documentation

16 months agoinitial configuration documentation
Sarah Hoffmann [Sun, 20 Aug 2023 08:42:33 +0000 (10:42 +0200)]
initial configuration documentation

16 months agodocs: documentation of API classes
Sarah Hoffmann [Sat, 19 Aug 2023 13:36:57 +0000 (15:36 +0200)]
docs: documentation of API classes

16 months agomore adaptions for mkdocstrings griffin plugin
Sarah Hoffmann [Sat, 19 Aug 2023 07:34:31 +0000 (09:34 +0200)]
more adaptions for mkdocstrings griffin plugin

16 months agoadd base framework for library reference
Sarah Hoffmann [Fri, 18 Aug 2023 16:05:57 +0000 (18:05 +0200)]
add base framework for library reference

16 months agoupdate to modern mkdocstrings python handler
Sarah Hoffmann [Fri, 18 Aug 2023 15:28:45 +0000 (17:28 +0200)]
update to modern mkdocstrings python handler

16 months agoMerge pull request #3174 from lonvia/osm2pgsql-update-fix
Sarah Hoffmann [Fri, 25 Aug 2023 19:26:23 +0000 (21:26 +0200)]
Merge pull request #3174 from lonvia/osm2pgsql-update-fix

Be more precise on what is deleted on updates

16 months agobe more strict about removal from place_to_be_deleted
Sarah Hoffmann [Fri, 25 Aug 2023 12:20:27 +0000 (14:20 +0200)]
be more strict about removal from place_to_be_deleted

If the type of a place is changed and then the same insert issued
again, the old data will effectively remain in the table.

Fixed #3168.

16 months agoadd test case for bad update
Sarah Hoffmann [Fri, 25 Aug 2023 06:45:47 +0000 (08:45 +0200)]
add test case for bad update

16 months agoMerge pull request #3172 from lonvia/query-timeout
Sarah Hoffmann [Fri, 25 Aug 2023 08:00:22 +0000 (10:00 +0200)]
Merge pull request #3172 from lonvia/query-timeout

Introduce timeouts for queries

16 months agoadd additional timeout for entire request
Sarah Hoffmann [Fri, 25 Aug 2023 07:16:53 +0000 (09:16 +0200)]
add additional timeout for entire request

16 months agouse backwards-compatible asyncio timeout implementation
Sarah Hoffmann [Thu, 24 Aug 2023 14:29:21 +0000 (16:29 +0200)]
use backwards-compatible asyncio timeout implementation

16 months agotranslate query timeouts into proper HTTP responses
Sarah Hoffmann [Thu, 24 Aug 2023 13:55:05 +0000 (15:55 +0200)]
translate query timeouts into proper HTTP responses

Need to use a 503 here because a 408 (Request timeout) will motivate
browsers to immediately resent the request.

16 months agoadd a timeout for DB queries
Sarah Hoffmann [Thu, 24 Aug 2023 12:57:33 +0000 (14:57 +0200)]
add a timeout for DB queries

16 months agoapply adjusted counts only to final result
Sarah Hoffmann [Thu, 24 Aug 2023 19:37:02 +0000 (21:37 +0200)]
apply adjusted counts only to final result

16 months agoMerge pull request #3169 from lonvia/tweak-search-with-frequent-names
Sarah Hoffmann [Thu, 24 Aug 2023 12:22:35 +0000 (14:22 +0200)]
Merge pull request #3169 from lonvia/tweak-search-with-frequent-names

Further tweak detection of queries that would return a massive amount of results

16 months agoallow terms with frequent searches together with viewbox
Sarah Hoffmann [Thu, 24 Aug 2023 07:21:09 +0000 (09:21 +0200)]
allow terms with frequent searches together with viewbox

16 months agoMerge pull request #3167 from lonvia/explicit-encoding
Sarah Hoffmann [Thu, 24 Aug 2023 06:53:11 +0000 (08:53 +0200)]
Merge pull request #3167 from lonvia/explicit-encoding

Send explicit charset in content-type when returning json

16 months agoMerge pull request #3139 from mtmail/update-search-examples
Sarah Hoffmann [Wed, 23 Aug 2023 21:41:30 +0000 (23:41 +0200)]
Merge pull request #3139 from mtmail/update-search-examples

Search.md - update XML and JSON example output

16 months agofurther tweak search containing very frequent tokens
Sarah Hoffmann [Wed, 23 Aug 2023 21:04:12 +0000 (23:04 +0200)]
further tweak search containing very frequent tokens

Excluding non-rare full names is not really possible because it makes
addresses with street names like 'main st' unsearchable. This tries to
leav all names in but refrain from ordering results by accuracy
when too many results are expected. This means that the DB will simply
get the first n results without any particular order.

16 months agosend charset again in content-type when returning json
Sarah Hoffmann [Wed, 23 Aug 2023 18:55:57 +0000 (20:55 +0200)]
send charset again in content-type when returning json

There are quite a few applications out there that will use some local
encoding when the charset is not explicitly given.

16 months agoMerge pull request #3165 from lonvia/update-osm2pgsql
Sarah Hoffmann [Wed, 23 Aug 2023 13:57:55 +0000 (15:57 +0200)]
Merge pull request #3165 from lonvia/update-osm2pgsql

Update osm2pgsql to 1.9.1

16 months agovagrant scripts: add missing yaml library
Sarah Hoffmann [Wed, 23 Aug 2023 06:34:12 +0000 (08:34 +0200)]
vagrant scripts: add missing yaml library

16 months agoadd new required json library for osm2pgsql
Sarah Hoffmann [Tue, 22 Aug 2023 18:05:25 +0000 (20:05 +0200)]
add new required json library for osm2pgsql

16 months agoupdate osm2pgsql to 1.9.1
Sarah Hoffmann [Tue, 22 Aug 2023 13:04:50 +0000 (15:04 +0200)]
update osm2pgsql to 1.9.1

16 months agoMerge pull request #3159 from lonvia/fix-name-lookup-for-housenames
Sarah Hoffmann [Sun, 20 Aug 2023 13:52:20 +0000 (15:52 +0200)]
Merge pull request #3159 from lonvia/fix-name-lookup-for-housenames

Fix name lookup for housenames

16 months agofix parameter use for ST_Project
Sarah Hoffmann [Sun, 20 Aug 2023 11:52:03 +0000 (13:52 +0200)]
fix parameter use for ST_Project

Before postgis 3.4 ST_Project required a geography as input and seemed
to have implicitly converted to geography. Since 3.4 geometry input
is supported but leads to a completely different result.