]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
21 months agobdd: extend reverse API tests for format checks
Sarah Hoffmann [Thu, 9 Mar 2023 19:20:50 +0000 (20:20 +0100)]
bdd: extend reverse API tests for format checks

Reorganise the API reverse tests and extend the checks for the
output format, testing for all expected fields.

21 months agobdd: add tests for valid debug output
Sarah Hoffmann [Thu, 9 Mar 2023 19:10:51 +0000 (20:10 +0100)]
bdd: add tests for valid debug output

21 months agobdd: replace old formatting strings
Sarah Hoffmann [Thu, 9 Mar 2023 18:49:55 +0000 (19:49 +0100)]
bdd: replace old formatting strings

21 months agobdd: more format checks for reverse XML
Sarah Hoffmann [Thu, 9 Mar 2023 18:40:24 +0000 (19:40 +0100)]
bdd: more format checks for reverse XML

21 months agobdd: new step variant 'result contains in field'
Sarah Hoffmann [Thu, 9 Mar 2023 18:31:21 +0000 (19:31 +0100)]
bdd: new step variant 'result contains in field'

This replaces the + notation for recursing into result dictionaries.

21 months agobdd: factor out computation of result to-check lists
Sarah Hoffmann [Thu, 9 Mar 2023 17:01:45 +0000 (18:01 +0100)]
bdd: factor out computation of result to-check lists

21 months agobdd: replace property_list construct with standard check functions
Sarah Hoffmann [Thu, 9 Mar 2023 16:55:27 +0000 (17:55 +0100)]
bdd: replace property_list construct with standard check functions

21 months agobdd: remove special case for osm_type field
Sarah Hoffmann [Thu, 9 Mar 2023 16:44:34 +0000 (17:44 +0100)]
bdd: remove special case for osm_type field

The fuzzy field check hide cover formatting errors. Use 'osm' when
only caring about the conent.

21 months agobdd: reorganise field comparisons
Sarah Hoffmann [Thu, 9 Mar 2023 16:05:05 +0000 (17:05 +0100)]
bdd: reorganise field comparisons

Move comparision on Field values from assert_field() into a
comparator class. Replace BadRowValueAssert with a simpler
check_row() function.

21 months agobdd: use new check_for_attributes() function also in steps
Sarah Hoffmann [Thu, 9 Mar 2023 15:44:07 +0000 (16:44 +0100)]
bdd: use new check_for_attributes() function also in steps

21 months agobdd: fully check correctness of geojson and geocodejson
Sarah Hoffmann [Thu, 9 Mar 2023 15:36:46 +0000 (16:36 +0100)]
bdd: fully check correctness of geojson and geocodejson

Parse code now checks presence of all required fields and exports
all fields for inspection.

21 months agobdd: remove OrderedDict
Sarah Hoffmann [Thu, 9 Mar 2023 15:08:39 +0000 (16:08 +0100)]
bdd: remove OrderedDict

dicts are guaranteed to keep insertion order by since Python 3.7, making
use of ORderedDict mute.

21 months agoMerge pull request #2993 from biswajit-k/delete-tags
Sarah Hoffmann [Thu, 9 Mar 2023 13:31:45 +0000 (14:31 +0100)]
Merge pull request #2993 from biswajit-k/delete-tags

Adds sanitizer for preventing certain tags to enter search index based on parameters

21 months agoAdds sanitizer for preventing certain tags to enter search index based on parameters
biswajit-k [Thu, 2 Mar 2023 14:55:06 +0000 (20:25 +0530)]
Adds sanitizer for preventing certain tags to enter search index based on parameters

fix: pylint error

added docs for delete tags sanitizer

fixed typos in docs and code comments

fix: python typechecking error

fixed rank address type

Revert "fixed typos in docs and code comments"

This reverts commit 6839eea755a87f557895f30524fb5c03dd983d60.

added default parameters and refactored code

added test for all parameters

21 months agoMerge pull request #2999 from biswajit-k/fix-typos
Sarah Hoffmann [Wed, 8 Mar 2023 07:55:27 +0000 (08:55 +0100)]
Merge pull request #2999 from biswajit-k/fix-typos

fixed typos in docs and code comments

21 months agofixed typos in docs and code comments
biswajit-k [Mon, 6 Mar 2023 11:39:38 +0000 (17:09 +0530)]
fixed typos in docs and code comments

21 months agoadd latest security incident
Sarah Hoffmann [Wed, 22 Feb 2023 10:24:04 +0000 (11:24 +0100)]
add latest security incident

Also removes 3.6 which is no longer supported.

21 months agoharmonize flags for PHP's htmlspecialchars
Sarah Hoffmann [Mon, 20 Feb 2023 15:46:53 +0000 (16:46 +0100)]
harmonize flags for PHP's htmlspecialchars

21 months agoadapt PHP tests for debug output
Sarah Hoffmann [Mon, 20 Feb 2023 15:23:28 +0000 (16:23 +0100)]
adapt PHP tests for debug output

21 months agoproperly encode special HTML characters in debug mode
Sarah Hoffmann [Mon, 20 Feb 2023 14:41:04 +0000 (15:41 +0100)]
properly encode special HTML characters in debug mode

21 months agoMerge pull request #2986 from mtmail/add-more-languages-from-osm-wiki
Sarah Hoffmann [Mon, 20 Feb 2023 10:12:08 +0000 (11:12 +0100)]
Merge pull request #2986 from mtmail/add-more-languages-from-osm-wiki

sp_wiki_loader: add more default languages

21 months agosp_wiki_loader: add more default languages
marc tobias [Fri, 17 Feb 2023 23:31:21 +0000 (00:31 +0100)]
sp_wiki_loader: add more default languages

21 months agoadd timestamp to debug SQL output
Sarah Hoffmann [Sat, 18 Feb 2023 08:49:30 +0000 (09:49 +0100)]
add timestamp to debug SQL output

21 months agoadd warning for reverse index migration
Sarah Hoffmann [Sat, 18 Feb 2023 08:43:37 +0000 (09:43 +0100)]
add warning for reverse index migration

21 months agoMerge pull request #2985 from lonvia/fix-place-rank-inheritance
Sarah Hoffmann [Sat, 18 Feb 2023 08:35:19 +0000 (09:35 +0100)]
Merge pull request #2985 from lonvia/fix-place-rank-inheritance

Restrict place rank inheritance to address items

22 months agorestrict place rank inheritance to address items
Sarah Hoffmann [Fri, 17 Feb 2023 15:25:26 +0000 (16:25 +0100)]
restrict place rank inheritance to address items

Place tags must have no influence on street- or POI-level
objects.

22 months agoMerge pull request #2983 from lonvia/improve-reverse-place-node-lookup
Sarah Hoffmann [Fri, 17 Feb 2023 14:51:55 +0000 (15:51 +0100)]
Merge pull request #2983 from lonvia/improve-reverse-place-node-lookup

Improve reverse place node lookup

22 months agouse reverse buffered index for search within country
Sarah Hoffmann [Fri, 17 Feb 2023 10:27:50 +0000 (11:27 +0100)]
use reverse buffered index for search within country

22 months agospeed up reverse lookup of place nodes
Sarah Hoffmann [Fri, 17 Feb 2023 09:31:49 +0000 (10:31 +0100)]
speed up reverse lookup of place nodes

Add a special index that contains the place nodes buffered by their
respective area according to their search rank. This replaces the
maximum area search for place nodes and reduces drastically the number
of place nodes that need to be retrieved.

22 months agoMerge pull request #2981 from lonvia/add-point-wkb-decoder
Sarah Hoffmann [Fri, 17 Feb 2023 07:40:14 +0000 (08:40 +0100)]
Merge pull request #2981 from lonvia/add-point-wkb-decoder

Python frontend: add a WKB decoder for the Point class

22 months agoadd a WKB decoder for the Point class
Sarah Hoffmann [Thu, 16 Feb 2023 14:35:54 +0000 (15:35 +0100)]
add a WKB decoder for the Point class

This allows to return point geometries from the database and makes
the SQL a bit simpler.

22 months agoMerge pull request #2978 from lonvia/add-debug-view
Sarah Hoffmann [Tue, 14 Feb 2023 13:08:42 +0000 (14:08 +0100)]
Merge pull request #2978 from lonvia/add-debug-view

Add debug view to Python API

22 months agoadd typing information for pygments to requirements
Sarah Hoffmann [Sun, 12 Feb 2023 09:17:08 +0000 (10:17 +0100)]
add typing information for pygments to requirements

22 months agoactions: use token to avoid rate limiting
Sarah Hoffmann [Sun, 12 Feb 2023 08:34:22 +0000 (09:34 +0100)]
actions: use token to avoid rate limiting

22 months agoadd debug output for unit tests
Sarah Hoffmann [Tue, 14 Feb 2023 10:05:37 +0000 (11:05 +0100)]
add debug output for unit tests

This uses the debug output facility meant for pretty HTML output
to give us debugging output for the unit tests.

22 months agoadd HTML-formatted debug output to lookup
Sarah Hoffmann [Sat, 11 Feb 2023 19:42:24 +0000 (20:42 +0100)]
add HTML-formatted debug output to lookup

22 months agoMerge pull request #2974 from bloom256/main-tag-in-reverse-lookup
Sarah Hoffmann [Sat, 11 Feb 2023 10:01:11 +0000 (11:01 +0100)]
Merge pull request #2974 from bloom256/main-tag-in-reverse-lookup

Main tag information added to geocodejson in reverse geocoding

22 months agoMerge pull request #2975 from bloom256/typo-fix
Sarah Hoffmann [Sat, 11 Feb 2023 10:00:15 +0000 (11:00 +0100)]
Merge pull request #2975 from bloom256/typo-fix

typo fixed

22 months agotypo fixed
danil [Tue, 7 Feb 2023 20:21:58 +0000 (00:21 +0400)]
typo fixed

22 months agoMain tag information added to geocodejson in reverse geocoding
danil [Tue, 7 Feb 2023 20:19:49 +0000 (00:19 +0400)]
Main tag information added to geocodejson in reverse geocoding

22 months agoMerge pull request #2970 from lonvia/add-details-endpoint
Sarah Hoffmann [Mon, 6 Feb 2023 15:32:35 +0000 (16:32 +0100)]
Merge pull request #2970 from lonvia/add-details-endpoint

Python implementation of details endpoint

22 months agoactions: force PHPUnit 9
Sarah Hoffmann [Sat, 4 Feb 2023 13:23:19 +0000 (14:23 +0100)]
actions: force PHPUnit 9

PHPUnit 10 is incompatible with our tests. Not worth adapting anymore.

22 months agoadd tests for details result formatting and trim results
Sarah Hoffmann [Sat, 4 Feb 2023 13:17:47 +0000 (14:17 +0100)]
add tests for details result formatting and trim results

Values that are None are no longer included in the output to save
a bit of bandwidth.

22 months agoexpand details BDD tests
Sarah Hoffmann [Fri, 3 Feb 2023 20:59:16 +0000 (21:59 +0100)]
expand details BDD tests

There are now minor differences in the output between PHP and
Python versions, so introduce specific tests.

22 months agoimplement details endpoint in Python servers
Sarah Hoffmann [Fri, 3 Feb 2023 20:14:33 +0000 (21:14 +0100)]
implement details endpoint in Python servers

22 months agoswitch details cli command to new Python implementation
Sarah Hoffmann [Fri, 3 Feb 2023 09:43:54 +0000 (10:43 +0100)]
switch details cli command to new Python implementation

22 months agoadd lookup of postcdoe data
Sarah Hoffmann [Thu, 2 Feb 2023 15:22:18 +0000 (16:22 +0100)]
add lookup of postcdoe data

22 months agoadd lookup of tiger data
Sarah Hoffmann [Thu, 2 Feb 2023 14:31:42 +0000 (15:31 +0100)]
add lookup of tiger data

22 months agoadd lookup of address interpolations
Sarah Hoffmann [Thu, 2 Feb 2023 14:01:54 +0000 (15:01 +0100)]
add lookup of address interpolations

22 months agofix new linting issues from pylint 2.16
Sarah Hoffmann [Thu, 2 Feb 2023 08:48:20 +0000 (09:48 +0100)]
fix new linting issues from pylint 2.16

22 months agoadd unit tests for lookup function
Sarah Hoffmann [Wed, 1 Feb 2023 21:59:31 +0000 (22:59 +0100)]
add unit tests for lookup function

22 months agoimprove scaffolding for API unit tests
Sarah Hoffmann [Wed, 1 Feb 2023 09:22:53 +0000 (10:22 +0100)]
improve scaffolding for API unit tests

Use the static table definition to create the test database.
Add helper function to simplify filling the tables.

22 months agoadd lookup() call to the library API
Sarah Hoffmann [Wed, 1 Feb 2023 08:56:33 +0000 (09:56 +0100)]
add lookup() call to the library API

Currently only looks places up in placex.

22 months agodocs: fix internal links
Sarah Hoffmann [Sat, 4 Feb 2023 20:21:23 +0000 (21:21 +0100)]
docs: fix internal links

Fixes #2968.

22 months agoMerge pull request #2963 from lonvia/add-sqlalchemy-schema
Sarah Hoffmann [Mon, 30 Jan 2023 10:17:22 +0000 (11:17 +0100)]
Merge pull request #2963 from lonvia/add-sqlalchemy-schema

Add table definitions for SQLAlchemy

22 months agoadd pytest-asyncio as a requirement for testing
Sarah Hoffmann [Sun, 29 Jan 2023 08:53:42 +0000 (09:53 +0100)]
add pytest-asyncio as a requirement for testing

22 months agoadd property cache for API
Sarah Hoffmann [Sat, 28 Jan 2023 21:24:36 +0000 (22:24 +0100)]
add property cache for API

This caches results from querying nominatim_properties.

22 months agoadapt annotations for SQLAlchemy 2.x
Sarah Hoffmann [Fri, 27 Jan 2023 20:53:53 +0000 (21:53 +0100)]
adapt annotations for SQLAlchemy 2.x

It is not possible to produce type annotations that work with both
versions 1.4 and 2.0. So keep to the principle of only supporting
newest versions when it comes to mypy. This means that some types
may have to be string quoted to not cause issues when running with
SQLAlchemy 1.4.

22 months agoadd new geoalchemy requirement
Sarah Hoffmann [Fri, 27 Jan 2023 08:15:06 +0000 (09:15 +0100)]
add new geoalchemy requirement

22 months agoadapt status to use SQLAlchemy tables
Sarah Hoffmann [Thu, 26 Jan 2023 16:55:46 +0000 (17:55 +0100)]
adapt status to use SQLAlchemy tables

22 months agoconvert StatusResult to a dataclass
Sarah Hoffmann [Thu, 26 Jan 2023 16:51:15 +0000 (17:51 +0100)]
convert StatusResult to a dataclass

This gives us nice str() functions.

22 months agoadd SQLAlchemy table schema for Nominatim tables
Sarah Hoffmann [Thu, 26 Jan 2023 16:36:11 +0000 (17:36 +0100)]
add SQLAlchemy table schema for Nominatim tables

Also defines an extended connection object that includes access to
the table definitions. Makes it easier to access the tables from
code that has been split off into separate modules.

22 months agoMerge pull request #2958 from lonvia/streaming-json-writer
Sarah Hoffmann [Wed, 25 Jan 2023 16:36:23 +0000 (17:36 +0100)]
Merge pull request #2958 from lonvia/streaming-json-writer

Introduce streaming json writer for JSON output

22 months agoadd streaming json writer for JSON output
Sarah Hoffmann [Wed, 25 Jan 2023 13:14:47 +0000 (14:14 +0100)]
add streaming json writer for JSON output

22 months agoMerge pull request #2957 from lonvia/reorganise-api-module
Sarah Hoffmann [Wed, 25 Jan 2023 08:29:31 +0000 (09:29 +0100)]
Merge pull request #2957 from lonvia/reorganise-api-module

Assorted improvements to the new api library module

22 months agoallow to add php-compatible endpoints
Sarah Hoffmann [Tue, 24 Jan 2023 20:36:45 +0000 (21:36 +0100)]
allow to add php-compatible endpoints

If the new setting NOMINATIM_SERVE_LEGACY_URLS is set, the servers
expose the endpoints also with the .php suffix to ensure backwards
compatibility.

22 months agoadd support for CORS headers
Sarah Hoffmann [Tue, 24 Jan 2023 20:26:32 +0000 (21:26 +0100)]
add support for CORS headers

Adds the additional dependency to sanic-cors for the Sanic server.

22 months agofactor out common server implementation code
Sarah Hoffmann [Tue, 24 Jan 2023 20:04:32 +0000 (21:04 +0100)]
factor out common server implementation code

Most of the server implementation of V1 API now resides in
api.v1.server_glue. The webframeworks only supply some glue code
which is independent to changes in the API code.

22 months agoreorganize code around result formatting
Sarah Hoffmann [Tue, 24 Jan 2023 16:20:51 +0000 (17:20 +0100)]
reorganize code around result formatting

Code is now organized by api version. So formatting has moved to
the api.v1 module. Instead of holding a separate ResultFormatter
object per result format, simply move the functions to the
formater collector and hand in the requested format as a parameter.
Thus reorganized, the api.v1 module can export three simple functions
for result formatting which in turn makes the code that uses
the formatters much simpler.

22 months agoreorganize api submodule
Sarah Hoffmann [Tue, 24 Jan 2023 12:28:04 +0000 (13:28 +0100)]
reorganize api submodule

Use a directory for the submodule where the __init__ file contains
the public API. This makes it easier to separate public interface
from the internal implementation.

22 months agoapi: delay setup of initial database connection
Sarah Hoffmann [Tue, 24 Jan 2023 09:56:22 +0000 (10:56 +0100)]
api: delay setup of initial database connection

Defer database setup until the first call to a function. Needs an
additional lock because the setup still needs to be done sequentially.

22 months agoMerge pull request #2955 from lonvia/fix-importance-refresh
Sarah Hoffmann [Mon, 23 Jan 2023 08:07:43 +0000 (09:07 +0100)]
Merge pull request #2955 from lonvia/fix-importance-refresh

Fix importance recalculation

22 months agoMerge pull request #2954 from lonvia/remove-comma-as-separator
Sarah Hoffmann [Mon, 23 Jan 2023 08:06:23 +0000 (09:06 +0100)]
Merge pull request #2954 from lonvia/remove-comma-as-separator

Remove comma as name separator

22 months agofix importance recalculation
Sarah Hoffmann [Sun, 22 Jan 2023 20:30:43 +0000 (21:30 +0100)]
fix importance recalculation

The signature of the compute_importance() function has changed.

22 months agoremove comma as name separator
Sarah Hoffmann [Sun, 22 Jan 2023 20:10:12 +0000 (21:10 +0100)]
remove comma as name separator

Commas are most of the time used as a part of a name, not to
separate multiple names.

See also #2950.

22 months agoexclude names ending in :wikipedia from indexing
Sarah Hoffmann [Sat, 21 Jan 2023 10:16:08 +0000 (11:16 +0100)]
exclude names ending in :wikipedia from indexing

The wikipedia prefix is used for referencing a wikipedia article
for the given tag, not the object, so not useful to search.

22 months agofix typo in argument to details CLI command
Sarah Hoffmann [Sat, 21 Jan 2023 09:44:10 +0000 (10:44 +0100)]
fix typo in argument to details CLI command

Fixes #2951.

23 months agoupdate Makefile in test directory
Sarah Hoffmann [Mon, 9 Jan 2023 19:49:33 +0000 (20:49 +0100)]
update Makefile in test directory

23 months agoMerge pull request #2940 from lonvia/remove-ubuntu-18-from-actions
Sarah Hoffmann [Thu, 5 Jan 2023 19:16:19 +0000 (20:16 +0100)]
Merge pull request #2940 from lonvia/remove-ubuntu-18-from-actions

Actions: use Ubuntu 20 image for testing old versions of dependent software

23 months agoincrease minimum required version of PHP to 7.3
Sarah Hoffmann [Thu, 5 Jan 2023 15:58:46 +0000 (16:58 +0100)]
increase minimum required version of PHP to 7.3

Other versions are not tested anymore.

23 months agoactions: move tests from Ubuntu 18 to 20
Sarah Hoffmann [Thu, 5 Jan 2023 14:35:03 +0000 (15:35 +0100)]
actions: move tests from Ubuntu 18 to 20

These are the tests that try to make sure old library version really
still work as expected. Increases PHP to 7.3 because 7.2 has errors.

23 months agodo not run osm2pgsql append with mutliple threads
Sarah Hoffmann [Thu, 5 Jan 2023 10:34:56 +0000 (11:34 +0100)]
do not run osm2pgsql append with mutliple threads

As the updates modify the placex table, there may be deadlocks
when different objects want to forward modifications to the same
place (for example because they are both linked to it).

23 months agoMerge pull request #2937 from lonvia/python-server-stub
Sarah Hoffmann [Tue, 3 Jan 2023 13:26:33 +0000 (14:26 +0100)]
Merge pull request #2937 from lonvia/python-server-stub

Scaffolding for new Python-based search frontend

23 months agoMerge pull request #2856 from t-tomek/patch-1
Sarah Hoffmann [Tue, 3 Jan 2023 09:58:50 +0000 (10:58 +0100)]
Merge pull request #2856 from t-tomek/patch-1

Update DB.php

23 months agono type checking on old Ubuntu 18
Sarah Hoffmann [Wed, 14 Dec 2022 20:24:02 +0000 (21:24 +0100)]
no type checking on old Ubuntu 18

23 months agoadd event handler for default connection settings
Sarah Hoffmann [Wed, 14 Dec 2022 19:31:46 +0000 (20:31 +0100)]
add event handler for default connection settings

23 months agoupdate versions for Python packages
Sarah Hoffmann [Wed, 14 Dec 2022 15:41:52 +0000 (16:41 +0100)]
update versions for Python packages

23 months agodrop official support for Ubuntu 18
Sarah Hoffmann [Wed, 14 Dec 2022 15:24:38 +0000 (16:24 +0100)]
drop official support for Ubuntu 18

23 months agodrop support for Python 3.6
Sarah Hoffmann [Wed, 14 Dec 2022 15:14:23 +0000 (16:14 +0100)]
drop support for Python 3.6

23 months agoupdate dependencies for Actions
Sarah Hoffmann [Tue, 13 Dec 2022 11:12:05 +0000 (12:12 +0100)]
update dependencies for Actions

23 months agoconvert version to named tuple
Sarah Hoffmann [Tue, 13 Dec 2022 09:36:19 +0000 (10:36 +0100)]
convert version to named tuple

Also return the new NominatimVersion rather than a string in the
status result.

23 months agofix error message for non-existing database
Sarah Hoffmann [Wed, 7 Dec 2022 19:05:24 +0000 (20:05 +0100)]
fix error message for non-existing database

23 months agoadd unit tests for new Python API
Sarah Hoffmann [Wed, 7 Dec 2022 18:47:46 +0000 (19:47 +0100)]
add unit tests for new Python API

23 months agodocs: extend dependency documentation
Sarah Hoffmann [Tue, 6 Dec 2022 11:00:39 +0000 (12:00 +0100)]
docs: extend dependency documentation

23 months agoextend BDD API tests to query via Python frameworks
Sarah Hoffmann [Tue, 6 Dec 2022 10:20:50 +0000 (11:20 +0100)]
extend BDD API tests to query via Python frameworks

A new config option ENGINE allows to choose between php and any of the
supported Python engines.

23 months agofix liniting issues and add type annotations
Sarah Hoffmann [Mon, 5 Dec 2022 15:16:18 +0000 (16:16 +0100)]
fix liniting issues and add type annotations

23 months agoadd support for starlette framework
Sarah Hoffmann [Mon, 5 Dec 2022 10:32:57 +0000 (11:32 +0100)]
add support for starlette framework

23 months agoadd support for falcon as server framework
Sarah Hoffmann [Fri, 2 Dec 2022 16:28:46 +0000 (17:28 +0100)]
add support for falcon as server framework

23 months agoadd sanic development server implementation
Sarah Hoffmann [Thu, 1 Dec 2022 16:58:22 +0000 (17:58 +0100)]
add sanic development server implementation

23 months agoimplement command line status call in Python
Sarah Hoffmann [Fri, 18 Nov 2022 15:11:31 +0000 (16:11 +0100)]
implement command line status call in Python