]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
7 years agoreplace double-quoting with single quotes where applicable
Sarah Hoffmann [Thu, 26 Oct 2017 19:21:21 +0000 (21:21 +0200)]
replace double-quoting with single quotes where applicable

7 years agoPHP code style rule to enforce single quotes
marc tobias [Sat, 21 Oct 2017 12:52:58 +0000 (14:52 +0200)]
PHP code style rule to enforce single quotes

7 years agoMerge pull request #834 from mtmail/tests-for-closest-housenumber
Sarah Hoffmann [Thu, 26 Oct 2017 18:51:51 +0000 (20:51 +0200)]
Merge pull request #834 from mtmail/tests-for-closest-housenumber

tests for lib.php closestHouseNumber

7 years agotests for lib.php closestHouseNumber
Marc Tobias Metten [Wed, 25 Oct 2017 21:58:13 +0000 (23:58 +0200)]
tests for lib.php closestHouseNumber

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Wed, 25 Oct 2017 20:47:38 +0000 (22:47 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agorestrict number of results for reverse queries
Sarah Hoffmann [Wed, 25 Oct 2017 20:34:29 +0000 (22:34 +0200)]
restrict number of results for reverse queries

When given a coordinate off the coast of a large town, the entire
town may end up in the potential results during the reverse query.
Postgres then needs to sort tens of thousands of results before it
can determine the clostest one. Given that the results at such a
large search radius are bound to be imprecise anyway, restrict
the number of results postgres should consider to 1000.

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Wed, 25 Oct 2017 18:26:01 +0000 (20:26 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agofix variable typo when filtering results
Sarah Hoffmann [Wed, 25 Oct 2017 18:16:35 +0000 (20:16 +0200)]
fix variable typo when filtering results

Fixes #830 and #832.

7 years agoplacex must not return a lookup housenumber
Sarah Hoffmann [Wed, 25 Oct 2017 18:11:51 +0000 (20:11 +0200)]
placex must not return a lookup housenumber

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Tue, 24 Oct 2017 21:33:35 +0000 (23:33 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agopenalize housenumber after the postcode
Sarah Hoffmann [Tue, 24 Oct 2017 21:30:41 +0000 (23:30 +0200)]
penalize housenumber after the postcode

7 years agofix uninitialised rank variable when regrouping searches
Sarah Hoffmann [Tue, 24 Oct 2017 21:17:47 +0000 (23:17 +0200)]
fix uninitialised rank variable when regrouping searches

7 years agorevert use of global penalty for a search direction
Sarah Hoffmann [Tue, 24 Oct 2017 20:42:29 +0000 (22:42 +0200)]
revert use of global penalty for a search direction

Adding a penalty to a search description because there
is a term at the beginning which looks like a country
turned out to be a bad idea as there are too many
abbreviations around that match against frequently
matched words.

7 years agotiger import: convert counties to str
Sarah Hoffmann [Mon, 23 Oct 2017 19:24:11 +0000 (21:24 +0200)]
tiger import: convert counties to str

For python2 the gdal features come out as str and
cannot be combined with unicode strings.

7 years agohuge cleanup of tigerAddressImport.py
marc tobias [Sun, 22 Oct 2017 09:28:34 +0000 (11:28 +0200)]
huge cleanup of tigerAddressImport.py

7 years agohuge cleanup of tigerAddressImport.py
marc tobias [Sun, 22 Oct 2017 09:01:10 +0000 (11:01 +0200)]
huge cleanup of tigerAddressImport.py

7 years agoMerge pull request #829 from lonvia/result-as-a-class
Sarah Hoffmann [Tue, 24 Oct 2017 20:17:59 +0000 (22:17 +0200)]
Merge pull request #829 from lonvia/result-as-a-class

Use PlaceLookup in search for retriving place details

7 years agouse PlaceLookup::loadParamArray in search and lookup
Sarah Hoffmann [Mon, 23 Oct 2017 21:28:00 +0000 (23:28 +0200)]
use PlaceLookup::loadParamArray in search and lookup

7 years agoadd loadParamArray function to PlaceLookup and use for reverse
Sarah Hoffmann [Mon, 23 Oct 2017 20:33:14 +0000 (22:33 +0200)]
add loadParamArray function to PlaceLookup and use for reverse

7 years agouse PlaceLookup in search
Sarah Hoffmann [Sun, 22 Oct 2017 19:59:08 +0000 (21:59 +0200)]
use PlaceLookup in search

7 years agomake PlaceLookup::lookup() accept multiple results
Sarah Hoffmann [Sun, 22 Oct 2017 18:20:56 +0000 (20:20 +0200)]
make PlaceLookup::lookup() accept multiple results

7 years agoreplace SQL code in PlaceLookup with content of search's get_details
Sarah Hoffmann [Sun, 22 Oct 2017 17:01:14 +0000 (19:01 +0200)]
replace SQL code in PlaceLookup with content of search's get_details

7 years agouse Result class in reverse geocoding
Sarah Hoffmann [Fri, 20 Oct 2017 13:41:26 +0000 (15:41 +0200)]
use Result class in reverse geocoding

Also simplifies the reverse algorithm slightly by no longer
having an additional distance lookup.

7 years agointroduce Result class in Geocode and SearchDescription
Sarah Hoffmann [Wed, 18 Oct 2017 21:54:47 +0000 (23:54 +0200)]
introduce Result class in Geocode and SearchDescription

7 years agoMerge pull request #822 from mtmail/ui-allow-copypaste-combined-latlon
Sarah Hoffmann [Sun, 22 Oct 2017 10:11:02 +0000 (12:11 +0200)]
Merge pull request #822 from mtmail/ui-allow-copypaste-combined-latlon

Ui allow copypaste combined latlon

7 years agoMerge pull request #819 from mtmail/tiger-2017-import
Sarah Hoffmann [Sat, 21 Oct 2017 13:50:05 +0000 (15:50 +0200)]
Merge pull request #819 from mtmail/tiger-2017-import

Tiger 2017 data no longer contains -divroad- field

7 years agoUI: allow copy&pasting lat,lon into the lat search field
marc tobias [Sat, 21 Oct 2017 12:28:28 +0000 (14:28 +0200)]
UI: allow copy&pasting lat,lon into the lat search field

7 years agoUI: allow copy&pasting lat,lon into the lat search field
marc tobias [Sat, 21 Oct 2017 12:11:46 +0000 (14:11 +0200)]
UI: allow copy&pasting lat,lon into the lat search field

7 years agoMerge pull request #821 from mtmail/ui-scrollwheel-minimap
Sarah Hoffmann [Sat, 21 Oct 2017 11:53:24 +0000 (13:53 +0200)]
Merge pull request #821 from mtmail/ui-scrollwheel-minimap

UI: scrollwheel, minimap

7 years agoUI: scrollwheel, minimap
marc tobias [Sat, 21 Oct 2017 11:24:02 +0000 (13:24 +0200)]
UI: scrollwheel, minimap

7 years agoMerge pull request #820 from mtmail/php-test-path-changed
Sarah Hoffmann [Sat, 21 Oct 2017 10:17:50 +0000 (12:17 +0200)]
Merge pull request #820 from mtmail/php-test-path-changed

Vagrant documentation: update path to php tests

7 years agoVagrant documentation: update path to php tests
marc tobias [Sat, 21 Oct 2017 09:46:12 +0000 (11:46 +0200)]
Vagrant documentation: update path to php tests

7 years agoTiger 2017 data no longer contains -divroad- field
marc tobias [Fri, 20 Oct 2017 13:17:51 +0000 (15:17 +0200)]
Tiger 2017 data no longer contains -divroad- field

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Sun, 15 Oct 2017 16:08:25 +0000 (18:08 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agoMerge pull request #814 from lonvia/phrase-as-a-class
Sarah Hoffmann [Sun, 15 Oct 2017 16:07:55 +0000 (18:07 +0200)]
Merge pull request #814 from lonvia/phrase-as-a-class

Make phrases a class and add early checking of token validity

7 years agoadapt unit tests to new Phrase class
Sarah Hoffmann [Sat, 14 Oct 2017 18:28:52 +0000 (20:28 +0200)]
adapt unit tests to new Phrase class

7 years agofix CodeSniffer offences
Sarah Hoffmann [Fri, 13 Oct 2017 21:11:09 +0000 (23:11 +0200)]
fix CodeSniffer offences

7 years agomove word recheck into token collection
Sarah Hoffmann [Fri, 13 Oct 2017 21:04:12 +0000 (23:04 +0200)]
move word recheck into token collection

Drop tokens for special and postcode searches already when
collecting them for ValidTokens when they cannot be found
in the normalized query.

7 years agosimplify cross-check of country tokens
Sarah Hoffmann [Fri, 13 Oct 2017 20:23:39 +0000 (22:23 +0200)]
simplify cross-check of country tokens

Drop country tokens that do not match the country code list
early. Remove in turn the special country code check for
structured phrases. It is sufficient to do this during
word list building.

7 years agoremove unused $aPossibleMainWordIDs array
Sarah Hoffmann [Fri, 13 Oct 2017 19:34:13 +0000 (21:34 +0200)]
remove unused $aPossibleMainWordIDs array

7 years agoadd documentation for Phrase
Sarah Hoffmann [Fri, 13 Oct 2017 19:23:45 +0000 (21:23 +0200)]
add documentation for Phrase

7 years agotake frequency scores from token description
Sarah Hoffmann [Thu, 12 Oct 2017 20:59:07 +0000 (22:59 +0200)]
take frequency scores from token description

No need to hand them in separately.

7 years agoconvert phrase array to class
Sarah Hoffmann [Thu, 12 Oct 2017 20:37:44 +0000 (22:37 +0200)]
convert phrase array to class

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Thu, 12 Oct 2017 19:03:55 +0000 (21:03 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agotake country names only from relations
Sarah Hoffmann [Thu, 12 Oct 2017 19:03:03 +0000 (21:03 +0200)]
take country names only from relations

7 years agoShow address rank in details and hide unset admin_level
Sarah Hoffmann [Wed, 11 Oct 2017 20:17:59 +0000 (22:17 +0200)]
Show address rank in details and hide unset admin_level

Address rank explains better why the address parts are where
they are.

Fixes #766.

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Tue, 10 Oct 2017 21:03:50 +0000 (23:03 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agoSort results for near searches by proximity
Sarah Hoffmann [Tue, 10 Oct 2017 20:42:23 +0000 (22:42 +0200)]
Sort results for near searches by proximity

If a reference coordinate is given, results really should be
sorted by distance to this point ignoring importance completely.

Fixes #796.

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Tue, 10 Oct 2017 19:25:43 +0000 (21:25 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agorevert customizations prior to merge of refactoring
Sarah Hoffmann [Tue, 10 Oct 2017 19:23:45 +0000 (21:23 +0200)]
revert customizations prior to merge of refactoring

7 years agoMerge pull request #812 from lonvia/search-as-a-class
Sarah Hoffmann [Tue, 10 Oct 2017 19:08:11 +0000 (21:08 +0200)]
Merge pull request #812 from lonvia/search-as-a-class

Refactoring Search arrays

7 years agodocumentation for SearchContext and SearchDescription
Sarah Hoffmann [Mon, 9 Oct 2017 22:15:56 +0000 (00:15 +0200)]
documentation for SearchContext and SearchDescription

7 years agocoding style and some documentation
Sarah Hoffmann [Mon, 9 Oct 2017 21:12:13 +0000 (23:12 +0200)]
coding style and some documentation

7 years agomove complete search query code into SearchDescription
Sarah Hoffmann [Mon, 9 Oct 2017 20:55:50 +0000 (22:55 +0200)]
move complete search query code into SearchDescription

7 years agoadapt phpunit tests to new SearchContext class
Sarah Hoffmann [Mon, 9 Oct 2017 20:11:46 +0000 (22:11 +0200)]
adapt phpunit tests to new SearchContext class

7 years agomove country list to SearchContext
Sarah Hoffmann [Sun, 8 Oct 2017 21:33:54 +0000 (23:33 +0200)]
move country list to SearchContext

7 years agomove excluded place list to SearchContext
Sarah Hoffmann [Sun, 8 Oct 2017 21:15:06 +0000 (23:15 +0200)]
move excluded place list to SearchContext

7 years agomove viewbox sql to new SearchContext
Sarah Hoffmann [Sun, 8 Oct 2017 20:44:01 +0000 (22:44 +0200)]
move viewbox sql to new SearchContext

7 years agoreplace NearPoint with a more generic context object
Sarah Hoffmann [Sun, 8 Oct 2017 19:23:31 +0000 (21:23 +0200)]
replace NearPoint with a more generic context object

The NearPoint is actually common to all SearchDescriptions
and there is other context data as well. like viewbox, that
needs to be available to the search object but is common.

7 years agodon't trust words from word table to be sanatized
Sarah Hoffmann [Sun, 8 Oct 2017 15:36:38 +0000 (17:36 +0200)]
don't trust words from word table to be sanatized

7 years agoadd missing include
Sarah Hoffmann [Sun, 8 Oct 2017 15:13:41 +0000 (17:13 +0200)]
add missing include

7 years agofix CodeSniffer violations
Sarah Hoffmann [Sun, 8 Oct 2017 15:00:59 +0000 (17:00 +0200)]
fix CodeSniffer violations

7 years agofix more syntax issues
Sarah Hoffmann [Sun, 8 Oct 2017 14:42:04 +0000 (16:42 +0200)]
fix more syntax issues

7 years agomove Search dump function into SearchDescription class
Sarah Hoffmann [Sun, 8 Oct 2017 14:03:30 +0000 (16:03 +0200)]
move Search dump function into SearchDescription class

7 years agofix syntax errors from introduction of SearchDescription
Sarah Hoffmann [Sun, 8 Oct 2017 13:26:14 +0000 (15:26 +0200)]
fix syntax errors from introduction of  SearchDescription

7 years agoconvert getGroupedSearches to SearchDescription class
Sarah Hoffmann [Sun, 8 Oct 2017 10:57:22 +0000 (12:57 +0200)]
convert getGroupedSearches to SearchDescription class

7 years agoadd function to convert array to SQL
Sarah Hoffmann [Sun, 8 Oct 2017 08:06:17 +0000 (10:06 +0200)]
add function to convert array to SQL

7 years agouse SearchDescription class in query loop
Sarah Hoffmann [Sat, 7 Oct 2017 10:01:56 +0000 (12:01 +0200)]
use SearchDescription class in query loop

7 years agomove initial search setup to new class type
Sarah Hoffmann [Thu, 5 Oct 2017 22:14:48 +0000 (00:14 +0200)]
move initial search setup to new class type

7 years agoadd new class for searches
Sarah Hoffmann [Thu, 5 Oct 2017 21:03:03 +0000 (23:03 +0200)]
add new class for searches

7 years agodrop searches with excluded country codes earlier
Sarah Hoffmann [Sat, 7 Oct 2017 10:23:46 +0000 (12:23 +0200)]
drop searches with excluded country codes earlier

7 years agoremove code for dropping address terms
Sarah Hoffmann [Sat, 7 Oct 2017 09:53:33 +0000 (11:53 +0200)]
remove code for dropping address terms

This code has been inactive in quite a while and is a suboptimal
solution. We need to be much more selective in what gets dropped.

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Fri, 6 Oct 2017 20:02:48 +0000 (22:02 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agofix variable names
Sarah Hoffmann [Fri, 6 Oct 2017 20:01:52 +0000 (22:01 +0200)]
fix variable names

7 years agofurther restrict use of partial terms in names
Sarah Hoffmann [Fri, 6 Oct 2017 19:36:28 +0000 (21:36 +0200)]
further restrict use of partial terms in names

7 years agohousenumbers may only appear before or after the name
Sarah Hoffmann [Fri, 6 Oct 2017 19:12:25 +0000 (21:12 +0200)]
housenumbers may only appear before or after the name

7 years agopenalize search order where a country comes first
Sarah Hoffmann [Fri, 6 Oct 2017 19:07:33 +0000 (21:07 +0200)]
penalize search order where a country comes first

7 years agoallow postcodes and housenumbers together
Sarah Hoffmann [Fri, 6 Oct 2017 18:48:35 +0000 (20:48 +0200)]
allow postcodes and housenumbers together

Fixes #805.

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Thu, 5 Oct 2017 22:26:00 +0000 (00:26 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agosanitize special search term before normalizing
Sarah Hoffmann [Thu, 5 Oct 2017 22:22:27 +0000 (00:22 +0200)]
sanitize special search term before normalizing

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Wed, 4 Oct 2017 21:34:01 +0000 (23:34 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agofix postcode search
Sarah Hoffmann [Wed, 4 Oct 2017 21:22:04 +0000 (23:22 +0200)]
fix postcode search

Name token must be fully replaced with the postcode and
postcode search must be done only once.

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Wed, 4 Oct 2017 18:16:27 +0000 (20:16 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agoonly allow either postcode or special search
Sarah Hoffmann [Wed, 4 Oct 2017 18:15:06 +0000 (20:15 +0200)]
only allow either postcode or special search

Fixes #804.

7 years agouse correct source for radius column in debug view
Sarah Hoffmann [Wed, 4 Oct 2017 18:14:35 +0000 (20:14 +0200)]
use correct source for radius column in debug view

7 years agotests: more coverage for all API endpoints
Sarah Hoffmann [Tue, 3 Oct 2017 22:05:34 +0000 (00:05 +0200)]
tests: more coverage for all API endpoints

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Tue, 3 Oct 2017 14:28:57 +0000 (16:28 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agoMerge pull request #803 from lonvia/update-postcodes
Sarah Hoffmann [Tue, 3 Oct 2017 14:28:22 +0000 (16:28 +0200)]
Merge pull request #803 from lonvia/update-postcodes

Add script to update table with artifical postcode centroids

7 years agoadd script for updating postcodes
Sarah Hoffmann [Tue, 3 Oct 2017 10:07:26 +0000 (12:07 +0200)]
add script for updating postcodes

7 years agomove psqlRunScript implementation into cmd lib
Sarah Hoffmann [Tue, 3 Oct 2017 08:16:17 +0000 (10:16 +0200)]
move psqlRunScript implementation into cmd lib

Function needed for update.php as well.

7 years agotest: remove road-fallback test from db tests
Sarah Hoffmann [Tue, 3 Oct 2017 12:26:08 +0000 (14:26 +0200)]
test: remove road-fallback test from db tests

This should be tested in the api section.

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Tue, 3 Oct 2017 10:12:32 +0000 (12:12 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agofix search for postcode via structured query
Sarah Hoffmann [Tue, 3 Oct 2017 10:10:27 +0000 (12:10 +0200)]
fix search for postcode via structured query

Results from the artifical postcode table were dropped
when reevaluating rank of results.

7 years agoMerge remote-tracking branch 'upstream/master'
Sarah Hoffmann [Mon, 2 Oct 2017 21:10:21 +0000 (23:10 +0200)]
Merge remote-tracking branch 'upstream/master'

7 years agomore coverage tests for Geocode.php
Sarah Hoffmann [Mon, 2 Oct 2017 21:09:45 +0000 (23:09 +0200)]
more coverage tests for Geocode.php

7 years agoremove unnecessary size check
Sarah Hoffmann [Mon, 2 Oct 2017 20:31:52 +0000 (22:31 +0200)]
remove unnecessary size check

7 years agobe more strict with searches involving house numbers
Sarah Hoffmann [Mon, 2 Oct 2017 19:57:44 +0000 (21:57 +0200)]
be more strict with searches involving house numbers

Housenumber searches without a name cannot exist per
definition. Searches with only a name but no address
should not fall back on a search without house number.
This should improve postcode only search.

7 years agoavoid unnecessary SQL when rechecking rank restrictions
Sarah Hoffmann [Mon, 2 Oct 2017 18:42:37 +0000 (20:42 +0200)]
avoid unnecessary SQL when rechecking rank restrictions

7 years agofix viewbox related test
Sarah Hoffmann [Mon, 2 Oct 2017 18:39:33 +0000 (20:39 +0200)]
fix viewbox related test

Coordinates are no longer specially ordered.

7 years agodocs: clarify how to run pip install
Sarah Hoffmann [Sun, 1 Oct 2017 20:48:16 +0000 (22:48 +0200)]
docs: clarify how to run pip install

Fixes #792.