]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
12 months agoFixed typechecking error
Robbe Haesendonck [Thu, 23 Nov 2023 10:25:49 +0000 (11:25 +0100)]
Fixed typechecking error

12 months agoAdded missing return types to functions
Robbe Haesendonck [Fri, 29 Sep 2023 08:23:35 +0000 (10:23 +0200)]
Added missing return types to functions

12 months ago CI tests: Removed creation of user www-data.
Robbe Haesendonck [Fri, 29 Sep 2023 08:18:44 +0000 (10:18 +0200)]
 CI tests: Removed creation of user www-data.
Removed creation of user www-data as it already exists

12 months agoFixed legacy import command
Robbe Haesendonck [Thu, 28 Sep 2023 07:59:42 +0000 (09:59 +0200)]
Fixed legacy import command
Check whether prepare-database is true, if so exit early

12 months agoDisabled pylint too-many-branches
Robbe Haesendonck [Wed, 27 Sep 2023 14:40:08 +0000 (16:40 +0200)]
Disabled pylint too-many-branches

12 months agoFixed setting tokenizer property
Robbe Haesendonck [Wed, 27 Sep 2023 14:32:28 +0000 (16:32 +0200)]
Fixed setting tokenizer property

12 months agoUpdated no-superuser install ci test
Robbe Haesendonck [Wed, 27 Sep 2023 13:28:21 +0000 (15:28 +0200)]
Updated no-superuser install ci test

Added nominatim_database_webuser (www-data).
Set non-superuser password for importing

12 months agoUpdated check to see if osm_file is set
Robbe Haesendonck [Wed, 27 Sep 2023 08:50:40 +0000 (10:50 +0200)]
Updated check to see if osm_file is set

12 months agoFixed formatting
Robbe Haesendonck [Wed, 27 Sep 2023 08:37:57 +0000 (10:37 +0200)]
Fixed formatting

12 months agoUpdated ci tests to reflect changes in Nominatim CLI
Robbe Haesendonck [Wed, 27 Sep 2023 08:28:20 +0000 (10:28 +0200)]
Updated ci tests to reflect changes in Nominatim CLI

12 months agoMade sure legacy import command still works
Robbe Haesendonck [Wed, 27 Sep 2023 07:29:54 +0000 (09:29 +0200)]
Made sure legacy import command still works

12 months agoRemoved unused variable, fixed connection
Robbe Haesendonck [Wed, 27 Sep 2023 07:24:04 +0000 (09:24 +0200)]
Removed unused variable, fixed connection

12 months agoRemoved _is_complete_import check
Robbe Haesendonck [Wed, 27 Sep 2023 07:21:56 +0000 (09:21 +0200)]
Removed _is_complete_import check

12 months agoImproved logic.
Robbe Haesendonck [Tue, 26 Sep 2023 12:46:28 +0000 (14:46 +0200)]
Improved logic.

Fixed small oversight in mutually exclusiveness of arguments

12 months agoAdded new psql user for importing the data
Robbe Haesendonck [Tue, 26 Sep 2023 10:59:14 +0000 (12:59 +0200)]
Added new psql user for importing the data

12 months agoChanged naming of flags.
Robbe Haesendonck [Tue, 26 Sep 2023 09:59:32 +0000 (11:59 +0200)]
Changed naming of flags.

Made sure legacy import is also still ok

12 months agoAdded check to see if hstore is loaded
Robbe Haesendonck [Mon, 25 Sep 2023 10:39:38 +0000 (12:39 +0200)]
Added check to see if hstore is loaded

12 months agoFixed ci-tests, osm-file flag
Robbe Haesendonck [Mon, 25 Sep 2023 09:14:14 +0000 (11:14 +0200)]
Fixed ci-tests, osm-file flag

Preparing database should work without osm-file

12 months agoRenamed flags
Robbe Haesendonck [Mon, 25 Sep 2023 09:09:20 +0000 (11:09 +0200)]
Renamed flags

12 months agoFixed pylint warnings
Robbe Haesendonck [Thu, 21 Sep 2023 10:28:45 +0000 (12:28 +0200)]
Fixed pylint warnings

12 months agoAdded check for hstore extension
Robbe Haesendonck [Thu, 21 Sep 2023 10:20:46 +0000 (12:20 +0200)]
Added check for hstore extension

12 months agoFixed typo
Robbe Haesendonck [Thu, 21 Sep 2023 09:20:24 +0000 (11:20 +0200)]
Fixed typo

12 months agoFixed linting errors
Robbe Haesendonck [Thu, 21 Sep 2023 07:58:38 +0000 (09:58 +0200)]
Fixed linting errors

12 months agoAdded version check for PostGis and Postgres
Robbe Haesendonck [Wed, 20 Sep 2023 14:05:12 +0000 (16:05 +0200)]
Added version check for PostGis and Postgres

12 months agoUpdated CI tests to check new import flags
Robbe Haesendonck [Wed, 20 Sep 2023 11:42:06 +0000 (13:42 +0200)]
Updated CI tests to check new import flags

12 months agoAdded --prepare-database flag
Robbe Haesendonck [Wed, 20 Sep 2023 11:00:39 +0000 (13:00 +0200)]
Added --prepare-database flag

12 months agoAdded --no-superuser flag
Robbe Haesendonck [Tue, 19 Sep 2023 14:19:11 +0000 (16:19 +0200)]
Added --no-superuser flag

To allow import into already existing databases.
Refs: #2719

12 months agoactions: pin pytest-asyncio version for Ubuntu 20
Sarah Hoffmann [Sun, 3 Dec 2023 14:51:42 +0000 (15:51 +0100)]
actions: pin pytest-asyncio version for Ubuntu 20

Newest versions are no longer compatible with older pytest.

12 months agoskip lookup with full names when there are none
Sarah Hoffmann [Fri, 1 Dec 2023 11:11:58 +0000 (12:11 +0100)]
skip lookup with full names when there are none

12 months agoMerge pull request #3263 from lonvia/near-search-penalty-inheritance
Sarah Hoffmann [Wed, 29 Nov 2023 13:02:24 +0000 (14:02 +0100)]
Merge pull request #3263 from lonvia/near-search-penalty-inheritance

More tweaks for Python frontend search

12 months agofurther restrict stop search criterion
Sarah Hoffmann [Wed, 29 Nov 2023 10:19:06 +0000 (11:19 +0100)]
further restrict stop search criterion

12 months agouse restrict for housenumber lookups with few numbers
Sarah Hoffmann [Sat, 25 Nov 2023 17:39:28 +0000 (18:39 +0100)]
use restrict for housenumber lookups with few numbers

12 months agoNearSearch needs to inherit penalty from inner search
Sarah Hoffmann [Tue, 28 Nov 2023 19:12:12 +0000 (20:12 +0100)]
NearSearch needs to inherit penalty from inner search

12 months agoMerge pull request #3262 from lonvia/fix-category-search
Sarah Hoffmann [Tue, 28 Nov 2023 19:02:36 +0000 (20:02 +0100)]
Merge pull request #3262 from lonvia/fix-category-search

Fix use of category parameter for search() function

12 months agocorrectly exclude streets with housenumber searches
Sarah Hoffmann [Tue, 28 Nov 2023 16:53:37 +0000 (17:53 +0100)]
correctly exclude streets with housenumber searches

Street result are not subject to the full filtering in the SQL
query, so recheck.

12 months agoadd tests for interaction of category parameter with category terms
Sarah Hoffmann [Tue, 28 Nov 2023 15:56:08 +0000 (16:56 +0100)]
add tests for interaction of category parameter with category terms

12 months agorename use of category as POI search to near_item
Sarah Hoffmann [Tue, 28 Nov 2023 15:27:05 +0000 (16:27 +0100)]
rename use of category as POI search to near_item

Use the term category only as a short-cut for "tuple of key and value".

12 months agothe category parameter in search should result in a qualifier
Sarah Hoffmann [Tue, 28 Nov 2023 11:01:49 +0000 (12:01 +0100)]
the category parameter in search should result in a qualifier

12 months agoMerge pull request #3260 from lonvia/improve-catgeory-search
Sarah Hoffmann [Mon, 27 Nov 2023 11:02:11 +0000 (12:02 +0100)]
Merge pull request #3260 from lonvia/improve-catgeory-search

Various improvements to search with special phrases for Python frontend

12 months agodrop category tokens when they make up a full phrase
Sarah Hoffmann [Sun, 26 Nov 2023 19:58:50 +0000 (20:58 +0100)]
drop category tokens when they make up a full phrase

12 months agorestrict base results in near search by rank
Sarah Hoffmann [Sun, 26 Nov 2023 16:41:29 +0000 (17:41 +0100)]
restrict base results in near search by rank

This avoids in particular that roads or POIs are used as base
for the near search when a place result is present.

12 months agodeduplicate categories/qualifiers
Sarah Hoffmann [Sun, 26 Nov 2023 16:11:15 +0000 (17:11 +0100)]
deduplicate categories/qualifiers

12 months agoorder near searches by distance instead of importance
Sarah Hoffmann [Sun, 26 Nov 2023 15:48:04 +0000 (16:48 +0100)]
order near searches by distance instead of importance

12 months agoavoid duplicate lines during category search
Sarah Hoffmann [Sun, 26 Nov 2023 08:50:59 +0000 (09:50 +0100)]
avoid duplicate lines during category search

12 months agofix polygon selection for classtable lookups
Sarah Hoffmann [Sat, 25 Nov 2023 20:01:27 +0000 (21:01 +0100)]
fix polygon selection for classtable lookups

Polygons should be used preferably with higher address ranks
where the areas are smaller.

12 months agoMerge pull request #3257 from lonvia/slow-queries
Sarah Hoffmann [Thu, 23 Nov 2023 11:05:50 +0000 (12:05 +0100)]
Merge pull request #3257 from lonvia/slow-queries

Performance tweaks for search

12 months agoincrease penalty for one-letter words
Sarah Hoffmann [Thu, 23 Nov 2023 09:51:58 +0000 (10:51 +0100)]
increase penalty for one-letter words

12 months agomore preference for name-only queries in search
Sarah Hoffmann [Wed, 22 Nov 2023 22:57:23 +0000 (23:57 +0100)]
more preference for name-only queries in search

12 months agoavoid index use when filtering by layer
Sarah Hoffmann [Wed, 22 Nov 2023 19:54:04 +0000 (20:54 +0100)]
avoid index use when filtering by layer

12 months agoadd timestamps to text logging
Sarah Hoffmann [Wed, 22 Nov 2023 16:38:32 +0000 (17:38 +0100)]
add timestamps to text logging

12 months agoavoid index on rank_address in near search
Sarah Hoffmann [Wed, 22 Nov 2023 16:33:17 +0000 (17:33 +0100)]
avoid index on rank_address in near search

12 months agoexclude country-level searches with non-address layers
Sarah Hoffmann [Wed, 22 Nov 2023 16:01:41 +0000 (17:01 +0100)]
exclude country-level searches with non-address layers

12 months agoMerge pull request #3252 from kumarUjjawal/patch-1
Sarah Hoffmann [Wed, 22 Nov 2023 11:51:37 +0000 (12:51 +0100)]
Merge pull request #3252 from kumarUjjawal/patch-1

minor typo fix

12 months agominor typo fix
Kumar Ujjawal [Mon, 20 Nov 2023 11:53:42 +0000 (17:23 +0530)]
minor typo fix

fixed a minor typo, from 'wit' to 'with'.

12 months agoadd report on newest vulnerability
Sarah Hoffmann [Mon, 20 Nov 2023 09:44:48 +0000 (10:44 +0100)]
add report on newest vulnerability

13 months agoimprove code to collect the PostGIS version
Sarah Hoffmann [Thu, 16 Nov 2023 10:02:25 +0000 (11:02 +0100)]
improve code to collect the PostGIS version

The SQL contained an unchecked string literal, which may in theory be
used to attack the database.

13 months agoMerge pull request #3248 from lonvia/fix-postcode-area-computation
Sarah Hoffmann [Wed, 15 Nov 2023 21:10:21 +0000 (22:10 +0100)]
Merge pull request #3248 from lonvia/fix-postcode-area-computation

PHP frontent: fix postcode area computation for address points

13 months agoadapt typing to newest version of SQLAlchemy
Sarah Hoffmann [Wed, 15 Nov 2023 18:59:26 +0000 (19:59 +0100)]
adapt typing to newest version of SQLAlchemy

13 months agophp frontend: fix on-the-fly lookup of postcode areas
Sarah Hoffmann [Wed, 15 Nov 2023 16:45:12 +0000 (17:45 +0100)]
php frontend: fix on-the-fly lookup of postcode areas

13 months agoremove now unnecessary type igonre comment
Sarah Hoffmann [Wed, 1 Nov 2023 10:57:57 +0000 (11:57 +0100)]
remove now unnecessary type igonre comment

13 months agofix assertion on address list, it may be empty
Sarah Hoffmann [Tue, 31 Oct 2023 20:10:23 +0000 (21:10 +0100)]
fix assertion on address list, it may be empty

Fixes #3237.

13 months agoMerge pull request #3235 from lonvia/fix-python-deploy
Sarah Hoffmann [Wed, 25 Oct 2023 12:54:13 +0000 (14:54 +0200)]
Merge pull request #3235 from lonvia/fix-python-deploy

Python frontend deployment: add systemd service for the socket

13 months agopython deployment: add systemd service for the socket
Sarah Hoffmann [Wed, 25 Oct 2023 09:21:40 +0000 (11:21 +0200)]
python deployment: add systemd service for the socket

13 months agoMerge pull request #3234 from lonvia/reduce-admin-style
Sarah Hoffmann [Wed, 25 Oct 2023 07:38:17 +0000 (09:38 +0200)]
Merge pull request #3234 from lonvia/reduce-admin-style

Streamline admin style

13 months agoMerge pull request #3233 from lonvia/support-for-sqlite
Sarah Hoffmann [Tue, 24 Oct 2023 09:54:35 +0000 (11:54 +0200)]
Merge pull request #3233 from lonvia/support-for-sqlite

Add support for SQLite DBs in frontend: reverse

13 months agofurther reduce admin style import to admin-only objects
Sarah Hoffmann [Tue, 24 Oct 2023 07:50:43 +0000 (09:50 +0200)]
further reduce admin style import to admin-only objects

13 months agorestrict geometry size for SQLite
Sarah Hoffmann [Thu, 19 Oct 2023 19:24:53 +0000 (21:24 +0200)]
restrict geometry size for SQLite

13 months agoconvert sqlite: add index on parent_place_id
Sarah Hoffmann [Tue, 17 Oct 2023 08:59:47 +0000 (10:59 +0200)]
convert sqlite: add index on parent_place_id

13 months agoremove type info from SQLALchemy condition functions
Sarah Hoffmann [Tue, 17 Oct 2023 08:57:52 +0000 (10:57 +0200)]
remove type info from SQLALchemy condition functions

A boolean type makes the SQLite dialect produce a costruct like
'func() = 1' in WHERE condition. While syntactically correct, it tends
to confuse the query planer.

13 months agomake code work with Spatialite 4.3
Sarah Hoffmann [Mon, 16 Oct 2023 14:57:13 +0000 (16:57 +0200)]
make code work with Spatialite 4.3

Transfer is_address_point into SQLAlchemy function, so that
json.has_key() can use the older json_extract() function.
And work around broken Distance function.

13 months agoenable BDD tests for sqlite databases
Sarah Hoffmann [Fri, 13 Oct 2023 19:32:03 +0000 (21:32 +0200)]
enable BDD tests for sqlite databases

The database must currently be created by hand and the name handed
in via -DAPI_TEST_DB='sqlite:...'.

13 months agotrim all coordinate output to 7 digits
Sarah Hoffmann [Fri, 13 Oct 2023 12:09:11 +0000 (14:09 +0200)]
trim all coordinate output to 7 digits

13 months agoadd indexing support for DWithin and intersects for sqlite
Sarah Hoffmann [Fri, 13 Oct 2023 09:38:36 +0000 (11:38 +0200)]
add indexing support for DWithin and intersects for sqlite

13 months agomake reverse API work with sqlite
Sarah Hoffmann [Fri, 13 Oct 2023 09:03:13 +0000 (11:03 +0200)]
make reverse API work with sqlite

13 months agoactions: enable sqlite testing
Sarah Hoffmann [Thu, 12 Oct 2023 14:00:28 +0000 (16:00 +0200)]
actions: enable sqlite testing

13 months agotry future annotations to resolve Generics compatibility
Sarah Hoffmann [Thu, 12 Oct 2023 14:19:12 +0000 (16:19 +0200)]
try future annotations to resolve Generics compatibility

13 months agomake status API work with sqlite incl. unit tests
Sarah Hoffmann [Thu, 12 Oct 2023 14:17:16 +0000 (16:17 +0200)]
make status API work with sqlite incl. unit tests

13 months agomake details API work with sqlite incl. unit tests
Sarah Hoffmann [Thu, 12 Oct 2023 13:31:20 +0000 (15:31 +0200)]
make details API work with sqlite incl. unit tests

13 months agomake lookup call work with sqlite
Sarah Hoffmann [Thu, 12 Oct 2023 11:51:10 +0000 (13:51 +0200)]
make lookup call work with sqlite

Includes porting unit tests.

13 months agoadd exporting of SQLite table
Sarah Hoffmann [Thu, 12 Oct 2023 08:45:12 +0000 (10:45 +0200)]
add exporting of SQLite table

13 months agoadd skeleton code for convert function
Sarah Hoffmann [Wed, 11 Oct 2023 20:35:18 +0000 (22:35 +0200)]
add skeleton code for convert function

13 months agostreamline SQLAlchemy DB schema
Sarah Hoffmann [Wed, 11 Oct 2023 09:30:42 +0000 (11:30 +0200)]
streamline SQLAlchemy DB schema

Remove all information not strictly used by the frontend as well as
any index information. This will make it easier to create a SQLite
database from the schema.

13 months agoremove unused code
Sarah Hoffmann [Mon, 23 Oct 2023 09:55:18 +0000 (11:55 +0200)]
remove unused code

13 months agoMerge branch 'clean-deleted-relations' of https://github.com/lujoh/Nominatim into...
Sarah Hoffmann [Mon, 23 Oct 2023 08:47:31 +0000 (10:47 +0200)]
Merge branch 'clean-deleted-relations' of https://github.com/lujoh/Nominatim into lujoh-clean-deleted-relations

13 months agoMerge pull request #3228 from pawel-wroniszewski/fix/postcode-validation
Sarah Hoffmann [Mon, 23 Oct 2023 08:35:42 +0000 (10:35 +0200)]
Merge pull request #3228 from pawel-wroniszewski/fix/postcode-validation

Properly validate postcodes with country code

13 months agomade age a required argument for the -clean-deleted command
lujoh [Fri, 20 Oct 2023 19:31:55 +0000 (15:31 -0400)]
made age a required argument for the -clean-deleted command

13 months agoRevert country settings
Paweł Wroniszewski [Fri, 20 Oct 2023 10:39:47 +0000 (12:39 +0200)]
Revert country settings

14 months agoadded --clean deleted command to the documentation
lujoh [Wed, 18 Oct 2023 06:03:17 +0000 (02:03 -0400)]
added --clean deleted command to the documentation

14 months agoadjusted tests for --clean-deleted-relations command
lujoh [Wed, 18 Oct 2023 03:03:37 +0000 (23:03 -0400)]
adjusted tests for --clean-deleted-relations command

14 months agomoved sql function flush_deleted_places() to utils
lujoh [Tue, 17 Oct 2023 22:22:27 +0000 (18:22 -0400)]
moved sql function flush_deleted_places() to utils

14 months agoProperly validate postcodes with country code
Paweł Wroniszewski [Mon, 16 Oct 2023 22:44:24 +0000 (00:44 +0200)]
Properly validate postcodes with country code

Include postcode pattern in postcode normalisation regex, instead of
removing it from postcode pattern in config.

It properly handles postcode validation and normalization when country code
is part of the postcode, e.g. for Isle of Man, Jersey, Anguilla, Andorra,
Cayman Islands and more.

Fixes #3227.

14 months agoadded subcommand to clean deleted relations for issue # 2444
lujoh [Fri, 13 Oct 2023 02:00:43 +0000 (22:00 -0400)]
added subcommand to clean deleted relations for issue # 2444

14 months agoadapt typing for newer version of mypy
Sarah Hoffmann [Mon, 16 Oct 2023 15:03:48 +0000 (17:03 +0200)]
adapt typing for newer version of mypy

14 months agoMerge pull request #3222 from lonvia/fix-river-output
Sarah Hoffmann [Tue, 10 Oct 2023 09:20:12 +0000 (11:20 +0200)]
Merge pull request #3222 from lonvia/fix-river-output

Make sure the place name always comes first in output

14 months agoreduce influence of viewbox
Sarah Hoffmann [Sat, 7 Oct 2023 15:30:01 +0000 (17:30 +0200)]
reduce influence of viewbox

Perfectly matching city names should still get priority.

14 months agomake sure the place name always comes first in output
Sarah Hoffmann [Wed, 4 Oct 2023 12:41:19 +0000 (14:41 +0200)]
make sure the place name always comes first in output

Also deleted some now unused code.

14 months agoMerge pull request #3212 from lonvia/more-tests
Sarah Hoffmann [Thu, 5 Oct 2023 14:36:53 +0000 (16:36 +0200)]
Merge pull request #3212 from lonvia/more-tests

Add more unit tests for search

14 months agoswitch back meaning of reverse and search in warm
Sarah Hoffmann [Wed, 4 Oct 2023 13:19:24 +0000 (15:19 +0200)]
switch back meaning of reverse and search in warm

Also do'n try to warm up searches on reverse-only databases.

Fixes #3213.

14 months agomore unit tests for search
Sarah Hoffmann [Tue, 26 Sep 2023 07:40:30 +0000 (09:40 +0200)]
more unit tests for search

14 months agoMerge pull request #3211 from lonvia/replace-get-addressdata
Sarah Hoffmann [Tue, 26 Sep 2023 19:29:15 +0000 (21:29 +0200)]
Merge pull request #3211 from lonvia/replace-get-addressdata

Move get_addressdata() implementation to Python