]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
2 years agoadapt frontend to new interpolation table layout
Sarah Hoffmann [Wed, 26 Jan 2022 20:24:24 +0000 (21:24 +0100)]
adapt frontend to new interpolation table layout

2 years agoadapt BDD tests for new interpolation style
Sarah Hoffmann [Wed, 26 Jan 2022 14:24:06 +0000 (15:24 +0100)]
adapt BDD tests for new interpolation style

2 years agoinherit tags from interpolation not parent
Sarah Hoffmann [Wed, 26 Jan 2022 11:05:04 +0000 (12:05 +0100)]
inherit tags from interpolation not parent

Nodes on an interpolation now only get the address tags of
interpolations and then compute their own parent from that. They no
longer inherit the parent directly.

2 years agoadd migration for new interpolation table layout
Sarah Hoffmann [Thu, 27 Jan 2022 10:12:40 +0000 (11:12 +0100)]
add migration for new interpolation table layout

2 years agoadd migration for new lookup index
Sarah Hoffmann [Tue, 25 Jan 2022 11:00:35 +0000 (12:00 +0100)]
add migration for new lookup index

2 years agooptimize indexes for interpolation lines
Sarah Hoffmann [Tue, 25 Jan 2022 10:24:13 +0000 (11:24 +0100)]
optimize indexes for interpolation lines

Do not index 'inactive' rows (with startnumber is null) where possible.

2 years agoimprove handling von updates on nodes in interpolations
Sarah Hoffmann [Tue, 25 Jan 2022 09:14:05 +0000 (10:14 +0100)]
improve handling von updates on nodes in interpolations

Use the same update mechanism as for updates on the interpolations
themselves. Updates must solely happen in place_insert as this is
the place where actual changes of the data happen.

2 years agoupdate interpolations instead of deleting and recreating
Sarah Hoffmann [Mon, 24 Jan 2022 15:26:28 +0000 (16:26 +0100)]
update interpolations instead of deleting and recreating

2 years agoMerge pull request #2595 from nslxndr/fix-doc-typos
Sarah Hoffmann [Wed, 26 Jan 2022 22:08:41 +0000 (23:08 +0100)]
Merge pull request #2595 from nslxndr/fix-doc-typos

Fix typos in UI doc

2 years agoFix typos in UI doc
Sandor Nagy [Wed, 26 Jan 2022 20:39:20 +0000 (21:39 +0100)]
Fix typos in UI doc

2 years agoMerge pull request #2594 from lonvia/update-osm2pgsql
Sarah Hoffmann [Tue, 25 Jan 2022 11:11:57 +0000 (12:11 +0100)]
Merge pull request #2594 from lonvia/update-osm2pgsql

Update to osm2pgsql 1.6.0

2 years agoupdate to osm2pgsql 1.6.0
Sarah Hoffmann [Mon, 24 Jan 2022 15:55:52 +0000 (16:55 +0100)]
update to osm2pgsql 1.6.0

2 years agoMerge pull request #2591 from lonvia/cleanup-place-insert
Sarah Hoffmann [Mon, 24 Jan 2022 14:58:23 +0000 (15:58 +0100)]
Merge pull request #2591 from lonvia/cleanup-place-insert

Reorganise code of place_insert() trigger

2 years agoreorganise place_insert trigger
Sarah Hoffmann [Mon, 24 Jan 2022 08:12:50 +0000 (09:12 +0100)]
reorganise place_insert trigger

Code cleanup and formatting as well as minor improvements, in
particular removal of unnecessary code.

2 years agoMerge pull request #2589 from lonvia/clean-housenumbers
Sarah Hoffmann [Fri, 21 Jan 2022 09:17:58 +0000 (10:17 +0100)]
Merge pull request #2589 from lonvia/clean-housenumbers

Add command for cleaning up word table

2 years agoadd tests for cleaning housenumbers
Sarah Hoffmann [Thu, 20 Jan 2022 22:47:20 +0000 (23:47 +0100)]
add tests for cleaning housenumbers

2 years agodo not clean housenumbers in reverse-only mode
Sarah Hoffmann [Thu, 20 Jan 2022 19:21:13 +0000 (20:21 +0100)]
do not clean housenumbers in reverse-only mode

2 years agoadd actual removal of housenumber tokens
Sarah Hoffmann [Thu, 20 Jan 2022 19:18:15 +0000 (20:18 +0100)]
add actual removal of housenumber tokens

2 years agoadd new command for cleaning word tokens
Sarah Hoffmann [Thu, 20 Jan 2022 19:05:15 +0000 (20:05 +0100)]
add new command for cleaning word tokens

Just pulls outdated housenumbers for the moment.

2 years agoMerge pull request #2588 from lonvia/housenumber-sanitizer
Sarah Hoffmann [Thu, 20 Jan 2022 16:44:24 +0000 (17:44 +0100)]
Merge pull request #2588 from lonvia/housenumber-sanitizer

Move housenumber parsing into sanitizer

2 years agoadapt ICU tets to new housenumber sanitizer
Sarah Hoffmann [Thu, 20 Jan 2022 15:05:49 +0000 (16:05 +0100)]
adapt ICU tets to new housenumber sanitizer

Restrict tests to making sure that handing in multiple housenumbers
works.

2 years agofix linting issues
Sarah Hoffmann [Thu, 20 Jan 2022 15:00:23 +0000 (16:00 +0100)]
fix linting issues

2 years agocomplete documentation for new clean-houseunubmers sanatizer
Sarah Hoffmann [Thu, 20 Jan 2022 14:49:32 +0000 (15:49 +0100)]
complete documentation for new clean-houseunubmers sanatizer

2 years agogeneralize filter-kind parameter for sanatizers
Sarah Hoffmann [Thu, 20 Jan 2022 14:42:42 +0000 (15:42 +0100)]
generalize filter-kind parameter for sanatizers

Now behaves the same for tag_analyzer_by_language and
clean_housenumbers. Adds tests.

2 years agoadd pytest config
Sarah Hoffmann [Thu, 20 Jan 2022 14:38:02 +0000 (15:38 +0100)]
add pytest config

We are using custom marks now which need to be registered to avoid
warnings.

2 years agoclean_housenumbers: make kinds and delimiters configurable
Sarah Hoffmann [Thu, 20 Jan 2022 11:07:12 +0000 (12:07 +0100)]
clean_housenumbers: make kinds and delimiters configurable

Also adds unit tests for various options.

2 years agofactor out housenumber splitting into sanitizer
Sarah Hoffmann [Fri, 7 Jan 2022 21:41:09 +0000 (22:41 +0100)]
factor out housenumber splitting into sanitizer

2 years agoMerge pull request #2585 from lonvia/name-mutations
Sarah Hoffmann [Wed, 19 Jan 2022 16:09:36 +0000 (17:09 +0100)]
Merge pull request #2585 from lonvia/name-mutations

Introduce character mutations to token analysis

2 years agodocs: add pointer to caddy deployment discussion
Sarah Hoffmann [Wed, 19 Jan 2022 14:28:01 +0000 (15:28 +0100)]
docs: add pointer to caddy deployment discussion

2 years agofix linting error
Sarah Hoffmann [Thu, 13 Jan 2022 08:30:31 +0000 (09:30 +0100)]
fix linting error

2 years agomove parsing of mutation config to setup phase
Sarah Hoffmann [Wed, 12 Jan 2022 18:41:16 +0000 (19:41 +0100)]
move parsing of mutation config to setup phase

2 years agoadd documentation for new mutation feature
Sarah Hoffmann [Wed, 12 Jan 2022 16:37:06 +0000 (17:37 +0100)]
add documentation for new mutation feature

2 years agointroduce mutation variants to generic token analyser
Sarah Hoffmann [Wed, 12 Jan 2022 15:25:47 +0000 (16:25 +0100)]
introduce mutation variants to generic token analyser

Mutations are regular-expression-based replacements that are applied
after variants have been computed. They are meant to be used for
variations on character level.

Add spelling variations for German umlauts.

2 years agomove variant configuration reading in separate file
Sarah Hoffmann [Wed, 12 Jan 2022 08:53:32 +0000 (09:53 +0100)]
move variant configuration reading in separate file

2 years agorefactor variant production to use generators
Sarah Hoffmann [Tue, 11 Jan 2022 16:51:05 +0000 (17:51 +0100)]
refactor variant production to use generators

2 years agoMerge pull request #2578 from lonvia/iso-3166-2
Sarah Hoffmann [Thu, 13 Jan 2022 13:54:35 +0000 (14:54 +0100)]
Merge pull request #2578 from lonvia/iso-3166-2

Make ISO3166-2 references searchable

2 years agoMerge pull request #2579 from geofabrik/doc-update-typo
Sarah Hoffmann [Thu, 13 Jan 2022 13:01:57 +0000 (14:01 +0100)]
Merge pull request #2579 from geofabrik/doc-update-typo

Fix typo in name of service. The rest of the docs call it nominatim-updateS

2 years agoFix typo in name of service. The rest of the docs call it nominatim-updateS
Amanda McCann [Thu, 13 Jan 2022 12:14:17 +0000 (13:14 +0100)]
Fix typo in name of service. The rest of the docs call it nominatim-updateS

2 years agomake ISO3166-2 references searchable
Sarah Hoffmann [Thu, 13 Jan 2022 08:44:42 +0000 (09:44 +0100)]
make ISO3166-2 references searchable

2 years agoMerge pull request #2571 from lonvia/ukrainian-apostrophe
Sarah Hoffmann [Tue, 11 Jan 2022 08:41:07 +0000 (09:41 +0100)]
Merge pull request #2571 from lonvia/ukrainian-apostrophe

Consider "modifier letter apostrophe" to be punctuation

2 years agoconsider "modifier letter apostrophe" to be punctuation
Sarah Hoffmann [Mon, 10 Jan 2022 16:40:03 +0000 (17:40 +0100)]
consider "modifier letter apostrophe" to be punctuation

While technically being a letter, the apostrophe is often replaced
with a normal apostrophe in writing which is a punctuation mark.
This makes sure that the modifier letter apostrophe yields the same
normalization results and thus is really interchangable.

Only has an effect after the next reimport.

Fixes #2569.

2 years agoMerge pull request #2570 from woodpeck/patch-3
Sarah Hoffmann [Mon, 10 Jan 2022 13:21:48 +0000 (14:21 +0100)]
Merge pull request #2570 from woodpeck/patch-3

Fix typos

2 years agoFix typos
Frederik Ramm [Mon, 10 Jan 2022 12:38:53 +0000 (13:38 +0100)]
Fix typos

2 years agoMerge pull request #2565 from lonvia/swap-wordset-order
Sarah Hoffmann [Thu, 6 Jan 2022 08:02:46 +0000 (09:02 +0100)]
Merge pull request #2565 from lonvia/swap-wordset-order

Swap order of query interpretation

2 years agoswap order of query interpretation
Sarah Hoffmann [Wed, 5 Jan 2022 14:21:14 +0000 (15:21 +0100)]
swap order of query interpretation

A forward interpretation of the form 'street, city, country' is
much more frequent than the reverse form 'country, city, street'.
Thus swap the order of interpretations that the forward order comes
first.

2 years agoMerge pull request #2562 from lonvia/copyright-headers
Sarah Hoffmann [Tue, 4 Jan 2022 22:10:37 +0000 (23:10 +0100)]
Merge pull request #2562 from lonvia/copyright-headers

Add consistent copyright headers

2 years agoadd consistent SPDX copyright headers
Sarah Hoffmann [Mon, 3 Jan 2022 15:23:58 +0000 (16:23 +0100)]
add consistent SPDX copyright headers

2 years agoMerge pull request #2559 from lonvia/disable-jit-in-queries
Sarah Hoffmann [Mon, 3 Jan 2022 14:13:57 +0000 (15:13 +0100)]
Merge pull request #2559 from lonvia/disable-jit-in-queries

Disable JIT and parallel workers on search frontend

2 years agodisable JIT and parallel workers on search frontend
Sarah Hoffmann [Wed, 22 Dec 2021 07:59:31 +0000 (08:59 +0100)]
disable JIT and parallel workers on search frontend

Bad query planning now also interferes with queries for search and
reverse.

2 years agoMerge pull request #2553 from lonvia/revert-street-matching-to-full-names
Sarah Hoffmann [Tue, 14 Dec 2021 14:52:34 +0000 (15:52 +0100)]
Merge pull request #2553 from lonvia/revert-street-matching-to-full-names

Revert street matching to full names

2 years agocorrectly match abbreviated addr:street
Sarah Hoffmann [Wed, 8 Dec 2021 20:58:43 +0000 (21:58 +0100)]
correctly match abbreviated addr:street

This only works when addr:street is abbreviated and the street
name isn't. It does not work the other way around.

2 years agoMerge pull request #2542 from lonvia/update-phpunit
Sarah Hoffmann [Tue, 7 Dec 2021 14:44:45 +0000 (15:44 +0100)]
Merge pull request #2542 from lonvia/update-phpunit

Update PHPUnit use to 9.5

2 years agorestrict PHPUnit to 9.5 version
Sarah Hoffmann [Tue, 7 Dec 2021 13:49:31 +0000 (14:49 +0100)]
restrict PHPUnit to 9.5 version

There are so many breaking changes with PHPUnit that it is
impossible to give any other guarantees.

2 years agoenable PHPUnit 9 for coverage
Sarah Hoffmann [Tue, 7 Dec 2021 11:07:17 +0000 (12:07 +0100)]
enable PHPUnit 9 for coverage

A couple of functions have been renamed.

2 years agophp unit: replace deprecated regex assert
Sarah Hoffmann [Tue, 7 Dec 2021 10:34:21 +0000 (11:34 +0100)]
php unit: replace deprecated regex assert

The regEx assertion has been renamed in PHPUnit 9.5
and causes deprecation warnings.

2 years agophp unit: don't enforce a name on the test database
Sarah Hoffmann [Tue, 7 Dec 2021 10:31:45 +0000 (11:31 +0100)]
php unit: don't enforce a name on the test database

Also gets rid of a PHPUnit deprecation warning.

2 years agophp test: class must be called like the file
Sarah Hoffmann [Tue, 7 Dec 2021 10:20:38 +0000 (11:20 +0100)]
php test: class must be called like the file

2 years agodisable codecov
Sarah Hoffmann [Tue, 7 Dec 2021 10:13:30 +0000 (11:13 +0100)]
disable codecov

Not working.

2 years agoMerge pull request #2540 from lonvia/remove-support-for-centos7
Sarah Hoffmann [Tue, 7 Dec 2021 08:17:29 +0000 (09:17 +0100)]
Merge pull request #2540 from lonvia/remove-support-for-centos7

Remove installation instructions for CentOS 7

2 years agoremove installation instructions for CentOS 7
Sarah Hoffmann [Mon, 6 Dec 2021 15:05:27 +0000 (16:05 +0100)]
remove installation instructions for CentOS 7

This ends official support for CentOS 7.

2 years agoremove some odd varaints of addr:street from the styles
Sarah Hoffmann [Mon, 6 Dec 2021 14:17:00 +0000 (15:17 +0100)]
remove some odd varaints of addr:street from the styles

Some import has added names in partial tags which confuse the
street name matching.

2 years agoskip most addr: tags with suffixes
Sarah Hoffmann [Mon, 6 Dec 2021 13:46:40 +0000 (14:46 +0100)]
skip most addr: tags with suffixes

Only one addr: tag can be processed currently, so make
sure it is the one without suffixes to not get odd data.
addr:street is the exception because it uses a different
matching mechanism.

2 years agoICU: matching any street name will do again
Sarah Hoffmann [Mon, 6 Dec 2021 13:26:08 +0000 (14:26 +0100)]
ICU: matching any street name will do again

2 years agorevert to using full names for street name matching
Sarah Hoffmann [Mon, 6 Dec 2021 10:38:38 +0000 (11:38 +0100)]
revert to using full names for street name matching

Using partial names turned out to not work well because there are
often similarly named streets next to each other. It also
prevents us from being able to take into account all addr:street:*
tags.

This change gets all the full term tokens for the addr:street tags
from the DB. As they are used for matching only, we can assume that
the term must already be there or there will be no match. This
avoid creating unused full name tags.

2 years agoMerge pull request #2539 from lonvia/clean-up-python-tests
Sarah Hoffmann [Fri, 3 Dec 2021 16:08:25 +0000 (17:08 +0100)]
Merge pull request #2539 from lonvia/clean-up-python-tests

Restructure and extend python unit tests

2 years agospecify text type in test SQL
Sarah Hoffmann [Fri, 3 Dec 2021 11:01:53 +0000 (12:01 +0100)]
specify text type in test SQL

Older version of postgres fail otherwise.

2 years agosplit cli tests by subcommand and extend coverage
Sarah Hoffmann [Thu, 2 Dec 2021 22:45:48 +0000 (23:45 +0100)]
split cli tests by subcommand and extend coverage

2 years agoremove unnecessary pass statements
Sarah Hoffmann [Thu, 2 Dec 2021 14:54:24 +0000 (15:54 +0100)]
remove unnecessary pass statements

2 years agomore unit tests for tokenizers
Sarah Hoffmann [Thu, 2 Dec 2021 14:46:36 +0000 (15:46 +0100)]
more unit tests for tokenizers

2 years agoextend API unit tests
Sarah Hoffmann [Wed, 1 Dec 2021 19:48:29 +0000 (20:48 +0100)]
extend API unit tests

2 years agoadd tests for migration
Sarah Hoffmann [Wed, 1 Dec 2021 19:27:40 +0000 (20:27 +0100)]
add tests for migration

2 years agomore testing for refresh functions
Sarah Hoffmann [Wed, 1 Dec 2021 13:58:54 +0000 (14:58 +0100)]
more testing for refresh functions

2 years agomore tests for exec utilities
Sarah Hoffmann [Wed, 1 Dec 2021 13:23:51 +0000 (14:23 +0100)]
more tests for exec utilities

2 years agoadd more tests for database import
Sarah Hoffmann [Wed, 1 Dec 2021 10:54:58 +0000 (11:54 +0100)]
add more tests for database import

2 years agoadd tests for adding additional data
Sarah Hoffmann [Wed, 1 Dec 2021 10:22:46 +0000 (11:22 +0100)]
add tests for adding additional data

Also adds checks that parameters for osm2pgsql are set
as expected.

2 years agoadd tests for flatten_config_file and other than yaml formats
Sarah Hoffmann [Wed, 1 Dec 2021 09:24:11 +0000 (10:24 +0100)]
add tests for flatten_config_file and other than yaml formats

2 years agotests: add fixture for making test project directory
Sarah Hoffmann [Tue, 30 Nov 2021 17:01:46 +0000 (18:01 +0100)]
tests: add fixture for making test project directory

2 years agogeneralize fixtures for cli tests
Sarah Hoffmann [Tue, 30 Nov 2021 13:07:39 +0000 (14:07 +0100)]
generalize fixtures for cli tests

2 years agopython test: move single-use fixtures to subdirectories
Sarah Hoffmann [Tue, 30 Nov 2021 11:03:16 +0000 (12:03 +0100)]
python test: move single-use fixtures to subdirectories

2 years agoremove unused test files
Sarah Hoffmann [Tue, 30 Nov 2021 10:23:00 +0000 (11:23 +0100)]
remove unused test files

2 years agoorganise python tests in subdirectories
Sarah Hoffmann [Tue, 30 Nov 2021 10:10:47 +0000 (11:10 +0100)]
organise python tests in subdirectories

The directories follow the same structure as the modules in
nominatim/.

3 years agoMerge pull request #2530 from lonvia/declassify-highway
Sarah Hoffmann [Thu, 25 Nov 2021 07:41:25 +0000 (08:41 +0100)]
Merge pull request #2530 from lonvia/declassify-highway

Change default rank for highway objects to 30

3 years agochange default rank for highway objects to 30
Sarah Hoffmann [Wed, 24 Nov 2021 13:40:23 +0000 (14:40 +0100)]
change default rank for highway objects to 30

The highway key is being used more and more for non-ways these
days. This clashes with Nominatim's assumption that essentially
everything that has a highway tag can be used as the street part
of the address.

Change the default rank of highway objects to 30 to avoid this.
Only the known values for streets keep the rank 26 and are now
listed explicitly.

3 years agoMerge pull request #2529 from lonvia/sort-street-results-by-tiger-housenumber
Sarah Hoffmann [Wed, 24 Nov 2021 15:23:41 +0000 (16:23 +0100)]
Merge pull request #2529 from lonvia/sort-street-results-by-tiger-housenumber

Take tiger housenumber into account when ranking street results

3 years agoadd migration for inclusive housenumber Tiger index
Sarah Hoffmann [Wed, 24 Nov 2021 10:05:04 +0000 (11:05 +0100)]
add migration for inclusive housenumber Tiger index

3 years agoadd index for Tiger housenumber queries
Sarah Hoffmann [Tue, 23 Nov 2021 19:24:08 +0000 (20:24 +0100)]
add index for Tiger housenumber queries

3 years agotake Tiger housenumbers into account when ranking street results
Sarah Hoffmann [Tue, 23 Nov 2021 19:04:50 +0000 (20:04 +0100)]
take Tiger housenumbers into account when ranking street results

Queries with a housenumber need to rank streets higher that
have the requested housenumber attached. We already do that for
ordinary housenumber objects and for interpolations. This
adds support for Tiger housenumbers as well.

Fixes #2501.

3 years agoMerge pull request #2528 from lonvia/allow-french-extra-housenumbers
Sarah Hoffmann [Sun, 21 Nov 2021 09:53:20 +0000 (10:53 +0100)]
Merge pull request #2528 from lonvia/allow-french-extra-housenumbers

Don't penalize French 'bis' housenumbers

3 years agoMerge pull request #2526 from lonvia/docs-moving-database
Sarah Hoffmann [Fri, 19 Nov 2021 20:14:53 +0000 (21:14 +0100)]
Merge pull request #2526 from lonvia/docs-moving-database

Add a section about moving the database to another machine

3 years agodon't penalize French 'bis' housenumbers
Sarah Hoffmann [Fri, 19 Nov 2021 20:12:17 +0000 (21:12 +0100)]
don't penalize French 'bis' housenumbers

House numbers of the form '9 bis' are usual in France. So
be a bit more lenient before adding penalties to house numbers
with letters in them.

Fixes #2527.

3 years agoMerge pull request #2525 from lonvia/fix-replication-indexer
Sarah Hoffmann [Fri, 19 Nov 2021 15:16:30 +0000 (16:16 +0100)]
Merge pull request #2525 from lonvia/fix-replication-indexer

Fix instantiation of indexer for replication

3 years agoadd a section about moving the database to another machine
Sarah Hoffmann [Fri, 19 Nov 2021 15:11:32 +0000 (16:11 +0100)]
add a section about moving the database to another machine

3 years agoonly instantiate indexer once for replication
Sarah Hoffmann [Fri, 19 Nov 2021 13:47:00 +0000 (14:47 +0100)]
only instantiate indexer once for replication

Also makes sure that indexer object exists everywhere were needed.

See #2518.

3 years agoMerge pull request #2517 from lonvia/transliteration-special-chars
Sarah Hoffmann [Thu, 11 Nov 2021 06:42:42 +0000 (07:42 +0100)]
Merge pull request #2517 from lonvia/transliteration-special-chars

ICU: avoid non-alphanumerical characters in transliteration

3 years agomake sure housenumbers are properly quoted
Sarah Hoffmann [Wed, 10 Nov 2021 16:15:34 +0000 (17:15 +0100)]
make sure housenumbers are properly quoted

3 years agoavoid special characters in word tokens
Sarah Hoffmann [Wed, 10 Nov 2021 16:14:13 +0000 (17:14 +0100)]
avoid special characters in word tokens

Transliteration should only consist of ASCII letters
and numbers. Avoid any other characters.

3 years agoMerge pull request #2516 from lonvia/test-for-website-dir
Sarah Hoffmann [Wed, 10 Nov 2021 12:27:09 +0000 (13:27 +0100)]
Merge pull request #2516 from lonvia/test-for-website-dir

Better error reporting when API script does not exist

3 years agobetter error reporting when API script does not exist
Sarah Hoffmann [Wed, 10 Nov 2021 08:42:49 +0000 (09:42 +0100)]
better error reporting when API script does not exist

Check if the API script exists on the expected location before
running php-cli. This way we can add a useful hint about the
project directory.

Fixes #2513.

3 years agoMerge pull request #2511 from lonvia/fix-combination-error-needs-address
Sarah Hoffmann [Sat, 6 Nov 2021 11:11:55 +0000 (12:11 +0100)]
Merge pull request #2511 from lonvia/fix-combination-error-needs-address

Fix boolean combination of NeedsAddress flag

3 years agofix combination of NeedsAddress flag
Sarah Hoffmann [Fri, 5 Nov 2021 21:18:37 +0000 (22:18 +0100)]
fix combination of NeedsAddress flag

When dealing with multiple partial terms, only keep the
flag, when all partial terms are so frequent as to need
an address.

Fixes #2510.