]>
git.openstreetmap.org Git - nominatim.git/log
Sarah Hoffmann [Wed, 6 Dec 2023 19:56:21 +0000 (20:56 +0100)]
enable all API tests for sqlite and port missing features
Sarah Hoffmann [Wed, 6 Dec 2023 12:42:58 +0000 (13:42 +0100)]
extend sqlite converter for search tables
Sarah Hoffmann [Wed, 6 Dec 2023 10:14:36 +0000 (11:14 +0100)]
remove unused function
Sarah Hoffmann [Wed, 6 Dec 2023 10:13:12 +0000 (11:13 +0100)]
improve typing for @compiles constructs
The first parameter is in fact the self parameter referring to
the function class.
Sarah Hoffmann [Wed, 6 Dec 2023 10:03:12 +0000 (11:03 +0100)]
void unnecessary aliases
Sarah Hoffmann [Wed, 6 Dec 2023 09:55:21 +0000 (10:55 +0100)]
factor out SQL for filtering by location
Also improves on the decision if an indexed is used or not.
Sarah Hoffmann [Wed, 6 Dec 2023 09:37:06 +0000 (10:37 +0100)]
simplify handling of SQL lookup code for search_name
Use function classes which can be instantiated directly.
Sarah Hoffmann [Tue, 5 Dec 2023 20:20:57 +0000 (21:20 +0100)]
correctly close API objects during testing
Sarah Hoffmann [Tue, 5 Dec 2023 17:02:40 +0000 (18:02 +0100)]
clean up ST_DWithin and intersects() functions
A non-index version of ST_DWithin is not necessary. ST_Distance
can be used for that purpose. Index use for intersects can be
covered with a simple parameter.
Sarah Hoffmann [Tue, 5 Dec 2023 15:07:56 +0000 (16:07 +0100)]
simplify weigh_search() function
Use JSON arrays which can have mixed types and therefore have
a more logical structure than separate arrays. Avoid JSON dicts
because of their verboseness.
Sarah Hoffmann [Tue, 5 Dec 2023 14:23:16 +0000 (15:23 +0100)]
fix parameter formatting in sqlite debug output
Sarah Hoffmann [Tue, 5 Dec 2023 11:22:00 +0000 (12:22 +0100)]
enable connection pools for sqlite
Connecting is reasonably expensive because the spatialite extension
needs to be loaded. Disable pooling for tests because there is some
memory leak when quickly opening and closing QueuePools with sqlite
connections.
Sarah Hoffmann [Tue, 5 Dec 2023 10:29:16 +0000 (11:29 +0100)]
hide type differences between Postgres and Sqlite in custom types
Also define a custom set of operators in preparation of differences
in implementation.
Robbe Haesendonck [Thu, 23 Nov 2023 14:59:01 +0000 (15:59 +0100)]
Removed unnecessary check for --prepare-database flag
Robbe Haesendonck [Thu, 23 Nov 2023 14:51:35 +0000 (15:51 +0100)]
Connect using localhost instead of socket
Robbe Haesendonck [Thu, 23 Nov 2023 12:41:13 +0000 (13:41 +0100)]
Added changing permissions of nominatim-project dir
Robbe Haesendonck [Thu, 23 Nov 2023 12:17:33 +0000 (13:17 +0100)]
Added osm-import to sudoers file for tokenizer setup
Robbe Haesendonck [Thu, 23 Nov 2023 11:03:36 +0000 (12:03 +0100)]
Fixing CI tests for install-no-superuser
Robbe Haesendonck [Thu, 23 Nov 2023 10:25:49 +0000 (11:25 +0100)]
Fixed typechecking error
Robbe Haesendonck [Fri, 29 Sep 2023 08:23:35 +0000 (10:23 +0200)]
Added missing return types to functions
Robbe Haesendonck [Fri, 29 Sep 2023 08:18:44 +0000 (10:18 +0200)]
CI tests: Removed creation of user www-data.
Removed creation of user www-data as it already exists
Robbe Haesendonck [Thu, 28 Sep 2023 07:59:42 +0000 (09:59 +0200)]
Fixed legacy import command
Check whether prepare-database is true, if so exit early
Robbe Haesendonck [Wed, 27 Sep 2023 14:40:08 +0000 (16:40 +0200)]
Disabled pylint too-many-branches
Robbe Haesendonck [Wed, 27 Sep 2023 14:32:28 +0000 (16:32 +0200)]
Fixed setting tokenizer property
Robbe Haesendonck [Wed, 27 Sep 2023 13:28:21 +0000 (15:28 +0200)]
Updated no-superuser install ci test
Added nominatim_database_webuser (www-data).
Set non-superuser password for importing
Robbe Haesendonck [Wed, 27 Sep 2023 08:50:40 +0000 (10:50 +0200)]
Updated check to see if osm_file is set
Robbe Haesendonck [Wed, 27 Sep 2023 08:37:57 +0000 (10:37 +0200)]
Fixed formatting
Robbe Haesendonck [Wed, 27 Sep 2023 08:28:20 +0000 (10:28 +0200)]
Updated ci tests to reflect changes in Nominatim CLI
Robbe Haesendonck [Wed, 27 Sep 2023 07:29:54 +0000 (09:29 +0200)]
Made sure legacy import command still works
Robbe Haesendonck [Wed, 27 Sep 2023 07:24:04 +0000 (09:24 +0200)]
Removed unused variable, fixed connection
Robbe Haesendonck [Wed, 27 Sep 2023 07:21:56 +0000 (09:21 +0200)]
Removed _is_complete_import check
Robbe Haesendonck [Tue, 26 Sep 2023 12:46:28 +0000 (14:46 +0200)]
Improved logic.
Fixed small oversight in mutually exclusiveness of arguments
Robbe Haesendonck [Tue, 26 Sep 2023 10:59:14 +0000 (12:59 +0200)]
Added new psql user for importing the data
Robbe Haesendonck [Tue, 26 Sep 2023 09:59:32 +0000 (11:59 +0200)]
Changed naming of flags.
Made sure legacy import is also still ok
Robbe Haesendonck [Mon, 25 Sep 2023 10:39:38 +0000 (12:39 +0200)]
Added check to see if hstore is loaded
Robbe Haesendonck [Mon, 25 Sep 2023 09:14:14 +0000 (11:14 +0200)]
Fixed ci-tests, osm-file flag
Preparing database should work without osm-file
Robbe Haesendonck [Mon, 25 Sep 2023 09:09:20 +0000 (11:09 +0200)]
Renamed flags
Robbe Haesendonck [Thu, 21 Sep 2023 10:28:45 +0000 (12:28 +0200)]
Fixed pylint warnings
Robbe Haesendonck [Thu, 21 Sep 2023 10:20:46 +0000 (12:20 +0200)]
Added check for hstore extension
Robbe Haesendonck [Thu, 21 Sep 2023 09:20:24 +0000 (11:20 +0200)]
Fixed typo
Robbe Haesendonck [Thu, 21 Sep 2023 07:58:38 +0000 (09:58 +0200)]
Fixed linting errors
Robbe Haesendonck [Wed, 20 Sep 2023 14:05:12 +0000 (16:05 +0200)]
Added version check for PostGis and Postgres
Robbe Haesendonck [Wed, 20 Sep 2023 11:42:06 +0000 (13:42 +0200)]
Updated CI tests to check new import flags
Robbe Haesendonck [Wed, 20 Sep 2023 11:00:39 +0000 (13:00 +0200)]
Added --prepare-database flag
Robbe Haesendonck [Tue, 19 Sep 2023 14:19:11 +0000 (16:19 +0200)]
Added --no-superuser flag
To allow import into already existing databases.
Refs: #2719
Sarah Hoffmann [Sun, 3 Dec 2023 14:51:42 +0000 (15:51 +0100)]
actions: pin pytest-asyncio version for Ubuntu 20
Newest versions are no longer compatible with older pytest.
Sarah Hoffmann [Fri, 1 Dec 2023 11:11:58 +0000 (12:11 +0100)]
skip lookup with full names when there are none
Sarah Hoffmann [Wed, 29 Nov 2023 13:02:24 +0000 (14:02 +0100)]
Merge pull request #3263 from lonvia/near-search-penalty-inheritance
More tweaks for Python frontend search
Sarah Hoffmann [Wed, 29 Nov 2023 10:19:06 +0000 (11:19 +0100)]
further restrict stop search criterion
Sarah Hoffmann [Sat, 25 Nov 2023 17:39:28 +0000 (18:39 +0100)]
use restrict for housenumber lookups with few numbers
Sarah Hoffmann [Tue, 28 Nov 2023 19:12:12 +0000 (20:12 +0100)]
NearSearch needs to inherit penalty from inner search
Sarah Hoffmann [Tue, 28 Nov 2023 19:02:36 +0000 (20:02 +0100)]
Merge pull request #3262 from lonvia/fix-category-search
Fix use of category parameter for search() function
Sarah Hoffmann [Tue, 28 Nov 2023 16:53:37 +0000 (17:53 +0100)]
correctly exclude streets with housenumber searches
Street result are not subject to the full filtering in the SQL
query, so recheck.
Sarah Hoffmann [Tue, 28 Nov 2023 15:56:08 +0000 (16:56 +0100)]
add tests for interaction of category parameter with category terms
Sarah Hoffmann [Tue, 28 Nov 2023 15:27:05 +0000 (16:27 +0100)]
rename use of category as POI search to near_item
Use the term category only as a short-cut for "tuple of key and value".
Sarah Hoffmann [Tue, 28 Nov 2023 11:01:49 +0000 (12:01 +0100)]
the category parameter in search should result in a qualifier
Sarah Hoffmann [Mon, 27 Nov 2023 11:02:11 +0000 (12:02 +0100)]
Merge pull request #3260 from lonvia/improve-catgeory-search
Various improvements to search with special phrases for Python frontend
Sarah Hoffmann [Sun, 26 Nov 2023 19:58:50 +0000 (20:58 +0100)]
drop category tokens when they make up a full phrase
Sarah Hoffmann [Sun, 26 Nov 2023 16:41:29 +0000 (17:41 +0100)]
restrict base results in near search by rank
This avoids in particular that roads or POIs are used as base
for the near search when a place result is present.
Sarah Hoffmann [Sun, 26 Nov 2023 16:11:15 +0000 (17:11 +0100)]
deduplicate categories/qualifiers
Sarah Hoffmann [Sun, 26 Nov 2023 15:48:04 +0000 (16:48 +0100)]
order near searches by distance instead of importance
Sarah Hoffmann [Sun, 26 Nov 2023 08:50:59 +0000 (09:50 +0100)]
avoid duplicate lines during category search
Sarah Hoffmann [Sat, 25 Nov 2023 20:01:27 +0000 (21:01 +0100)]
fix polygon selection for classtable lookups
Polygons should be used preferably with higher address ranks
where the areas are smaller.
Sarah Hoffmann [Thu, 23 Nov 2023 11:05:50 +0000 (12:05 +0100)]
Merge pull request #3257 from lonvia/slow-queries
Performance tweaks for search
Sarah Hoffmann [Thu, 23 Nov 2023 09:51:58 +0000 (10:51 +0100)]
increase penalty for one-letter words
Sarah Hoffmann [Wed, 22 Nov 2023 22:57:23 +0000 (23:57 +0100)]
more preference for name-only queries in search
Sarah Hoffmann [Wed, 22 Nov 2023 19:54:04 +0000 (20:54 +0100)]
avoid index use when filtering by layer
Sarah Hoffmann [Wed, 22 Nov 2023 16:38:32 +0000 (17:38 +0100)]
add timestamps to text logging
Sarah Hoffmann [Wed, 22 Nov 2023 16:33:17 +0000 (17:33 +0100)]
avoid index on rank_address in near search
Sarah Hoffmann [Wed, 22 Nov 2023 16:01:41 +0000 (17:01 +0100)]
exclude country-level searches with non-address layers
Sarah Hoffmann [Wed, 22 Nov 2023 11:51:37 +0000 (12:51 +0100)]
Merge pull request #3252 from kumarUjjawal/patch-1
minor typo fix
Kumar Ujjawal [Mon, 20 Nov 2023 11:53:42 +0000 (17:23 +0530)]
minor typo fix
fixed a minor typo, from 'wit' to 'with'.
Sarah Hoffmann [Mon, 20 Nov 2023 09:44:48 +0000 (10:44 +0100)]
add report on newest vulnerability
Sarah Hoffmann [Thu, 16 Nov 2023 10:02:25 +0000 (11:02 +0100)]
improve code to collect the PostGIS version
The SQL contained an unchecked string literal, which may in theory be
used to attack the database.
Sarah Hoffmann [Wed, 15 Nov 2023 21:10:21 +0000 (22:10 +0100)]
Merge pull request #3248 from lonvia/fix-postcode-area-computation
PHP frontent: fix postcode area computation for address points
Sarah Hoffmann [Wed, 15 Nov 2023 18:59:26 +0000 (19:59 +0100)]
adapt typing to newest version of SQLAlchemy
Sarah Hoffmann [Wed, 15 Nov 2023 16:45:12 +0000 (17:45 +0100)]
php frontend: fix on-the-fly lookup of postcode areas
Sarah Hoffmann [Wed, 1 Nov 2023 10:57:57 +0000 (11:57 +0100)]
remove now unnecessary type igonre comment
Sarah Hoffmann [Tue, 31 Oct 2023 20:10:23 +0000 (21:10 +0100)]
fix assertion on address list, it may be empty
Fixes #3237.
Sarah Hoffmann [Wed, 25 Oct 2023 12:54:13 +0000 (14:54 +0200)]
Merge pull request #3235 from lonvia/fix-python-deploy
Python frontend deployment: add systemd service for the socket
Sarah Hoffmann [Wed, 25 Oct 2023 09:21:40 +0000 (11:21 +0200)]
python deployment: add systemd service for the socket
Sarah Hoffmann [Wed, 25 Oct 2023 07:38:17 +0000 (09:38 +0200)]
Merge pull request #3234 from lonvia/reduce-admin-style
Streamline admin style
Sarah Hoffmann [Tue, 24 Oct 2023 09:54:35 +0000 (11:54 +0200)]
Merge pull request #3233 from lonvia/support-for-sqlite
Add support for SQLite DBs in frontend: reverse
Sarah Hoffmann [Tue, 24 Oct 2023 07:50:43 +0000 (09:50 +0200)]
further reduce admin style import to admin-only objects
Sarah Hoffmann [Thu, 19 Oct 2023 19:24:53 +0000 (21:24 +0200)]
restrict geometry size for SQLite
Sarah Hoffmann [Tue, 17 Oct 2023 08:59:47 +0000 (10:59 +0200)]
convert sqlite: add index on parent_place_id
Sarah Hoffmann [Tue, 17 Oct 2023 08:57:52 +0000 (10:57 +0200)]
remove type info from SQLALchemy condition functions
A boolean type makes the SQLite dialect produce a costruct like
'func() = 1' in WHERE condition. While syntactically correct, it tends
to confuse the query planer.
Sarah Hoffmann [Mon, 16 Oct 2023 14:57:13 +0000 (16:57 +0200)]
make code work with Spatialite 4.3
Transfer is_address_point into SQLAlchemy function, so that
json.has_key() can use the older json_extract() function.
And work around broken Distance function.
Sarah Hoffmann [Fri, 13 Oct 2023 19:32:03 +0000 (21:32 +0200)]
enable BDD tests for sqlite databases
The database must currently be created by hand and the name handed
in via -DAPI_TEST_DB='sqlite:...'.
Sarah Hoffmann [Fri, 13 Oct 2023 12:09:11 +0000 (14:09 +0200)]
trim all coordinate output to 7 digits
Sarah Hoffmann [Fri, 13 Oct 2023 09:38:36 +0000 (11:38 +0200)]
add indexing support for DWithin and intersects for sqlite
Sarah Hoffmann [Fri, 13 Oct 2023 09:03:13 +0000 (11:03 +0200)]
make reverse API work with sqlite
Sarah Hoffmann [Thu, 12 Oct 2023 14:00:28 +0000 (16:00 +0200)]
actions: enable sqlite testing
Sarah Hoffmann [Thu, 12 Oct 2023 14:19:12 +0000 (16:19 +0200)]
try future annotations to resolve Generics compatibility
Sarah Hoffmann [Thu, 12 Oct 2023 14:17:16 +0000 (16:17 +0200)]
make status API work with sqlite incl. unit tests
Sarah Hoffmann [Thu, 12 Oct 2023 13:31:20 +0000 (15:31 +0200)]
make details API work with sqlite incl. unit tests
Sarah Hoffmann [Thu, 12 Oct 2023 11:51:10 +0000 (13:51 +0200)]
make lookup call work with sqlite
Includes porting unit tests.
Sarah Hoffmann [Thu, 12 Oct 2023 08:45:12 +0000 (10:45 +0200)]
add exporting of SQLite table
Sarah Hoffmann [Wed, 11 Oct 2023 20:35:18 +0000 (22:35 +0200)]
add skeleton code for convert function
Sarah Hoffmann [Wed, 11 Oct 2023 09:30:42 +0000 (11:30 +0200)]
streamline SQLAlchemy DB schema
Remove all information not strictly used by the frontend as well as
any index information. This will make it easier to create a SQLite
database from the schema.