]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
2 years agoMerge pull request #2621 from lonvia/housenumber-analyzer
Sarah Hoffmann [Tue, 1 Mar 2022 14:19:07 +0000 (15:19 +0100)]
Merge pull request #2621 from lonvia/housenumber-analyzer

Introduce optional token analysis for housenumbers

2 years agodo not expand records in select list
Sarah Hoffmann [Tue, 1 Mar 2022 07:54:15 +0000 (08:54 +0100)]
do not expand records in select list

An expression of the form 'SELECT (func()).*' will be expanded
by Postgresql _before_ execution with the result that the function
will be called as many times as there are fields in the record.
This is not what we want. The function call needs to go into
the FROM clause instead.

2 years agofix linting issue
Sarah Hoffmann [Fri, 18 Feb 2022 22:24:50 +0000 (23:24 +0100)]
fix linting issue

2 years agoadd tests for new analyzed housenumbers
Sarah Hoffmann [Fri, 18 Feb 2022 20:51:19 +0000 (21:51 +0100)]
add tests for new analyzed housenumbers

2 years agoadapt housenumber cleanup to new word table structure
Sarah Hoffmann [Fri, 18 Feb 2022 15:43:17 +0000 (16:43 +0100)]
adapt housenumber cleanup to new word table structure

2 years agobdd: disable some housenumber tests for legacy
Sarah Hoffmann [Fri, 18 Feb 2022 14:58:38 +0000 (15:58 +0100)]
bdd: disable some housenumber tests for legacy

Optional spaces in housenumbers are not supported by legacy tokenizer,
so disable those tests.

2 years agoadd documentation for housenumber analyzer
Sarah Hoffmann [Fri, 18 Feb 2022 14:55:10 +0000 (15:55 +0100)]
add documentation for housenumber analyzer

2 years agohousenumber analyzer: avoid creating too many variants
Sarah Hoffmann [Wed, 16 Feb 2022 19:36:30 +0000 (20:36 +0100)]
housenumber analyzer: avoid creating too many variants

Housenumber fields with lots of text are likely bad data. So is
data with many changes from letter to digit. Exclude them from adding
optional spaces.

2 years agoadd new analyser for houenumbers
Sarah Hoffmann [Wed, 16 Feb 2022 16:18:23 +0000 (17:18 +0100)]
add new analyser for houenumbers

This analyser makes spaces optional.

2 years agoadd framework for analysing housenumbers
Sarah Hoffmann [Wed, 16 Feb 2022 10:15:43 +0000 (11:15 +0100)]
add framework for analysing housenumbers

This lays the groundwork for adding variants for housenumbers.
When analysis is enabled, then the 'word' field in the word table
is used as usual, so that variants can be created. There will be
only one analyser allowed which must have the fixed name
'@housenumber'.

2 years agoicu: move token deduplication into TokenInfo
Sarah Hoffmann [Tue, 15 Feb 2022 20:51:49 +0000 (21:51 +0100)]
icu: move token deduplication into TokenInfo

Puts collection into one common place.

2 years agoicu: move housenumber token computation out of TokenInfo
Sarah Hoffmann [Tue, 15 Feb 2022 20:20:47 +0000 (21:20 +0100)]
icu: move housenumber token computation out of TokenInfo

This was the last function to use the cache. There is a more clean
separation of responsibility now.

2 years agohandle unknown analyzer
Sarah Hoffmann [Tue, 15 Feb 2022 13:38:03 +0000 (14:38 +0100)]
handle unknown analyzer

When changing something in the default configuration of the sanatizers
that refers to an analyzer that is not yet loaded, there shouldn't be
any errors.

2 years agomove generation of normalized token form to analyzer
Sarah Hoffmann [Tue, 15 Feb 2022 11:15:18 +0000 (12:15 +0100)]
move generation of normalized token form to analyzer

This gives the analyzer more flexibility in choosing the normalized
form. In particular, an analyzer creating different variants can choose
the variant that will be used as the canonical form.

2 years agoMerge pull request #2614 from lonvia/reorganise-country-names
Sarah Hoffmann [Fri, 25 Feb 2022 08:46:20 +0000 (09:46 +0100)]
Merge pull request #2614 from lonvia/reorganise-country-names

Reorganise handling of country names imported from OSM

2 years agoadd migration to add new derived_names column
Sarah Hoffmann [Thu, 24 Feb 2022 19:49:39 +0000 (20:49 +0100)]
add migration to add new derived_names column

2 years agoadd tests for country updates
Sarah Hoffmann [Thu, 24 Feb 2022 15:18:49 +0000 (16:18 +0100)]
add tests for country updates

2 years agobdd: run full import on tests
Sarah Hoffmann [Thu, 24 Feb 2022 10:35:21 +0000 (11:35 +0100)]
bdd: run full import on tests

This uncovered a couple of outdated/wrong tests which have been
fixed, too.

2 years agocountry_name: use separate columns for names from OSM
Sarah Hoffmann [Tue, 22 Feb 2022 22:35:48 +0000 (23:35 +0100)]
country_name: use separate columns for names from OSM

This allows us to distinguish between base names and imported ones
and consiquently removing imported ones if necessary.

2 years agodelete unused country name tokens
Sarah Hoffmann [Tue, 22 Feb 2022 19:15:04 +0000 (20:15 +0100)]
delete unused country name tokens

2 years agoupdate supported versions
Sarah Hoffmann [Wed, 23 Feb 2022 08:22:17 +0000 (09:22 +0100)]
update supported versions

2 years agoadd 'healthcare' as main tag
Sarah Hoffmann [Mon, 21 Feb 2022 10:52:17 +0000 (11:52 +0100)]
add 'healthcare' as main tag

Given that the tag is most of the time duplicated by an amenity
tag which is already imported, only import it as a fallback when
there is no name.

Fixes #2609.

2 years agocreate idx_place_interpolations for import already
Sarah Hoffmann [Fri, 18 Feb 2022 10:11:22 +0000 (11:11 +0100)]
create idx_place_interpolations for import already

It is needed to look up if a node is part of an interpolation.

Fixes #2608.

2 years agoMerge pull request #2603 from lonvia/one-step-housenumber-search
Sarah Hoffmann [Thu, 10 Feb 2022 16:27:56 +0000 (17:27 +0100)]
Merge pull request #2603 from lonvia/one-step-housenumber-search

One step housenumber search

2 years agoadd test that interpolations are found by odd/even
Sarah Hoffmann [Thu, 10 Feb 2022 10:23:51 +0000 (11:23 +0100)]
add test that interpolations are found by odd/even

2 years agomake sure step is taken into account for interpolations
Sarah Hoffmann [Wed, 9 Feb 2022 20:42:28 +0000 (21:42 +0100)]
make sure step is taken into account for interpolations

2 years agoinclude houseumber search in name query
Sarah Hoffmann [Tue, 8 Feb 2022 21:35:12 +0000 (22:35 +0100)]
include houseumber search in name query

The name query already looks for the existence of housenumbers and
may as well retrive them. Saves up to threee additional lookups.
It also means that we can lift the restriction on looking
for existance of housenumbers for simple queries only.

2 years agodisable debug message in interpolation processing
Sarah Hoffmann [Mon, 7 Feb 2022 22:30:25 +0000 (23:30 +0100)]
disable debug message in interpolation processing

2 years agoMerge pull request #2602 from lonvia/filter-bad-housenumbers
Sarah Hoffmann [Mon, 7 Feb 2022 15:27:04 +0000 (16:27 +0100)]
Merge pull request #2602 from lonvia/filter-bad-housenumbers

Handle mistagged housenumbers like names

2 years agoliniting: disable too-many-ancestors
Sarah Hoffmann [Mon, 7 Feb 2022 10:49:18 +0000 (11:49 +0100)]
liniting: disable too-many-ancestors

This is triggered by UserDict which is meant of deriving.

2 years agoadd tests for housenumber-as-name feature
Sarah Hoffmann [Mon, 7 Feb 2022 10:45:12 +0000 (11:45 +0100)]
add tests for housenumber-as-name feature

2 years agoadd tests for get_string_list()
Sarah Hoffmann [Mon, 7 Feb 2022 10:22:24 +0000 (11:22 +0100)]
add tests for get_string_list()

Renaming test file for sanitizer config because pytest requires
unique names for test files.

2 years agosanitizer: move helpers into a configuration class
Sarah Hoffmann [Mon, 7 Feb 2022 09:48:00 +0000 (10:48 +0100)]
sanitizer: move helpers into a configuration class

2 years agoimplement is-a-name option for housenumbers
Sarah Hoffmann [Sat, 5 Feb 2022 14:13:45 +0000 (15:13 +0100)]
implement is-a-name option for housenumbers

2 years agoMerge pull request #2598 from geofabrik/doc-update-systemd-timer
Sarah Hoffmann [Sun, 6 Feb 2022 09:24:48 +0000 (10:24 +0100)]
Merge pull request #2598 from geofabrik/doc-update-systemd-timer

Document how to set up systemd timers for --once updates

2 years agoreally remove CentOS from CI
Sarah Hoffmann [Sat, 5 Feb 2022 15:07:12 +0000 (16:07 +0100)]
really remove CentOS from CI

2 years agoremove CentOS from CI
Sarah Hoffmann [Sat, 5 Feb 2022 14:14:47 +0000 (15:14 +0100)]
remove CentOS from CI

The CentOS docker image no longer works after CentOS8 went EOL.
See #2601 for discussion.

2 years agoMerge pull request #2599 from StephanGeorg/patch-1
Sarah Hoffmann [Thu, 3 Feb 2022 08:45:59 +0000 (09:45 +0100)]
Merge pull request #2599 from StephanGeorg/patch-1

Fixed link

2 years agoFixed link
Stephan Georg [Thu, 3 Feb 2022 08:39:03 +0000 (09:39 +0100)]
Fixed link

2 years agoDocument how to set up systemd timers for --once updates
Amanda McCann [Thu, 13 Jan 2022 12:11:25 +0000 (13:11 +0100)]
Document how to set up systemd timers for --once updates

2 years agorestrict change propagation to interpolation lines
Sarah Hoffmann [Fri, 28 Jan 2022 10:05:37 +0000 (11:05 +0100)]
restrict change propagation to interpolation lines

Also means that Postgresql will use the right index for the query.

2 years agoMerge pull request #2597 from lonvia/reorganise-interpolations
Sarah Hoffmann [Fri, 28 Jan 2022 07:40:08 +0000 (08:40 +0100)]
Merge pull request #2597 from lonvia/reorganise-interpolations

Reorganise interpolation code

2 years agoMerge pull request #2596 from lonvia/remove-codecov
Sarah Hoffmann [Thu, 27 Jan 2022 16:11:17 +0000 (17:11 +0100)]
Merge pull request #2596 from lonvia/remove-codecov

Remove codecov

2 years agoremove tests for closest housenumber function
Sarah Hoffmann [Thu, 27 Jan 2022 15:21:45 +0000 (16:21 +0100)]
remove tests for closest housenumber function

2 years agophp unit tests don't work on ubuntu 18
Sarah Hoffmann [Tue, 25 Jan 2022 13:03:55 +0000 (14:03 +0100)]
php unit tests don't work on ubuntu 18

2 years agoremove codecov
Sarah Hoffmann [Tue, 25 Jan 2022 11:09:33 +0000 (12:09 +0100)]
remove codecov

Causes more trouble than doing good.

2 years agoraise PostgreSQL requirement to 9.6
Sarah Hoffmann [Thu, 27 Jan 2022 14:15:56 +0000 (15:15 +0100)]
raise PostgreSQL requirement to 9.6

The new code uses the open-ended array notation which is only
available sind psql 9.6.

2 years agouse new tiger step column for queries
Sarah Hoffmann [Thu, 27 Jan 2022 13:08:08 +0000 (14:08 +0100)]
use new tiger step column for queries

2 years agoadd step column to tiger data table
Sarah Hoffmann [Thu, 27 Jan 2022 10:54:12 +0000 (11:54 +0100)]
add step column to tiger data table

This replaces the interpolationtype column.

2 years agoadd migration for upcoming change to tiger tables
Sarah Hoffmann [Thu, 27 Jan 2022 10:41:16 +0000 (11:41 +0100)]
add migration for upcoming change to tiger tables

2 years agoadapt frontend to new interpolation table layout
Sarah Hoffmann [Wed, 26 Jan 2022 20:24:24 +0000 (21:24 +0100)]
adapt frontend to new interpolation table layout

2 years agoadapt BDD tests for new interpolation style
Sarah Hoffmann [Wed, 26 Jan 2022 14:24:06 +0000 (15:24 +0100)]
adapt BDD tests for new interpolation style

2 years agoinherit tags from interpolation not parent
Sarah Hoffmann [Wed, 26 Jan 2022 11:05:04 +0000 (12:05 +0100)]
inherit tags from interpolation not parent

Nodes on an interpolation now only get the address tags of
interpolations and then compute their own parent from that. They no
longer inherit the parent directly.

2 years agoadd migration for new interpolation table layout
Sarah Hoffmann [Thu, 27 Jan 2022 10:12:40 +0000 (11:12 +0100)]
add migration for new interpolation table layout

2 years agoadd migration for new lookup index
Sarah Hoffmann [Tue, 25 Jan 2022 11:00:35 +0000 (12:00 +0100)]
add migration for new lookup index

2 years agooptimize indexes for interpolation lines
Sarah Hoffmann [Tue, 25 Jan 2022 10:24:13 +0000 (11:24 +0100)]
optimize indexes for interpolation lines

Do not index 'inactive' rows (with startnumber is null) where possible.

2 years agoimprove handling von updates on nodes in interpolations
Sarah Hoffmann [Tue, 25 Jan 2022 09:14:05 +0000 (10:14 +0100)]
improve handling von updates on nodes in interpolations

Use the same update mechanism as for updates on the interpolations
themselves. Updates must solely happen in place_insert as this is
the place where actual changes of the data happen.

2 years agoupdate interpolations instead of deleting and recreating
Sarah Hoffmann [Mon, 24 Jan 2022 15:26:28 +0000 (16:26 +0100)]
update interpolations instead of deleting and recreating

2 years agoMerge pull request #2595 from nslxndr/fix-doc-typos
Sarah Hoffmann [Wed, 26 Jan 2022 22:08:41 +0000 (23:08 +0100)]
Merge pull request #2595 from nslxndr/fix-doc-typos

Fix typos in UI doc

2 years agoFix typos in UI doc
Sandor Nagy [Wed, 26 Jan 2022 20:39:20 +0000 (21:39 +0100)]
Fix typos in UI doc

2 years agoMerge pull request #2594 from lonvia/update-osm2pgsql
Sarah Hoffmann [Tue, 25 Jan 2022 11:11:57 +0000 (12:11 +0100)]
Merge pull request #2594 from lonvia/update-osm2pgsql

Update to osm2pgsql 1.6.0

2 years agoupdate to osm2pgsql 1.6.0
Sarah Hoffmann [Mon, 24 Jan 2022 15:55:52 +0000 (16:55 +0100)]
update to osm2pgsql 1.6.0

2 years agoMerge pull request #2591 from lonvia/cleanup-place-insert
Sarah Hoffmann [Mon, 24 Jan 2022 14:58:23 +0000 (15:58 +0100)]
Merge pull request #2591 from lonvia/cleanup-place-insert

Reorganise code of place_insert() trigger

2 years agoreorganise place_insert trigger
Sarah Hoffmann [Mon, 24 Jan 2022 08:12:50 +0000 (09:12 +0100)]
reorganise place_insert trigger

Code cleanup and formatting as well as minor improvements, in
particular removal of unnecessary code.

2 years agoMerge pull request #2589 from lonvia/clean-housenumbers
Sarah Hoffmann [Fri, 21 Jan 2022 09:17:58 +0000 (10:17 +0100)]
Merge pull request #2589 from lonvia/clean-housenumbers

Add command for cleaning up word table

2 years agoadd tests for cleaning housenumbers
Sarah Hoffmann [Thu, 20 Jan 2022 22:47:20 +0000 (23:47 +0100)]
add tests for cleaning housenumbers

2 years agodo not clean housenumbers in reverse-only mode
Sarah Hoffmann [Thu, 20 Jan 2022 19:21:13 +0000 (20:21 +0100)]
do not clean housenumbers in reverse-only mode

2 years agoadd actual removal of housenumber tokens
Sarah Hoffmann [Thu, 20 Jan 2022 19:18:15 +0000 (20:18 +0100)]
add actual removal of housenumber tokens

2 years agoadd new command for cleaning word tokens
Sarah Hoffmann [Thu, 20 Jan 2022 19:05:15 +0000 (20:05 +0100)]
add new command for cleaning word tokens

Just pulls outdated housenumbers for the moment.

2 years agoMerge pull request #2588 from lonvia/housenumber-sanitizer
Sarah Hoffmann [Thu, 20 Jan 2022 16:44:24 +0000 (17:44 +0100)]
Merge pull request #2588 from lonvia/housenumber-sanitizer

Move housenumber parsing into sanitizer

2 years agoadapt ICU tets to new housenumber sanitizer
Sarah Hoffmann [Thu, 20 Jan 2022 15:05:49 +0000 (16:05 +0100)]
adapt ICU tets to new housenumber sanitizer

Restrict tests to making sure that handing in multiple housenumbers
works.

2 years agofix linting issues
Sarah Hoffmann [Thu, 20 Jan 2022 15:00:23 +0000 (16:00 +0100)]
fix linting issues

2 years agocomplete documentation for new clean-houseunubmers sanatizer
Sarah Hoffmann [Thu, 20 Jan 2022 14:49:32 +0000 (15:49 +0100)]
complete documentation for new clean-houseunubmers sanatizer

2 years agogeneralize filter-kind parameter for sanatizers
Sarah Hoffmann [Thu, 20 Jan 2022 14:42:42 +0000 (15:42 +0100)]
generalize filter-kind parameter for sanatizers

Now behaves the same for tag_analyzer_by_language and
clean_housenumbers. Adds tests.

2 years agoadd pytest config
Sarah Hoffmann [Thu, 20 Jan 2022 14:38:02 +0000 (15:38 +0100)]
add pytest config

We are using custom marks now which need to be registered to avoid
warnings.

2 years agoclean_housenumbers: make kinds and delimiters configurable
Sarah Hoffmann [Thu, 20 Jan 2022 11:07:12 +0000 (12:07 +0100)]
clean_housenumbers: make kinds and delimiters configurable

Also adds unit tests for various options.

2 years agofactor out housenumber splitting into sanitizer
Sarah Hoffmann [Fri, 7 Jan 2022 21:41:09 +0000 (22:41 +0100)]
factor out housenumber splitting into sanitizer

2 years agoMerge pull request #2585 from lonvia/name-mutations
Sarah Hoffmann [Wed, 19 Jan 2022 16:09:36 +0000 (17:09 +0100)]
Merge pull request #2585 from lonvia/name-mutations

Introduce character mutations to token analysis

2 years agodocs: add pointer to caddy deployment discussion
Sarah Hoffmann [Wed, 19 Jan 2022 14:28:01 +0000 (15:28 +0100)]
docs: add pointer to caddy deployment discussion

2 years agofix linting error
Sarah Hoffmann [Thu, 13 Jan 2022 08:30:31 +0000 (09:30 +0100)]
fix linting error

2 years agomove parsing of mutation config to setup phase
Sarah Hoffmann [Wed, 12 Jan 2022 18:41:16 +0000 (19:41 +0100)]
move parsing of mutation config to setup phase

2 years agoadd documentation for new mutation feature
Sarah Hoffmann [Wed, 12 Jan 2022 16:37:06 +0000 (17:37 +0100)]
add documentation for new mutation feature

2 years agointroduce mutation variants to generic token analyser
Sarah Hoffmann [Wed, 12 Jan 2022 15:25:47 +0000 (16:25 +0100)]
introduce mutation variants to generic token analyser

Mutations are regular-expression-based replacements that are applied
after variants have been computed. They are meant to be used for
variations on character level.

Add spelling variations for German umlauts.

2 years agomove variant configuration reading in separate file
Sarah Hoffmann [Wed, 12 Jan 2022 08:53:32 +0000 (09:53 +0100)]
move variant configuration reading in separate file

2 years agorefactor variant production to use generators
Sarah Hoffmann [Tue, 11 Jan 2022 16:51:05 +0000 (17:51 +0100)]
refactor variant production to use generators

2 years agoMerge pull request #2578 from lonvia/iso-3166-2
Sarah Hoffmann [Thu, 13 Jan 2022 13:54:35 +0000 (14:54 +0100)]
Merge pull request #2578 from lonvia/iso-3166-2

Make ISO3166-2 references searchable

2 years agoMerge pull request #2579 from geofabrik/doc-update-typo
Sarah Hoffmann [Thu, 13 Jan 2022 13:01:57 +0000 (14:01 +0100)]
Merge pull request #2579 from geofabrik/doc-update-typo

Fix typo in name of service. The rest of the docs call it nominatim-updateS

2 years agoFix typo in name of service. The rest of the docs call it nominatim-updateS
Amanda McCann [Thu, 13 Jan 2022 12:14:17 +0000 (13:14 +0100)]
Fix typo in name of service. The rest of the docs call it nominatim-updateS

2 years agomake ISO3166-2 references searchable
Sarah Hoffmann [Thu, 13 Jan 2022 08:44:42 +0000 (09:44 +0100)]
make ISO3166-2 references searchable

2 years agoMerge pull request #2571 from lonvia/ukrainian-apostrophe
Sarah Hoffmann [Tue, 11 Jan 2022 08:41:07 +0000 (09:41 +0100)]
Merge pull request #2571 from lonvia/ukrainian-apostrophe

Consider "modifier letter apostrophe" to be punctuation

2 years agoconsider "modifier letter apostrophe" to be punctuation
Sarah Hoffmann [Mon, 10 Jan 2022 16:40:03 +0000 (17:40 +0100)]
consider "modifier letter apostrophe" to be punctuation

While technically being a letter, the apostrophe is often replaced
with a normal apostrophe in writing which is a punctuation mark.
This makes sure that the modifier letter apostrophe yields the same
normalization results and thus is really interchangable.

Only has an effect after the next reimport.

Fixes #2569.

2 years agoMerge pull request #2570 from woodpeck/patch-3
Sarah Hoffmann [Mon, 10 Jan 2022 13:21:48 +0000 (14:21 +0100)]
Merge pull request #2570 from woodpeck/patch-3

Fix typos

2 years agoFix typos
Frederik Ramm [Mon, 10 Jan 2022 12:38:53 +0000 (13:38 +0100)]
Fix typos

2 years agoMerge pull request #2565 from lonvia/swap-wordset-order
Sarah Hoffmann [Thu, 6 Jan 2022 08:02:46 +0000 (09:02 +0100)]
Merge pull request #2565 from lonvia/swap-wordset-order

Swap order of query interpretation

2 years agoswap order of query interpretation
Sarah Hoffmann [Wed, 5 Jan 2022 14:21:14 +0000 (15:21 +0100)]
swap order of query interpretation

A forward interpretation of the form 'street, city, country' is
much more frequent than the reverse form 'country, city, street'.
Thus swap the order of interpretations that the forward order comes
first.

2 years agoMerge pull request #2562 from lonvia/copyright-headers
Sarah Hoffmann [Tue, 4 Jan 2022 22:10:37 +0000 (23:10 +0100)]
Merge pull request #2562 from lonvia/copyright-headers

Add consistent copyright headers

2 years agoadd consistent SPDX copyright headers
Sarah Hoffmann [Mon, 3 Jan 2022 15:23:58 +0000 (16:23 +0100)]
add consistent SPDX copyright headers

2 years agoMerge pull request #2559 from lonvia/disable-jit-in-queries
Sarah Hoffmann [Mon, 3 Jan 2022 14:13:57 +0000 (15:13 +0100)]
Merge pull request #2559 from lonvia/disable-jit-in-queries

Disable JIT and parallel workers on search frontend

2 years agodisable JIT and parallel workers on search frontend
Sarah Hoffmann [Wed, 22 Dec 2021 07:59:31 +0000 (08:59 +0100)]
disable JIT and parallel workers on search frontend

Bad query planning now also interferes with queries for search and
reverse.

2 years agoMerge pull request #2553 from lonvia/revert-street-matching-to-full-names
Sarah Hoffmann [Tue, 14 Dec 2021 14:52:34 +0000 (15:52 +0100)]
Merge pull request #2553 from lonvia/revert-street-matching-to-full-names

Revert street matching to full names