]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
4 years agoremove linked places also from the location_area_large tables
Sarah Hoffmann [Sun, 10 May 2020 11:59:47 +0000 (13:59 +0200)]
remove linked places also from the location_area_large tables

We don't want linked places to show up in addresses either,
so remove them from the address lookup table.

4 years agoAdd simple/structured query selector to HTML search page (#1722)
galewis2 [Thu, 7 May 2020 23:29:44 +0000 (19:29 -0400)]
Add simple/structured query selector to HTML search page (#1722)

4 years agoMerge pull request #1786 from lonvia/remove-ubuntu-1604
Sarah Hoffmann [Thu, 7 May 2020 20:42:31 +0000 (22:42 +0200)]
Merge pull request #1786 from lonvia/remove-ubuntu-1604

remove Ubuntu 16 installation instructions

4 years agoMerge pull request #1782 from Simon-Will/1781-make-tests-work-with-phpunit-8
Sarah Hoffmann [Thu, 7 May 2020 20:01:35 +0000 (22:01 +0200)]
Merge pull request #1782 from Simon-Will/1781-make-tests-work-with-phpunit-8

Make tests work with phpunit 8

4 years agoremove Ubuntu 16 installation instructions
Sarah Hoffmann [Thu, 7 May 2020 19:55:04 +0000 (21:55 +0200)]
remove Ubuntu 16 installation instructions

Also fixes up CentOS 8 links in documentation.

4 years agoUse Ubuntu’s packaged composer, not the custom installation
Simon Will [Thu, 7 May 2020 19:44:45 +0000 (21:44 +0200)]
Use Ubuntu’s packaged composer, not the custom installation

4 years agoMerge pull request #1780 from Simon-Will/1768-vagrant-installation-for-ubuntu-20
Sarah Hoffmann [Thu, 7 May 2020 18:46:44 +0000 (20:46 +0200)]
Merge pull request #1780 from Simon-Will/1768-vagrant-installation-for-ubuntu-20

Add vagrant machine for Ubuntu 20.04

4 years agoIntegrate Ubuntu 20 instructions into documentation
Simon Will [Wed, 6 May 2020 22:36:13 +0000 (00:36 +0200)]
Integrate Ubuntu 20 instructions into documentation

4 years agoDocument minimum phpunit version
Simon Will [Wed, 6 May 2020 21:47:16 +0000 (23:47 +0200)]
Document minimum phpunit version

4 years agoInstall phpunit 8 on Ubuntu 18 with composer
Simon Will [Wed, 6 May 2020 21:46:53 +0000 (23:46 +0200)]
Install phpunit 8 on Ubuntu 18 with composer

4 years agoMerge pull request #1784 from krahulreddy/patch-1
Sarah Hoffmann [Wed, 6 May 2020 19:37:29 +0000 (21:37 +0200)]
Merge pull request #1784 from krahulreddy/patch-1

Removed redundant question

4 years agoRemoved redundant question
K Rahul Reddy [Wed, 6 May 2020 15:56:32 +0000 (21:26 +0530)]
Removed redundant question

4 years agoUse assertEqualsWithDelta for float comparisons
Simon Will [Tue, 5 May 2020 21:43:09 +0000 (23:43 +0200)]
Use assertEqualsWithDelta for float comparisons

PHPUnit 7.3 introduced the functions assertEqualsWithDelta for comparing
floats with a delta. The old four-argument version of assertEquals is
deprecated in PHPUnit 8 and removed in PHPUnit 9.

This commit means that the tests will fail with PHPUnit < 7.3 because
assertEqualsWithDelta is not defined there.

4 years agoDeclare return type of testcase setUp method
Simon Will [Tue, 5 May 2020 21:40:18 +0000 (23:40 +0200)]
Declare return type of testcase setUp method

PHPUnit 7 changed the signature of the TestCase methods to include the
return type.

4 years agoAdd vagrant machine for Ubuntu 20.04
Simon Will [Tue, 5 May 2020 21:10:35 +0000 (23:10 +0200)]
Add vagrant machine for Ubuntu 20.04

The instructions in
[`VAGRANT.md`](https://github.com/osm-search/Nominatim/blob/42c80893cb1038e21c05c2d0d30e3a7a20f0fa26/VAGRANT.md)
still work as before. The names of the Vagrant machines are updated so
that Ubuntu 18.04 (previously called `ubuntu`) is now called `ubuntu18`
and Ubuntu 20.04 is now called `ubuntu20`.

The version changes from Ubuntu 18.04 to Ubuntu 20.04 are:

  - Python: 3.6 to 3.8
  - Postgres: 10 to 12
  - PHP: 7.2 to 7.4

In the `apt-get`, I changed `--force` to `--allow-downgrades --allow-remove-essential --allow-change-held-packages`, because the former is deprecated. Cf. the [manpage of apt-get](http://manpages.ubuntu.com/manpages/focal/man8/apt-get.8.html)

The php module `codesniffer` was previously installed via Composer, but it is available via the Ubuntu repository, so I installed it via `apt-get` now.

4 years agodocs: add link to new status page
Sarah Hoffmann [Mon, 4 May 2020 19:11:57 +0000 (21:11 +0200)]
docs: add link to new status page

4 years agodocumenation for /status endpoint
marc tobias [Mon, 4 May 2020 15:06:06 +0000 (17:06 +0200)]
documenation for /status endpoint

4 years agoproperly escape class parameter
Sarah Hoffmann [Sat, 2 May 2020 19:54:14 +0000 (21:54 +0200)]
properly escape class parameter

The class parameter was used as is, allowing for potential
SQL injection via the API.

Thanks to @bladeswords for finding this.

4 years agoMerge pull request #1770 from lonvia/eyusupov-separate-compilation
Sarah Hoffmann [Sun, 26 Apr 2020 19:48:43 +0000 (21:48 +0200)]
Merge pull request #1770 from lonvia/eyusupov-separate-compilation

Separate compilation

4 years agoMerge pull request #1769 from lonvia/display-name-order
Sarah Hoffmann [Sun, 26 Apr 2020 14:18:56 +0000 (16:18 +0200)]
Merge pull request #1769 from lonvia/display-name-order

 Ensure that result object name is always first in display_name

4 years agocmake: reintroduce check script
Sarah Hoffmann [Sun, 26 Apr 2020 14:17:43 +0000 (16:17 +0200)]
cmake: reintroduce check script

4 years agofix docs typos
Sarah Hoffmann [Sun, 26 Apr 2020 13:00:28 +0000 (15:00 +0200)]
fix docs typos

4 years agocmake: restructure splitting between modules
Sarah Hoffmann [Sun, 26 Apr 2020 12:17:21 +0000 (14:17 +0200)]
cmake: restructure splitting between modules

Make a clear distinction between parts used for the importer
and parts used for the API.

4 years agoMerge branch 'separate-compilation' of https://github.com/eyusupov/Nominatim into...
Sarah Hoffmann [Sun, 26 Apr 2020 08:47:41 +0000 (10:47 +0200)]
Merge branch 'separate-compilation' of https://github.com/eyusupov/Nominatim into eyusupov-separate-compilation

4 years agoMerge pull request #1754 from mtmail/nominatim-db-tests-against-postgres
Sarah Hoffmann [Sun, 26 Apr 2020 08:20:30 +0000 (10:20 +0200)]
Merge pull request #1754 from mtmail/nominatim-db-tests-against-postgres

Nominatim::DB tests against separate postgresql database

4 years agolonvia PR feedback
marc tobias [Sun, 26 Apr 2020 01:33:15 +0000 (03:33 +0200)]
lonvia PR feedback

4 years agosimplify display_name computation
Sarah Hoffmann [Sat, 25 Apr 2020 22:18:29 +0000 (00:18 +0200)]
simplify display_name computation

4 years agoensure that result object name is always first in display_name
Sarah Hoffmann [Sat, 25 Apr 2020 22:14:55 +0000 (00:14 +0200)]
ensure that result object name is always first in display_name

The display name might be mixed up if the result object has a lower
rank_address than its address members.

4 years agoMerge pull request #1752 from mtmail/new-oo-shell-class
Sarah Hoffmann [Sat, 25 Apr 2020 14:48:04 +0000 (16:48 +0200)]
Merge pull request #1752 from mtmail/new-oo-shell-class

new PHP Nominatim\Shell class to wrap shell escaping

4 years agoMerge pull request #1758 from krahulreddy/advanced-installations
Sarah Hoffmann [Wed, 22 Apr 2020 07:59:44 +0000 (09:59 +0200)]
Merge pull request #1758 from krahulreddy/advanced-installations

Advanced installations

4 years agoMerge pull request #1764 from mtmail/docs-countrycodes-based-on-adminlevel-2
Sarah Hoffmann [Wed, 22 Apr 2020 07:57:59 +0000 (09:57 +0200)]
Merge pull request #1764 from mtmail/docs-countrycodes-based-on-adminlevel-2

API docs: countrycode assignment happens using admin_level=2 tags

4 years agohighway:construction should appear as 'road' in the address list
Sarah Hoffmann [Wed, 22 Apr 2020 07:08:33 +0000 (09:08 +0200)]
highway:construction should appear as 'road' in the address list

Fixes #1763.

4 years agoAPI documentation: clarification countrycode assignment happens using admin_level...
marc tobias [Tue, 21 Apr 2020 15:42:12 +0000 (17:42 +0200)]
API documentation: clarification countrycode assignment happens using admin_level=2 tags

4 years agonominatim.py: fix wrong use of assert
Sarah Hoffmann [Sun, 19 Apr 2020 15:59:49 +0000 (17:59 +0200)]
nominatim.py: fix wrong use of assert

Fixes #1762.

4 years agoFix documentation links (#1760)
K Rahul Reddy [Sat, 18 Apr 2020 22:42:24 +0000 (04:12 +0530)]
Fix documentation links (#1760)

Update installation documentation link in VAGRANT.md, update.php

4 years agoAdjustments made to documentation
K Rahul Reddy [Fri, 17 Apr 2020 09:54:37 +0000 (15:24 +0530)]
Adjustments made to documentation

4 years agoAdded Advanced Installations documentation
K Rahul Reddy [Wed, 15 Apr 2020 11:48:57 +0000 (17:18 +0530)]
Added Advanced Installations documentation

4 years agoAdded scripts for multiple country setup and updates
K Rahul Reddy [Wed, 15 Apr 2020 11:48:02 +0000 (17:18 +0530)]
Added scripts for multiple country setup and updates

4 years agoMerge pull request #1756 from lonvia/downgrade-waterways
Sarah Hoffmann [Fri, 17 Apr 2020 06:46:40 +0000 (08:46 +0200)]
Merge pull request #1756 from lonvia/downgrade-waterways

downgrade waterways

4 years agodowngrade waterways
Sarah Hoffmann [Tue, 14 Apr 2020 15:14:20 +0000 (17:14 +0200)]
downgrade waterways

A lot of streams in OSM are of minor importance, they certainly
should show up lower in the list of results than villages. Those
rivers/streams that are well known have a wikipedia page and get
a higher importance from that.

The disadvantage with downgrading is that the address gets even
more useless but that's something that needs to be solved outside
the rank search.

4 years agoMerge pull request #1753 from mtmail/fix-travis-ci-badge
Sarah Hoffmann [Mon, 13 Apr 2020 16:36:02 +0000 (18:36 +0200)]
Merge pull request #1753 from mtmail/fix-travis-ci-badge

fix Travis-CI badge in README output

4 years agoNominatim::DB tests against separate postgresql database
marc tobias [Mon, 13 Apr 2020 15:48:20 +0000 (17:48 +0200)]
Nominatim::DB tests against separate postgresql database

4 years agofix Travis-CI badge in README output
marc tobias [Mon, 13 Apr 2020 15:55:17 +0000 (17:55 +0200)]
fix Travis-CI badge in README output

4 years agofix logging of lookup calls
Sarah Hoffmann [Mon, 13 Apr 2020 09:53:44 +0000 (11:53 +0200)]
fix logging of lookup calls

Log start was called but the actual writing was missing.

4 years agonew PHP Nominatim\Shell class to wrap shell escaping
marc tobias [Tue, 18 Feb 2020 18:42:15 +0000 (19:42 +0100)]
new PHP Nominatim\Shell class to wrap shell escaping

4 years agoMerge pull request #1751 from lonvia/respect-admin-hierarchy
Sarah Hoffmann [Sat, 11 Apr 2020 21:41:19 +0000 (23:41 +0200)]
Merge pull request #1751 from lonvia/respect-admin-hierarchy

Address ranks must not invert admin_level hierarchy

4 years agoaddress ranks must not invert admin_level hierarchy
Sarah Hoffmann [Wed, 8 Apr 2020 08:04:49 +0000 (10:04 +0200)]
address ranks must not invert admin_level hierarchy

When inheriting an address rank from a linked place we
must be careful not to destroy the hierarchy established
through boundary admin_level. Therefore, before assigning
an address rank from a linked place, find the next higher
boundary in the admin_level hierarchy, look up its address
rank and then only use the address rank from the linked
place if it is higher.

4 years agoMerge branch 'update-jquery-leaflet' of https://github.com/mtmail/Nominatim into...
Sarah Hoffmann [Sat, 11 Apr 2020 18:53:14 +0000 (20:53 +0200)]
Merge branch 'update-jquery-leaflet' of https://github.com/mtmail/Nominatim into mtmail-update-jquery-leaflet

4 years agoMerge pull request #1749 from lonvia/ranking-during-updates
Sarah Hoffmann [Sat, 11 Apr 2020 18:52:05 +0000 (20:52 +0200)]
Merge pull request #1749 from lonvia/ranking-during-updates

Reset search and address ranks on update

4 years agowebsite dependencies: jQuery v2.1 => 3.5, leaflet 1.3 => 1.6
marc tobias [Sat, 11 Apr 2020 16:18:57 +0000 (18:18 +0200)]
website dependencies: jQuery v2.1 => 3.5, leaflet 1.3 => 1.6

4 years agoreset address and search ranks on update
Sarah Hoffmann [Sat, 11 Apr 2020 07:20:13 +0000 (09:20 +0200)]
reset address and search ranks on update

With ranks being dynamically changed through linking of places,
it is important to reset the ranks on update, so that changes
of the rank due to changes in linking are correctly taken into
account.

4 years agofactor out computation of address and search rank
Sarah Hoffmann [Fri, 10 Apr 2020 20:37:14 +0000 (22:37 +0200)]
factor out computation of address and search rank

4 years agomake admin levels 3 and 7 distinct ones in addresses
Sarah Hoffmann [Fri, 10 Apr 2020 20:56:55 +0000 (22:56 +0200)]
make admin levels 3 and 7 distinct ones in addresses

There really is no need to conflate these two levels as they
are in use in various countries.

Also adds province as a distinct place.

Fixes #1736.

4 years agoMerge pull request #1745 from lonvia/shuffle-sql-functions
Sarah Hoffmann [Fri, 10 Apr 2020 15:23:09 +0000 (17:23 +0200)]
Merge pull request #1745 from lonvia/shuffle-sql-functions

Some more SQL function reorganisation

4 years agoMerge branch 'deletable-and-polygons-as-json' of https://github.com/mtmail/Nominatim...
Sarah Hoffmann [Fri, 10 Apr 2020 15:20:51 +0000 (17:20 +0200)]
Merge branch 'deletable-and-polygons-as-json' of https://github.com/mtmail/Nominatim into mtmail-deletable-and-polygons-as-json

4 years agoAdd JSON output for /deletable.php and /polygons.php
marc tobias [Fri, 10 Apr 2020 01:21:52 +0000 (03:21 +0200)]
Add JSON output for /deletable.php and /polygons.php

4 years agomove ranks-related functions in separate sql file
Sarah Hoffmann [Fri, 10 Apr 2020 09:34:14 +0000 (11:34 +0200)]
move ranks-related functions in separate sql file

Also adds a common function for computing the update radius
around place nodes.

4 years agomove helper functions from placex_triggers into utils
Sarah Hoffmann [Fri, 10 Apr 2020 09:05:11 +0000 (11:05 +0200)]
move helper functions from placex_triggers into utils

Also adds documentation for these functions.

4 years agoMerge pull request #1742 from mtmail/travis-ci-add-os
Sarah Hoffmann [Fri, 10 Apr 2020 06:46:50 +0000 (08:46 +0200)]
Merge pull request #1742 from mtmail/travis-ci-add-os

Travis-Ci configuration: remove -sudo-, add -os-

4 years agotravis-ci configuration: remove -sudo-, add -os-
marc tobias [Thu, 9 Apr 2020 23:20:51 +0000 (01:20 +0200)]
travis-ci configuration: remove -sudo-, add -os-

4 years agoMerge pull request #1741 from filimongeorge/patch-1
Sarah Hoffmann [Thu, 9 Apr 2020 21:00:34 +0000 (23:00 +0200)]
Merge pull request #1741 from filimongeorge/patch-1

Updated Import and Update .md file

4 years agoMerge pull request #1740 from mtmail/setupclass-index-outputfile-not-used
Sarah Hoffmann [Thu, 9 Apr 2020 20:57:51 +0000 (22:57 +0200)]
Merge pull request #1740 from mtmail/setupclass-index-outputfile-not-used

SetupClass.php: remove unused variable

4 years agoMerge pull request #1739 from lonvia/remove-self-from-geojson
Sarah Hoffmann [Thu, 9 Apr 2020 20:51:20 +0000 (22:51 +0200)]
Merge pull request #1739 from lonvia/remove-self-from-geojson

Further tweaks to geocodejson output

4 years agoUpdated Import and Update .md file
filimongeorge [Thu, 9 Apr 2020 17:51:38 +0000 (20:51 +0300)]
Updated Import and Update .md file

4 years agoSetupClass.php: remove unused variable
marc tobias [Wed, 8 Apr 2020 12:16:06 +0000 (14:16 +0200)]
SetupClass.php: remove unused variable

4 years agoremove name from geocodejson when not set
Sarah Hoffmann [Wed, 8 Apr 2020 09:12:27 +0000 (11:12 +0200)]
remove name from geocodejson when not set

4 years agoadapt tests to geocodejson format adaptions
Sarah Hoffmann [Wed, 8 Apr 2020 09:11:53 +0000 (11:11 +0200)]
adapt tests to geocodejson format adaptions

4 years agofurther tweaks to geocodejson address output
Sarah Hoffmann [Wed, 8 Apr 2020 08:11:08 +0000 (10:11 +0200)]
further tweaks to geocodejson address output

Removes the place itself from the address details and use
the lowest ranking element in the rank range for the output.

4 years agoignore isaddress in details output when it is not present
Sarah Hoffmann [Wed, 8 Apr 2020 08:28:28 +0000 (10:28 +0200)]
ignore isaddress in details output when it is not present

4 years agoMerge pull request #1737 from mtmail/expose-isaddress-in-details-json
Sarah Hoffmann [Tue, 7 Apr 2020 18:49:31 +0000 (20:49 +0200)]
Merge pull request #1737 from mtmail/expose-isaddress-in-details-json

details JSON: also print isaddress addressline field

4 years agodetails JSON: also print isaddress addressline field
marc tobias [Tue, 7 Apr 2020 12:50:41 +0000 (14:50 +0200)]
details JSON: also print isaddress addressline field

4 years agoMerge pull request #1734 from krahulreddy/fixed-parselatlon
Sarah Hoffmann [Sun, 5 Apr 2020 21:25:50 +0000 (23:25 +0200)]
Merge pull request #1734 from krahulreddy/fixed-parselatlon

Added whitespace support for parseLatLon

4 years agoavoid deletes on search_name in reverse-only mode
Sarah Hoffmann [Sat, 4 Apr 2020 16:26:27 +0000 (18:26 +0200)]
avoid deletes on search_name in reverse-only mode

4 years agoAdded test cases for whitespaces in LatLon
Rahul [Fri, 3 Apr 2020 16:39:11 +0000 (22:09 +0530)]
Added test cases for whitespaces in LatLon

4 years agoAdded whitespace characters support in LatLon parsing
Rahul [Fri, 3 Apr 2020 16:14:27 +0000 (21:44 +0530)]
Added whitespace characters support in LatLon parsing

4 years agofix phpcs issues
Sarah Hoffmann [Fri, 3 Apr 2020 18:07:50 +0000 (20:07 +0200)]
fix phpcs issues

4 years agoMerge pull request #1733 from krahulreddy/whitespaces-considered-as-single-space
Sarah Hoffmann [Fri, 3 Apr 2020 16:01:47 +0000 (18:01 +0200)]
Merge pull request #1733 from krahulreddy/whitespaces-considered-as-single-space

Support whitespace characters(x09-x0d) as single space

4 years agoMerge pull request #1732 from lonvia/improve-geocodejson-output
Sarah Hoffmann [Thu, 2 Apr 2020 19:21:04 +0000 (21:21 +0200)]
Merge pull request #1732 from lonvia/improve-geocodejson-output

Improve geocodejson output

4 years agoSupport whitespace characters(x09-x0d) as single space
K Rahul Reddy [Wed, 1 Apr 2020 23:34:40 +0000 (05:04 +0530)]
Support whitespace characters(x09-x0d) as single space

4 years agore-add district to geocodejson
Sarah Hoffmann [Wed, 1 Apr 2020 19:24:42 +0000 (21:24 +0200)]
re-add district to geocodejson

4 years agoupdate documentation for geocodejson
Sarah Hoffmann [Wed, 1 Apr 2020 09:17:25 +0000 (11:17 +0200)]
update documentation for geocodejson

Address parts should be usable now.

4 years agoadd tests for geocodejson address fields
Sarah Hoffmann [Wed, 1 Apr 2020 09:14:48 +0000 (11:14 +0200)]
add tests for geocodejson address fields

4 years agodetermine geocodejson address by rank instead of type
Sarah Hoffmann [Wed, 1 Apr 2020 09:12:52 +0000 (11:12 +0200)]
determine geocodejson address by rank instead of type

Using the address rank to set the address parts catches
a much wider variety of types like 'town' and 'suburb'.
With recent address ranking changes the rank ranges
are relatively reliable.

4 years agofactor out geocodejson address generation
Sarah Hoffmann [Wed, 1 Apr 2020 08:27:17 +0000 (10:27 +0200)]
factor out geocodejson address generation

Unifies the two implementations currently used for search and address.

4 years agoMerge pull request #1731 from lonvia/remove-polygon-from-docs
Sarah Hoffmann [Wed, 1 Apr 2020 08:21:45 +0000 (10:21 +0200)]
Merge pull request #1731 from lonvia/remove-polygon-from-docs

docs: remove example with polygon parameter

4 years agodocs: remove example with polygon parameter
Sarah Hoffmann [Tue, 31 Mar 2020 18:10:03 +0000 (20:10 +0200)]
docs: remove example with polygon parameter

This parameter was undocumented, long deprecated and is gone now.

4 years agofix typo
Sarah Hoffmann [Tue, 31 Mar 2020 17:53:55 +0000 (19:53 +0200)]
fix typo

Fixes #1730

4 years agofix handling of postcode areas in addresses
Sarah Hoffmann [Mon, 30 Mar 2020 21:27:48 +0000 (23:27 +0200)]
fix handling of postcode areas in addresses

The order of preference is now:
1. a post code on the place itself
2. a post code area in the address
3. the computed postcode from the place

Fixes #1723.

4 years agoadapt tests to new borough ranking
Sarah Hoffmann [Mon, 30 Mar 2020 21:04:20 +0000 (23:04 +0200)]
adapt tests to new borough ranking

4 years agodowngrade borough and remove unincorporated area
Sarah Hoffmann [Mon, 30 Mar 2020 16:30:11 +0000 (18:30 +0200)]
downgrade borough and remove unincorporated area

4 years agoMerge pull request #1729 from lonvia/fix-details-link-for-boundaries
Sarah Hoffmann [Sun, 29 Mar 2020 21:12:16 +0000 (23:12 +0200)]
Merge pull request #1729 from lonvia/fix-details-link-for-boundaries

Fix details link for boundaries

4 years agoremove polygon=1 (polypoints) feature
marc tobias [Tue, 5 Mar 2019 17:14:25 +0000 (18:14 +0100)]
remove polygon=1 (polypoints) feature

4 years agoalso emit place_type in json version of details
Sarah Hoffmann [Sun, 29 Mar 2020 19:06:39 +0000 (21:06 +0200)]
also emit place_type in json version of details

4 years agorather use new place_type in getAddressNames()
Sarah Hoffmann [Sun, 29 Mar 2020 18:49:35 +0000 (20:49 +0200)]
rather use new place_type in getAddressNames()

If for a boundary the place_type is defined, handle the address
part like a place node. This is the same behaviour as before
when class/type where patched earlier.

4 years agoFix address link for boundaries in details
Sarah Hoffmann [Sun, 29 Mar 2020 15:40:56 +0000 (17:40 +0200)]
Fix address link for boundaries in details

Removes the special casing for boundaries with a place
type in get_addressdata(). Instead the place type is now
returned as an extra field, so that the caller has to
handle the situation.

This fixes the details link next to the address in the details
view, which previously would go to a place class instead of the
original boundary class.

4 years agoMerge pull request #1720 from lonvia/better-linking-of-places
Sarah Hoffmann [Fri, 27 Mar 2020 20:12:39 +0000 (21:12 +0100)]
Merge pull request #1720 from lonvia/better-linking-of-places

Use wikidata tags for improving linking of places with boundaries

4 years agoUpdated TIGER database link in documentation (#1725)
Aakankasha Sharma [Fri, 27 Mar 2020 14:50:05 +0000 (20:20 +0530)]
Updated TIGER database link in documentation (#1725)

Updated TIGER database link in documentation

4 years agoadapt API tests to place linkage changes
Sarah Hoffmann [Wed, 25 Mar 2020 10:38:31 +0000 (11:38 +0100)]
adapt API tests to place linkage changes

The missing district is due to a data error for wikidata tags.

4 years agouse wikidata tag for linking places
Sarah Hoffmann [Sat, 21 Mar 2020 21:43:28 +0000 (22:43 +0100)]
use wikidata tag for linking places

Having the same wikidata is a strong indicator that the same place
is meant. There are some assignment errors where the wikidata does
not link to the object itself but to something that mentions the
place. To reduce errors there, prefer same name.

4 years agoremove linking via admin_centre role
Sarah Hoffmann [Sat, 21 Mar 2020 20:59:11 +0000 (21:59 +0100)]
remove linking via admin_centre role

The admin_centre role is for the seat of government which is not
the same as the administrative entity. This is mostly used
correctly these days, so avoid matching by that role.