From 39e300640e4a027c68b3a989700c0fbc3fe325e8 Mon Sep 17 00:00:00 2001 From: Sarah Hoffmann Date: Tue, 25 Jan 2022 12:09:33 +0100 Subject: [PATCH] remove codecov Causes more trouble than doing good. --- .github/workflows/ci-tests.yml | 31 ++++--------------------------- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml index f326c3ca..01eb8232 100644 --- a/.github/workflows/ci-tests.yml +++ b/.github/workflows/ci-tests.yml @@ -64,7 +64,6 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php }} - coverage: xdebug tools: phpunit, phpcs, composer - uses: actions/setup-python@v2 @@ -82,11 +81,11 @@ jobs: ubuntu: ${{ matrix.ubuntu }} - name: Install test prerequsites - run: sudo apt-get install -y -qq pylint python3-pytest python3-behave python3-pytest-cov php-codecoverage + run: sudo apt-get install -y -qq pylint python3-pytest python3-behave if: matrix.ubuntu == 20 - name: Install test prerequsites - run: pip3 install pylint==2.6.0 pytest pytest-cov behave==1.2.6 + run: pip3 install pylint==2.6.0 pytest behave==1.2.6 if: matrix.ubuntu == 18 - name: PHP linting @@ -98,41 +97,19 @@ jobs: working-directory: Nominatim - name: PHP unit tests - run: phpunit --coverage-clover ../../coverage-php.xml ./ + run: phpunit ./ working-directory: Nominatim/test/php - if: matrix.ubuntu == 20 - name: Python unit tests - run: $PYTEST --cov=nominatim --cov-report=xml test/python + run: $PYTEST test/python working-directory: Nominatim env: PYTEST: ${{ matrix.pytest }} - - name: BDD tests - run: | - mkdir cov - behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build --format=progress3 -DPHPCOV=./cov - composer require phpunit/phpcov:7.0.2 - vendor/bin/phpcov merge --clover ../../coverage-bdd.xml ./cov - working-directory: Nominatim/test/bdd - if: matrix.ubuntu == 20 - - name: BDD tests run: | behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build --format=progress3 working-directory: Nominatim/test/bdd - if: matrix.ubuntu == 18 - - - name: Upload coverage to Codecov - uses: codecov/codecov-action@v1 - with: - files: ./Nominatim/coverage*.xml - directory: ./ - name: codecov-umbrella - fail_ci_if_error: false - path_to_write_report: ./coverage/codecov_report.txt - verbose: true - if: matrix.ubuntu == 20 icu-test: -- 2.39.5