From 87d78e87d2c527120e93bec09c85c5e36a76e9a1 Mon Sep 17 00:00:00 2001
From: Eric Stadtherr <estadtherr@caci.com>
Date: Tue, 24 Jul 2018 15:25:12 -0600
Subject: [PATCH] changed nominatim.so module path to be a runtime
 configuration setting as opposed to a command line argument

---
 settings/defaults.php | 1 +
 utils/setup.php       | 8 ++------
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/settings/defaults.php b/settings/defaults.php
index 2d8f47d0..8cdbcb5a 100644
--- a/settings/defaults.php
+++ b/settings/defaults.php
@@ -9,6 +9,7 @@ if (isset($_GET['debug']) && $_GET['debug']) @define('CONST_Debug', true);
 @define('CONST_Debug', false);
 @define('CONST_Database_DSN', 'pgsql://@/nominatim'); // <driver>://<username>:<password>@<host>:<port>/<database>
 @define('CONST_Database_Web_User', 'www-data');
+@define('CONST_Database_Module_Path', CONST_InstallPath.'/module');
 @define('CONST_Max_Word_Frequency', '50000');
 @define('CONST_Limit_Reindexing', true);
 // Restrict search languages.
diff --git a/utils/setup.php b/utils/setup.php
index 4d2ea802..95eda0f4 100755
--- a/utils/setup.php
+++ b/utils/setup.php
@@ -16,7 +16,6 @@ $aCMDOptions
 
    array('osm-file', '', 0, 1, 1, 1, 'realpath', 'File to import'),
    array('threads', '', 0, 1, 1, 1, 'int', 'Number of threads (where possible)'),
-   array('module-path', '', 0, 1, 1, 1, 'string', 'Directory on Postgres server containing Nominatim module'),
 
    array('all', '', 0, 1, 0, 0, 'bool', 'Do the complete process'),
 
@@ -80,11 +79,8 @@ if (isset($aCMDResult['osm2pgsql-cache'])) {
     $iCacheMemory = getCacheMemoryMB();
 }
 
-$sModulePath = CONST_InstallPath . '/module';
-if (isset($aCMDResult['module-path'])) {
-    $sModulePath = $aCMDResult['module-path'];
-    echo 'module path: ' . $sModulePath . '\n';
-}
+$sModulePath = CONST_Database_Module_Path;
+info('module path: ' . $sModulePath);
 
 $aDSNInfo = DB::parseDSN(CONST_Database_DSN);
 if (!isset($aDSNInfo['port']) || !$aDSNInfo['port']) $aDSNInfo['port'] = 5432;
-- 
2.39.5