From 89c576fbe16e90ce20766f61d07fc7576186ce2e Mon Sep 17 00:00:00 2001
From: Sarah Hoffmann <lonvia@denofr.de>
Date: Wed, 4 Oct 2017 00:05:34 +0200
Subject: [PATCH 1/1] tests: more coverage for all API endpoints

---
 lib/PlaceLookup.php                  | 11 -----------
 test/bdd/api/details/simple.feature  |  6 ++++++
 test/bdd/api/reverse/queries.feature |  9 +++++++++
 test/bdd/api/search/queries.feature  | 27 ++++++++++++++++++++++++++-
 4 files changed, 41 insertions(+), 12 deletions(-)

diff --git a/lib/PlaceLookup.php b/lib/PlaceLookup.php
index 40d003fa..4920a131 100644
--- a/lib/PlaceLookup.php
+++ b/lib/PlaceLookup.php
@@ -45,27 +45,16 @@ class PlaceLookup
         $this->bNameDetails = $bNameDetails;
     }
 
-
     public function setIncludePolygonAsPoints($b = true)
     {
         $this->bIncludePolygonAsPoints = $b;
     }
 
-    public function getIncludePolygonAsPoints()
-    {
-        return $this->bIncludePolygonAsPoints;
-    }
-
     public function setIncludePolygonAsText($b = true)
     {
         $this->bIncludePolygonAsText = $b;
     }
 
-    public function getIncludePolygonAsText()
-    {
-        return $this->bIncludePolygonAsText;
-    }
-
     public function setIncludePolygonAsGeoJSON($b = true)
     {
         $this->bIncludePolygonAsGeoJSON = $b;
diff --git a/test/bdd/api/details/simple.feature b/test/bdd/api/details/simple.feature
index 638e89ca..8971c5c2 100644
--- a/test/bdd/api/details/simple.feature
+++ b/test/bdd/api/details/simple.feature
@@ -12,3 +12,9 @@ Feature: Object details
      | N4267356889 |
      | W230804120 |
      | R123924 |
+
+    Scenario: Details with keywords
+        When sending details query for W78099902
+            | keywords |
+            | 1 |
+        Then the result is valid html
diff --git a/test/bdd/api/reverse/queries.feature b/test/bdd/api/reverse/queries.feature
index e1d089b9..b860823e 100644
--- a/test/bdd/api/reverse/queries.feature
+++ b/test/bdd/api/reverse/queries.feature
@@ -23,3 +23,12 @@ Feature: Reverse geocoding
         And result addresses contain
           | road            | postcode | country_code |
           | West 1st Street | 57274    | us |
+
+    Scenario: Interpolated house number
+        When sending jsonv2 reverse coordinates -33.231795578514635,-54.38682173844428
+        Then results contain
+          | osm_type | category | type |
+          | way      | place    | house |
+        And result addresses contain
+          | house_number | road |
+          | 1410         | Juan Antonio Lavalleja |
diff --git a/test/bdd/api/search/queries.feature b/test/bdd/api/search/queries.feature
index 2767f87c..5ef8f7ed 100644
--- a/test/bdd/api/search/queries.feature
+++ b/test/bdd/api/search/queries.feature
@@ -44,6 +44,17 @@ Feature: Search queries
           | country      | Deutschland |
           | country_code | de |
 
+    Scenario: With missing housenumber search falls back to road
+        When sending json search query "342 rocha, santa lucia" with address
+        Then address of result 0 is
+          | type         | value |
+          | road         | Rocha |
+          | city         | Santa Lucía |
+          | state        | Canelones |
+          | postcode     | 90700 |
+          | country      | Uruguay |
+          | country_code | uy |
+
     @Tiger
     Scenario: TIGER house number
         When sending json search query "323 22nd Street Southwest, Huron"
@@ -91,11 +102,25 @@ Feature: Search queries
           | amenity | restaurant |
 
     Scenario: Arbitrary key/value search near given coordinate
-        When sending json search query "[man_made=mast]  47.15739,9.61264"
+        When sending json search query "[man_made=mast]  47.15739° N 9.61264° E"
+        Then results contain
+          | class    | type |
+          | man_made | mast |
+
+    Scenario: Arbitrary key/value search near given coordinate and named place
+        When sending json search query "[man_made=mast] amerlugalpe  47° 9′ 26″ N 9° 36′ 45″ E"
         Then results contain
           | class    | type |
           | man_made | mast |
 
+    Scenario: Name search near given coordinate
+        When sending json search query "amerlugalpe, N 47.15739° E 9.61264°"
+        Then exactly 1 result is returned
+
+    Scenario: Name search near given coordinate without result
+        When sending json search query "amerlugalpe, N 47 15 7 W 9 61 26"
+        Then exactly 0 results are returned
+
     Scenario: Arbitrary key/value search near a road
         When sending json search query "[leisure=table_soccer_table] immenbusch"
         Then results contain
-- 
2.39.5