From db3ced17bbfff00411f506d8c84419c875959d5e Mon Sep 17 00:00:00 2001
From: Sarah Hoffmann <lonvia@denofr.de>
Date: Tue, 9 Feb 2021 11:52:07 +0100
Subject: [PATCH] rename lib to lib-php

---
 cmake/script.tmpl                                 | 4 ++--
 cmake/tool.tmpl                                   | 2 +-
 {lib => lib-php}/AddressDetails.php               | 0
 {lib => lib-php}/ClassTypes.php                   | 0
 {lib => lib-php}/DB.php                           | 0
 {lib => lib-php}/DatabaseError.php                | 0
 {lib => lib-php}/DebugHtml.php                    | 0
 {lib => lib-php}/DebugNone.php                    | 0
 {lib => lib-php}/Geocode.php                      | 0
 {lib => lib-php}/ParameterParser.php              | 0
 {lib => lib-php}/Phrase.php                       | 0
 {lib => lib-php}/PlaceLookup.php                  | 0
 {lib => lib-php}/Result.php                       | 0
 {lib => lib-php}/ReverseGeocode.php               | 0
 {lib => lib-php}/SearchContext.php                | 0
 {lib => lib-php}/SearchDescription.php            | 0
 {lib => lib-php}/Shell.php                        | 0
 {lib => lib-php}/SpecialSearchOperator.php        | 0
 {lib => lib-php}/Status.php                       | 0
 {lib => lib-php}/TokenCountry.php                 | 0
 {lib => lib-php}/TokenHousenumber.php             | 0
 {lib => lib-php}/TokenList.php                    | 0
 {lib => lib-php}/TokenPostcode.php                | 0
 {lib => lib-php}/TokenSpecialTerm.php             | 0
 {lib => lib-php}/TokenWord.php                    | 0
 {lib => lib-php}/admin/check_import_finished.php  | 0
 {lib => lib-php}/admin/country_languages.php      | 0
 {lib => lib-php}/admin/export.php                 | 0
 {lib => lib-php}/admin/query.php                  | 0
 {lib => lib-php}/admin/setup.php                  | 0
 {lib => lib-php}/admin/specialphrases.php         | 0
 {lib => lib-php}/admin/update.php                 | 0
 {lib => lib-php}/admin/warm.php                   | 0
 {lib => lib-php}/cmd.php                          | 0
 {lib => lib-php}/dotenv_loader.php                | 0
 {lib => lib-php}/init-cmd.php                     | 0
 {lib => lib-php}/init-website.php                 | 0
 {lib => lib-php}/init.php                         | 0
 {lib => lib-php}/lib.php                          | 0
 {lib => lib-php}/log.php                          | 0
 {lib => lib-php}/output.php                       | 0
 {lib => lib-php}/setup/SetupClass.php             | 0
 {lib => lib-php}/setup_functions.php              | 0
 {lib => lib-php}/template/address-geocodejson.php | 0
 {lib => lib-php}/template/address-geojson.php     | 0
 {lib => lib-php}/template/address-json.php        | 0
 {lib => lib-php}/template/address-xml.php         | 0
 {lib => lib-php}/template/details-json.php        | 0
 {lib => lib-php}/template/error-json.php          | 0
 {lib => lib-php}/template/error-xml.php           | 0
 {lib => lib-php}/template/search-batch-json.php   | 0
 {lib => lib-php}/template/search-geocodejson.php  | 0
 {lib => lib-php}/template/search-geojson.php      | 0
 {lib => lib-php}/template/search-json.php         | 0
 {lib => lib-php}/template/search-xml.php          | 0
 {lib => lib-php}/website/deletable.php            | 0
 {lib => lib-php}/website/details.php              | 0
 {lib => lib-php}/website/lookup.php               | 0
 {lib => lib-php}/website/polygons.php             | 0
 {lib => lib-php}/website/reverse.php              | 0
 {lib => lib-php}/website/search.php               | 0
 {lib => lib-php}/website/status.php               | 0
 test/bdd/steps/cgi-with-coverage.php              | 2 +-
 test/bdd/steps/nominatim_environment.py           | 2 +-
 test/bdd/steps/steps_api_queries.py               | 2 +-
 test/php/bootstrap.php                            | 2 +-
 test/php/phpunit.xml                              | 2 +-
 test/python/test_cli.py                           | 2 +-
 68 files changed, 9 insertions(+), 9 deletions(-)
 rename {lib => lib-php}/AddressDetails.php (100%)
 rename {lib => lib-php}/ClassTypes.php (100%)
 rename {lib => lib-php}/DB.php (100%)
 rename {lib => lib-php}/DatabaseError.php (100%)
 rename {lib => lib-php}/DebugHtml.php (100%)
 rename {lib => lib-php}/DebugNone.php (100%)
 rename {lib => lib-php}/Geocode.php (100%)
 rename {lib => lib-php}/ParameterParser.php (100%)
 rename {lib => lib-php}/Phrase.php (100%)
 rename {lib => lib-php}/PlaceLookup.php (100%)
 rename {lib => lib-php}/Result.php (100%)
 rename {lib => lib-php}/ReverseGeocode.php (100%)
 rename {lib => lib-php}/SearchContext.php (100%)
 rename {lib => lib-php}/SearchDescription.php (100%)
 rename {lib => lib-php}/Shell.php (100%)
 rename {lib => lib-php}/SpecialSearchOperator.php (100%)
 rename {lib => lib-php}/Status.php (100%)
 rename {lib => lib-php}/TokenCountry.php (100%)
 rename {lib => lib-php}/TokenHousenumber.php (100%)
 rename {lib => lib-php}/TokenList.php (100%)
 rename {lib => lib-php}/TokenPostcode.php (100%)
 rename {lib => lib-php}/TokenSpecialTerm.php (100%)
 rename {lib => lib-php}/TokenWord.php (100%)
 rename {lib => lib-php}/admin/check_import_finished.php (100%)
 rename {lib => lib-php}/admin/country_languages.php (100%)
 rename {lib => lib-php}/admin/export.php (100%)
 rename {lib => lib-php}/admin/query.php (100%)
 rename {lib => lib-php}/admin/setup.php (100%)
 rename {lib => lib-php}/admin/specialphrases.php (100%)
 rename {lib => lib-php}/admin/update.php (100%)
 rename {lib => lib-php}/admin/warm.php (100%)
 rename {lib => lib-php}/cmd.php (100%)
 rename {lib => lib-php}/dotenv_loader.php (100%)
 rename {lib => lib-php}/init-cmd.php (100%)
 rename {lib => lib-php}/init-website.php (100%)
 rename {lib => lib-php}/init.php (100%)
 rename {lib => lib-php}/lib.php (100%)
 rename {lib => lib-php}/log.php (100%)
 rename {lib => lib-php}/output.php (100%)
 rename {lib => lib-php}/setup/SetupClass.php (100%)
 rename {lib => lib-php}/setup_functions.php (100%)
 rename {lib => lib-php}/template/address-geocodejson.php (100%)
 rename {lib => lib-php}/template/address-geojson.php (100%)
 rename {lib => lib-php}/template/address-json.php (100%)
 rename {lib => lib-php}/template/address-xml.php (100%)
 rename {lib => lib-php}/template/details-json.php (100%)
 rename {lib => lib-php}/template/error-json.php (100%)
 rename {lib => lib-php}/template/error-xml.php (100%)
 rename {lib => lib-php}/template/search-batch-json.php (100%)
 rename {lib => lib-php}/template/search-geocodejson.php (100%)
 rename {lib => lib-php}/template/search-geojson.php (100%)
 rename {lib => lib-php}/template/search-json.php (100%)
 rename {lib => lib-php}/template/search-xml.php (100%)
 rename {lib => lib-php}/website/deletable.php (100%)
 rename {lib => lib-php}/website/details.php (100%)
 rename {lib => lib-php}/website/lookup.php (100%)
 rename {lib => lib-php}/website/polygons.php (100%)
 rename {lib => lib-php}/website/reverse.php (100%)
 rename {lib => lib-php}/website/search.php (100%)
 rename {lib => lib-php}/website/status.php (100%)

diff --git a/cmake/script.tmpl b/cmake/script.tmpl
index aa25a124..5fdfe542 100755
--- a/cmake/script.tmpl
+++ b/cmake/script.tmpl
@@ -1,6 +1,6 @@
 #!@PHP_BIN@ -Cq
 <?php
-require('@CMAKE_SOURCE_DIR@/lib/dotenv_loader.php');
+require('@CMAKE_SOURCE_DIR@/lib-php/dotenv_loader.php');
 
 @define('CONST_Default_ModulePath', '@CMAKE_BINARY_DIR@/module');
 @define('CONST_Default_Osm2pgsql', '@CMAKE_BINARY_DIR@/osm2pgsql/osm2pgsql');
@@ -10,4 +10,4 @@ require('@CMAKE_SOURCE_DIR@/lib/dotenv_loader.php');
 loadDotEnv();
 $_SERVER['NOMINATIM_NOMINATIM_TOOL'] = '@CMAKE_BINARY_DIR@/nominatim';
 
-require_once('@CMAKE_SOURCE_DIR@/lib/admin/@script_source@');
+require_once('@CMAKE_SOURCE_DIR@/lib-php/admin/@script_source@');
diff --git a/cmake/tool.tmpl b/cmake/tool.tmpl
index c73249b1..67d57ad7 100755
--- a/cmake/tool.tmpl
+++ b/cmake/tool.tmpl
@@ -10,6 +10,6 @@ from nominatim import cli
 
 exit(cli.nominatim(module_dir='@CMAKE_BINARY_DIR@/module',
                    osm2pgsql_path='@CMAKE_BINARY_DIR@/osm2pgsql/osm2pgsql',
-                   phplib_dir='@CMAKE_SOURCE_DIR@/lib',
+                   phplib_dir='@CMAKE_SOURCE_DIR@/lib-php',
                    data_dir='@CMAKE_SOURCE_DIR@',
                    phpcgi_path='@PHPCGI_BIN@'))
diff --git a/lib/AddressDetails.php b/lib-php/AddressDetails.php
similarity index 100%
rename from lib/AddressDetails.php
rename to lib-php/AddressDetails.php
diff --git a/lib/ClassTypes.php b/lib-php/ClassTypes.php
similarity index 100%
rename from lib/ClassTypes.php
rename to lib-php/ClassTypes.php
diff --git a/lib/DB.php b/lib-php/DB.php
similarity index 100%
rename from lib/DB.php
rename to lib-php/DB.php
diff --git a/lib/DatabaseError.php b/lib-php/DatabaseError.php
similarity index 100%
rename from lib/DatabaseError.php
rename to lib-php/DatabaseError.php
diff --git a/lib/DebugHtml.php b/lib-php/DebugHtml.php
similarity index 100%
rename from lib/DebugHtml.php
rename to lib-php/DebugHtml.php
diff --git a/lib/DebugNone.php b/lib-php/DebugNone.php
similarity index 100%
rename from lib/DebugNone.php
rename to lib-php/DebugNone.php
diff --git a/lib/Geocode.php b/lib-php/Geocode.php
similarity index 100%
rename from lib/Geocode.php
rename to lib-php/Geocode.php
diff --git a/lib/ParameterParser.php b/lib-php/ParameterParser.php
similarity index 100%
rename from lib/ParameterParser.php
rename to lib-php/ParameterParser.php
diff --git a/lib/Phrase.php b/lib-php/Phrase.php
similarity index 100%
rename from lib/Phrase.php
rename to lib-php/Phrase.php
diff --git a/lib/PlaceLookup.php b/lib-php/PlaceLookup.php
similarity index 100%
rename from lib/PlaceLookup.php
rename to lib-php/PlaceLookup.php
diff --git a/lib/Result.php b/lib-php/Result.php
similarity index 100%
rename from lib/Result.php
rename to lib-php/Result.php
diff --git a/lib/ReverseGeocode.php b/lib-php/ReverseGeocode.php
similarity index 100%
rename from lib/ReverseGeocode.php
rename to lib-php/ReverseGeocode.php
diff --git a/lib/SearchContext.php b/lib-php/SearchContext.php
similarity index 100%
rename from lib/SearchContext.php
rename to lib-php/SearchContext.php
diff --git a/lib/SearchDescription.php b/lib-php/SearchDescription.php
similarity index 100%
rename from lib/SearchDescription.php
rename to lib-php/SearchDescription.php
diff --git a/lib/Shell.php b/lib-php/Shell.php
similarity index 100%
rename from lib/Shell.php
rename to lib-php/Shell.php
diff --git a/lib/SpecialSearchOperator.php b/lib-php/SpecialSearchOperator.php
similarity index 100%
rename from lib/SpecialSearchOperator.php
rename to lib-php/SpecialSearchOperator.php
diff --git a/lib/Status.php b/lib-php/Status.php
similarity index 100%
rename from lib/Status.php
rename to lib-php/Status.php
diff --git a/lib/TokenCountry.php b/lib-php/TokenCountry.php
similarity index 100%
rename from lib/TokenCountry.php
rename to lib-php/TokenCountry.php
diff --git a/lib/TokenHousenumber.php b/lib-php/TokenHousenumber.php
similarity index 100%
rename from lib/TokenHousenumber.php
rename to lib-php/TokenHousenumber.php
diff --git a/lib/TokenList.php b/lib-php/TokenList.php
similarity index 100%
rename from lib/TokenList.php
rename to lib-php/TokenList.php
diff --git a/lib/TokenPostcode.php b/lib-php/TokenPostcode.php
similarity index 100%
rename from lib/TokenPostcode.php
rename to lib-php/TokenPostcode.php
diff --git a/lib/TokenSpecialTerm.php b/lib-php/TokenSpecialTerm.php
similarity index 100%
rename from lib/TokenSpecialTerm.php
rename to lib-php/TokenSpecialTerm.php
diff --git a/lib/TokenWord.php b/lib-php/TokenWord.php
similarity index 100%
rename from lib/TokenWord.php
rename to lib-php/TokenWord.php
diff --git a/lib/admin/check_import_finished.php b/lib-php/admin/check_import_finished.php
similarity index 100%
rename from lib/admin/check_import_finished.php
rename to lib-php/admin/check_import_finished.php
diff --git a/lib/admin/country_languages.php b/lib-php/admin/country_languages.php
similarity index 100%
rename from lib/admin/country_languages.php
rename to lib-php/admin/country_languages.php
diff --git a/lib/admin/export.php b/lib-php/admin/export.php
similarity index 100%
rename from lib/admin/export.php
rename to lib-php/admin/export.php
diff --git a/lib/admin/query.php b/lib-php/admin/query.php
similarity index 100%
rename from lib/admin/query.php
rename to lib-php/admin/query.php
diff --git a/lib/admin/setup.php b/lib-php/admin/setup.php
similarity index 100%
rename from lib/admin/setup.php
rename to lib-php/admin/setup.php
diff --git a/lib/admin/specialphrases.php b/lib-php/admin/specialphrases.php
similarity index 100%
rename from lib/admin/specialphrases.php
rename to lib-php/admin/specialphrases.php
diff --git a/lib/admin/update.php b/lib-php/admin/update.php
similarity index 100%
rename from lib/admin/update.php
rename to lib-php/admin/update.php
diff --git a/lib/admin/warm.php b/lib-php/admin/warm.php
similarity index 100%
rename from lib/admin/warm.php
rename to lib-php/admin/warm.php
diff --git a/lib/cmd.php b/lib-php/cmd.php
similarity index 100%
rename from lib/cmd.php
rename to lib-php/cmd.php
diff --git a/lib/dotenv_loader.php b/lib-php/dotenv_loader.php
similarity index 100%
rename from lib/dotenv_loader.php
rename to lib-php/dotenv_loader.php
diff --git a/lib/init-cmd.php b/lib-php/init-cmd.php
similarity index 100%
rename from lib/init-cmd.php
rename to lib-php/init-cmd.php
diff --git a/lib/init-website.php b/lib-php/init-website.php
similarity index 100%
rename from lib/init-website.php
rename to lib-php/init-website.php
diff --git a/lib/init.php b/lib-php/init.php
similarity index 100%
rename from lib/init.php
rename to lib-php/init.php
diff --git a/lib/lib.php b/lib-php/lib.php
similarity index 100%
rename from lib/lib.php
rename to lib-php/lib.php
diff --git a/lib/log.php b/lib-php/log.php
similarity index 100%
rename from lib/log.php
rename to lib-php/log.php
diff --git a/lib/output.php b/lib-php/output.php
similarity index 100%
rename from lib/output.php
rename to lib-php/output.php
diff --git a/lib/setup/SetupClass.php b/lib-php/setup/SetupClass.php
similarity index 100%
rename from lib/setup/SetupClass.php
rename to lib-php/setup/SetupClass.php
diff --git a/lib/setup_functions.php b/lib-php/setup_functions.php
similarity index 100%
rename from lib/setup_functions.php
rename to lib-php/setup_functions.php
diff --git a/lib/template/address-geocodejson.php b/lib-php/template/address-geocodejson.php
similarity index 100%
rename from lib/template/address-geocodejson.php
rename to lib-php/template/address-geocodejson.php
diff --git a/lib/template/address-geojson.php b/lib-php/template/address-geojson.php
similarity index 100%
rename from lib/template/address-geojson.php
rename to lib-php/template/address-geojson.php
diff --git a/lib/template/address-json.php b/lib-php/template/address-json.php
similarity index 100%
rename from lib/template/address-json.php
rename to lib-php/template/address-json.php
diff --git a/lib/template/address-xml.php b/lib-php/template/address-xml.php
similarity index 100%
rename from lib/template/address-xml.php
rename to lib-php/template/address-xml.php
diff --git a/lib/template/details-json.php b/lib-php/template/details-json.php
similarity index 100%
rename from lib/template/details-json.php
rename to lib-php/template/details-json.php
diff --git a/lib/template/error-json.php b/lib-php/template/error-json.php
similarity index 100%
rename from lib/template/error-json.php
rename to lib-php/template/error-json.php
diff --git a/lib/template/error-xml.php b/lib-php/template/error-xml.php
similarity index 100%
rename from lib/template/error-xml.php
rename to lib-php/template/error-xml.php
diff --git a/lib/template/search-batch-json.php b/lib-php/template/search-batch-json.php
similarity index 100%
rename from lib/template/search-batch-json.php
rename to lib-php/template/search-batch-json.php
diff --git a/lib/template/search-geocodejson.php b/lib-php/template/search-geocodejson.php
similarity index 100%
rename from lib/template/search-geocodejson.php
rename to lib-php/template/search-geocodejson.php
diff --git a/lib/template/search-geojson.php b/lib-php/template/search-geojson.php
similarity index 100%
rename from lib/template/search-geojson.php
rename to lib-php/template/search-geojson.php
diff --git a/lib/template/search-json.php b/lib-php/template/search-json.php
similarity index 100%
rename from lib/template/search-json.php
rename to lib-php/template/search-json.php
diff --git a/lib/template/search-xml.php b/lib-php/template/search-xml.php
similarity index 100%
rename from lib/template/search-xml.php
rename to lib-php/template/search-xml.php
diff --git a/lib/website/deletable.php b/lib-php/website/deletable.php
similarity index 100%
rename from lib/website/deletable.php
rename to lib-php/website/deletable.php
diff --git a/lib/website/details.php b/lib-php/website/details.php
similarity index 100%
rename from lib/website/details.php
rename to lib-php/website/details.php
diff --git a/lib/website/lookup.php b/lib-php/website/lookup.php
similarity index 100%
rename from lib/website/lookup.php
rename to lib-php/website/lookup.php
diff --git a/lib/website/polygons.php b/lib-php/website/polygons.php
similarity index 100%
rename from lib/website/polygons.php
rename to lib-php/website/polygons.php
diff --git a/lib/website/reverse.php b/lib-php/website/reverse.php
similarity index 100%
rename from lib/website/reverse.php
rename to lib-php/website/reverse.php
diff --git a/lib/website/search.php b/lib-php/website/search.php
similarity index 100%
rename from lib/website/search.php
rename to lib-php/website/search.php
diff --git a/lib/website/status.php b/lib-php/website/status.php
similarity index 100%
rename from lib/website/status.php
rename to lib-php/website/status.php
diff --git a/test/bdd/steps/cgi-with-coverage.php b/test/bdd/steps/cgi-with-coverage.php
index 80f898a3..6f0d79bb 100644
--- a/test/bdd/steps/cgi-with-coverage.php
+++ b/test/bdd/steps/cgi-with-coverage.php
@@ -10,7 +10,7 @@ function coverage_shutdown($oCoverage)
 }
 
 $covfilter = new SebastianBergmann\CodeCoverage\Filter();
-$covfilter->addDirectoryToWhitelist($_SERVER['COV_PHP_DIR'].'/lib');
+$covfilter->addDirectoryToWhitelist($_SERVER['COV_PHP_DIR'].'/lib-php');
 $covfilter->addDirectoryToWhitelist($_SERVER['COV_PHP_DIR'].'/website');
 $coverage = new SebastianBergmann\CodeCoverage\CodeCoverage(null, $covfilter);
 $coverage->start($_SERVER['COV_TEST_NAME']);
diff --git a/test/bdd/steps/nominatim_environment.py b/test/bdd/steps/nominatim_environment.py
index 0ee92137..892d21e9 100644
--- a/test/bdd/steps/nominatim_environment.py
+++ b/test/bdd/steps/nominatim_environment.py
@@ -262,7 +262,7 @@ class NominatimEnvironment:
         """ Run one of the Nominatim utility scripts with the given arguments.
         """
         cmd = ['/usr/bin/env', 'php', '-Cq']
-        cmd.append((Path(self.src_dir) / 'lib' / 'admin' / '{}.php'.format(script)).resolve())
+        cmd.append((Path(self.src_dir) / 'lib-php' / 'admin' / '{}.php'.format(script)).resolve())
         cmd.extend(['--' + x for x in args])
         for k, v in kwargs.items():
             cmd.extend(('--' + k.replace('_', '-'), str(v)))
diff --git a/test/bdd/steps/steps_api_queries.py b/test/bdd/steps/steps_api_queries.py
index ad4a8515..1b3da08b 100644
--- a/test/bdd/steps/steps_api_queries.py
+++ b/test/bdd/steps/steps_api_queries.py
@@ -60,7 +60,7 @@ def query_cmd(context, query, dups):
     """ Query directly via PHP script.
     """
     cmd = ['/usr/bin/env', 'php']
-    cmd.append(context.nominatim.src_dir  / 'lib' / 'admin' / 'query.php')
+    cmd.append(context.nominatim.src_dir  / 'lib-php' / 'admin' / 'query.php')
     if query:
         cmd.extend(['--search', query])
     # add more parameters in table form
diff --git a/test/php/bootstrap.php b/test/php/bootstrap.php
index 3a36db38..bfdbbf05 100644
--- a/test/php/bootstrap.php
+++ b/test/php/bootstrap.php
@@ -1,5 +1,5 @@
 <?php
-    @define('CONST_LibDir', '../../lib');
+    @define('CONST_LibDir', '../../lib-php');
     @define('CONST_DataDir', '../..');
 
     @define('CONST_Debug', true);
diff --git a/test/php/phpunit.xml b/test/php/phpunit.xml
index 8764d49e..79341a00 100644
--- a/test/php/phpunit.xml
+++ b/test/php/phpunit.xml
@@ -19,7 +19,7 @@
     </testsuites>
     <filter>
         <whitelist>
-            <directory>../../lib/</directory>
+            <directory>../../lib-php/</directory>
         </whitelist>
     </filter>
 
diff --git a/test/python/test_cli.py b/test/python/test_cli.py
index f62bccf7..334a9e78 100644
--- a/test/python/test_cli.py
+++ b/test/python/test_cli.py
@@ -23,7 +23,7 @@ from nominatim.db import status
 def call_nominatim(*args):
     return nominatim.cli.nominatim(module_dir='build/module',
                                    osm2pgsql_path='build/osm2pgsql/osm2pgsql',
-                                   phplib_dir='lib',
+                                   phplib_dir='lib-php',
                                    data_dir='.',
                                    phpcgi_path='/usr/bin/php-cgi',
                                    cli_args=args)
-- 
2.39.5