resolves an issue with tags used count that can get out of control if called from...

[osqa.git] / forum / models / tag.py

diff --git a/forum/models/tag.py b/forum/models/tag.py
index 2a3609a9636d6f4cd6fdbe2f7461620a5162ef48..791636fa0a9810f2dee4c935d8bc5304d64d9bf0 100644 (file)
--- a/forum/models/tag.py
+++ b/forum/models/tag.py
@@ -1,36 +1,18 @@
 import datetime
 from base import *
 
-from forum.modules import MODULES_PACKAGE
-
+from django.conf import settings as django_settings
+from django.core.cache.backends.base import BaseCache
 from django.utils.translation import ugettext as _
-import django.dispatch
-
-class ActiveTagManager(models.Manager):
-    def get_query_set(self):
-        qs = super(ActiveTagManager, self).get_query_set().exclude(used_count__lt=1)
-
-        CurrentUserHolder = None
+from django.utils.encoding import smart_unicode, force_unicode
 
-        moderation_import = 'from %s.moderation.startup import CurrentUserHolder' % MODULES_PACKAGE
-        exec moderation_import
+from forum import modules
 
-        if CurrentUserHolder is not None:
-            user = CurrentUserHolder.user
+class ActiveTagManager(CachedManager):
+    use_for_related_fields = True
 
-            try:
-                filter_content = not user.is_staff and not user.is_superuser
-            except:
-                filter_content = True
-
-            if filter_content:
-                moderation_import = 'from %s.moderation.hooks import get_tag_ids' % MODULES_PACKAGE
-                exec moderation_import
-                qs = qs.exclude(id__in=get_tag_ids('deleted')).exclude(id__in=get_tag_ids('rejected')).exclude(
-                    id__in=get_tag_ids('in_moderation')
-                )
-
-        return qs
+    def get_query_set(self):
+        return super(ActiveTagManager, self).get_query_set().exclude(used_count__lt=1)
 
 class Tag(BaseModel):
     name            = models.CharField(max_length=255, unique=True)
@@ -41,20 +23,44 @@ class Tag(BaseModel):
     used_count = models.PositiveIntegerField(default=0)
 
     active = ActiveTagManager()
-    objects = ActiveTagManager()
 
     class Meta:
         ordering = ('-used_count', 'name')
         app_label = 'forum'
 
     def __unicode__(self):
-        return u'%s' % self.name
+        return force_unicode(self.name)
 
     def add_to_usage_count(self, value):
-        if self.used_count + value < 0:
+        if int(self.used_count + value) < 0:
             self.used_count = 0
         else:
-            self.used_count = models.F('used_count') + value
+            self.used_count += value
+
+        self.save()
+
+    def cache_key(self):
+        return self._generate_cache_key(Tag.safe_cache_name(self.name))
+
+    @classmethod
+    def safe_cache_name(cls, name):
+        return "".join([str(ord(c)) for c in name])
+
+    @classmethod
+    def infer_cache_key(cls, querydict):
+        if 'name' in querydict:
+            cache_key = cls._generate_cache_key(cls.safe_cache_name(querydict['name']))
+
+            if len(cache_key) > django_settings.CACHE_MAX_KEY_LENGTH:
+                cache_key = cache_key[:django_settings.CACHE_MAX_KEY_LENGTH]
+
+            return cache_key
+
+        return None
+
+    @classmethod
+    def value_to_list_on_cache_query(cls):
+        return 'name'
 
     @models.permalink
     def get_absolute_url(self):