do not use the JavaScript SDK for Facebook authentication, use the server side flow...

[osqa.git] / forum_modules / facebookauth / authentication.py

diff --git a/forum_modules/facebookauth/authentication.py b/forum_modules/facebookauth/authentication.py
index 308c18cf45afbca502154e17b43105a2b202e765..55cf16d88b4d986de0169b96b0be8d4a861fa2a4 100644 (file)
--- a/forum_modules/facebookauth/authentication.py
+++ b/forum_modules/facebookauth/authentication.py
@@ -1,17 +1,20 @@
-import hashlib
-from time import time
-from datetime import datetime
+# -*- coding: utf-8 -*-
+
+import cgi
+import logging
+

 from urllib import urlopen,  urlencode
 from urllib import urlopen,  urlencode

-from urlparse import parse_qs

 from forum.authentication.base import AuthenticationConsumer, ConsumerTemplateContext, InvalidAuthentication
 from forum.authentication.base import AuthenticationConsumer, ConsumerTemplateContext, InvalidAuthentication

-from django.utils.translation import ugettext as _
+
+from django.conf import settings as django_settings

 from django.utils.encoding import smart_unicode
 from django.utils.encoding import smart_unicode

+from django.utils.translation import ugettext as _

 
 import settings
 
 try:
     from json import load as load_json
 
 import settings
 
 try:
     from json import load as load_json

-except:
+except Exception:

     from django.utils.simplejson import JSONDecoder
 
     def load_json(json):
     from django.utils.simplejson import JSONDecoder
 
     def load_json(json):


@@ -19,38 +22,55 @@ except:
         return decoder.decode(json.read())
 
 class FacebookAuthConsumer(AuthenticationConsumer):
         return decoder.decode(json.read())
 
 class FacebookAuthConsumer(AuthenticationConsumer):

+
+    def prepare_authentication_request(self, request, redirect_to):
+        args = dict(
+            client_id=settings.FB_API_KEY,
+            redirect_uri="%s%s" % (django_settings.APP_URL, redirect_to),
+            scope="email"
+        )
+
+        facebook_api_authentication_url = "https://graph.facebook.com/oauth/authorize?" + urlencode(args)
+
+        return facebook_api_authentication_url

     
     def process_authentication_request(self, request):
     
     def process_authentication_request(self, request):

-        API_KEY = str(settings.FB_API_KEY)
-
-        # Check if the Facebook cookie has been received.
-        if 'fbs_%s' % API_KEY in request.COOKIES:
-            fbs_cookie = request.COOKIES['fbs_%s' % API_KEY]
-            parsed_fbs = parse_qs(smart_unicode(fbs_cookie))
-            self.parsed_fbs = parsed_fbs
-
-            # Check if the session hasn't expired.
-            if self.check_session_expiry(request.COOKIES):
-                return parsed_fbs['uid'][0]
-            else:
-                raise InvalidAuthentication(_('Sorry, your Facebook session has expired, please try again'))
-        else:
-            raise InvalidAuthentication(_('The authentication with Facebook connect failed, cannot find authentication tokens'))
-    def check_session_expiry(self, cookies):
-        return datetime.fromtimestamp(float(self.parsed_fbs['expires'][0])) > datetime.now()
-
-    def get_user_data(self, cookies):
-        API_KEY = str(settings.FB_API_KEY)
-        fbs_cookie = cookies['fbs_%s' % API_KEY]
-        parsed_fbs = parse_qs(smart_unicode(fbs_cookie))
-
-        # Communicate with the access token to the Facebook oauth interface.
-        json = load_json(urlopen('https://graph.facebook.com/me?access_token=%s' % parsed_fbs['access_token'][0]))
+        try:
+            args = dict(client_id=settings.FB_API_KEY, redirect_uri="%s%s" % (django_settings.APP_URL, request.path))
+
+            args["client_secret"] = settings.FB_APP_SECRET  #facebook APP Secret
+
+            args["code"] = request.GET.get("code", None)
+            response = cgi.parse_qs(urlopen("https://graph.facebook.com/oauth/access_token?" + urlencode(args)).read())
+            access_token = response["access_token"][-1]
+
+            # Store the access token in cookie
+            request.session["assoc_key"] = access_token
+
+            return access_token
+        except Exception, e:
+            logging.error("Problem during facebook authentication: %s" % e)
+            raise InvalidAuthentication(_("Something wrond happened during Facebook authentication, administrators will be notified"))
+
+    def get_user_data(self, assoc_key):
+        profile = load_json(urlopen("https://graph.facebook.com/me?" + urlencode(dict(access_token=assoc_key))))
+
+        name = profile["name"]
+
+        # Check whether the length if the email is greater than 75, if it is -- just replace the email
+        # with a blank string variable, otherwise we're going to have trouble with the Django model.
+        email = smart_unicode(profile['email'])
+        if len(email) > 75:
+            email = ''
+
+        # If the name is longer than 30 characters - leave it blank
+        if len(name) > 30:
+            name = ''

 
         # Return the user data.
         return {
 
         # Return the user data.
         return {

-            'username': '%s %s' % (smart_unicode(json['first_name']), smart_unicode(json['last_name'])),
-            'email': smart_unicode(json['email']),
+            'username': name,
+            'email': email,

         }
 
 class FacebookAuthContext(ConsumerTemplateContext):
         }
 
 class FacebookAuthContext(ConsumerTemplateContext):


@@ -59,6 +79,6 @@ class FacebookAuthContext(ConsumerTemplateContext):
     weight = 100
     human_name = 'Facebook'
     code_template = 'modules/facebookauth/button.html'
     weight = 100
     human_name = 'Facebook'
     code_template = 'modules/facebookauth/button.html'

-    extra_css = ["http://www.facebook.com/css/connect/connect_button.css"]
+    extra_css = []

 
 

-    API_KEY = settings.FB_API_KEY
\ No newline at end of file
+    API_KEY = settings.FB_API_KEY