Jira OSQA-456, avoid using nested loops, use the 'in' operator in the template instead.

[osqa.git] / forum / models / question.py

diff --git a/forum/models/question.py b/forum/models/question.py
index 54840166d1d9c51534de77884296f670622bb0cf..136d3de78590cc3d2fbba2604ef09e412489b63b 100644 (file)
--- a/forum/models/question.py
+++ b/forum/models/question.py
@@ -2,20 +2,24 @@ from base import *
 from tag import Tag
 from django.utils.translation import ugettext as _
 
 from tag import Tag
 from django.utils.translation import ugettext as _
 

-question_view = django.dispatch.Signal(providing_args=['instance', 'user'])
+class QuestionManager(NodeManager):
+    def search(self, keywords):
+        return False, self.filter(models.Q(title__icontains=keywords) | models.Q(body__icontains=keywords))

 
 class Question(Node):
     class Meta(Node.Meta):
         proxy = True
 
 
 class Question(Node):
     class Meta(Node.Meta):
         proxy = True
 

-    answer_count = DenormalizedField("children", node_type="answer", deleted=None)
+    answer_count = DenormalizedField("children", ~models.Q(state_string__contains="(deleted)"), node_type="answer")
+    accepted_count = DenormalizedField("children", ~models.Q(state_string__contains="(deleted)"), node_type="answer", marked=True)

     favorite_count = DenormalizedField("actions", action_type="favorite", canceled=False)
 
     friendly_name = _("question")
     favorite_count = DenormalizedField("actions", action_type="favorite", canceled=False)
 
     friendly_name = _("question")

+    objects = QuestionManager()

 
 

-    @property   
+    @property

     def closed(self):
     def closed(self):

-        return self.extra_action
+        return self.nis.closed

 
     @property    
     def view_count(self):
 
     @property    
     def view_count(self):


@@ -23,25 +27,24 @@ class Question(Node):
 
     @property
     def headline(self):
 
     @property
     def headline(self):

-        if self.marked:
-            return _('[closed] ') + self.title
-
-        if self.deleted:
+        if self.nis.deleted:

             return _('[deleted] ') + self.title
 
             return _('[deleted] ') + self.title
 

-        return self.title
+        if self.nis.closed:
+            return _('[closed] ') + self.title

 
 

-    @property
-    def answer_accepted(self):
-        return self.extra_ref is not None
+        return self.title

 
     @property
 
     @property

-    def accepted_answer(self):
-        return self.extra_ref
+    def accepted_answers(self):
+        return self.answers.filter(~models.Q(state_string__contains="(deleted)"), marked=True)

 
     @models.permalink    
     def get_absolute_url(self):
         return ('question', (), {'id': self.id, 'slug': django_urlquote(slugify(self.title))})
 
     @models.permalink    
     def get_absolute_url(self):
         return ('question', (), {'id': self.id, 'slug': django_urlquote(slugify(self.title))})

+        
+    def meta_description(self):
+        return self.summary

 
     def get_revision_url(self):
         return reverse('question_revisions', args=[self.id])
 
     def get_revision_url(self):
         return reverse('question_revisions', args=[self.id])


@@ -51,19 +54,14 @@ class Question(Node):
         related_list = cache.get(cache_key)
 
         if related_list is None:
         related_list = cache.get(cache_key)
 
         if related_list is None:

-            related_list = Question.objects.values('id').filter(tags__id__in=[t.id for t in self.tags.all()]
-            ).exclude(id=self.id).filter(deleted=None).annotate(frequency=models.Count('id')).order_by('-frequency')[:count]
+            related_list = Question.objects.filter_state(deleted=False).values('id').filter(tags__id__in=[t.id for t in self.tags.all()]
+            ).exclude(id=self.id).annotate(frequency=models.Count('id')).order_by('-frequency')[:count]

             cache.set(cache_key, related_list, 60 * 60)
 
         return [Question.objects.get(id=r['id']) for r in related_list]
             cache.set(cache_key, related_list, 60 * 60)
 
         return [Question.objects.get(id=r['id']) for r in related_list]

+    

 
 
 
 

-def question_viewed(instance, **kwargs):
-    instance.extra_count += 1
-    instance.save()
-
-question_view.connect(question_viewed)
-

 
 class QuestionSubscription(models.Model):
     user = models.ForeignKey(User)
 
 class QuestionSubscription(models.Model):
     user = models.ForeignKey(User)