Make RequestHolder thread-safe

[osqa.git] / forum / models / node.py

diff --git a/forum/models/node.py b/forum/models/node.py
index a71ae4725898fbfc7dc6cddaa854590b9f248d39..5b6cdb512a0554edac61d303594e15a11f65f494 100644 (file)
--- a/forum/models/node.py
+++ b/forum/models/node.py
@@ -1,8 +1,11 @@
+# -*- coding: utf-8 -*-
+

 from base import *
 import re
 from tag import Tag
 
 import markdown
 from base import *
 import re
 from tag import Tag
 
 import markdown

+from django.utils.encoding import smart_unicode

 from django.utils.translation import ugettext as _
 from django.utils.safestring import mark_safe
 from django.utils.html import strip_tags
 from django.utils.translation import ugettext as _
 from django.utils.safestring import mark_safe
 from django.utils.html import strip_tags


@@ -39,7 +42,7 @@ class NodeContent(models.Model):
             return ''
 
     def as_markdown(self, *extensions):
             return ''
 
     def as_markdown(self, *extensions):

-        return self._as_markdown(self.body, *extensions)
+        return self._as_markdown(smart_unicode(self.body), *extensions)

 
     @property
     def headline(self):
 
     @property
     def headline(self):


@@ -52,7 +55,7 @@ class NodeContent(models.Model):
 
     def tagname_list(self):
         if self.tagnames:
 
     def tagname_list(self):
         if self.tagnames:

-            return [name.strip() for name in self.tagnames.split(u' ') if name]
+            return [name.strip() for name in self.tagnames.split() if name]

         else:
             return []
 
         else:
             return []
 


@@ -242,7 +245,7 @@ class Node(BaseModel, NodeContent):
     marked = models.BooleanField(default=False)
 
     comment_count = DenormalizedField("children", node_type="comment", canceled=False)
     marked = models.BooleanField(default=False)
 
     comment_count = DenormalizedField("children", node_type="comment", canceled=False)

-    flag_count = DenormalizedField("flags")
+    flag_count = DenormalizedField("actions", action_type="flag", canceled=False)

 
     friendly_name = _("post")
 
 
     friendly_name = _("post")
 


@@ -254,7 +257,7 @@ class Node(BaseModel, NodeContent):
     @classmethod
     def _generate_cache_key(cls, key, group="node"):
         return super(Node, cls)._generate_cache_key(key, group)
     @classmethod
     def _generate_cache_key(cls, key, group="node"):
         return super(Node, cls)._generate_cache_key(key, group)

-        
+

     @classmethod
     def get_type(cls):
         return cls.__name__.lower()
     @classmethod
     def get_type(cls):
         return cls.__name__.lower()


@@ -314,16 +317,27 @@ class Node(BaseModel, NodeContent):
 
     @property
     def summary(self):
 
     @property
     def summary(self):

-        content = strip_tags(self.html)[:SUMMARY_LENGTH]
+        content = strip_tags(self.html)

 
         # Remove multiple spaces.
         content = re.sub(' +',' ', content)
 
 
         # Remove multiple spaces.
         content = re.sub(' +',' ', content)
 

-        # Remove line breaks. We don't need them at all.
-        content = content.replace("\n", '')
+        # Replace line breaks with a space, we don't need them at all.
+        content = content.replace("\n", ' ')
+
+        # Truncate and all an ellipsis if length greater than summary length.
+        content = (content[:SUMMARY_LENGTH] + '...') if len(content) > SUMMARY_LENGTH else content

 
         return content
 
 
         return content
 

+    # Can be used to block subscription notifications for a specific node from a module
+    def _is_notifiable(self):
+        return True
+
+    @property
+    def is_notifiable(self):
+        return self._is_notifiable()
+

     @models.permalink
     def get_revisions_url(self):
         return ('revisions', (), {'id': self.id})
     @models.permalink
     def get_revisions_url(self):
         return ('revisions', (), {'id': self.id})


@@ -359,7 +373,22 @@ class Node(BaseModel, NodeContent):
         self.body = self.rendered(revision.body)
 
         self.active_revision = revision
         self.body = self.rendered(revision.body)
 
         self.active_revision = revision

-        self.update_last_activity(user)
+
+        # Try getting the previous revision
+        try:
+            prev_revision = NodeRevision.objects.get(node=self, revision=revision.revision-1)
+
+            update_activity = True
+
+            # Do not update the activity if only the tags are changed
+            if prev_revision.title == revision.title and prev_revision.body == revision.body \
+            and prev_revision.tagnames != revision.tagnames and not settings.UPDATE_LATEST_ACTIVITY_ON_TAG_EDIT:
+                update_activity = False
+        except NodeRevision.DoesNotExist:
+            update_activity = True
+        finally:
+            if update_activity:
+                self.update_last_activity(user)

 
         self.save()
 
 
         self.save()
 


@@ -375,6 +404,18 @@ class Node(BaseModel, NodeContent):
 
         return active_users
 
 
         return active_users
 

+    def get_last_edited(self):
+        if not self.last_edited:
+            try:
+                le = self.actions.exclude(action_type__in=('voteup', 'votedown', 'flag'), canceled=True).order_by('-action_date')[0]
+                self.last_edited = le
+                self.save()
+            except:
+                pass
+
+        return self.last_edited
+
+

     def _list_changes_in_tags(self):
         dirty = self.get_dirty_fields()
 
     def _list_changes_in_tags(self):
         dirty = self.get_dirty_fields()
 


@@ -382,10 +423,10 @@ class Node(BaseModel, NodeContent):
             return None
         else:
             if self._original_state['tagnames']:
             return None
         else:
             if self._original_state['tagnames']:

-                old_tags = set(name for name in self._original_state['tagnames'].split(u' '))
+                old_tags = set(self._original_state['tagnames'].split())

             else:
                 old_tags = set()
             else:
                 old_tags = set()

-            new_tags = set(name for name in self.tagnames.split(u' ') if name)
+            new_tags = set(self.tagnames.split())

 
             return dict(
                     current=list(new_tags),
 
             return dict(
                     current=list(new_tags),


@@ -437,6 +478,10 @@ class Node(BaseModel, NodeContent):
                 tag.save()
 
     def delete(self, *args, **kwargs):
                 tag.save()
 
     def delete(self, *args, **kwargs):

+        for tag in self.tags.all():
+            tag.add_to_usage_count(-1)
+            tag.save()
+

         self.active_revision = None
         self.save()
 
         self.active_revision = None
         self.save()
 


@@ -463,7 +508,11 @@ class Node(BaseModel, NodeContent):
         tags_changed = self._process_changes_in_tags()
         
         super(Node, self).save(*args, **kwargs)
         tags_changed = self._process_changes_in_tags()
         
         super(Node, self).save(*args, **kwargs)

-        if tags_changed: self.tags = list(Tag.objects.filter(name__in=self.tagname_list()))
+        if tags_changed:
+            if self.tagnames.strip():
+                self.tags = list(Tag.objects.filter(name__in=self.tagname_list()))
+            else:
+                self.tags = []

 
     class Meta:
         app_label = 'forum'
 
     class Meta:
         app_label = 'forum'