q may not be there

[osqa.git] / forum / views / commands.py

diff --git a/forum/views/commands.py b/forum/views/commands.py
index e909bdf2b95036baa98fe00390cf69066f3dd0d6..be6aa71ab771fb3b9b84d8ab215c107935795d59 100644 (file)
--- a/forum/views/commands.py
+++ b/forum/views/commands.py
@@ -1,18 +1,21 @@
 # -*- coding: utf-8 -*-
 
 import datetime
 # -*- coding: utf-8 -*-
 
 import datetime

+import json

 import logging
 
 from urllib import urlencode
 
 from django.core.exceptions import ObjectDoesNotExist
 from django.core.urlresolvers import reverse
 import logging
 
 from urllib import urlencode
 
 from django.core.exceptions import ObjectDoesNotExist
 from django.core.urlresolvers import reverse

-from django.utils import simplejson

 from django.utils.encoding import smart_unicode
 from django.utils.translation import ungettext, ugettext as _
 from django.utils.encoding import smart_unicode
 from django.utils.translation import ungettext, ugettext as _

-from django.http import HttpResponse, HttpResponseRedirect, Http404
+from django.http import (HttpResponse, HttpResponseRedirect, Http404,
+                         HttpResponseBadRequest)

 from django.shortcuts import get_object_or_404, render_to_response
 
 from django.shortcuts import get_object_or_404, render_to_response
 

+from django.contrib import messages
+

 from forum.models import *
 from forum.utils.decorators import ajax_login_required
 from forum.actions import *
 from forum.models import *
 from forum.utils.decorators import ajax_login_required
 from forum.actions import *


@@ -22,7 +25,7 @@ from forum import settings
 from decorators import command, CommandException, RefreshPageCommand
 
 class NotEnoughRepPointsException(CommandException):
 from decorators import command, CommandException, RefreshPageCommand
 
 class NotEnoughRepPointsException(CommandException):

-    def __init__(self, action, user_reputation=None, reputation_required=None):
+    def __init__(self, action, user_reputation=None, reputation_required=None, node=None):

         if reputation_required is not None and user_reputation is not None:
             message = _(
                 """Sorry, but you don't have enough reputation points to %(action)s.<br />
         if reputation_required is not None and user_reputation is not None:
             message = _(
                 """Sorry, but you don't have enough reputation points to %(action)s.<br />


@@ -75,6 +78,10 @@ class CannotDoubleActionException(CommandException):
 
 @decorate.withfn(command)
 def vote_post(request, id, vote_type):
 
 @decorate.withfn(command)
 def vote_post(request, id, vote_type):

+    if not request.method == 'POST':
+        raise CommandException(_("Invalid request"))
+
+

     post = get_object_or_404(Node, id=id).leaf
     user = request.user
 
     post = get_object_or_404(Node, id=id).leaf
     user = request.user
 


@@ -87,7 +94,7 @@ def vote_post(request, id, vote_type):
     if not (vote_type == 'up' and user.can_vote_up() or user.can_vote_down()):
         reputation_required = int(settings.REP_TO_VOTE_UP) if vote_type == 'up' else int(settings.REP_TO_VOTE_DOWN)
         action_type = vote_type == 'up' and _('upvote') or _('downvote')
     if not (vote_type == 'up' and user.can_vote_up() or user.can_vote_down()):
         reputation_required = int(settings.REP_TO_VOTE_UP) if vote_type == 'up' else int(settings.REP_TO_VOTE_DOWN)
         action_type = vote_type == 'up' and _('upvote') or _('downvote')

-        raise NotEnoughRepPointsException(action_type, user_reputation=user.reputation, reputation_required=reputation_required)
+        raise NotEnoughRepPointsException(action_type, user_reputation=user.reputation, reputation_required=reputation_required, node=post)

 
     user_vote_count_today = user.get_vote_count_today()
     user_can_vote_count_today = user.can_vote_count_today()
 
     user_vote_count_today = user.get_vote_count_today()
     user_can_vote_count_today = user.can_vote_count_today()


@@ -178,7 +185,7 @@ def like_comment(request, id):
         raise CannotDoOnOwnException(_('like'))
 
     if not user.can_like_comment(comment):
         raise CannotDoOnOwnException(_('like'))
 
     if not user.can_like_comment(comment):

-        raise NotEnoughRepPointsException( _('like comments'))
+        raise NotEnoughRepPointsException( _('like comments'), node=comment)

 
     like = VoteAction.get_action_for(node=comment, user=user)
 
 
     like = VoteAction.get_action_for(node=comment, user=user)
 


@@ -218,17 +225,17 @@ def delete_comment(request, id):
 
 @decorate.withfn(command)
 def mark_favorite(request, id):
 
 @decorate.withfn(command)
 def mark_favorite(request, id):

-    question = get_object_or_404(Question, id=id)
+    node = get_object_or_404(Node, id=id)

 
     if not request.user.is_authenticated():
         raise AnonymousNotAllowedException(_('mark a question as favorite'))
 
     try:
 
     if not request.user.is_authenticated():
         raise AnonymousNotAllowedException(_('mark a question as favorite'))
 
     try:

-        favorite = FavoriteAction.objects.get(canceled=False, node=question, user=request.user)
+        favorite = FavoriteAction.objects.get(canceled=False, node=node, user=request.user)

         favorite.cancel(ip=request.META['REMOTE_ADDR'])
         added = False
     except ObjectDoesNotExist:
         favorite.cancel(ip=request.META['REMOTE_ADDR'])
         added = False
     except ObjectDoesNotExist:

-        FavoriteAction(node=question, user=request.user, ip=request.META['REMOTE_ADDR']).save()
+        FavoriteAction(node=node, user=request.user, ip=request.META['REMOTE_ADDR']).save()

         added = True
 
     return {
         added = True
 
     return {


@@ -303,7 +310,7 @@ def node_markdown(request, id):
         raise AnonymousNotAllowedException(_('accept answers'))
 
     node = get_object_or_404(Node, id=id)
         raise AnonymousNotAllowedException(_('accept answers'))
 
     node = get_object_or_404(Node, id=id)

-    return HttpResponse(node.active_revision.body, mimetype="text/plain")
+    return HttpResponse(node.active_revision.body, content_type="text/plain")

 
 
 @decorate.withfn(command)
 
 
 @decorate.withfn(command)


@@ -349,7 +356,7 @@ def accept_answer(request, id):
             """)
 
             # Notify the user with a message that an answer has been accepted
             """)
 
             # Notify the user with a message that an answer has been accepted

-            request.user.message_set.create(message=msg)
+            messages.info(request, msg)

 
             # Redirect URL should include additional get parameters that might have been attached
             redirect_url = answer.parent.get_absolute_url() + "?accepted_answer=true&%s" % smart_unicode(urlencode(request.GET))
 
             # Redirect URL should include additional get parameters that might have been attached
             redirect_url = answer.parent.get_absolute_url() + "?accepted_answer=true&%s" % smart_unicode(urlencode(request.GET))


@@ -541,18 +548,19 @@ def mark_tag(request, tag=None, **kwargs):#tagging system
                 pass
         else:
             ts.update(reason=reason)
                 pass
         else:
             ts.update(reason=reason)

-    return HttpResponse(simplejson.dumps(''), mimetype="application/json")
+    return HttpResponse(json.dumps(''), content_type="application/json")

 
 def matching_tags(request):
 
 def matching_tags(request):

-    if len(request.GET['q']) == 0:
-        raise CommandException(_("Invalid request"))
+    q = request.GET.get('q')
+    if not q:
+        return HttpResponseBadRequest(_("Invalid request"))

 
 

-    possible_tags = Tag.active.filter(name__icontains = request.GET['q'])
+    possible_tags = Tag.active.filter(name__icontains=q)

     tag_output = ''
     for tag in possible_tags:
         tag_output += "%s|%s|%s\n" % (tag.id, tag.name, tag.used_count)
 
     tag_output = ''
     for tag in possible_tags:
         tag_output += "%s|%s|%s\n" % (tag.id, tag.name, tag.used_count)
 

-    return HttpResponse(tag_output, mimetype="text/plain")
+    return HttpResponse(tag_output, content_type="text/plain")

 
 def matching_users(request):
     if len(request.GET['q']) == 0:
 
 def matching_users(request):
     if len(request.GET['q']) == 0:


@@ -564,7 +572,7 @@ def matching_users(request):
     for user in possible_users:
         output += ("%s|%s|%s\n" % (user.id, user.decorated_name, user.reputation))
 
     for user in possible_users:
         output += ("%s|%s|%s\n" % (user.id, user.decorated_name, user.reputation))
 

-    return HttpResponse(output, mimetype="text/plain")
+    return HttpResponse(output, content_type="text/plain")

 
 def related_questions(request):
     if request.POST and request.POST.get('title', None):
 
 def related_questions(request):
     if request.POST and request.POST.get('title', None):


@@ -573,9 +581,9 @@ def related_questions(request):
         if can_rank and isinstance(can_rank, basestring):
             questions = questions.order_by(can_rank)
 
         if can_rank and isinstance(can_rank, basestring):
             questions = questions.order_by(can_rank)
 

-        return HttpResponse(simplejson.dumps(
+        return HttpResponse(json.dumps(

                 [dict(title=q.title, url=q.get_absolute_url(), score=q.score, summary=q.summary)
                 [dict(title=q.title, url=q.get_absolute_url(), score=q.score, summary=q.summary)

-                 for q in questions.filter_state(deleted=False)[0:10]]), mimetype="application/json")
+                 for q in questions.filter_state(deleted=False)[0:10]]), content_type="application/json")

     else:
         raise Http404()
 
     else:
         raise Http404()
 


@@ -613,7 +621,11 @@ def award_points(request, user_id, answer_id):
         raise AnonymousNotAllowedException(_('award'))
 
     if not request.POST:
         raise AnonymousNotAllowedException(_('award'))
 
     if not request.POST:

-        return render_to_response("node/award_points.html", { 'user' : user, 'awarded_user' : awarded_user, })
+        return render_to_response("node/award_points.html", {
+            'user' : user,
+            'awarded_user' : awarded_user,
+            'reputation_to_comment' : str(settings.REP_TO_COMMENT)
+        })

     else:
         points = int(request.POST['points'])
 
     else:
         points = int(request.POST['points'])
 


@@ -630,3 +642,4 @@ def award_points(request, user_id, answer_id):
         AwardPointsAction(user=request.user, node=answer, extra=extra).save(data=dict(value=points, affected=awarded_user))
 
         return { 'message' : _("You have awarded %(awarded_user)s with %(points)d points") % {'awarded_user' : awarded_user, 'points' : points} }
         AwardPointsAction(user=request.user, node=answer, extra=extra).save(data=dict(value=points, affected=awarded_user))
 
         return { 'message' : _("You have awarded %(awarded_user)s with %(points)d points") % {'awarded_user' : awarded_user, 'points' : points} }

+