Prevents questions on which the slug comes out empty to enter a redirect loop.

[osqa.git] / forum / models / base.py

diff --git a/forum/models/base.py b/forum/models/base.py
index 63c73e848408c24a1e81fbd13981fbdb4b18f4d1..3d54d75e95d8025efee2a6af8c97ebf3b47e60a8 100644 (file)
--- a/forum/models/base.py
+++ b/forum/models/base.py
@@ -46,14 +46,9 @@ class CachedQuerySet(models.query.QuerySet):
         return obj
 
     def get(self, *args, **kwargs):
         return obj
 
     def get(self, *args, **kwargs):

-        try:
-            pk = [v for (k,v) in kwargs.items() if k in ('pk', 'pk__exact', 'id', 'id__exact'
-                            ) or k.endswith('_ptr__pk') or k.endswith('_ptr__id')][0]
-        except:
-            pk = None
+        key = self.model.infer_cache_key(kwargs)

 
 

-        if pk is not None:
-            key = self.model.cache_key(pk)
+        if key is not None:

             obj = cache.get(key)
 
             if obj is None:
             obj = cache.get(key)
 
             if obj is None:


@@ -137,10 +132,6 @@ class BaseModel(models.Model):
         super(BaseModel, self).__init__(*args, **kwargs)
         self.reset_original_state(kwargs.keys())
 
         super(BaseModel, self).__init__(*args, **kwargs)
         self.reset_original_state(kwargs.keys())
 

-    @classmethod
-    def cache_key(cls, pk):
-        return '%s:%s:%s' % (settings.APP_URL, cls.__name__, pk)
-

     def reset_original_state(self, reset_fields=None):
         self._original_state = self._as_dict()
         
     def reset_original_state(self, reset_fields=None):
         self._original_state = self._as_dict()
         


@@ -160,10 +151,10 @@ class BaseModel(models.Model):
             (f.name, getattr(self, f.name)) for f in self._meta.fields if self._original_state[f.attname] != self.__dict__[f.attname]
         ])
 
             (f.name, getattr(self, f.name)) for f in self._meta.fields if self._original_state[f.attname] != self.__dict__[f.attname]
         ])
 

-    def save(self, *args, **kwargs):
+    def save(self, full_save=False, *args, **kwargs):

         put_back = [k for k, v in self.__dict__.items() if isinstance(v, models.expressions.ExpressionNode)]
 
         put_back = [k for k, v in self.__dict__.items() if isinstance(v, models.expressions.ExpressionNode)]
 

-        if self.id:
+        if self.id and not full_save:

             self.__class__.objects.filter(id=self.id).update(**self._get_update_kwargs())
         else:
             super(BaseModel, self).save()
             self.__class__.objects.filter(id=self.id).update(**self._get_update_kwargs())
         else:
             super(BaseModel, self).save()


@@ -180,11 +171,31 @@ class BaseModel(models.Model):
         self.reset_original_state()
         self.cache()
 
         self.reset_original_state()
         self.cache()
 

+    @classmethod
+    def _generate_cache_key(cls, key, group=None):
+        if group is None:
+            group = cls.__name__
+
+        return '%s:%s:%s' % (settings.APP_URL, group, key)
+
+    def cache_key(self):
+        return self._generate_cache_key(self.id)
+
+    @classmethod
+    def infer_cache_key(cls, querydict):
+        try:
+            pk = [v for (k,v) in querydict.items() if k in ('pk', 'pk__exact', 'id', 'id__exact'
+                            ) or k.endswith('_ptr__pk') or k.endswith('_ptr__id')][0]
+
+            return cls._generate_cache_key(pk)
+        except:
+            return None
+

     def cache(self):
     def cache(self):

-        cache.set(self.cache_key(self.id), self._as_dict(), 60 * 60)
+        cache.set(self.cache_key(), self._as_dict(), 60 * 60)

 
     def uncache(self):
 
     def uncache(self):

-        cache.delete(self.cache_key(self.id))
+        cache.delete(self.cache_key())

 
     def delete(self):
         self.uncache()
 
     def delete(self):
         self.uncache()