X-Git-Url: https://git.openstreetmap.org./osqa.git/blobdiff_plain/0b6a8cd252047fcac0bee3fefc25d6ba10fe1d01..7794c77e43f8c29ceefd58f446aef98e15d181ea:/forum/models/user.py?ds=sidebyside diff --git a/forum/models/user.py b/forum/models/user.py index 1e9ffd6..e8871f4 100644 --- a/forum/models/user.py +++ b/forum/models/user.py @@ -1,13 +1,14 @@ from base import * from utils import PickledObjectField +from django.conf import settings as django_settings from django.core.exceptions import ObjectDoesNotExist, MultipleObjectsReturned from django.contrib.contenttypes.models import ContentType from django.contrib.auth.models import User as DjangoUser, AnonymousUser as DjangoAnonymousUser from django.db.models import Q -try: - from hashlib import md5 -except: - from md5 import new as md5 + +from django.utils.encoding import smart_unicode + +from forum.settings import TRUNCATE_LONG_USERNAMES, TRUNCATE_USERNAMES_LONGER_THAN import string from random import Random @@ -15,13 +16,9 @@ from random import Random from django.utils.translation import ugettext as _ import logging -QUESTIONS_PER_PAGE_CHOICES = ( -(10, u'10'), -(30, u'30'), -(50, u'50'), -) - class AnonymousUser(DjangoAnonymousUser): + reputation = 0 + def get_visible_answers(self, question): return question.answers.filter_state(deleted=False) @@ -33,6 +30,9 @@ class AnonymousUser(DjangoAnonymousUser): def can_vote_down(self): return False + + def can_vote_count_today(self): + return 0 def can_flag_offensive(self, post=None): return False @@ -55,6 +55,9 @@ class AnonymousUser(DjangoAnonymousUser): def can_convert_to_comment(self, answer): return False + def can_convert_to_question(self, answer): + return False + def can_convert_comment_to_answer(self, comment): return False @@ -111,7 +114,7 @@ class User(BaseModel, DjangoUser): is_approved = models.BooleanField(default=False) email_isvalid = models.BooleanField(default=False) - reputation = models.PositiveIntegerField(default=0) + reputation = models.IntegerField(default=0) gold = models.PositiveIntegerField(default=0) silver = models.PositiveIntegerField(default=0) bronze = models.PositiveIntegerField(default=0) @@ -129,7 +132,7 @@ class User(BaseModel, DjangoUser): vote_down_count = DenormalizedField("actions", canceled=False, action_type="votedown") def __unicode__(self): - return self.username + return smart_unicode(self.username) @property def prop(self): @@ -148,14 +151,19 @@ class User(BaseModel, DjangoUser): @property def decorated_name(self): + username = smart_unicode(self.username) + + if len(username) > TRUNCATE_USERNAMES_LONGER_THAN and TRUNCATE_LONG_USERNAMES: + username = '%s...' % username[:TRUNCATE_USERNAMES_LONGER_THAN-3] + if settings.SHOW_STATUS_DIAMONDS: if self.is_superuser: - return u"%s \u2666\u2666" % self.username + return u"%s \u2666\u2666" % username if self.is_staff: - return u"%s \u2666" % self.username + return u"%s \u2666" % username - return self.username + return username @property def last_activity(self): @@ -169,7 +177,8 @@ class User(BaseModel, DjangoUser): return md5(self.email.lower()).hexdigest() def save(self, *args, **kwargs): - if self.reputation < 0: + # If the community doesn't allow negative reputation, set it to 0 + if not settings.ALLOW_NEGATIVE_REPUTATION and self.reputation < 0: self.reputation = 0 new = not bool(self.id) @@ -180,9 +189,6 @@ class User(BaseModel, DjangoUser): sub_settings = SubscriptionSettings(user=self) sub_settings.save() - def get_absolute_url(self): - return self.get_profile_url() - def get_messages(self): messages = [] for m in self.message_set.all(): @@ -194,22 +200,46 @@ class User(BaseModel, DjangoUser): @models.permalink def get_profile_url(self): - return ('user_profile', (), {'id': self.id, 'slug': slugify(self.username)}) + keyword_arguments = { + 'slug': slugify(smart_unicode(self.username)) + } + if settings.INCLUDE_ID_IN_USER_URLS: + keyword_arguments.update({ + 'id': self.id, + }) + return ('user_profile', (), keyword_arguments) def get_absolute_url(self): return self.get_profile_url() @models.permalink def get_asked_url(self): - return ('user_questions', (), {'mode': _('asked-by'), 'user': self.id, 'slug': slugify(self.username)}) + return ('user_questions', (), {'mode': _('asked-by'), 'user': self.id, 'slug': slugify(smart_unicode(self.username))}) + + @models.permalink + def get_user_subscriptions_url(self): + keyword_arguments = { + 'slug': slugify(smart_unicode(self.username)) + } + if settings.INCLUDE_ID_IN_USER_URLS: + keyword_arguments.update({ + 'id': self.id, + }) + return ('user_subscriptions', (), keyword_arguments) @models.permalink def get_answered_url(self): return ('user_questions', (), {'mode': _('answered-by'), 'user': self.id, 'slug': slugify(self.username)}) - @models.permalink def get_subscribed_url(self): - return ('user_questions', (), {'mode': _('subscribed-by'), 'user': self.id, 'slug': slugify(self.username)}) + try: + # Try to retrieve the Subscribed User URL. + url = reverse('user_questions', + kwargs={'mode': _('subscribed-by'), 'user': self.id, 'slug': slugify(smart_unicode(self.username))}) + return url + except Exception, e: + # If some Exception has been raised, don't forget to log it. + logging.error("Error retrieving a subscribed user URL: %s" % e) def get_profile_link(self): profile_link = u'%s' % (self.get_profile_url(), self.username) @@ -235,6 +265,22 @@ class User(BaseModel, DjangoUser): today = datetime.date.today() return self.actions.filter(canceled=False, action_type="flag", action_date__gte=(today - datetime.timedelta(days=1))).count() + + def can_vote_count_today(self): + votes_today = settings.MAX_VOTES_PER_DAY + + if settings.USER_REPUTATION_TO_MAX_VOTES: + votes_today = votes_today + int(self.reputation) + + return votes_today + + def can_use_canned_comments(self): + # The canned comments feature is available only for admins and moderators, + # and only if the "Use canned comments" setting is activated in the administration. + if (self.is_superuser or self.is_staff) and settings.USE_CANNED_COMMENTS: + return True + else: + return False @true_if_is_super_or_staff def can_view_deleted_post(self, post): @@ -279,16 +325,23 @@ class User(BaseModel, DjangoUser): def can_delete_comment(self, comment): return self == comment.author or self.reputation >= int(settings.REP_TO_DELETE_COMMENTS) - @true_if_is_super_or_staff def can_convert_comment_to_answer(self, comment): - return self == comment.author or self.reputation >= int(settings.REP_TO_CONVERT_COMMENTS_TO_ANSWERS) + # We need to know what is the comment parent node type. + comment_parent_type = comment.parent.node_type + + # If the parent is not a question or an answer this comment cannot be converted to an answer. + if comment_parent_type != "question" and comment_parent_type != "answer": + return False + + return (comment.parent.node_type in ('question', 'answer')) and (self.is_superuser or self.is_staff or ( + self == comment.author) or (self.reputation >= int(settings.REP_TO_CONVERT_COMMENTS_TO_ANSWERS))) def can_convert_to_comment(self, answer): return (not answer.marked) and (self.is_superuser or self.is_staff or answer.author == self or self.reputation >= int (settings.REP_TO_CONVERT_TO_COMMENT)) - def can_convert_to_question(self, answer): - return (not answer.marked) and (self.is_superuser or self.is_staff or answer.author == self or self.reputation >= int + def can_convert_to_question(self, node): + return (not node.marked) and (self.is_superuser or self.is_staff or node.author == self or self.reputation >= int (settings.REP_TO_CONVERT_TO_QUESTION)) @true_if_is_super_or_staff @@ -324,7 +377,17 @@ class User(BaseModel, DjangoUser): @true_if_is_super_or_staff def can_reopen_question(self, question): - return self == question.author and self.reputation >= int(settings.REP_TO_REOPEN_OWN) + # Check whether the setting to Unify close and reopen permissions has been activated + if bool(settings.UNIFY_PERMISSIONS_TO_CLOSE_AND_REOPEN): + # If we unify close to reopen check whether the user has permissions to close. + # If he has -- he can reopen his question too. + can_reopen = ( + self == question.author and self.reputation >= int(settings.REP_TO_CLOSE_OWN) + ) or self.reputation >= int(settings.REP_TO_CLOSE_OTHERS) + else: + # Check whether the user is the author and has the required permissions to reopen + can_reopen = self == question.author and self.reputation >= int(settings.REP_TO_REOPEN_OWN) + return can_reopen @true_if_is_super_or_staff def can_delete_post(self, post): @@ -362,7 +425,7 @@ class User(BaseModel, DjangoUser): except MultipleObjectsReturned: logging.error("Multiple suspension actions found for user %s (%s)" % (self.username, self.id)) self.__dict__['_suspension_dencache_'] = self.reputes.filter(action__action_type="suspend", action__canceled=False - ).order_by('-action__action_date')[0] + ).order_by('-action__action_date')[0].action return self.__dict__['_suspension_dencache_'] @@ -400,7 +463,10 @@ class UserProperty(BaseModel): @classmethod def infer_cache_key(cls, querydict): if 'user' in querydict and 'key' in querydict: - return cls._generate_cache_key("%s:%s" % (querydict['user'].id, querydict['key'])) + cache_key = cls._generate_cache_key("%s:%s" % (querydict['user'].id, querydict['key'])) + if len(cache_key) > django_settings.CACHE_MAX_KEY_LENGTH: + cache_key = cache_key[:django_settings.CACHE_MAX_KEY_LENGTH] + return cache_key return None @@ -467,9 +533,6 @@ class SubscriptionSettings(models.Model): #auto_subscribe_to all_questions = models.BooleanField(default=False) all_questions_watched_tags = models.BooleanField(default=False) - questions_asked = models.BooleanField(default=True) - questions_answered = models.BooleanField(default=True) - questions_commented = models.BooleanField(default=False) questions_viewed = models.BooleanField(default=False) #notify activity on subscribed