X-Git-Url: https://git.openstreetmap.org./osqa.git/blobdiff_plain/14504aa581ca93dcbb32342c2b541b685f136aee..981f2713a5caa510f596a089f78579f5ed317bd5:/forum/sitemap.py?ds=sidebyside diff --git a/forum/sitemap.py b/forum/sitemap.py index 43d0934..0bf8538 100644 --- a/forum/sitemap.py +++ b/forum/sitemap.py @@ -1,10 +1,12 @@ +import re + from django.contrib.sitemaps import Sitemap from forum.models import Question +from forum.settings import QUESTIONS_SITEMAP_LIMIT, QUESTIONS_SITEMAP_CHANGEFREQ from django.conf import settings -from django.http import HttpResponse +from django.http import HttpResponse, Http404 from django.template import loader from django.core import urlresolvers -from django.contrib.sites.models import get_current_site from django.utils.encoding import smart_str from django.core.paginator import EmptyPage, PageNotAnInteger @@ -15,15 +17,41 @@ def index(request, sitemaps): pages = site().paginator.num_pages else: pages = site.paginator.num_pages - sitemap_url = urlresolvers.reverse('forum.sitemap.sitemap', kwargs={'section': section}) - sites.append('%s%s' % (settings.APP_URL, sitemap_url)) - if pages > 1: - for page in range(2, pages+1): - sites.append('%s%s?p=%s' % (settings.APP_URL, sitemap_url, page)) + sitemap_url = urlresolvers.reverse('sitemap_section_index', kwargs={'section': section}) + + # Replace double forward slashes with single ones + final_url = '%s%s' % (settings.APP_URL, sitemap_url) + final_url = re.sub("/+", "/", final_url) + final_url = final_url.replace('http:/', 'http://') + final_url = final_url.replace('https:/', 'https://') + + sites.append(final_url) + xml = loader.render_to_string('sitemap_index.xml', {'sitemaps': sites}) return HttpResponse(xml, mimetype='application/xml') -def sitemap(request, sitemaps, section=None): +def sitemap_section_index(request, section, sitemaps): + try: + sitemap = sitemaps[section]() + except KeyError: + raise Http404("Sitemap doesn't exist") + + paginator = sitemap.paginator + + locations = [] + + for page in paginator.page_range: + location = urlresolvers.reverse('sitemap_section_page', kwargs={ 'page' : page, 'section' : section }) + location = '%s%s' % (settings.APP_URL, location) + location = re.sub("/+", "/", location) + location = location.replace('http:/', 'http://') + location = location.replace('https:/', 'https://') + locations.append(location) + + xml = loader.render_to_string('sitemap_section_index.xml', { 'locations' : locations, }) + return HttpResponse(xml, mimetype='application/xml') + +def sitemap(request, sitemaps, section=None, page=1): maps, urls = [], [] if section is not None: if section not in sitemaps: @@ -31,7 +59,6 @@ def sitemap(request, sitemaps, section=None): maps.append(sitemaps[section]) else: maps = sitemaps.values() - page = request.GET.get("p", 1) for site in maps: try: @@ -47,10 +74,11 @@ def sitemap(request, sitemaps, section=None): return HttpResponse(xml, mimetype='application/xml') class OsqaSitemap(Sitemap): - changefreq = 'daily' + limit = QUESTIONS_SITEMAP_LIMIT + changefreq = QUESTIONS_SITEMAP_CHANGEFREQ priority = 0.5 def items(self): - return Question.objects.filter_state(deleted=False) + return Question.objects.filter_state(deleted=False).order_by('id') def lastmod(self, obj): return obj.last_activity_at @@ -78,4 +106,4 @@ class OsqaSitemap(Sitemap): 'priority': self.__get('priority', item, None) } urls.append(url_info) - return urls \ No newline at end of file + return urls