X-Git-Url: https://git.openstreetmap.org./osqa.git/blobdiff_plain/1a949f7c97dc2f34c135f5cdf088df2927d3d652..9e1d006070eda41708425becf5e8c9cbdb5c2053:/forum/forms.py diff --git a/forum/forms.py b/forum/forms.py index a78f207..0a5afe3 100644 --- a/forum/forms.py +++ b/forum/forms.py @@ -2,14 +2,13 @@ import re from datetime import date from django import forms from models import * -from const import * from django.utils.translation import ugettext as _ +from django.contrib.humanize.templatetags.humanize import apnumber from forum.models import User -from django.contrib.contenttypes.models import ContentType + from django.utils.safestring import mark_safe from forum.utils.forms import NextUrlField, UserNameField, SetPasswordForm -from django.conf import settings -from django.contrib.contenttypes.models import ContentType +from forum import settings import logging class TitleField(forms.CharField): @@ -23,68 +22,100 @@ class TitleField(forms.CharField): self.initial = '' def clean(self, value): - if len(value) < 10: - raise forms.ValidationError(_('title must be > 10 characters')) + if len(value) < settings.FORM_MIN_QUESTION_TITLE: + raise forms.ValidationError(_('title must be must be at least %s characters') % settings.FORM_MIN_QUESTION_TITLE) return value class EditorField(forms.CharField): def __init__(self, *args, **kwargs): super(EditorField, self).__init__(*args, **kwargs) - self.required = True self.widget = forms.Textarea(attrs={'id':'editor'}) self.label = _('content') self.help_text = u'' self.initial = '' + +class QuestionEditorField(EditorField): + def __init__(self, *args, **kwargs): + super(QuestionEditorField, self).__init__(*args, **kwargs) + self.required = not bool(settings.FORM_EMPTY_QUESTION_BODY) + + def clean(self, value): - if len(value) < 10: - raise forms.ValidationError(_('question content must be > 10 characters')) + if self.required and (len(value) < settings.FORM_MIN_QUESTION_BODY): + raise forms.ValidationError(_('question content must be at least %s characters') % settings.FORM_MIN_QUESTION_BODY) return value -class TagNamesField(forms.CharField): +class AnswerEditorField(EditorField): def __init__(self, *args, **kwargs): + super(AnswerEditorField, self).__init__(*args, **kwargs) + self.required = True + + def clean(self, value): + if len(value) < settings.FORM_MIN_QUESTION_BODY: + raise forms.ValidationError(_('answer content must be at least %s characters') % settings.FORM_MIN_QUESTION_BODY) + + return value + + +class TagNamesField(forms.CharField): + def __init__(self, user=None, *args, **kwargs): super(TagNamesField, self).__init__(*args, **kwargs) self.required = True self.widget = forms.TextInput(attrs={'size' : 50, 'autocomplete' : 'off'}) self.max_length = 255 self.label = _('tags') #self.help_text = _('please use space to separate tags (this enables autocomplete feature)') - self.help_text = _('Tags are short keywords, with no spaces within. Up to five tags can be used.') + self.help_text = _('Tags are short keywords, with no spaces within. At least %(min)s and up to %(max)s tags can be used.') % { + 'min': settings.FORM_MIN_NUMBER_OF_TAGS, 'max': settings.FORM_MAX_NUMBER_OF_TAGS + } self.initial = '' + self.user = user def clean(self, value): value = super(TagNamesField, self).clean(value) - data = value.strip() - if len(data) < 1: - raise forms.ValidationError(_('tags are required')) + data = value.strip().lower() split_re = re.compile(r'[ ,]+') list = split_re.split(data) - list_temp = [] - if len(list) > 5: - raise forms.ValidationError(_('please use 5 tags or less')) - tagname_re = re.compile(r'[a-z0-9]+') + if len(list) > settings.FORM_MAX_NUMBER_OF_TAGS or len(list) < settings.FORM_MIN_NUMBER_OF_TAGS: + raise forms.ValidationError(_('please use between %(min)s and %(max)s tags') % { 'min': settings.FORM_MIN_NUMBER_OF_TAGS, 'max': settings.FORM_MAX_NUMBER_OF_TAGS}) + + list_temp = [] + tagname_re = re.compile(r'^[\w+\.-]+$', re.UNICODE) for tag in list: - if len(tag) > 20: - raise forms.ValidationError(_('tags must be shorter than 20 characters')) + if len(tag) > settings.FORM_MAX_LENGTH_OF_TAG or len(tag) < settings.FORM_MIN_LENGTH_OF_TAG: + raise forms.ValidationError(_('please use between %(min)s and %(max)s characters in you tags') % { 'min': settings.FORM_MIN_LENGTH_OF_TAG, 'max': settings.FORM_MAX_LENGTH_OF_TAG}) if not tagname_re.match(tag): - raise forms.ValidationError(_('please use following characters in tags: letters \'a-z\', numbers, and characters \'.-_#\'')) + raise forms.ValidationError(_('please use following characters in tags: letters , numbers, and characters \'.-_\'')) # only keep one same tag if tag not in list_temp and len(tag.strip()) > 0: list_temp.append(tag) + + if settings.LIMIT_TAG_CREATION and not self.user.can_create_tags(): + existent = Tag.objects.filter(name__in=list_temp).values_list('name', flat=True) + + if len(existent) < len(list_temp): + unexistent = [n for n in list_temp if not n in existent] + raise forms.ValidationError(_("You don't have enough reputation to create new tags. The following tags do not exist yet: %s") % + ', '.join(unexistent)) + + return u' '.join(list_temp) class WikiField(forms.BooleanField): - def __init__(self, *args, **kwargs): + def __init__(self, disabled=False, *args, **kwargs): super(WikiField, self).__init__(*args, **kwargs) self.required = False self.label = _('community wiki') self.help_text = _('if you choose community wiki option, the question and answer do not generate points and name of author will not be shown') + if disabled: + self.widget=forms.CheckboxInput(attrs={'disabled': "disabled"}) def clean(self,value): - return value and settings.WIKI_ON + return value class EmailNotifyField(forms.BooleanField): def __init__(self, *args, **kwargs): @@ -101,18 +132,6 @@ class SummaryField(forms.CharField): self.label = _('update summary:') self.help_text = _('enter a brief summary of your revision (e.g. fixed spelling, grammar, improved style, this field is optional)') -class ModerateUserForm(forms.ModelForm): - is_approved = forms.BooleanField(label=_("Automatically accept user's contributions for the email updates"), - required=False) - - def clean_is_approved(self): - if 'is_approved' not in self.cleaned_data: - self.cleaned_data['is_approved'] = False - return self.cleaned_data['is_approved'] - - class Meta: - model = User - fields = ('is_approved',) class FeedbackForm(forms.Form): name = forms.CharField(label=_('Your name:'), required=False) @@ -122,35 +141,29 @@ class FeedbackForm(forms.Form): class AskForm(forms.Form): title = TitleField() - text = EditorField() - tags = TagNamesField() - wiki = WikiField() + text = QuestionEditorField() + + def __init__(self, data=None, user=None, *args, **kwargs): + super(AskForm, self).__init__(data, *args, **kwargs) - openid = forms.CharField(required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 40, 'class':'openid-input'})) - user = forms.CharField(required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) - email = forms.CharField(required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) + self.fields['tags'] = TagNamesField(user) + + if settings.WIKI_ON: + self.fields['wiki'] = WikiField() class AnswerForm(forms.Form): - text = EditorField() + text = AnswerEditorField() wiki = WikiField() - openid = forms.CharField(required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 40, 'class':'openid-input'})) - user = forms.CharField(required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) - email = forms.CharField(required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) - email_notify = EmailNotifyField() - def __init__(self, question, user, *args, **kwargs): + + def __init__(self, question, *args, **kwargs): super(AnswerForm, self).__init__(*args, **kwargs) - self.fields['email_notify'].widget.attrs['id'] = 'question-subscribe-updates'; - if question.wiki and settings.WIKI_ON: - self.fields['wiki'].initial = True - if user.is_authenticated(): - if user in question.followed_by.all(): - self.fields['email_notify'].initial = True - return - self.fields['email_notify'].initial = False + if settings.WIKI_ON: + self.fields['wiki'] = WikiField() + + if question.nis.wiki: + self.fields['wiki'].initial = True -class CloseForm(forms.Form): - reason = forms.ChoiceField(choices=CLOSE_REASONS) class RetagQuestionForm(forms.Form): tags = TagNamesField() @@ -165,43 +178,55 @@ class RevisionForm(forms.Form): """ revision = forms.ChoiceField(widget=forms.Select(attrs={'style' : 'width:520px'})) - def __init__(self, post, latest_revision, *args, **kwargs): + def __init__(self, post, *args, **kwargs): super(RevisionForm, self).__init__(*args, **kwargs) + revisions = post.revisions.all().values_list( 'revision', 'author__username', 'revised_at', 'summary') date_format = '%c' self.fields['revision'].choices = [ (r[0], u'%s - %s (%s) %s' % (r[0], r[1], r[2].strftime(date_format), r[3])) for r in revisions] - self.fields['revision'].initial = latest_revision.revision + + self.fields['revision'].initial = post.active_revision.revision class EditQuestionForm(forms.Form): title = TitleField() - text = EditorField() - tags = TagNamesField() + text = QuestionEditorField() summary = SummaryField() - def __init__(self, question, revision, *args, **kwargs): + def __init__(self, question, user, revision=None, *args, **kwargs): super(EditQuestionForm, self).__init__(*args, **kwargs) + + if revision is None: + revision = question.active_revision + self.fields['title'].initial = revision.title - self.fields['text'].initial = revision.text + self.fields['text'].initial = revision.body + + self.fields['tags'] = TagNamesField(user) self.fields['tags'].initial = revision.tagnames - # Once wiki mode is enabled, it can't be disabled - if not question.wiki: - self.fields['wiki'] = WikiField() + + if settings.WIKI_ON: + self.fields['wiki'] = WikiField(disabled=(question.nis.wiki and not user.can_cancel_wiki(question)), initial=question.nis.wiki) class EditAnswerForm(forms.Form): - text = EditorField() + text = AnswerEditorField() summary = SummaryField() - def __init__(self, answer, revision, *args, **kwargs): + def __init__(self, answer, user, revision=None, *args, **kwargs): super(EditAnswerForm, self).__init__(*args, **kwargs) - self.fields['text'].initial = revision.text + + if revision is None: + revision = answer.active_revision + + self.fields['text'].initial = revision.body + + if settings.WIKI_ON: + self.fields['wiki'] = WikiField(disabled=(answer.nis.wiki and not user.can_cancel_wiki(answer)), initial=answer.nis.wiki) class EditUserForm(forms.Form): email = forms.EmailField(label=u'Email', help_text=_('this email does not have to be linked to gravatar'), required=True, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) - if settings.EDITABLE_SCREEN_NAME: - username = UserNameField(label=_('Screen name')) realname = forms.CharField(label=_('Real name'), required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) website = forms.URLField(label=_('Website'), required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) city = forms.CharField(label=_('Location'), required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) @@ -210,8 +235,8 @@ class EditUserForm(forms.Form): def __init__(self, user, *args, **kwargs): super(EditUserForm, self).__init__(*args, **kwargs) - logging.debug('initializing the form') if settings.EDITABLE_SCREEN_NAME: + self.fields['username'] = UserNameField(label=_('Screen name')) self.fields['username'].initial = user.username self.fields['username'].user_instance = user self.fields['email'].initial = user.email @@ -227,9 +252,7 @@ class EditUserForm(forms.Form): self.user = user def clean_email(self): - """For security reason one unique email in database""" if self.user.email != self.cleaned_data['email']: - #todo dry it, there is a similar thing in openidauth if settings.EMAIL_UNIQUE == True: if 'email' in self.cleaned_data: try: @@ -241,6 +264,12 @@ class EditUserForm(forms.Form): raise forms.ValidationError(_('this email has already been registered, please use another one')) return self.cleaned_data['email'] +NOTIFICATION_CHOICES = ( + ('i', _('Instantly')), + ('d', _('Daily')), + ('w', _('Weekly')), + ('n', _('No notifications')), +) class SubscriptionSettingsForm(forms.Form): member_joins = forms.ChoiceField(widget=forms.RadioSelect, choices=NOTIFICATION_CHOICES)