X-Git-Url: https://git.openstreetmap.org./osqa.git/blobdiff_plain/621380bc14845c6bb631a642a799b83320fecbb0..7b67c56ced3d009d7309ea19cea1df793881f160:/forum_modules/akismet/startup.py diff --git a/forum_modules/akismet/startup.py b/forum_modules/akismet/startup.py index 5f9ab84..c050754 100644 --- a/forum_modules/akismet/startup.py +++ b/forum_modules/akismet/startup.py @@ -1,57 +1,77 @@ +import json + from django.utils.translation import ugettext as _ from django.http import HttpResponse, HttpResponseRedirect -from django.utils import simplejson +from django.template import RequestContext +from django.utils.encoding import smart_str from django.shortcuts import render_to_response -from forum.modules.decorators import decorate +from forum.modules import decorate from forum import views from lib.akismet import Akismet from forum.settings import APP_URL, OSQA_VERSION -from settings import WORDPRESS_API_KEY, REP_TO_FOR_NO_SPAM_CHECK + +from settings import WORDPRESS_API_KEY, REP_FOR_NO_SPAM_CHECK + from forum.models.user import User +from forum.forms.general import SimpleCaptchaForm import settings +def can_bypass_spam_check(user): + return user.is_authenticated and (user.is_superuser or user.is_staff or cmp(int(user.reputation), REP_FOR_NO_SPAM_CHECK) > 0) + def check_spam(param, comment_type): def wrapper(origin, request, *args, **kwargs): - if (request.POST and request.POST.get(param, None) and WORDPRESS_API_KEY) and (not request.user.is_authenticated() - or not (request.user.is_staff and request.user.is_superuser and request.user.reputation >= REP_TO_FOR_NO_SPAM_CHECK)): - comment = request.POST[param] - user = request.user + if request.POST and request.POST.get(param, None) and WORDPRESS_API_KEY and (not can_bypass_spam_check(request.user)): + + comment = smart_str(request.POST[param]) data = { - "user_ip":request.META["REMOTE_ADDR"], - "user_agent":request.environ['HTTP_USER_AGENT'], - "comment_type": comment_type, - "comment":comment + "user_ip":request.META["REMOTE_ADDR"], + "user_agent":request.environ['HTTP_USER_AGENT'], + "comment_type": comment_type, + "comment":comment } - if user.is_authenticated(): + if request.user.is_authenticated(): data.update({ - "comment_author":request.user.username, - "comment_author_email":request.user.email, - "comment_author_url":request.user.website, + "comment_author":smart_str(request.user.username), + "comment_author_email":request.user.email, + "comment_author_url":request.user.website, }) api = Akismet(settings.WORDPRESS_API_KEY, APP_URL, "OSQA/%s" % OSQA_VERSION) if api.comment_check(comment, data): + post_data = request.POST + captcha_form = SimpleCaptchaForm(request.POST) + if request.is_ajax(): response = { - 'success': False, - 'error_message': _("Sorry, but akismet thinks your %s is spam.") % comment_type + 'success': False, + 'error_message': _("Sorry, but akismet thinks your %s is spam.") % comment_type } - return HttpResponse(simplejson.dumps(response), mimetype="application/json") + return HttpResponse(json.dumps(response), mimetype="application/json") else: - return render_to_response('modules/akismet/foundspam.html', { - 'action_name': comment_type - }) - + captcha_checked = False + try: + if captcha_form.is_valid() and 'recaptcha' in captcha_form.fields.keys(): + captcha_checked = True + except: + pass + + if not captcha_checked: + return render_to_response('modules/akismet/foundspam.html', { + 'action_name': comment_type, + 'post_data' : post_data, + 'captcha_form' : captcha_form, + }, RequestContext(request)) + return origin(request, *args, **kwargs) + return wrapper - + decorate(views.writers.ask)(check_spam('text', _('question'))) decorate(views.writers.answer)(check_spam('text', _('answer'))) decorate(views.commands.comment)(check_spam('comment', _('comment'))) - -