X-Git-Url: https://git.openstreetmap.org./osqa.git/blobdiff_plain/c5bc10247ac31142957ebf9d688993a582635985..22a9abd9db8e94df91a134e1f929de83b20f3c51:/forum/forms.py?ds=inline diff --git a/forum/forms.py b/forum/forms.py index c644b04..0a5afe3 100644 --- a/forum/forms.py +++ b/forum/forms.py @@ -23,71 +23,99 @@ class TitleField(forms.CharField): def clean(self, value): if len(value) < settings.FORM_MIN_QUESTION_TITLE: - raise forms.ValidationError(_('title must be must be at least %s characters' % settings.FORM_MIN_QUESTION_TITLE)) + raise forms.ValidationError(_('title must be must be at least %s characters') % settings.FORM_MIN_QUESTION_TITLE) return value class EditorField(forms.CharField): def __init__(self, *args, **kwargs): super(EditorField, self).__init__(*args, **kwargs) - self.required = True self.widget = forms.Textarea(attrs={'id':'editor'}) self.label = _('content') self.help_text = u'' self.initial = '' + +class QuestionEditorField(EditorField): + def __init__(self, *args, **kwargs): + super(QuestionEditorField, self).__init__(*args, **kwargs) + self.required = not bool(settings.FORM_EMPTY_QUESTION_BODY) + + def clean(self, value): - if len(value) < settings.FORM_MIN_QUESTION_BODY and not settings.FORM_EMPTY_QUESTION_BODY: - raise forms.ValidationError(_('question content must be must be at least %s characters' % settings.FORM_MIN_QUESTION_BODY)) + if self.required and (len(value) < settings.FORM_MIN_QUESTION_BODY): + raise forms.ValidationError(_('question content must be at least %s characters') % settings.FORM_MIN_QUESTION_BODY) return value -class TagNamesField(forms.CharField): +class AnswerEditorField(EditorField): def __init__(self, *args, **kwargs): + super(AnswerEditorField, self).__init__(*args, **kwargs) + self.required = True + + def clean(self, value): + if len(value) < settings.FORM_MIN_QUESTION_BODY: + raise forms.ValidationError(_('answer content must be at least %s characters') % settings.FORM_MIN_QUESTION_BODY) + + return value + + +class TagNamesField(forms.CharField): + def __init__(self, user=None, *args, **kwargs): super(TagNamesField, self).__init__(*args, **kwargs) self.required = True self.widget = forms.TextInput(attrs={'size' : 50, 'autocomplete' : 'off'}) self.max_length = 255 self.label = _('tags') #self.help_text = _('please use space to separate tags (this enables autocomplete feature)') - self.help_text = _('Tags are short keywords, with no spaces within. At least one %(min)s and up to %(max)s tags can be used.') % { - 'min': apnumber(settings.FORM_MIN_NUMBER_OF_TAGS), 'max': apnumber(settings.FORM_MAX_NUMBER_OF_TAGS) + self.help_text = _('Tags are short keywords, with no spaces within. At least %(min)s and up to %(max)s tags can be used.') % { + 'min': settings.FORM_MIN_NUMBER_OF_TAGS, 'max': settings.FORM_MAX_NUMBER_OF_TAGS } self.initial = '' + self.user = user def clean(self, value): value = super(TagNamesField, self).clean(value) - data = value.strip() - if len(data) < 1: - raise forms.ValidationError(_('tags are required')) + data = value.strip().lower() split_re = re.compile(r'[ ,]+') list = split_re.split(data) - list_temp = [] + if len(list) > settings.FORM_MAX_NUMBER_OF_TAGS or len(list) < settings.FORM_MIN_NUMBER_OF_TAGS: - raise forms.ValidationError(_('please use betwen %(min)s and %(max)s tags') % { - 'min': apnumber(settings.FORM_MIN_NUMBER_OF_TAGS), 'max': apnumber(settings.FORM_MAX_NUMBER_OF_TAGS) - }) + raise forms.ValidationError(_('please use between %(min)s and %(max)s tags') % { 'min': settings.FORM_MIN_NUMBER_OF_TAGS, 'max': settings.FORM_MAX_NUMBER_OF_TAGS}) - tagname_re = re.compile(r'[a-z0-9]+') + list_temp = [] + tagname_re = re.compile(r'^[\w+\.-]+$', re.UNICODE) for tag in list: - if len(tag) > 20: - raise forms.ValidationError(_('tags must be shorter than 20 characters')) + if len(tag) > settings.FORM_MAX_LENGTH_OF_TAG or len(tag) < settings.FORM_MIN_LENGTH_OF_TAG: + raise forms.ValidationError(_('please use between %(min)s and %(max)s characters in you tags') % { 'min': settings.FORM_MIN_LENGTH_OF_TAG, 'max': settings.FORM_MAX_LENGTH_OF_TAG}) if not tagname_re.match(tag): - raise forms.ValidationError(_('please use following characters in tags: letters \'a-z\', numbers, and characters \'.-_#\'')) + raise forms.ValidationError(_('please use following characters in tags: letters , numbers, and characters \'.-_\'')) # only keep one same tag if tag not in list_temp and len(tag.strip()) > 0: list_temp.append(tag) + + if settings.LIMIT_TAG_CREATION and not self.user.can_create_tags(): + existent = Tag.objects.filter(name__in=list_temp).values_list('name', flat=True) + + if len(existent) < len(list_temp): + unexistent = [n for n in list_temp if not n in existent] + raise forms.ValidationError(_("You don't have enough reputation to create new tags. The following tags do not exist yet: %s") % + ', '.join(unexistent)) + + return u' '.join(list_temp) class WikiField(forms.BooleanField): - def __init__(self, *args, **kwargs): + def __init__(self, disabled=False, *args, **kwargs): super(WikiField, self).__init__(*args, **kwargs) self.required = False self.label = _('community wiki') self.help_text = _('if you choose community wiki option, the question and answer do not generate points and name of author will not be shown') + if disabled: + self.widget=forms.CheckboxInput(attrs={'disabled': "disabled"}) def clean(self,value): - return value and settings.WIKI_ON + return value class EmailNotifyField(forms.BooleanField): def __init__(self, *args, **kwargs): @@ -113,20 +141,28 @@ class FeedbackForm(forms.Form): class AskForm(forms.Form): title = TitleField() - text = EditorField() - tags = TagNamesField() - wiki = WikiField() + text = QuestionEditorField() + def __init__(self, data=None, user=None, *args, **kwargs): + super(AskForm, self).__init__(data, *args, **kwargs) + + self.fields['tags'] = TagNamesField(user) + + if settings.WIKI_ON: + self.fields['wiki'] = WikiField() class AnswerForm(forms.Form): - text = EditorField() + text = AnswerEditorField() wiki = WikiField() def __init__(self, question, *args, **kwargs): super(AnswerForm, self).__init__(*args, **kwargs) - if question.wiki and settings.WIKI_ON: - self.fields['wiki'].initial = True + if settings.WIKI_ON: + self.fields['wiki'] = WikiField() + + if question.nis.wiki: + self.fields['wiki'].initial = True class RetagQuestionForm(forms.Form): @@ -156,11 +192,10 @@ class RevisionForm(forms.Form): class EditQuestionForm(forms.Form): title = TitleField() - text = EditorField() - tags = TagNamesField() + text = QuestionEditorField() summary = SummaryField() - def __init__(self, question, revision=None, *args, **kwargs): + def __init__(self, question, user, revision=None, *args, **kwargs): super(EditQuestionForm, self).__init__(*args, **kwargs) if revision is None: @@ -168,17 +203,18 @@ class EditQuestionForm(forms.Form): self.fields['title'].initial = revision.title self.fields['text'].initial = revision.body + + self.fields['tags'] = TagNamesField(user) self.fields['tags'].initial = revision.tagnames - - # Once wiki mode is enabled, it can't be disabled - if not question.wiki: - self.fields['wiki'] = WikiField() + + if settings.WIKI_ON: + self.fields['wiki'] = WikiField(disabled=(question.nis.wiki and not user.can_cancel_wiki(question)), initial=question.nis.wiki) class EditAnswerForm(forms.Form): - text = EditorField() + text = AnswerEditorField() summary = SummaryField() - def __init__(self, answer, revision=None, *args, **kwargs): + def __init__(self, answer, user, revision=None, *args, **kwargs): super(EditAnswerForm, self).__init__(*args, **kwargs) if revision is None: @@ -186,6 +222,9 @@ class EditAnswerForm(forms.Form): self.fields['text'].initial = revision.body + if settings.WIKI_ON: + self.fields['wiki'] = WikiField(disabled=(answer.nis.wiki and not user.can_cancel_wiki(answer)), initial=answer.nis.wiki) + class EditUserForm(forms.Form): email = forms.EmailField(label=u'Email', help_text=_('this email does not have to be linked to gravatar'), required=True, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) realname = forms.CharField(label=_('Real name'), required=False, max_length=255, widget=forms.TextInput(attrs={'size' : 35})) @@ -213,9 +252,7 @@ class EditUserForm(forms.Form): self.user = user def clean_email(self): - """For security reason one unique email in database""" if self.user.email != self.cleaned_data['email']: - #todo dry it, there is a similar thing in openidauth if settings.EMAIL_UNIQUE == True: if 'email' in self.cleaned_data: try: