X-Git-Url: https://git.openstreetmap.org./osqa.git/blobdiff_plain/de61afcbf3b458518c743b6f3db8767701b04129..3522d39052cb537bffd978904975e57dc6342467:/forum/views/users.py diff --git a/forum/views/users.py b/forum/views/users.py index 543d5c7..fbde095 100644 --- a/forum/views/users.py +++ b/forum/views/users.py @@ -15,9 +15,9 @@ from django.utils import simplejson from django.core.urlresolvers import reverse from forum.forms import * from forum.utils.html import sanitize_html -from forum.authentication import user_updated -from datetime import date +from datetime import datetime, date import decorators +from forum.actions import EditProfileAction, FavoriteAction, BonusRepAction, SuspendAction import time @@ -26,7 +26,7 @@ USERS_PAGE_SIZE = 35# refactor - move to some constants file def users(request): is_paginated = True sortby = request.GET.get('sort', 'reputation') - suser = request.REQUEST.get('q', "") + suser = request.REQUEST.get('q', "") try: page = int(request.GET.get('page', '1')) except ValueError: @@ -41,11 +41,12 @@ def users(request): objects_list = Paginator(User.objects.all().order_by('username'), USERS_PAGE_SIZE) # default else: - objects_list = Paginator(User.objects.all().order_by('-reputation'), USERS_PAGE_SIZE) + objects_list = Paginator(User.objects.all().order_by('-is_active', '-reputation'), USERS_PAGE_SIZE) base_url = reverse('users') + '?sort=%s&' % sortby else: sortby = "reputation" - objects_list = Paginator(User.objects.filter(username__icontains=suser).order_by('-reputation'), USERS_PAGE_SIZE) + objects_list = Paginator(User.objects.filter(username__icontains=suser).order_by('-reputation'), USERS_PAGE_SIZE + ) base_url = reverse('users') + '?name=%s&sort=%s&' % (suser, sortby) try: @@ -54,56 +55,36 @@ def users(request): users = objects_list.page(objects_list.num_pages) return render_to_response('users/users.html', { - "users" : users, - "suser" : suser, - "keywords" : suser, - "tab_id" : sortby, - "context" : { - 'is_paginated' : is_paginated, - 'pages': objects_list.num_pages, - 'page': page, - 'has_previous': users.has_previous(), - 'has_next': users.has_next(), - 'previous': users.previous_page_number(), - 'next': users.next_page_number(), - 'base_url' : base_url - } - - }, context_instance=RequestContext(request)) - -@login_required -def moderate_user(request, id): - """ajax handler of user moderation - """ - if not request.user.is_superuser or request.method != 'POST': - raise Http404 - if not request.is_ajax(): - return HttpResponseForbidden(mimetype="application/json") - - user = get_object_or_404(User, id=id) - form = ModerateUserForm(request.POST, instance=user) - - if form.is_valid(): - form.save() - logging.debug('data saved') - response = HttpResponse(simplejson.dumps(''), mimetype="application/json") - else: - response = HttpResponseForbidden(mimetype="application/json") - return response + "users" : users, + "suser" : suser, + "keywords" : suser, + "tab_id" : sortby, + "context" : { + 'is_paginated' : is_paginated, + 'pages': objects_list.num_pages, + 'page': page, + 'has_previous': users.has_previous(), + 'has_next': users.has_next(), + 'previous': users.previous_page_number(), + 'next': users.next_page_number(), + 'base_url' : base_url + } + + }, context_instance=RequestContext(request)) def set_new_email(user, new_email, nomessage=False): if new_email != user.email: user.email = new_email user.email_isvalid = False user.save() - #if settings.EMAIL_VALIDATION == 'on': - # send_new_email_key(user,nomessage=nomessage) + #if settings.EMAIL_VALIDATION == 'on': + # send_new_email_key(user,nomessage=nomessage) @login_required def edit_user(request, id): user = get_object_or_404(User, id=id) - if request.user != user: - raise Http404 + if not (request.user.is_superuser or request.user == user): + return HttpResponseForbidden() if request.method == "POST": form = EditUserForm(user, request.POST) if form.is_valid(): @@ -111,116 +92,190 @@ def edit_user(request, id): set_new_email(user, new_email) - #user.username = sanitize_html(form.cleaned_data['username']) + if settings.EDITABLE_SCREEN_NAME: + user.username = sanitize_html(form.cleaned_data['username']) user.real_name = sanitize_html(form.cleaned_data['realname']) user.website = sanitize_html(form.cleaned_data['website']) user.location = sanitize_html(form.cleaned_data['city']) - user.date_of_birth = sanitize_html(form.cleaned_data['birthday']) + user.date_of_birth = form.cleaned_data['birthday'] if user.date_of_birth == "None": - user.date_of_birth = '1900-01-01' + user.date_of_birth = datetime(1900, 1, 1, 0, 0) user.about = sanitize_html(form.cleaned_data['about']) user.save() - # send user updated signal if full fields have been updated - if user.email and user.real_name and user.website and user.location and \ - user.date_of_birth and user.about: - user_updated.send(sender=user.__class__, instance=user, updated_by=user) + EditProfileAction(user=user, ip=request.META['REMOTE_ADDR']).save() + return HttpResponseRedirect(user.get_profile_url()) else: form = EditUserForm(user) return render_to_response('users/edit.html', { - 'form' : form, - 'gravatar_faq_url' : reverse('faq') + '#gravatar', - }, context_instance=RequestContext(request)) + 'user': user, + 'form' : form, + 'gravatar_faq_url' : reverse('faq') + '#gravatar', + }, context_instance=RequestContext(request)) + + +@login_required +def user_powers(request, id, action, status): + if not request.user.is_superuser: + return HttpResponseForbidden() + + user = get_object_or_404(User, id=id) + new_state = action == 'grant' + + if status == 'super': + user.is_superuser = new_state + elif status == 'staff': + user.is_staff = new_state + else: + raise Http404() + + user.save() + return HttpResponseRedirect(user.get_profile_url()) + + +@decorators.command +def award_points(request, id): + if (not request.POST) and request.POST.get('points', None): + raise decorators.CommandException(_("Invalid request type")) + + if not request.user.is_superuser: + raise decorators.CommandException(_("Only superusers are allowed to award reputation points")) + + user = get_object_or_404(User, id=id) + points = int(request.POST['points']) + + extra = dict(message=request.POST.get('message', ''), awarding_user=request.user.id, value=points) + BonusRepAction(user=user, extra=extra).save(data=dict(value=points)) + return dict(reputation=user.reputation) + + +@decorators.command +def suspend(request, id): + user = get_object_or_404(User, id=id) + + if not request.POST: + if user.is_suspended(): + suspension = user.suspension + suspension.cancel(ip=request.META['REMOTE_ADDR']) + return decorators.RefreshPageCommand() + else: + return render_to_response('users/suspend_user.html') + + if not request.user.is_superuser: + raise decorators.CommandException(_("Only superusers can ban other users")) + + data = { + 'bantype': request.POST.get('bantype', 'indefinetly').strip(), + 'publicmsg': request.POST.get('publicmsg', _('Bad behaviour')), + 'privatemsg': request.POST.get('privatemsg', None) or request.POST.get('publicmsg', ''), + 'suspender': request.user.id + } + + if data['bantype'] == 'forxdays': + try: + data['forxdays'] = int(request.POST['forxdays']) + except: + raise decorators.CommandException(_('Invalid numeric argument for the number of days.')) + + SuspendAction(user=user, ip=request.META['REMOTE_ADDR']).save(data=data) + + return decorators.RefreshPageCommand() def user_view(template, tab_name, tab_description, page_title, private=False): def decorator(fn): def decorated(request, id, slug=None): user = get_object_or_404(User, id=id) - if private and not user == request.user: + if private and not (user == request.user or request.user.is_superuser): return HttpResponseForbidden() context = fn(request, user) + + rev_page_title = user.username + " - " + page_title + context.update({ - "tab_name" : tab_name, - "tab_description" : tab_description, - "page_title" : page_title, + "tab_name" : tab_name, + "tab_description" : tab_description, + "page_title" : rev_page_title, + "can_view_private": (user == request.user) or request.user.is_superuser }) return render_to_response(template, context, context_instance=RequestContext(request)) + return decorated + return decorator -@user_view('users/stats.html', 'stats', _('user profile'), _('user profile overview')) +@user_view('users/stats.html', 'stats', _('user profile'), _('user overview')) def user_stats(request, user): - questions = Question.objects.filter(author=user, deleted=False).order_by('-added_at') - answers = Answer.objects.filter(author=user, deleted=False).order_by('-added_at') + questions = Question.objects.filter_state(deleted=False).filter(author=user).order_by('-added_at') + answers = Answer.objects.filter_state(deleted=False).filter(author=user).order_by('-added_at') - up_votes = user.get_up_vote_count() - down_votes = user.get_down_vote_count() + up_votes = user.vote_up_count + down_votes = user.vote_down_count votes_today = user.get_vote_count_today() votes_total = int(settings.MAX_VOTES_PER_DAY) user_tags = Tag.objects.filter(Q(nodes__author=user) | Q(nodes__children__author=user)) \ .annotate(user_tag_usage_count=Count('name')).order_by('-user_tag_usage_count') - awards = Badge.objects.filter(award_badge__user=user).annotate(count=Count('name')).order_by('-count') - - if request.user.is_superuser: - moderate_user_form = ModerateUserForm(instance=user) - else: - moderate_user_form = None - - return {'moderate_user_form': moderate_user_form, - "view_user" : user, - "questions" : questions, - "answers" : answers, - "up_votes" : up_votes, - "down_votes" : down_votes, - "total_votes": up_votes + down_votes, - "votes_today_left": votes_total-votes_today, - "votes_total_per_day": votes_total, - "user_tags" : user_tags[:50], - "awards": awards, - "total_awards" : awards.count(), - } - -@user_view('users/recent.html', 'recent', _('recent user activity'), _('profile - recent activity')) + awards = [(Badge.objects.get(id=b['id']), b['count']) for b in + Badge.objects.filter(awards__user=user).values('id').annotate(count=Count('cls')).order_by('-count')] + + return { + "view_user" : user, + "questions" : questions, + "answers" : answers, + "up_votes" : up_votes, + "down_votes" : down_votes, + "total_votes": up_votes + down_votes, + "votes_today_left": votes_total-votes_today, + "votes_total_per_day": votes_total, + "user_tags" : user_tags[:50], + "awards": awards, + "total_awards" : len(awards), + } + +@user_view('users/recent.html', 'recent', _('recent user activity'), _('recent activity')) def user_recent(request, user): - activities = Activity.objects.filter(activity_type__in=(TYPE_ACTIVITY_PRIZE, - TYPE_ACTIVITY_ASK_QUESTION, TYPE_ACTIVITY_ANSWER, - TYPE_ACTIVITY_COMMENT_QUESTION, TYPE_ACTIVITY_COMMENT_ANSWER, - TYPE_ACTIVITY_MARK_ANSWER), user=user).order_by('-active_at')[:USERS_PAGE_SIZE] + activities = user.actions.exclude( + action_type__in=("voteup", "votedown", "voteupcomment", "flag", "newpage", "editpage")).order_by( + '-action_date')[:USERS_PAGE_SIZE] return {"view_user" : user, "activities" : activities} -@user_view('users/votes.html', 'votes', _('user vote record'), _('profile - votes'), True) +@user_view('users/votes.html', 'votes', _('user vote record'), _('votes'), True) def user_votes(request, user): - votes = user.votes.exclude(node__deleted=True).order_by('-voted_at')[:USERS_PAGE_SIZE] + votes = user.votes.exclude(node__state_string__contains="(deleted").filter( + node__node_type__in=("question", "answer")).order_by('-voted_at')[:USERS_PAGE_SIZE] return {"view_user" : user, "votes" : votes} -@user_view('users/reputation.html', 'reputation', _('user reputation in the community'), _('profile - user reputation')) +@user_view('users/reputation.html', 'reputation', _('user reputation in the community'), _('user reputation')) def user_reputation(request, user): - reputation = user.reputes.order_by('-reputed_at') + rep = list(user.reputes.order_by('date')) + values = [r.value for r in rep] + redux = lambda x, y: x+y graph_data = simplejson.dumps([ - (time.mktime(rep.reputed_at.timetuple()) * 1000, rep.reputation) - for rep in reputation + (time.mktime(rep[i].date.timetuple()) * 1000, reduce(redux, values[:i], 0)) + for i in range(len(values)) ]) - return {"view_user": user, "reputation": reputation, "graph_data": graph_data} + rep = user.reputes.filter(action__canceled=False).order_by('-date')[0:20] + + return {"view_user": user, "reputation": rep, "graph_data": graph_data} -@user_view('users/questions.html', 'favorites', _('favorite questions'), _('profile - favorite questions'), True) +@user_view('users/questions.html', 'favorites', _('favorite questions'), _('favorite questions')) def user_favorites(request, user): - questions = user.favorite_questions.filter(deleted=False) + favorites = FavoriteAction.objects.filter(canceled=False, user=user) - return {"questions" : questions, "view_user" : user} + return {"favorites" : favorites, "view_user" : user} -@user_view('users/subscriptions.html', 'subscriptions', _('subscription settings'), _('profile - subscriptions'), True) +@user_view('users/subscriptions.html', 'subscriptions', _('subscription settings'), _('subscriptions'), True) def user_subscriptions(request, user): if request.method == 'POST': form = SubscriptionSettingsForm(request.POST) @@ -233,13 +288,13 @@ def user_subscriptions(request, user): request.user.message_set.create(message=_('Notifications are now enabled')) else: request.user.message_set.create(message=_('Notifications are now disabled')) - else: - form.is_valid() - for k,v in form.cleaned_data.items(): - setattr(user.subscription_settings, k, v) - user.subscription_settings.save() - request.user.message_set.create(message=_('New subscription settings are now saved')) + form.is_valid() + for k, v in form.cleaned_data.items(): + setattr(user.subscription_settings, k, v) + + user.subscription_settings.save() + request.user.message_set.create(message=_('New subscription settings are now saved')) else: form = SubscriptionSettingsForm(user.subscription_settings.__dict__) @@ -254,7 +309,7 @@ def account_settings(request): is_openid = False return render_to_response('account_settings.html', { - 'msg': msg, - 'is_openid': is_openid - }, context_instance=RequestContext(request)) + 'msg': msg, + 'is_openid': is_openid + }, context_instance=RequestContext(request))