X-Git-Url: https://git.openstreetmap.org./osqa.git/blobdiff_plain/ecd9fa68ea62902f79744b458e4ea2ed95ce00ac..441ed176bdff586e94390740969e103d783bd5f8:/forum/views/users.py diff --git a/forum/views/users.py b/forum/views/users.py index 7202d39..dee69cd 100644 --- a/forum/views/users.py +++ b/forum/views/users.py @@ -7,26 +7,30 @@ from django.contrib.contenttypes.models import ContentType from django.core.urlresolvers import reverse from django.shortcuts import render_to_response, get_object_or_404 from django.template import RequestContext -from django.http import HttpResponse, HttpResponseForbidden, HttpResponseRedirect, Http404 +from django.http import HttpResponse, HttpResponseRedirect, Http404 +from forum.http_responses import HttpResponseUnauthorized from django.utils.translation import ugettext as _ from django.utils.http import urlquote_plus from django.utils.html import strip_tags from django.utils import simplejson -from django.core.urlresolvers import reverse +from django.core.urlresolvers import reverse, NoReverseMatch from forum.forms import * from forum.utils.html import sanitize_html from datetime import datetime, date import decorators -from forum.actions import EditProfileAction, FavoriteAction, BonusRepAction +from forum.actions import EditProfileAction, FavoriteAction, BonusRepAction, SuspendAction +from forum.modules import ui import time +import decorators USERS_PAGE_SIZE = 35# refactor - move to some constants file +@decorators.render('users/users.html', 'users', _('users'), weight=200) def users(request): is_paginated = True sortby = request.GET.get('sort', 'reputation') - suser = request.REQUEST.get('q', "") + suser = request.REQUEST.get('q', "") try: page = int(request.GET.get('page', '1')) except ValueError: @@ -41,11 +45,12 @@ def users(request): objects_list = Paginator(User.objects.all().order_by('username'), USERS_PAGE_SIZE) # default else: - objects_list = Paginator(User.objects.all().order_by('-reputation'), USERS_PAGE_SIZE) + objects_list = Paginator(User.objects.all().order_by('-is_active', '-reputation'), USERS_PAGE_SIZE) base_url = reverse('users') + '?sort=%s&' % sortby else: sortby = "reputation" - objects_list = Paginator(User.objects.filter(username__icontains=suser).order_by('-reputation'), USERS_PAGE_SIZE) + objects_list = Paginator(User.objects.filter(username__icontains=suser).order_by('-reputation'), USERS_PAGE_SIZE + ) base_url = reverse('users') + '?name=%s&sort=%s&' % (suser, sortby) try: @@ -53,43 +58,37 @@ def users(request): except (EmptyPage, InvalidPage): users = objects_list.page(objects_list.num_pages) - return render_to_response('users/users.html', { - "users" : users, - "suser" : suser, - "keywords" : suser, - "tab_id" : sortby, - "context" : { - 'is_paginated' : is_paginated, - 'pages': objects_list.num_pages, - 'page': page, - 'has_previous': users.has_previous(), - 'has_next': users.has_next(), - 'previous': users.previous_page_number(), - 'next': users.next_page_number(), - 'base_url' : base_url - } - - }, context_instance=RequestContext(request)) - -def set_new_email(user, new_email, nomessage=False): - if new_email != user.email: - user.email = new_email - user.email_isvalid = False - user.save() - #if settings.EMAIL_VALIDATION == 'on': - # send_new_email_key(user,nomessage=nomessage) + return { + "users" : users, + "suser" : suser, + "keywords" : suser, + "tab_id" : sortby, + "context" : { + 'is_paginated' : is_paginated, + 'pages': objects_list.num_pages, + 'page': page, + 'has_previous': users.has_previous(), + 'has_next': users.has_next(), + 'previous': users.previous_page_number(), + 'next': users.next_page_number(), + 'base_url' : base_url + } + } + @login_required def edit_user(request, id): user = get_object_or_404(User, id=id) if not (request.user.is_superuser or request.user == user): - return HttpResponseForbidden() + return HttpResponseUnauthorized(request) if request.method == "POST": form = EditUserForm(user, request.POST) if form.is_valid(): new_email = sanitize_html(form.cleaned_data['email']) - set_new_email(user, new_email) + if new_email != user.email: + user.email = new_email + user.email_isvalid = False if settings.EDITABLE_SCREEN_NAME: user.username = sanitize_html(form.cleaned_data['username']) @@ -104,20 +103,21 @@ def edit_user(request, id): user.save() EditProfileAction(user=user, ip=request.META['REMOTE_ADDR']).save() + request.user.message_set.create(message=_("Profile updated.")) return HttpResponseRedirect(user.get_profile_url()) else: form = EditUserForm(user) return render_to_response('users/edit.html', { - 'user': user, - 'form' : form, - 'gravatar_faq_url' : reverse('faq') + '#gravatar', - }, context_instance=RequestContext(request)) + 'user': user, + 'form' : form, + 'gravatar_faq_url' : reverse('faq') + '#gravatar', + }, context_instance=RequestContext(request)) @login_required def user_powers(request, id, action, status): if not request.user.is_superuser: - return HttpResponseForbidden() + return HttpResponseUnauthorized(request) user = get_object_or_404(User, id=id) new_state = action == 'grant' @@ -129,7 +129,7 @@ def user_powers(request, id, action, status): else: raise Http404() - user.save() + user.save() return HttpResponseRedirect(user.get_profile_url()) @@ -151,29 +151,74 @@ def award_points(request, id): return dict(reputation=user.reputation) -def user_view(template, tab_name, tab_description, page_title, private=False): +@decorators.command +def suspend(request, id): + user = get_object_or_404(User, id=id) + + if not request.POST: + if user.is_suspended(): + suspension = user.suspension + suspension.cancel(ip=request.META['REMOTE_ADDR']) + return decorators.RefreshPageCommand() + else: + return render_to_response('users/suspend_user.html') + + if not request.user.is_superuser: + raise decorators.CommandException(_("Only superusers can ban other users")) + + data = { + 'bantype': request.POST.get('bantype', 'indefinetly').strip(), + 'publicmsg': request.POST.get('publicmsg', _('Bad behaviour')), + 'privatemsg': request.POST.get('privatemsg', None) or request.POST.get('publicmsg', ''), + 'suspender': request.user.id + } + + if data['bantype'] == 'forxdays': + try: + data['forxdays'] = int(request.POST['forxdays']) + except: + raise decorators.CommandException(_('Invalid numeric argument for the number of days.')) + + SuspendAction(user=user, ip=request.META['REMOTE_ADDR']).save(data=data) + + return decorators.RefreshPageCommand() + +def user_view(template, tab_name, tab_title, tab_description, private=False, tabbed=True, weight=500): def decorator(fn): def decorated(request, id, slug=None): user = get_object_or_404(User, id=id) if private and not (user == request.user or request.user.is_superuser): - return HttpResponseForbidden() + return HttpResponseUnauthorized(request) context = fn(request, user) - rev_page_title = user.username + " - " + page_title + rev_page_title = user.username + " - " + tab_description context.update({ - "tab_name" : tab_name, - "tab_description" : tab_description, - "page_title" : rev_page_title, - "can_view_private": (user == request.user) or request.user.is_superuser + "active_tab" : tab_name, + "tab_description" : tab_description, + "page_title" : rev_page_title, + "can_view_private": (user == request.user) or request.user.is_superuser }) return render_to_response(template, context, context_instance=RequestContext(request)) + + if tabbed: + def url_getter(vu): + try: + return reverse(fn.__name__, kwargs={'id': vu.id, 'slug': slugify(vu.username)}) + except NoReverseMatch: + return reverse(fn.__name__, kwargs={'id': vu.id}) + + ui.register(ui.PROFILE_TABS, ui.ProfileTab( + tab_name, tab_title, tab_description,url_getter, private, weight + )) + return decorated + return decorator -@user_view('users/stats.html', 'stats', _('user profile'), _('user overview')) -def user_stats(request, user): +@user_view('users/stats.html', 'stats', _('overview'), _('user overview')) +def user_profile(request, user): questions = Question.objects.filter_state(deleted=False).filter(author=user).order_by('-added_at') answers = Answer.objects.filter_state(deleted=False).filter(author=user).order_by('-added_at') @@ -186,58 +231,60 @@ def user_stats(request, user): .annotate(user_tag_usage_count=Count('name')).order_by('-user_tag_usage_count') awards = [(Badge.objects.get(id=b['id']), b['count']) for b in - Badge.objects.filter(awards__user=user).values('id').annotate(count=Count('cls')).order_by('-count')] + Badge.objects.filter(awards__user=user).values('id').annotate(count=Count('cls')).order_by('-count')] return { - "view_user" : user, - "questions" : questions, - "answers" : answers, - "up_votes" : up_votes, - "down_votes" : down_votes, - "total_votes": up_votes + down_votes, - "votes_today_left": votes_total-votes_today, - "votes_total_per_day": votes_total, - "user_tags" : user_tags[:50], - "awards": awards, - "total_awards" : len(awards), - } - -@user_view('users/recent.html', 'recent', _('recent user activity'), _('recent activity')) + "view_user" : user, + "questions" : questions, + "answers" : answers, + "up_votes" : up_votes, + "down_votes" : down_votes, + "total_votes": up_votes + down_votes, + "votes_today_left": votes_total-votes_today, + "votes_total_per_day": votes_total, + "user_tags" : user_tags[:50], + "awards": awards, + "total_awards" : len(awards), + } + +@user_view('users/recent.html', 'recent', _('recent activity'), _('recent user activity')) def user_recent(request, user): - activities = user.actions.exclude(action_type__in=("voteup", "votedown", "voteupcomment", "flag")).order_by('-action_date')[:USERS_PAGE_SIZE] + activities = user.actions.exclude( + action_type__in=("voteup", "votedown", "voteupcomment", "flag", "newpage", "editpage")).order_by( + '-action_date')[:USERS_PAGE_SIZE] return {"view_user" : user, "activities" : activities} -@user_view('users/votes.html', 'votes', _('user vote record'), _('votes'), True) -def user_votes(request, user): - votes = user.votes.exclude(node__state_string__contains="(deleted").filter(node__node_type__in=("question", "answer")).order_by('-voted_at')[:USERS_PAGE_SIZE] - - return {"view_user" : user, "votes" : votes} - - -@user_view('users/reputation.html', 'reputation', _('user reputation in the community'), _('user reputation')) +@user_view('users/reputation.html', 'reputation', _('karma history'), _('graph of user karma')) def user_reputation(request, user): rep = list(user.reputes.order_by('date')) values = [r.value for r in rep] - redux = lambda x, y: x+y + redux = lambda x, y: x+y graph_data = simplejson.dumps([ - (time.mktime(rep[i].date.timetuple()) * 1000, reduce(redux, values[:i], 0)) - for i in range(len(values)) + (time.mktime(rep[i].date.timetuple()) * 1000, reduce(redux, values[:i], 0)) + for i in range(len(values)) ]) rep = user.reputes.filter(action__canceled=False).order_by('-date')[0:20] - + return {"view_user": user, "reputation": rep, "graph_data": graph_data} -@user_view('users/questions.html', 'favorites', _('favorite questions'), _('favorite questions')) +@user_view('users/votes.html', 'votes', _('votes'), _('user vote record'), True) +def user_votes(request, user): + votes = user.votes.exclude(node__state_string__contains="(deleted").filter( + node__node_type__in=("question", "answer")).order_by('-voted_at')[:USERS_PAGE_SIZE] + + return {"view_user" : user, "votes" : votes} + +@user_view('users/questions.html', 'favorites', _('favorites'), _('questions that user selected as his/her favorite')) def user_favorites(request, user): favorites = FavoriteAction.objects.filter(canceled=False, user=user) return {"favorites" : favorites, "view_user" : user} -@user_view('users/subscriptions.html', 'subscriptions', _('subscription settings'), _('subscriptions'), True) +@user_view('users/subscriptions.html', 'subscriptions', _('subscription settings'), _('subscriptions'), True, tabbed=False) def user_subscriptions(request, user): if request.method == 'POST': form = SubscriptionSettingsForm(request.POST) @@ -250,13 +297,13 @@ def user_subscriptions(request, user): request.user.message_set.create(message=_('Notifications are now enabled')) else: request.user.message_set.create(message=_('Notifications are now disabled')) - else: - form.is_valid() - for k,v in form.cleaned_data.items(): - setattr(user.subscription_settings, k, v) - user.subscription_settings.save() - request.user.message_set.create(message=_('New subscription settings are now saved')) + form.is_valid() + for k, v in form.cleaned_data.items(): + setattr(user.subscription_settings, k, v) + + user.subscription_settings.save() + request.user.message_set.create(message=_('New subscription settings are now saved')) else: form = SubscriptionSettingsForm(user.subscription_settings.__dict__) @@ -271,7 +318,7 @@ def account_settings(request): is_openid = False return render_to_response('account_settings.html', { - 'msg': msg, - 'is_openid': is_openid - }, context_instance=RequestContext(request)) + 'msg': msg, + 'is_openid': is_openid + }, context_instance=RequestContext(request))