1 # The ChangesetController is the RESTful interface to Changeset objects
4 class ChangesetsController < ApiController
7 before_action :check_api_writable, :only => [:create, :update, :upload, :subscribe, :unsubscribe]
8 before_action :check_api_readable, :except => [:create, :update, :upload, :download, :query, :subscribe, :unsubscribe]
9 before_action :authorize, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
13 before_action :require_public_data, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
14 before_action :set_request_formats, :except => [:create, :close, :upload]
16 around_action :api_call_handle_error
17 around_action :api_call_timeout, :except => [:upload]
19 # Helper methods for checking consistency
20 include ConsistencyValidations
23 # Return XML giving the basic info about the changeset. Does not
24 # return anything about the nodes, ways and relations in the changeset.
26 @changeset = Changeset.find(params[:id])
27 @include_discussion = params[:include_discussion].presence
30 respond_to do |format|
36 # Create a changeset from XML.
40 cs = Changeset.from_xml(request.raw_post, :create => true)
42 # Assume that Changeset.from_xml has thrown an exception if there is an error parsing the xml
43 cs.user = current_user
46 # Subscribe user to changeset comments
47 cs.subscribers << current_user
49 render :plain => cs.id.to_s
53 # marks a changeset as closed. this may be called multiple times
54 # on the same changeset, so is idempotent.
58 changeset = Changeset.find(params[:id])
59 check_changeset_consistency(changeset, current_user)
61 # to close the changeset, we'll just set its closed_at time to
62 # now. this might not be enough if there are concurrency issues,
63 # but we'll have to wait and see.
64 changeset.set_closed_time_now
71 # Upload a diff in a single transaction.
73 # This means that each change within the diff must succeed, i.e: that
74 # each version number mentioned is still current. Otherwise the entire
75 # transaction *must* be rolled back.
77 # Furthermore, each element in the diff can only reference the current
80 # Returns: a diffResult document, as described in
81 # http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
83 # only allow POST requests, as the upload method is most definitely
84 # not idempotent, as several uploads with placeholder IDs will have
85 # different side-effects.
86 # see http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.2
89 changeset = Changeset.find(params[:id])
90 check_changeset_consistency(changeset, current_user)
92 diff_reader = DiffReader.new(request.raw_post, changeset)
93 Changeset.transaction do
94 result = diff_reader.commit
95 render :xml => result.to_s
100 # download the changeset as an osmChange document.
102 # to make it easier to revert diffs it would be better if the osmChange
103 # format were reversible, i.e: contained both old and new versions of
104 # modified elements. but it doesn't at the moment...
106 # this method cannot order the database changes fully (i.e: timestamp and
107 # version number may be too coarse) so the resulting diff may not apply
108 # to a different database. however since changesets are not atomic this
109 # behaviour cannot be guaranteed anyway and is the result of a design
112 changeset = Changeset.find(params[:id])
114 # get all the elements in the changeset which haven't been redacted
115 # and stick them in a big array.
116 elements = [changeset.old_nodes.unredacted,
117 changeset.old_ways.unredacted,
118 changeset.old_relations.unredacted].flatten
120 # sort the elements by timestamp and version number, as this is the
121 # almost sensible ordering available. this would be much nicer if
122 # global (SVN-style) versioning were used - then that would be
124 elements.sort! do |a, b|
125 if a.timestamp == b.timestamp
126 a.version <=> b.version
128 a.timestamp <=> b.timestamp
132 # generate an output element for each operation. note: we avoid looking
133 # at the history because it is simpler - but it would be more correct to
134 # check these assertions.
139 elements.each do |elt|
141 # first version, so it must be newly-created.
147 # if the element isn't visible then it must have been deleted
152 respond_to do |format|
158 # query changesets by bounding box, time, user or open/closed status.
160 raise OSM::APIBadUserInput, "cannot use order=oldest with time" if params[:time] && params[:order] == "oldest"
162 # find any bounding box
163 bbox = BoundingBox.from_bbox_params(params) if params["bbox"]
165 # create the conditions that the user asked for. some or all of
167 changesets = Changeset.all
168 changesets = conditions_bbox(changesets, bbox)
169 changesets = conditions_user(changesets, params["user"], params["display_name"])
170 changesets = conditions_time(changesets, params["time"])
171 changesets = conditions_open(changesets, params["open"])
172 changesets = conditions_closed(changesets, params["closed"])
173 changesets = conditions_ids(changesets, params["changesets"])
175 # sort the changesets
176 changesets = if params[:order] == "oldest"
177 changesets.order(:created_at => :asc)
179 changesets.order(:created_at => :desc)
183 changesets = changesets.limit(result_limit)
185 # preload users, tags and comments, and render result
186 @changesets = changesets.preload(:user, :changeset_tags, :comments)
189 respond_to do |format|
196 # updates a changeset's tags. none of the changeset's attributes are
197 # user-modifiable, so they will be ignored.
199 # changesets are not (yet?) versioned, so we don't have to deal with
200 # history tables here. changesets are locked to a single user, however.
202 # after succesful update, returns the XML of the changeset.
204 # request *must* be a PUT.
207 @changeset = Changeset.find(params[:id])
208 new_changeset = Changeset.from_xml(request.raw_post)
210 check_changeset_consistency(@changeset, current_user)
211 @changeset.update_from(new_changeset, current_user)
214 respond_to do |format|
221 # Adds a subscriber to the changeset
223 # Check the arguments are sane
224 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
226 # Extract the arguments
227 id = params[:id].to_i
229 # Find the changeset and check it is valid
230 changeset = Changeset.find(id)
231 raise OSM::APIChangesetAlreadySubscribedError, changeset if changeset.subscribers.exists?(current_user.id)
234 changeset.subscribers << current_user
236 # Return a copy of the updated changeset
237 @changeset = changeset
240 respond_to do |format|
247 # Removes a subscriber from the changeset
249 # Check the arguments are sane
250 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
252 # Extract the arguments
253 id = params[:id].to_i
255 # Find the changeset and check it is valid
256 changeset = Changeset.find(id)
257 raise OSM::APIChangesetNotSubscribedError, changeset unless changeset.subscribers.exists?(current_user.id)
259 # Remove the subscriber
260 changeset.subscribers.delete(current_user)
262 # Return a copy of the updated changeset
263 @changeset = changeset
266 respond_to do |format|
274 #------------------------------------------------------------
275 # utility functions below.
276 #------------------------------------------------------------
279 # if a bounding box was specified do some sanity checks.
280 # restrict changesets to those enclosed by a bounding box
281 # we need to return both the changesets and the bounding box
282 def conditions_bbox(changesets, bbox)
284 bbox.check_boundaries
285 bbox = bbox.to_scaled
287 changesets.where("min_lon < ? and max_lon > ? and min_lat < ? and max_lat > ?",
288 bbox.max_lon.to_i, bbox.min_lon.to_i,
289 bbox.max_lat.to_i, bbox.min_lat.to_i)
296 # restrict changesets to those by a particular user
297 def conditions_user(changesets, user, name)
298 if user.nil? && name.nil?
301 # shouldn't provide both name and UID
302 raise OSM::APIBadUserInput, "provide either the user ID or display name, but not both" if user && name
304 # use either the name or the UID to find the user which we're selecting on.
306 # user input checking, we don't have any UIDs < 1
307 raise OSM::APIBadUserInput, "invalid user ID" if user.to_i < 1
309 u = User.find(user.to_i)
311 u = User.find_by(:display_name => name)
314 # make sure we found a user
315 raise OSM::APINotFoundError if u.nil?
317 # should be able to get changesets of public users only, or
318 # our own changesets regardless of public-ness.
319 unless u.data_public?
320 # get optional user auth stuff so that users can see their own
321 # changesets if they're non-public
324 raise OSM::APINotFoundError if current_user.nil? || current_user != u
327 changesets.where(:user_id => u.id)
332 # restrict changes to those closed during a particular time period
333 def conditions_time(changesets, time)
336 elsif time.count(",") == 1
337 # if there is a range, i.e: comma separated, then the first is
338 # low, second is high - same as with bounding boxes.
340 # check that we actually have 2 elements in the array
341 times = time.split(",")
342 raise OSM::APIBadUserInput, "bad time range" if times.size != 2
344 from, to = times.collect { |t| Time.parse(t).utc }
345 changesets.where("closed_at >= ? and created_at <= ?", from, to)
347 # if there is no comma, assume its a lower limit on time
348 changesets.where("closed_at >= ?", Time.parse(time).utc)
350 # stupid Time seems to throw both of these for bad parsing, so
351 # we have to catch both and ensure the correct code path is taken.
352 rescue ArgumentError, RuntimeError => e
353 raise OSM::APIBadUserInput, e.message.to_s
357 # return changesets which are open (haven't been closed yet)
358 # we do this by seeing if the 'closed at' time is in the future. Also if we've
359 # hit the maximum number of changes then it counts as no longer open.
360 # if parameter 'open' is nill then open and closed changesets are returned
361 def conditions_open(changesets, open)
365 changesets.where("closed_at >= ? and num_changes <= ?",
366 Time.now.utc, Changeset::MAX_ELEMENTS)
371 # query changesets which are closed
372 # ('closed at' time has passed or changes limit is hit)
373 def conditions_closed(changesets, closed)
377 changesets.where("closed_at < ? or num_changes > ?",
378 Time.now.utc, Changeset::MAX_ELEMENTS)
383 # query changesets by a list of ids
384 # (either specified as array or comma-separated string)
385 def conditions_ids(changesets, ids)
389 raise OSM::APIBadUserInput, "No changesets were given to search for"
391 ids = ids.split(",").collect(&:to_i)
392 changesets.where(:id => ids)
397 # Get the maximum number of results to return
400 if params[:limit].to_i.positive? && params[:limit].to_i <= Settings.max_changeset_query_limit
403 raise OSM::APIBadUserInput, "Changeset limit must be between 1 and #{Settings.max_changeset_query_limit}"
406 Settings.default_changeset_query_limit