1 # The ChangesetController is the RESTful interface to Changeset objects
4 class ChangesetsController < ApiController
7 before_action :check_api_writable, :only => [:create, :update, :upload, :subscribe, :unsubscribe]
8 before_action :check_api_readable, :except => [:create, :update, :upload, :download, :query, :subscribe, :unsubscribe]
9 before_action :setup_user_auth, :only => [:show]
10 before_action :authorize, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
14 before_action :require_public_data, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
15 before_action :set_request_formats, :except => [:create, :close, :upload]
17 around_action :api_call_handle_error
18 around_action :api_call_timeout, :except => [:upload]
20 # Helper methods for checking consistency
21 include ConsistencyValidations
24 # Return XML giving the basic info about the changeset. Does not
25 # return anything about the nodes, ways and relations in the changeset.
27 @changeset = Changeset.find(params[:id])
28 if params[:include_discussion].presence
29 @comments = @changeset.comments
30 @comments = @comments.unscope(:where => :visible) if params[:show_hidden_comments].presence && can?(:restore, ChangesetComment)
31 @comments = @comments.includes(:author)
35 respond_to do |format|
41 # Create a changeset from XML.
45 cs = Changeset.from_xml(request.raw_post, :create => true)
47 # Assume that Changeset.from_xml has thrown an exception if there is an error parsing the xml
48 cs.user = current_user
51 # Subscribe user to changeset comments
52 cs.subscribe(current_user)
54 render :plain => cs.id.to_s
58 # marks a changeset as closed. this may be called multiple times
59 # on the same changeset, so is idempotent.
63 changeset = Changeset.find(params[:id])
64 check_changeset_consistency(changeset, current_user)
66 # to close the changeset, we'll just set its closed_at time to
67 # now. this might not be enough if there are concurrency issues,
68 # but we'll have to wait and see.
69 changeset.set_closed_time_now
76 # Upload a diff in a single transaction.
78 # This means that each change within the diff must succeed, i.e: that
79 # each version number mentioned is still current. Otherwise the entire
80 # transaction *must* be rolled back.
82 # Furthermore, each element in the diff can only reference the current
85 # Returns: a diffResult document, as described in
86 # http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
88 # only allow POST requests, as the upload method is most definitely
89 # not idempotent, as several uploads with placeholder IDs will have
90 # different side-effects.
91 # see http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.2
94 changeset = Changeset.find(params[:id])
95 check_changeset_consistency(changeset, current_user)
97 diff_reader = DiffReader.new(request.raw_post, changeset)
98 Changeset.transaction do
99 result = diff_reader.commit
100 # the number of changes in this changeset has already been
101 # updated and is visible in this transaction so we don't need
102 # to allow for any more when checking the limit
104 render :xml => result.to_s
109 # download the changeset as an osmChange document.
111 # to make it easier to revert diffs it would be better if the osmChange
112 # format were reversible, i.e: contained both old and new versions of
113 # modified elements. but it doesn't at the moment...
115 # this method cannot order the database changes fully (i.e: timestamp and
116 # version number may be too coarse) so the resulting diff may not apply
117 # to a different database. however since changesets are not atomic this
118 # behaviour cannot be guaranteed anyway and is the result of a design
121 changeset = Changeset.find(params[:id])
123 # get all the elements in the changeset which haven't been redacted
124 # and stick them in a big array.
125 elements = [changeset.old_nodes.unredacted,
126 changeset.old_ways.unredacted,
127 changeset.old_relations.unredacted].flatten
129 # sort the elements by timestamp and version number, as this is the
130 # almost sensible ordering available. this would be much nicer if
131 # global (SVN-style) versioning were used - then that would be
133 elements.sort_by! { |e| [e.timestamp, e.version] }
135 # generate an output element for each operation. note: we avoid looking
136 # at the history because it is simpler - but it would be more correct to
137 # check these assertions.
142 elements.each do |elt|
144 # first version, so it must be newly-created.
150 # if the element isn't visible then it must have been deleted
155 respond_to do |format|
161 # query changesets by bounding box, time, user or open/closed status.
163 raise OSM::APIBadUserInput, "cannot use order=oldest with time" if params[:time] && params[:order] == "oldest"
165 # find any bounding box
166 bbox = BoundingBox.from_bbox_params(params) if params["bbox"]
168 # create the conditions that the user asked for. some or all of
170 changesets = Changeset.all
171 changesets = conditions_bbox(changesets, bbox)
172 changesets = conditions_user(changesets, params["user"], params["display_name"])
173 changesets = conditions_time(changesets, params["time"])
174 changesets = conditions_from_to(changesets, params["from"], params["to"])
175 changesets = conditions_open(changesets, params["open"])
176 changesets = conditions_closed(changesets, params["closed"])
177 changesets = conditions_ids(changesets, params["changesets"])
179 # sort the changesets
180 changesets = if params[:order] == "oldest"
181 changesets.order(:created_at => :asc)
183 changesets.order(:created_at => :desc)
187 changesets = changesets.limit(result_limit)
189 # preload users, tags and comments, and render result
190 @changesets = changesets.preload(:user, :changeset_tags, :comments)
193 respond_to do |format|
200 # updates a changeset's tags. none of the changeset's attributes are
201 # user-modifiable, so they will be ignored.
203 # changesets are not (yet?) versioned, so we don't have to deal with
204 # history tables here. changesets are locked to a single user, however.
206 # after succesful update, returns the XML of the changeset.
208 # request *must* be a PUT.
211 @changeset = Changeset.find(params[:id])
212 new_changeset = Changeset.from_xml(request.raw_post)
214 check_changeset_consistency(@changeset, current_user)
215 @changeset.update_from(new_changeset, current_user)
218 respond_to do |format|
225 # Adds a subscriber to the changeset
227 # Check the arguments are sane
228 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
230 # Extract the arguments
231 id = params[:id].to_i
233 # Find the changeset and check it is valid
234 changeset = Changeset.find(id)
235 raise OSM::APIChangesetAlreadySubscribedError, changeset if changeset.subscribed?(current_user)
238 changeset.subscribe(current_user)
240 # Return a copy of the updated changeset
241 @changeset = changeset
244 respond_to do |format|
251 # Removes a subscriber from the changeset
253 # Check the arguments are sane
254 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
256 # Extract the arguments
257 id = params[:id].to_i
259 # Find the changeset and check it is valid
260 changeset = Changeset.find(id)
261 raise OSM::APIChangesetNotSubscribedError, changeset unless changeset.subscribed?(current_user)
263 # Remove the subscriber
264 changeset.unsubscribe(current_user)
266 # Return a copy of the updated changeset
267 @changeset = changeset
270 respond_to do |format|
278 #------------------------------------------------------------
279 # utility functions below.
280 #------------------------------------------------------------
283 # if a bounding box was specified do some sanity checks.
284 # restrict changesets to those enclosed by a bounding box
285 def conditions_bbox(changesets, bbox)
287 bbox.check_boundaries
288 bbox = bbox.to_scaled
290 changesets.where("min_lon < ? and max_lon > ? and min_lat < ? and max_lat > ?",
291 bbox.max_lon.to_i, bbox.min_lon.to_i,
292 bbox.max_lat.to_i, bbox.min_lat.to_i)
299 # restrict changesets to those by a particular user
300 def conditions_user(changesets, user, name)
301 if user.nil? && name.nil?
304 # shouldn't provide both name and UID
305 raise OSM::APIBadUserInput, "provide either the user ID or display name, but not both" if user && name
307 # use either the name or the UID to find the user which we're selecting on.
309 # user input checking, we don't have any UIDs < 1
310 raise OSM::APIBadUserInput, "invalid user ID" if user.to_i < 1
312 u = User.find_by(:id => user.to_i)
314 u = User.find_by(:display_name => name)
317 # make sure we found a user
318 raise OSM::APINotFoundError if u.nil?
320 # should be able to get changesets of public users only, or
321 # our own changesets regardless of public-ness.
322 unless u.data_public?
323 # get optional user auth stuff so that users can see their own
324 # changesets if they're non-public
327 raise OSM::APINotFoundError if current_user.nil? || current_user != u
330 changesets.where(:user => u)
335 # restrict changesets to those during a particular time period
336 def conditions_time(changesets, time)
339 elsif time.count(",") == 1
340 # if there is a range, i.e: comma separated, then the first is
341 # low, second is high - same as with bounding boxes.
343 # check that we actually have 2 elements in the array
344 times = time.split(",")
345 raise OSM::APIBadUserInput, "bad time range" if times.size != 2
347 from, to = times.collect { |t| Time.parse(t).utc }
348 changesets.where("closed_at >= ? and created_at <= ?", from, to)
350 # if there is no comma, assume its a lower limit on time
351 changesets.where("closed_at >= ?", Time.parse(time).utc)
353 # stupid Time seems to throw both of these for bad parsing, so
354 # we have to catch both and ensure the correct code path is taken.
355 rescue ArgumentError, RuntimeError => e
356 raise OSM::APIBadUserInput, e.message.to_s
360 # restrict changesets to those opened during a particular time period
361 # works similar to from..to of notes controller, including the requirement of 'from' when specifying 'to'
362 def conditions_from_to(changesets, from, to)
365 from = Time.parse(from).utc
367 raise OSM::APIBadUserInput, "Date #{from} is in a wrong format"
377 raise OSM::APIBadUserInput, "Date #{to} is in a wrong format"
380 changesets.where(:created_at => from..to)
387 # return changesets which are open (haven't been closed yet)
388 # we do this by seeing if the 'closed at' time is in the future. Also if we've
389 # hit the maximum number of changes then it counts as no longer open.
390 # if parameter 'open' is nill then open and closed changesets are returned
391 def conditions_open(changesets, open)
395 changesets.where("closed_at >= ? and num_changes <= ?",
396 Time.now.utc, Changeset::MAX_ELEMENTS)
401 # query changesets which are closed
402 # ('closed at' time has passed or changes limit is hit)
403 def conditions_closed(changesets, closed)
407 changesets.where("closed_at < ? or num_changes > ?",
408 Time.now.utc, Changeset::MAX_ELEMENTS)
413 # query changesets by a list of ids
414 # (either specified as array or comma-separated string)
415 def conditions_ids(changesets, ids)
419 raise OSM::APIBadUserInput, "No changesets were given to search for"
421 ids = ids.split(",").collect(&:to_i)
422 changesets.where(:id => ids)
427 # Get the maximum number of results to return
430 if params[:limit].to_i.positive? && params[:limit].to_i <= Settings.max_changeset_query_limit
433 raise OSM::APIBadUserInput, "Changeset limit must be between 1 and #{Settings.max_changeset_query_limit}"
436 Settings.default_changeset_query_limit