1 # The ChangesetController is the RESTful interface to Changeset objects
4 class ChangesetsController < ApiController
8 before_action :authorize, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
12 before_action :require_public_data, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
13 before_action :check_api_writable, :only => [:create, :update, :upload, :subscribe, :unsubscribe]
14 before_action :check_api_readable, :except => [:create, :update, :upload, :download, :query, :subscribe, :unsubscribe]
15 before_action(:only => [:index, :feed]) { |c| c.check_database_readable(true) }
16 around_action :api_call_handle_error
17 around_action :api_call_timeout, :except => [:upload]
19 # Helper methods for checking consistency
20 include ConsistencyValidations
22 # Create a changeset from XML.
26 cs = Changeset.from_xml(request.raw_post, true)
28 # Assume that Changeset.from_xml has thrown an exception if there is an error parsing the xml
29 cs.user = current_user
32 # Subscribe user to changeset comments
33 cs.subscribers << current_user
35 render :plain => cs.id.to_s
39 # Return XML giving the basic info about the changeset. Does not
40 # return anything about the nodes, ways and relations in the changeset.
42 @changeset = Changeset.find(params[:id])
43 @include_discussion = params[:include_discussion].presence
48 # marks a changeset as closed. this may be called multiple times
49 # on the same changeset, so is idempotent.
53 changeset = Changeset.find(params[:id])
54 check_changeset_consistency(changeset, current_user)
56 # to close the changeset, we'll just set its closed_at time to
57 # now. this might not be enough if there are concurrency issues,
58 # but we'll have to wait and see.
59 changeset.set_closed_time_now
66 # insert a (set of) points into a changeset bounding box. this can only
67 # increase the size of the bounding box. this is a hint that clients can
68 # set either before uploading a large number of changes, or changes that
69 # the client (but not the server) knows will affect areas further away.
71 # only allow POST requests, because although this method is
72 # idempotent, there is no "document" to PUT really...
75 cs = Changeset.find(params[:id])
76 check_changeset_consistency(cs, current_user)
78 # keep an array of lons and lats
82 # the request is in pseudo-osm format... this is kind-of an
83 # abuse, maybe should change to some other format?
84 doc = XML::Parser.string(request.raw_post, :options => XML::Parser::Options::NOERROR).parse
85 doc.find("//osm/node").each do |n|
86 lon << n["lon"].to_f * GeoRecord::SCALE
87 lat << n["lat"].to_f * GeoRecord::SCALE
90 # add the existing bounding box to the lon-lat array
91 lon << cs.min_lon unless cs.min_lon.nil?
92 lat << cs.min_lat unless cs.min_lat.nil?
93 lon << cs.max_lon unless cs.max_lon.nil?
94 lat << cs.max_lat unless cs.max_lat.nil?
96 # collapse the arrays to minimum and maximum
102 # save the larger bounding box and return the changeset, which
103 # will include the bigger bounding box.
110 # Upload a diff in a single transaction.
112 # This means that each change within the diff must succeed, i.e: that
113 # each version number mentioned is still current. Otherwise the entire
114 # transaction *must* be rolled back.
116 # Furthermore, each element in the diff can only reference the current
119 # Returns: a diffResult document, as described in
120 # http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
122 # only allow POST requests, as the upload method is most definitely
123 # not idempotent, as several uploads with placeholder IDs will have
124 # different side-effects.
125 # see http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.2
128 changeset = Changeset.find(params[:id])
129 check_changeset_consistency(changeset, current_user)
131 diff_reader = DiffReader.new(request.raw_post, changeset)
132 Changeset.transaction do
133 result = diff_reader.commit
134 render :xml => result.to_s
139 # download the changeset as an osmChange document.
141 # to make it easier to revert diffs it would be better if the osmChange
142 # format were reversible, i.e: contained both old and new versions of
143 # modified elements. but it doesn't at the moment...
145 # this method cannot order the database changes fully (i.e: timestamp and
146 # version number may be too coarse) so the resulting diff may not apply
147 # to a different database. however since changesets are not atomic this
148 # behaviour cannot be guaranteed anyway and is the result of a design
151 changeset = Changeset.find(params[:id])
153 # get all the elements in the changeset which haven't been redacted
154 # and stick them in a big array.
155 elements = [changeset.old_nodes.unredacted,
156 changeset.old_ways.unredacted,
157 changeset.old_relations.unredacted].flatten
159 # sort the elements by timestamp and version number, as this is the
160 # almost sensible ordering available. this would be much nicer if
161 # global (SVN-style) versioning were used - then that would be
163 elements.sort! do |a, b|
164 if a.timestamp == b.timestamp
165 a.version <=> b.version
167 a.timestamp <=> b.timestamp
171 # create changeset and user caches
173 user_display_name_cache = {}
175 # create an osmChange document for the output
176 result = OSM::API.new.get_xml_doc
177 result.root.name = "osmChange"
179 # generate an output element for each operation. note: we avoid looking
180 # at the history because it is simpler - but it would be more correct to
181 # check these assertions.
182 elements.each do |elt|
185 # first version, so it must be newly-created.
186 created = XML::Node.new "create"
187 created << elt.to_xml_node(changeset_cache, user_display_name_cache)
190 modified = XML::Node.new "modify"
191 modified << elt.to_xml_node(changeset_cache, user_display_name_cache)
193 # if the element isn't visible then it must have been deleted
194 deleted = XML::Node.new "delete"
195 deleted << elt.to_xml_node(changeset_cache, user_display_name_cache)
199 render :xml => result.to_s
203 # query changesets by bounding box, time, user or open/closed status.
205 # find any bounding box
206 bbox = BoundingBox.from_bbox_params(params) if params["bbox"]
208 # create the conditions that the user asked for. some or all of
210 changesets = Changeset.all
211 changesets = conditions_bbox(changesets, bbox)
212 changesets = conditions_user(changesets, params["user"], params["display_name"])
213 changesets = conditions_time(changesets, params["time"])
214 changesets = conditions_open(changesets, params["open"])
215 changesets = conditions_closed(changesets, params["closed"])
216 changesets = conditions_ids(changesets, params["changesets"])
218 # sort and limit the changesets
219 changesets = changesets.order("created_at DESC").limit(100)
221 # preload users, tags and comments, and render result
222 @changesets = changesets.preload(:user, :changeset_tags, :comments)
227 # updates a changeset's tags. none of the changeset's attributes are
228 # user-modifiable, so they will be ignored.
230 # changesets are not (yet?) versioned, so we don't have to deal with
231 # history tables here. changesets are locked to a single user, however.
233 # after succesful update, returns the XML of the changeset.
235 # request *must* be a PUT.
238 @changeset = Changeset.find(params[:id])
239 new_changeset = Changeset.from_xml(request.raw_post)
241 check_changeset_consistency(@changeset, current_user)
242 @changeset.update_from(new_changeset, current_user)
247 # Adds a subscriber to the changeset
249 # Check the arguments are sane
250 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
252 # Extract the arguments
253 id = params[:id].to_i
255 # Find the changeset and check it is valid
256 changeset = Changeset.find(id)
257 raise OSM::APIChangesetAlreadySubscribedError, changeset if changeset.subscribers.exists?(current_user.id)
260 changeset.subscribers << current_user
262 # Return a copy of the updated changeset
263 @changeset = changeset
268 # Removes a subscriber from the changeset
270 # Check the arguments are sane
271 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
273 # Extract the arguments
274 id = params[:id].to_i
276 # Find the changeset and check it is valid
277 changeset = Changeset.find(id)
278 raise OSM::APIChangesetNotSubscribedError, changeset unless changeset.subscribers.exists?(current_user.id)
280 # Remove the subscriber
281 changeset.subscribers.delete(current_user)
283 # Return a copy of the updated changeset
284 @changeset = changeset
290 #------------------------------------------------------------
291 # utility functions below.
292 #------------------------------------------------------------
295 # if a bounding box was specified do some sanity checks.
296 # restrict changesets to those enclosed by a bounding box
297 # we need to return both the changesets and the bounding box
298 def conditions_bbox(changesets, bbox)
300 bbox.check_boundaries
301 bbox = bbox.to_scaled
303 changesets.where("min_lon < ? and max_lon > ? and min_lat < ? and max_lat > ?",
304 bbox.max_lon.to_i, bbox.min_lon.to_i,
305 bbox.max_lat.to_i, bbox.min_lat.to_i)
312 # restrict changesets to those by a particular user
313 def conditions_user(changesets, user, name)
314 if user.nil? && name.nil?
317 # shouldn't provide both name and UID
318 raise OSM::APIBadUserInput, "provide either the user ID or display name, but not both" if user && name
320 # use either the name or the UID to find the user which we're selecting on.
322 # user input checking, we don't have any UIDs < 1
323 raise OSM::APIBadUserInput, "invalid user ID" if user.to_i < 1
325 u = User.find(user.to_i)
327 u = User.find_by(:display_name => name)
330 # make sure we found a user
331 raise OSM::APINotFoundError if u.nil?
333 # should be able to get changesets of public users only, or
334 # our own changesets regardless of public-ness.
335 unless u.data_public?
336 # get optional user auth stuff so that users can see their own
337 # changesets if they're non-public
340 raise OSM::APINotFoundError if current_user.nil? || current_user != u
343 changesets.where(:user_id => u.id)
348 # restrict changes to those closed during a particular time period
349 def conditions_time(changesets, time)
352 elsif time.count(",") == 1
353 # if there is a range, i.e: comma separated, then the first is
354 # low, second is high - same as with bounding boxes.
356 # check that we actually have 2 elements in the array
357 times = time.split(/,/)
358 raise OSM::APIBadUserInput, "bad time range" if times.size != 2
360 from, to = times.collect { |t| Time.parse(t) }
361 changesets.where("closed_at >= ? and created_at <= ?", from, to)
363 # if there is no comma, assume its a lower limit on time
364 changesets.where("closed_at >= ?", Time.parse(time))
366 # stupid Time seems to throw both of these for bad parsing, so
367 # we have to catch both and ensure the correct code path is taken.
368 rescue ArgumentError => ex
369 raise OSM::APIBadUserInput, ex.message.to_s
370 rescue RuntimeError => ex
371 raise OSM::APIBadUserInput, ex.message.to_s
375 # return changesets which are open (haven't been closed yet)
376 # we do this by seeing if the 'closed at' time is in the future. Also if we've
377 # hit the maximum number of changes then it counts as no longer open.
378 # if parameter 'open' is nill then open and closed changesets are returned
379 def conditions_open(changesets, open)
383 changesets.where("closed_at >= ? and num_changes <= ?",
384 Time.now.getutc, Changeset::MAX_ELEMENTS)
389 # query changesets which are closed
390 # ('closed at' time has passed or changes limit is hit)
391 def conditions_closed(changesets, closed)
395 changesets.where("closed_at < ? or num_changes > ?",
396 Time.now.getutc, Changeset::MAX_ELEMENTS)
401 # query changesets by a list of ids
402 # (either specified as array or comma-separated string)
403 def conditions_ids(changesets, ids)
407 raise OSM::APIBadUserInput, "No changesets were given to search for"
409 ids = ids.split(",").collect(&:to_i)
410 changesets.where(:id => ids)