change eslint rule no-alert to error

[rails.git] / config / eslint.js

diff --git a/config/eslint.js b/config/eslint.js
index 4e8881727d1cf5ed9faeeb8402512447b6fb0eb0..f70cbc6c057d9eaf8cdeca902d7a9a6d3a6172a7 100644 (file)
--- a/config/eslint.js
+++ b/config/eslint.js
@@ -1,9 +1,11 @@
 const globals = require("globals");
 const js = require("@eslint/js");
 const globals = require("globals");
 const js = require("@eslint/js");

+const erb = require("eslint-plugin-erb");

 const stylisticJs = require("@stylistic/eslint-plugin-js");
 
 module.exports = [
   js.configs.recommended,
 const stylisticJs = require("@stylistic/eslint-plugin-js");
 
 module.exports = [
   js.configs.recommended,

+  erb.configs.recommended,

   {
     plugins: {
       "@stylistic": stylisticJs
   {
     plugins: {
       "@stylistic": stylisticJs


@@ -23,6 +25,15 @@ module.exports = [
         updateLinks: "readonly"
       }
     },
         updateLinks: "readonly"
       }
     },

+    linterOptions: {
+      // The "unused disable directive" is set to "warn" by default.
+      // For the ERB plugin to work correctly, you must disable
+      // this directive to avoid issues described here
+      // https://github.com/eslint/eslint/discussions/18114
+      // If you're using the CLI, you might also use the following flag:
+      // --report-unused-disable-directives-severity=off
+      reportUnusedDisableDirectives: "off"
+    },

     rules: {
       "@stylistic/array-bracket-newline": ["error", "consistent"],
       "@stylistic/array-bracket-spacing": "error",
     rules: {
       "@stylistic/array-bracket-newline": ["error", "consistent"],
       "@stylistic/array-bracket-spacing": "error",


@@ -75,7 +86,7 @@ module.exports = [
       "curly": ["error", "multi-line", "consistent"],
       "dot-notation": "error",
       "eqeqeq": ["error", "smart"],
       "curly": ["error", "multi-line", "consistent"],
       "dot-notation": "error",
       "eqeqeq": ["error", "smart"],

-      "no-alert": "warn",
+      "no-alert": "error",

       "no-array-constructor": "error",
       "no-caller": "error",
       "no-console": "warn",
       "no-array-constructor": "error",
       "no-caller": "error",
       "no-console": "warn",


@@ -100,11 +111,10 @@ module.exports = [
       "no-nested-ternary": "error",
       "no-new": "error",
       "no-new-func": "error",
       "no-nested-ternary": "error",
       "no-new": "error",
       "no-new-func": "error",

-      "no-new-object": "error",

       "no-new-wrappers": "error",
       "no-new-wrappers": "error",

+      "no-object-constructor": "error",

       "no-octal-escape": "error",
       "no-param-reassign": "error",
       "no-octal-escape": "error",
       "no-param-reassign": "error",

-      "no-process-env": "error",

       "no-proto": "error",
       "no-script-url": "error",
       "no-self-compare": "error",
       "no-proto": "error",
       "no-script-url": "error",
       "no-self-compare": "error",