Close a number of holes in the API by making it validate changes

[rails.git] / app / models / trace.rb

diff --git a/app/models/trace.rb b/app/models/trace.rb
index e98b0c67ca33afe2e9358a4832d5597d8e9fbee6..f2dcf9ad9391902c10d81219094abb2c33b2f6c5 100644 (file)
--- a/app/models/trace.rb
+++ b/app/models/trace.rb
@@ -1,12 +1,25 @@
 class Trace < ActiveRecord::Base
   set_table_name 'gpx_files'
 
 class Trace < ActiveRecord::Base
   set_table_name 'gpx_files'
 

-  validates_presence_of :user_id, :name, :public, :description, :timestamp
+  validates_presence_of :user_id, :name, :timestamp
+  validates_presence_of :description, :on => :create

 #  validates_numericality_of :latitude, :longitude
 #  validates_numericality_of :latitude, :longitude

-  validates_inclusion_of :inserted, :in => [ true, false]
+  validates_inclusion_of :public, :inserted, :in => [ true, false]

   
   belongs_to :user
   
   belongs_to :user

-  has_many :tags, :class_name => 'Tracetag', :foreign_key => 'gpx_id', :dependent => :destroy
+  has_many :tags, :class_name => 'Tracetag', :foreign_key => 'gpx_id', :dependent => :delete_all
+  has_many :points, :class_name => 'Tracepoint', :foreign_key => 'gpx_id', :dependent => :delete_all
+
+  def destroy
+    super
+    FileUtils.rm_f(trace_name)
+    FileUtils.rm_f(icon_picture_name)
+    FileUtils.rm_f(large_picture_name)
+  end
+
+  def tagstring
+    return tags.collect {|tt| tt.tag}.join(" ")
+  end

 
   def tagstring=(s)
     self.tags = s.split().collect {|tag|
 
   def tagstring=(s)
     self.tags = s.split().collect {|tag|


@@ -47,12 +60,16 @@ class Trace < ActiveRecord::Base
   
   # FIXME change to permanent filestore area
   def large_picture_name
   
   # FIXME change to permanent filestore area
   def large_picture_name

-    "/tmp/#{id}.gif"
+    "/home/osm/icons/#{id}.gif"

   end
 
   # FIXME change to permanent filestore area
   def icon_picture_name
   end
 
   # FIXME change to permanent filestore area
   def icon_picture_name

-    "/tmp/#{id}_icon.gif"
+    "/home/osm/icons/#{id}_icon.gif"
+  end
+
+  def trace_name
+    "/home/osm/gpx/#{id}.gpx"

   end
 
   def to_xml_node
   end
 
   def to_xml_node


@@ -62,8 +79,85 @@ class Trace < ActiveRecord::Base
     el1['lat'] = self.latitude.to_s
     el1['lon'] = self.longitude.to_s
     el1['user'] = self.user.display_name
     el1['lat'] = self.latitude.to_s
     el1['lon'] = self.longitude.to_s
     el1['user'] = self.user.display_name

-    el1['public'] = self.user.public
+    el1['public'] = self.public.to_s
+    el1['pending'] = (!self.inserted).to_s

     el1['timestamp'] = self.timestamp.xmlschema
     return el1
   end
     el1['timestamp'] = self.timestamp.xmlschema
     return el1
   end

+
+  def import
+    begin
+      logger.info("GPX Import importing #{name} (#{id}) from #{user.email}")
+
+      # TODO *nix specific, could do to work on windows... would be functionally inferior though - check for '.gz'
+      filetype = `file -b #{trace_name}`.chomp
+      gzipped = filetype =~ /^gzip/
+      bzipped = filetype =~ /^bzip2/
+      zipped = filetype =~ /^Zip/
+
+      if gzipped
+        filename = tempfile = "/tmp/#{rand}"
+        system("gunzip -c #{trace_name} > #{filename}")
+      elsif bzipped
+        filename = tempfile = "/tmp/#{rand}"
+        system("bunzip2 -c #{trace_name} > #{filename}")
+      elsif zipped
+        filename = tempfile = "/tmp/#{rand}"
+        system("unzip -p #{trace_name} > #{filename}")
+      else
+        filename = trace_name
+      end
+
+      gpx = OSM::GPXImporter.new(filename)
+
+      f_lat = 0
+      f_lon = 0
+      first = true
+
+      Tracepoint.delete_all(['gpx_id = ?', self.id])
+
+      gpx.points do |point|
+        if first
+          f_lat = point['latitude']
+          f_lon = point['longitude']
+        end
+
+        tp = Tracepoint.new
+        tp.lat = point['latitude'].to_f
+        tp.lng = point['longitude'].to_f
+        tp.altitude = point['altitude'].to_f
+        tp.timestamp = point['timestamp']
+        tp.user_id = user.id
+        tp.gpx_id = id
+        tp.trackid = point['segment'].to_i
+        tp.save!
+      end
+
+      if gpx.actual_points > 0
+        max_lat = Tracepoint.maximum('latitude', :conditions => ['gpx_id = ?', id])
+        min_lat = Tracepoint.minimum('latitude', :conditions => ['gpx_id = ?', id])
+        max_lon = Tracepoint.maximum('longitude', :conditions => ['gpx_id = ?', id])
+        min_lon = Tracepoint.minimum('longitude', :conditions => ['gpx_id = ?', id])
+
+        max_lat = max_lat.to_f / 1000000
+        min_lat = min_lat.to_f / 1000000
+        max_lon = max_lon.to_f / 1000000
+        min_lon = min_lon.to_f / 1000000
+
+        self.latitude = f_lat
+        self.longitude = f_lon
+        self.large_picture = gpx.get_picture(min_lat, min_lon, max_lat, max_lon, gpx.actual_points)
+        self.icon_picture = gpx.get_icon(min_lat, min_lon, max_lat, max_lon)
+        self.size = gpx.actual_points
+        self.inserted = true
+        self.save
+      end
+
+      logger.info "done trace #{id}"
+
+      return gpx
+    ensure
+      FileUtils.rm_f(tempfile) if tempfile
+    end
+  end

 end
 end