Add a redirect and error message if user ends up trying to report something without...

[rails.git] / app / controllers / user_roles_controller.rb

diff --git a/app/controllers/user_roles_controller.rb b/app/controllers/user_roles_controller.rb
index 1cfbaf977b0d5a487f2bba28bd198dc2cfa88c9b..5ef68216bf81e8cc26a53845bf138110edbc1a10 100644 (file)
--- a/app/controllers/user_roles_controller.rb
+++ b/app/controllers/user_roles_controller.rb
@@ -10,12 +10,17 @@ class UserRolesController < ApplicationController
   before_action :in_role, :only => [:revoke]
 
   def grant
   before_action :in_role, :only => [:revoke]
 
   def grant

-    @this_user.roles.create(:role => @role, :granter_id => @user.id)
+    @this_user.roles.create(:role => @role, :granter => current_user)

     redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name
   end
 
   def revoke
     redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name
   end
 
   def revoke

-    UserRole.delete_all(:user_id => @this_user.id, :role => @role)
+    # checks that administrator role is not revoked from current user
+    if current_user == @this_user && @role == "administrator"
+      flash[:error] = t("user_role.filter.not_revoke_admin_current_user")
+    else
+      UserRole.where(:user_id => @this_user.id, :role => @role).delete_all
+    end

     redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name
   end
 
     redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name
   end
 


@@ -25,7 +30,7 @@ class UserRolesController < ApplicationController
   # require that the user is an administrator, or fill out a helpful error message
   # and return them to theuser page.
   def require_administrator
   # require that the user is an administrator, or fill out a helpful error message
   # and return them to theuser page.
   def require_administrator

-    unless @user.administrator?
+    unless current_user.administrator?

       flash[:error] = t "user_role.filter.not_an_administrator"
       redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name
     end
       flash[:error] = t "user_role.filter.not_an_administrator"
       redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name
     end