Facelift offline.html and use Bootstrap classes for "notifications"

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 2527192f9bcf970f4a6bd5c83d82ee9700dd0075..d763c6d469c36ae4c61043a0a38139794646d477 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2022-02-23 19:11:04 UTC using RuboCop version 1.25.1.
+# on 2023-01-03 19:11:30 UTC using RuboCop version 1.42.0.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new


@@ -14,27 +14,15 @@ require:
   - rubocop-rails
   - rubocop-rake
 
   - rubocop-rails
   - rubocop-rake
 

-# Offense count: 550
-# Cop supports --auto-correct.
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 556
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.

 # URISchemes: http, https
 Layout/LineLength:
 # URISchemes: http, https
 Layout/LineLength:

-  Max: 270
+  Max: 248

 
 

-# Offense count: 62
-# Cop supports --auto-correct.
-Lint/AmbiguousOperatorPrecedence:
-  Exclude:
-    - 'app/controllers/geocoder_controller.rb'
-    - 'app/models/user.rb'
-    - 'lib/bounding_box.rb'
-    - 'lib/osm.rb'
-    - 'lib/rich_text.rb'
-    - 'lib/short_link.rb'
-    - 'test/controllers/api/old_nodes_controller_test.rb'
-    - 'test/lib/short_link_test.rb'
-
-# Offense count: 34
+# Offense count: 29
+# This cop supports safe autocorrection (--autocorrect).

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:


@@ -54,27 +42,18 @@ Lint/AssignmentInCondition:
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
     - 'lib/osm.rb'
     - 'script/deliver-message'
 

-# Offense count: 7
-# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
-Lint/DuplicateBranch:
-  Exclude:
-    - 'app/controllers/api_controller.rb'
-    - 'app/controllers/diary_entries_controller.rb'
-    - 'app/controllers/geocoder_controller.rb'
-    - 'app/helpers/browse_tags_helper.rb'
-
-# Offense count: 665
-# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+# Offense count: 681
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.

 Metrics/AbcSize:
   Max: 189
 
 # Offense count: 73
 Metrics/AbcSize:
   Max: 189
 
 # Offense count: 73

-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
-# IgnoredMethods: refine
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# AllowedMethods: refine

 Metrics/BlockLength:
   Max: 71
 
 Metrics/BlockLength:
   Max: 71
 

-# Offense count: 15
+# Offense count: 20

 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5


@@ -82,15 +61,15 @@ Metrics/BlockNesting:
 # Offense count: 25
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
 # Offense count: 25
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:

-  Max: 313
+  Max: 316

 
 

-# Offense count: 58
-# Configuration parameters: IgnoredMethods.
+# Offense count: 60
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.

 Metrics/CyclomaticComplexity:
 Metrics/CyclomaticComplexity:

-  Max: 25
+  Max: 26

 
 

-# Offense count: 742
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# Offense count: 755
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.

 Metrics/MethodLength:
   Max: 179
 
 Metrics/MethodLength:
   Max: 179
 


@@ -99,23 +78,21 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 6
 
 Metrics/ParameterLists:
   Max: 6
 

-# Offense count: 59
-# Configuration parameters: IgnoredMethods.
+# Offense count: 57
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.

 Metrics/PerceivedComplexity:
 Metrics/PerceivedComplexity:

-  Max: 26
+  Max: 27

 
 

-# Offense count: 550
-Minitest/MultipleAssertions:
-  Max: 52
+# Offense count: 2513
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/EmptyLineBeforeAssertionMethods:
+  Enabled: false

 
 

-# Offense count: 3
-Naming/AccessorMethodName:
-  Exclude:
-    - 'app/controllers/application_controller.rb'
-    - 'app/helpers/title_helper.rb'
-    - 'lib/osm.rb'
+# Offense count: 564
+Minitest/MultipleAssertions:
+  Max: 54

 
 

-# Offense count: 8
+# Offense count: 1

 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # ForbiddenPrefixes: is_, has_, have_
 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # ForbiddenPrefixes: is_, has_, have_


@@ -123,12 +100,13 @@ Naming/AccessorMethodName:
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:

-    - 'app/models/changeset.rb'
-    - 'app/models/old_node.rb'
-    - 'app/models/old_relation.rb'
-    - 'app/models/old_way.rb'

     - 'app/models/user.rb'
     - 'app/models/user.rb'

-    - 'lib/classic_pagination/pagination.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ActionControllerFlashBeforeRender:
+  Exclude:
+    - 'app/controllers/traces_controller.rb'

 
 # Offense count: 5
 # Configuration parameters: Database, Include.
 
 # Offense count: 5
 # Configuration parameters: Database, Include.


@@ -170,7 +148,7 @@ Rails/InverseOf:
 
 # Offense count: 2
 # Configuration parameters: Include.
 
 # Offense count: 2
 # Configuration parameters: Include.

-# Include: app/controllers/**/*.rb
+# Include: app/controllers/**/*.rb, app/mailers/**/*.rb

 Rails/LexicallyScopedActionFilter:
   Exclude:
     - 'app/controllers/oauth2_applications_controller.rb'
 Rails/LexicallyScopedActionFilter:
   Exclude:
     - 'app/controllers/oauth2_applications_controller.rb'


@@ -187,29 +165,15 @@ Rails/NotNullColumn:
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 

-# Offense count: 9
+# Offense count: 7

 Rails/OutputSafety:
   Exclude:
 Rails/OutputSafety:
   Exclude:

-    - 'app/controllers/sessions_controller.rb'
-    - 'app/controllers/users_controller.rb'

     - 'app/helpers/application_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
     - 'app/helpers/application_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 

-# Offense count: 26
-# Cop supports --auto-correct.
-Rails/RedundantPresenceValidationOnBelongsTo:
-  Enabled: false
-
-# Offense count: 90
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
-  Enabled: false
-

 # Offense count: 6
 # Offense count: 6

-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).

 Rake/Desc:
   Exclude:
     - 'lib/tasks/auto_annotate_models.rake'
 Rake/Desc:
   Exclude:
     - 'lib/tasks/auto_annotate_models.rake'


@@ -217,15 +181,22 @@ Rake/Desc:
     - 'lib/tasks/subscribe_diary_authors.rake'
     - 'lib/tasks/subscribe_old_changesets.rake'
 
     - 'lib/tasks/subscribe_diary_authors.rake'
     - 'lib/tasks/subscribe_old_changesets.rake'
 

-# Offense count: 617
-# Cop supports --auto-correct.
+# Offense count: 631
+# This cop supports unsafe autocorrection (--autocorrect-all).

 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
 # Offense count: 72
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
 # Offense count: 72

-# Cop supports --auto-correct.
-# Configuration parameters: Strict, AllowedNumbers.
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.

 Style/NumericLiterals:
   MinDigits: 15
 Style/NumericLiterals:
   MinDigits: 15

+
+# Offense count: 110
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: .
+# SupportedOperators: *, +, &, |, ^
+Style/YodaExpression:
+  Enabled: false