Re-introduce additional round trip for verifying auth_provider

[rails.git] / test / models / tracetag_test.rb

diff --git a/test/models/tracetag_test.rb b/test/models/tracetag_test.rb
index 04263dbb74e905e3a65128fdb01409aaf3493564..0d2b17953a6c0e888796f3abee97aa05985f51cc 100644 (file)
--- a/test/models/tracetag_test.rb
+++ b/test/models/tracetag_test.rb
@@ -3,23 +3,23 @@ require "test_helper"
 class TracetagTest < ActiveSupport::TestCase
   def test_validations
     tracetag_valid({})
-    tracetag_valid({ :tag => nil }, false)
-    tracetag_valid({ :tag => "" }, false)
-    tracetag_valid(:tag => "a")
-    tracetag_valid(:tag => "a" * 255)
-    tracetag_valid({ :tag => "a" * 256 }, false)
-    tracetag_valid({ :tag => "a/b" }, false)
-    tracetag_valid({ :tag => "a;b" }, false)
-    tracetag_valid({ :tag => "a.b" }, false)
-    tracetag_valid({ :tag => "a,b" }, false)
-    tracetag_valid({ :tag => "a?b" }, false)
+    tracetag_valid({ :tag => nil }, :valid => false)
+    tracetag_valid({ :tag => "" }, :valid => false)
+    tracetag_valid({ :tag => "a" })
+    tracetag_valid({ :tag => "a" * 255 })
+    tracetag_valid({ :tag => "a" * 256 }, :valid => false)
+    tracetag_valid({ :tag => "a/b" }, :valid => false)
+    tracetag_valid({ :tag => "a;b" }, :valid => false)
+    tracetag_valid({ :tag => "a.b" }, :valid => false)
+    tracetag_valid({ :tag => "a,b" }, :valid => false)
+    tracetag_valid({ :tag => "a?b" }, :valid => false)
   end
 
   private
 
-  def tracetag_valid(attrs, result = true)
+  def tracetag_valid(attrs, valid: true)
     entry = build(:tracetag)
     entry.assign_attributes(attrs)
-    assert_equal result, entry.valid?, "Expected #{attrs.inspect} to be #{result}"
+    assert_equal valid, entry.valid?, "Expected #{attrs.inspect} to be #{valid}"
   end
 end