Merge remote-tracking branch 'upstream/pull/5073'

[rails.git] / app / helpers / open_graph_helper.rb

diff --git a/app/helpers/open_graph_helper.rb b/app/helpers/open_graph_helper.rb
index ab7e230cbec768a7745192934bc5d7ebb40965b1..b3f0ab92849e81be230992c0e3ff1f524258cc64 100644 (file)
--- a/app/helpers/open_graph_helper.rb
+++ b/app/helpers/open_graph_helper.rb
@@ -1,17 +1,38 @@
 module OpenGraphHelper
-  def opengraph_tags(title = nil)
+  require "addressable/uri"
+
+  def opengraph_tags(title, properties)
     tags = {
       "og:site_name" => t("layouts.project_name.title"),
-      "og:title" => [t("layouts.project_name.title"), title].compact.join(" | "),
+      "og:title" => title || t("layouts.project_name.title"),
       "og:type" => "website",
-      "og:image" => image_url("osm_logo_256.png", :protocol => "http"),
-      "og:image:secure_url" => image_url("osm_logo_256.png", :protocol => "https"),
       "og:url" => url_for(:only_path => false),
-      "og:description" => t("layouts.intro_text")
-    }
+      "og:description" => properties["og:description"] || t("layouts.intro_text")
+    }.merge(
+      opengraph_image_properties(properties)
+    )
+
+    safe_join(tags.map do |property, content|
+      tag.meta(:property => property, :content => content)
+    end, "\n")
+  end
+
+  private
 
-    tags.map do |property, content|
-      tag(:meta, :property => property, :content => content)
-    end.join("").html_safe
+  def opengraph_image_properties(properties)
+    begin
+      if properties["og:image"]
+        image_properties = {}
+        image_properties["og:image"] = Addressable::URI.join(root_url, properties["og:image"]).normalize
+        image_properties["og:image:alt"] = properties["og:image:alt"] if properties["og:image:alt"]
+        return image_properties
+      end
+    rescue Addressable::URI::InvalidURIError
+      # return default image
+    end
+    {
+      "og:image" => image_url("osm_logo_256.png"),
+      "og:image:alt" => t("layouts.logo.alt_text")
+    }
   end
 end