Merge pull request #5295 from tomhughes/danger-branches

[rails.git] / .rubocop.yml

diff --git a/.rubocop.yml b/.rubocop.yml
index 477b2ab02c152e3af3488a62eb8c0b79040d1db3..8b6ed018032c66c116e4b08fe6ba697e9c608a9d 100644 (file)
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,64 +1,112 @@
 inherit_from: .rubocop_todo.yml
 
 inherit_from: .rubocop_todo.yml
 

+require:
+  - rubocop-capybara
+  - rubocop-factory_bot
+  - rubocop-minitest
+  - rubocop-performance
+  - rubocop-rails
+  - rubocop-rake
+

 AllCops:
 AllCops:

-  Include:
-    - '**/*.gemspec'
-    - '**/*.podspec'
-    - '**/*.jbuilder'
-    - '**/*.rake'
-    - '**/*.opal'
-    - '**/config.ru'
-    - '**/Gemfile'
-    - '**/Rakefile'
-    - '**/Capfile'
-    - '**/Guardfile'
-    - '**/Podfile'
-    - '**/Thorfile'
-    - '**/Vagrantfile'
-    - '**/Berksfile'
-    - '**/Cheffile'
-    - '**/Vagabondfile'
-    - '**/Fastfile'
-    - '**/*.builder'
+  TargetRubyVersion: 3.1
+  NewCops: enable
+  Exclude:
+    - 'vendor/**/*'

 
 Rails:
   Enabled: true
 
 
 Rails:
   Enabled: true
 

-Style/BracesAroundHashParameters:
-  EnforcedStyle: context_dependent
-
-Style/ExtraSpacing:
+Layout/ExtraSpacing:

   AllowForAlignment: true
 
   AllowForAlignment: true
 

-Style/FileName:
+Lint/PercentStringArray:
+  Exclude:
+    - 'config/initializers/secure_headers.rb'
+    - 'app/controllers/application_controller.rb'
+    - 'app/controllers/site_controller.rb'
+
+Metrics/BlockLength:
+  Exclude:
+    - 'config/routes.rb'
+
+Metrics/ClassLength:
+  Exclude:
+    - 'test/**/*'
+
+Metrics/ModuleLength:
+  Max: 150
+
+Naming/FileName:

   Exclude:
     - 'script/deliver-message'
   Exclude:
     - 'script/deliver-message'

-    - 'script/locale/reload-languages'

     - 'script/update-spam-blocks'
 
     - 'script/update-spam-blocks'
 

-Style/IfInsideElse:
+Naming/MethodParameterName:
+  Enabled: false
+
+# This conflicts with Strong Migrations, which can't check `change_table`
+Rails/BulkChangeTable:
+  Enabled: false
+
+Rails/CreateTableWithTimestamps:
+  Enabled: false
+
+Rails/FindBy:
+  IgnoreWhereFirst: false
+
+Rails/FindEach:
+  Enabled: false
+
+Rails/HasManyOrHasOneDependent:
+  Enabled: false
+
+Rails/HttpPositionalArguments:
+  Enabled: false
+
+Rails/ReflectionClassName:
+  Enabled: false
+
+Rails/SkipsModelValidations:
+  Exclude:
+    - 'db/migrate/*.rb'
+    - 'app/controllers/users_controller.rb'
+
+Style/Documentation:

   Enabled: false
 
   Enabled: false
 

-Style/GlobalVars:
+Style/FormatStringToken:

   Exclude:
   Exclude:

-    - 'lib/quad_tile/extconf.rb'
+    - 'config/routes.rb'
+
+Style/IfInsideElse:
+  Enabled: false

 
 Style/GuardClause:
   Enabled: false
 
 
 Style/GuardClause:
   Enabled: false
 

+Style/HashEachMethods:
+  Enabled: true
+

 Style/HashSyntax:
   EnforcedStyle: hash_rockets
   Exclude:
     - 'lib/tasks/testing.rake'
     - 'config/initializers/wrap_parameters.rb'
 
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
   Exclude:
     - 'lib/tasks/testing.rake'
     - 'config/initializers/wrap_parameters.rb'
 

-Style/StringLiterals:
-  EnforcedStyle: double_quotes
+Style/HashTransformKeys:
+  Enabled: true

 
 

-Rails/HttpPositionalArguments:
-  Enabled: false
+Style/HashTransformValues:
+  Enabled: true

 
 

-Rails/SkipsModelValidations:
+Style/MixinUsage:

   Exclude:
   Exclude:

-    - 'db/migrate/*.rb'
-    - 'app/controllers/user_controller.rb'
+    - 'bin/setup'
+    - 'bin/update'
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/SymbolArray:
+  EnforcedStyle: brackets