- ##
- # tests whether the API works and prevents incorrect use while trying
- # to update nodes.
- def test_update
- ## First test with no user credentials
- # try and update a node without authorisation
- # first try to delete node without auth
- private_user = create(:user, :data_public => false)
- private_node = create(:node, :changeset => create(:changeset, :user => private_user))
- user = create(:user)
- node = create(:node, :changeset => create(:changeset, :user => user))
-
- content node.to_xml
- put :update, :params => { :id => node.id }
- assert_response :unauthorized
-
- ## Second test with the private user
-
- # setup auth
- basic_authorization private_user.email, "test"
-
- ## trying to break changesets
-
- # try and update in someone else's changeset
- content update_changeset(private_node.to_xml,
- create(:changeset).id)
- put :update, :params => { :id => private_node.id }
- assert_require_public_data "update with other user's changeset should be forbidden when data isn't public"
-
- # try and update in a closed changeset
- content update_changeset(private_node.to_xml,
- create(:changeset, :closed, :user => private_user).id)
- put :update, :params => { :id => private_node.id }
- assert_require_public_data "update with closed changeset should be forbidden, when data isn't public"
-
- # try and update in a non-existant changeset
- content update_changeset(private_node.to_xml, 0)
- put :update, :params => { :id => private_node.id }
- assert_require_public_data "update with changeset=0 should be forbidden, when data isn't public"
-
- ## try and submit invalid updates
- content xml_attr_rewrite(private_node.to_xml, "lat", 91.0)
- put :update, :params => { :id => private_node.id }
- assert_require_public_data "node at lat=91 should be forbidden, when data isn't public"
-
- content xml_attr_rewrite(private_node.to_xml, "lat", -91.0)
- put :update, :params => { :id => private_node.id }
- assert_require_public_data "node at lat=-91 should be forbidden, when data isn't public"
-
- content xml_attr_rewrite(private_node.to_xml, "lon", 181.0)
- put :update, :params => { :id => private_node.id }
- assert_require_public_data "node at lon=181 should be forbidden, when data isn't public"
-
- content xml_attr_rewrite(private_node.to_xml, "lon", -181.0)
- put :update, :params => { :id => private_node.id }
- assert_require_public_data "node at lon=-181 should be forbidden, when data isn't public"
-
- ## finally, produce a good request which still won't work
- content private_node.to_xml
- put :update, :params => { :id => private_node.id }
- assert_require_public_data "should have failed with a forbidden when data isn't public"
-
- ## Finally test with the public user
-
- # try and update a node without authorisation
- # first try to update node without auth
- content node.to_xml
- put :update, :params => { :id => node.id }
- assert_response :forbidden
-
- # setup auth
- basic_authorization user.email, "test"
-
- ## trying to break changesets
-
- # try and update in someone else's changeset
- content update_changeset(node.to_xml,
- create(:changeset).id)
- put :update, :params => { :id => node.id }
- assert_response :conflict, "update with other user's changeset should be rejected"
-
- # try and update in a closed changeset
- content update_changeset(node.to_xml,
- create(:changeset, :closed, :user => user).id)
- put :update, :params => { :id => node.id }
- assert_response :conflict, "update with closed changeset should be rejected"
-
- # try and update in a non-existant changeset
- content update_changeset(node.to_xml, 0)
- put :update, :params => { :id => node.id }
- assert_response :conflict, "update with changeset=0 should be rejected"
-
- ## try and submit invalid updates
- content xml_attr_rewrite(node.to_xml, "lat", 91.0)
- put :update, :params => { :id => node.id }
- assert_response :bad_request, "node at lat=91 should be rejected"
-
- content xml_attr_rewrite(node.to_xml, "lat", -91.0)
- put :update, :params => { :id => node.id }
- assert_response :bad_request, "node at lat=-91 should be rejected"
-
- content xml_attr_rewrite(node.to_xml, "lon", 181.0)
- put :update, :params => { :id => node.id }
- assert_response :bad_request, "node at lon=181 should be rejected"
-
- content xml_attr_rewrite(node.to_xml, "lon", -181.0)
- put :update, :params => { :id => node.id }
- assert_response :bad_request, "node at lon=-181 should be rejected"
-
- ## next, attack the versioning
- current_node_version = node.version
-
- # try and submit a version behind
- content xml_attr_rewrite(node.to_xml,
- "version", current_node_version - 1)
- put :update, :params => { :id => node.id }
- assert_response :conflict, "should have failed on old version number"
-
- # try and submit a version ahead
- content xml_attr_rewrite(node.to_xml,
- "version", current_node_version + 1)
- put :update, :params => { :id => node.id }
- assert_response :conflict, "should have failed on skipped version number"
-
- # try and submit total crap in the version field
- content xml_attr_rewrite(node.to_xml,
- "version", "p1r4t3s!")
- put :update, :params => { :id => node.id }
- assert_response :conflict,
- "should not be able to put 'p1r4at3s!' in the version field"
-
- ## try an update with the wrong ID
- content create(:node).to_xml
- put :update, :params => { :id => node.id }
- assert_response :bad_request,
- "should not be able to update a node with a different ID from the XML"
-
- ## try an update with a minimal valid XML doc which isn't a well-formed OSM doc.
- content "<update/>"
- put :update, :params => { :id => node.id }
- assert_response :bad_request,
- "should not be able to update a node with non-OSM XML doc."
-
- ## finally, produce a good request which should work
- content node.to_xml
- put :update, :params => { :id => node.id }
- assert_response :success, "a valid update request failed"
- end
-
- ##
- # test fetching multiple nodes
- def test_nodes
- node1 = create(:node)
- node2 = create(:node, :deleted)
- node3 = create(:node)
- node4 = create(:node, :with_history, :version => 2)
- node5 = create(:node, :deleted, :with_history, :version => 2)
-
- # check error when no parameter provided
- get :nodes
- assert_response :bad_request
-
- # check error when no parameter value provided
- get :nodes, :params => { :nodes => "" }
- assert_response :bad_request
-
- # test a working call
- get :nodes, :params => { :nodes => "#{node1.id},#{node2.id},#{node3.id},#{node4.id},#{node5.id}" }
- assert_response :success
- assert_select "osm" do
- assert_select "node", :count => 5
- assert_select "node[id='#{node1.id}'][visible='true']", :count => 1
- assert_select "node[id='#{node2.id}'][visible='false']", :count => 1
- assert_select "node[id='#{node3.id}'][visible='true']", :count => 1
- assert_select "node[id='#{node4.id}'][visible='true']", :count => 1
- assert_select "node[id='#{node5.id}'][visible='false']", :count => 1
projects / rails.git / blobdiff