Refactor user creation actions

[rails.git] / app / controllers / way_controller.rb

diff --git a/app/controllers/way_controller.rb b/app/controllers/way_controller.rb
index c3ffe3c0f457f488c899c2fbd2f1bf67858e4f22..6ea27deafa2a24a2226efaf7deb3cdb30a8e0b9c 100644 (file)
--- a/app/controllers/way_controller.rb
+++ b/app/controllers/way_controller.rb
@@ -19,7 +19,7 @@ class WayController < ApplicationController
       way.create_with_history @user
       render :text => way.id.to_s, :content_type => "text/plain"
     else
       way.create_with_history @user
       render :text => way.id.to_s, :content_type => "text/plain"
     else

-      render :nothing => true, :status => :bad_request
+      render :text => "", :status => :bad_request

     end
   end
 
     end
   end
 


@@ -43,7 +43,7 @@ class WayController < ApplicationController
       way.update_from(new_way, @user)
       render :text => way.version.to_s, :content_type => "text/plain"
     else
       way.update_from(new_way, @user)
       render :text => way.version.to_s, :content_type => "text/plain"
     else

-      render :nothing => true, :status => :bad_request
+      render :text => "", :status => :bad_request

     end
   end
 
     end
   end
 


@@ -56,7 +56,7 @@ class WayController < ApplicationController
       way.delete_with_history!(new_way, @user)
       render :text => way.version.to_s, :content_type => "text/plain"
     else
       way.delete_with_history!(new_way, @user)
       render :text => way.version.to_s, :content_type => "text/plain"
     else

-      render :nothing => true, :status => :bad_request
+      render :text => "", :status => :bad_request

     end
   end
 
     end
   end
 


@@ -64,6 +64,7 @@ class WayController < ApplicationController
     way = Way.includes(:nodes => :node_tags).find(params[:id])
     
     if way.visible
     way = Way.includes(:nodes => :node_tags).find(params[:id])
     
     if way.visible

+      visible_nodes = {}

       changeset_cache = {}
       user_display_name_cache = {}
 
       changeset_cache = {}
       user_display_name_cache = {}
 


@@ -71,9 +72,10 @@ class WayController < ApplicationController
       way.nodes.uniq.each do |node|
         if node.visible
           doc.root << node.to_xml_node(changeset_cache, user_display_name_cache)
       way.nodes.uniq.each do |node|
         if node.visible
           doc.root << node.to_xml_node(changeset_cache, user_display_name_cache)

+          visible_nodes[node.id] = node

         end
       end
         end
       end

-      doc.root << way.to_xml_node(nil, changeset_cache, user_display_name_cache)
+      doc.root << way.to_xml_node(visible_nodes, changeset_cache, user_display_name_cache)

       
       render :text => doc.to_s, :content_type => "text/xml"
     else
       
       render :text => doc.to_s, :content_type => "text/xml"
     else


@@ -97,7 +99,7 @@ class WayController < ApplicationController
 
       render :text => doc.to_s, :content_type => "text/xml"
     else
 
       render :text => doc.to_s, :content_type => "text/xml"
     else

-      render :nothing => true, :status => :bad_request
+      render :text => "", :status => :bad_request

     end
   end
 
     end
   end