Prefer keyword arguments when method has optional boolean arguments

[rails.git] / app / views / users / terms.html.erb

diff --git a/app/views/users/terms.html.erb b/app/views/users/terms.html.erb
index 18b86dd12582aa50c9415928dd9b0dfbf0ef2641..bc8b86ef2256a269e25b0a6f8401fb419d3ea166 100644 (file)
--- a/app/views/users/terms.html.erb
+++ b/app/views/users/terms.html.erb
@@ -7,20 +7,20 @@
   <div class='header-illustration new-user-terms'></div>
 <% end %>
 
   <div class='header-illustration new-user-terms'></div>
 <% end %>
 

-<%= form_tag({ :action => "save" }, { :class => " inner22 standard-form fillL" }) do %>
+<%= form_tag({ :action => "save" }, { :class => "standard-form fillL" }) do %>

   <!-- legale is <%= @legale %> -->
   <!-- legale is <%= @legale %> -->

-  <p class="deemphasize"><%= t '.read and accept' %></p>
-  <label class="standard-label">
-    <%= t '.heading_ct' %>
-  </label>
-  <div class='form-row horizontal-list'>
-    <p class="deemphasize"><%= t '.contributor_terms_explain' %></p>
+  <p class="text-muted"><%= t ".read and accept with tou" %></p>
+  <h4>
+    <%= t ".heading_ct" %>
+  </h4>
+  <div class='standard-form-row horizontal-list clearfix'>
+    <p class="text-muted"><%= t ".contributor_terms_explain" %></p>

     <label class="standard-label">
       <%= t ".legale_select" %>
     </label>
 
     <% [%w[france FR], %w[italy IT], %w[rest_of_world GB]].each do |name, legale| %>
     <label class="standard-label">
       <%= t ".legale_select" %>
     </label>
 
     <% [%w[france FR], %w[italy IT], %w[rest_of_world GB]].each do |name, legale| %>

-      <div class="form-row">
+      <div class="standard-form-row">

         <label for="legale_<%= legale %>">
           <%= radio_button_tag "legale", legale, @legale == legale, :data => { :url => url_for(:legale => legale) } %>
           <%= t(".legale_names." + name) %>
         <label for="legale_<%= legale %>">
           <%= radio_button_tag "legale", legale, @legale == legale, :data => { :url => url_for(:legale => legale) } %>
           <%= t(".legale_names." + name) %>


@@ -29,40 +29,46 @@
     <% end %>
   </div>
 
     <% end %>
   </div>
 

-  <div id="contributorTerms" class="col12 legale">
+  <div id="contributorTerms" class="legale">

     <%= render :partial => "terms" %>
   </div>
 
     <%= render :partial => "terms" %>
   </div>
 

-  <div class="deemphasize">
-    <p id="contributorGuidance">
-      <%= raw t '.guidance',
-                :summary => 'https://www.osmfoundation.org/wiki/License/Contributor_Terms_Summary',
-                :translations => 'https://www.osmfoundation.org/wiki/License/Contributor_Terms/Informal_Translations' %>
+  <div>
+    <p id="contributorGuidance" class="text-muted">
+      <%= t ".guidance_html",
+            :summary => "https://www.osmfoundation.org/wiki/License/Contributor_Terms_Summary",
+            :translations => "https://www.osmfoundation.org/wiki/License/Contributor_Terms/Informal_Translations" %>

     </p>
   </div>
     </p>
   </div>

+  <div class="standard-form-row">
+    <label for="read_ct">
+      <%= check_box_tag "read_ct" %>
+      <%= t ".read_ct" %>
+    </label>
+  </div>

 
 

-  <label class="standard-label">
-    <%= t 'layouts.tou' %>
-  </label>
-  <p class="deemphasize"><%= t '.tou_explain' %></p>
-  <div class="form-row">
+  <h4>
+    <%= t "layouts.tou" %>
+  </h4>
+  <p class="text-muted"><%= t ".tou_explain_html", :tou_link => link_to(t("layouts.tou"), "https://wiki.osmfoundation.org/wiki/Terms_of_Use", :target => :new) %></p>
+  <div class="standard-form-row">

     <label for="read_tou">
     <label for="read_tou">

-      <%= check_box_tag 'read_tou',1,false,:onclick=>"agreebtn = document.getElementById('agree');agreebtn.disabled=!this.checked;"%>
-      <%= t '.read_tou_html', :tou_link => link_to(t('layouts.tou'), "https://wiki.osmfoundation.org/wiki/Terms_of_Use", :target => :new) %>
+      <%= check_box_tag "read_tou" %>
+      <%= t ".read_tou" %>

     </label>
 
     <%= hidden_field_tag("referer", h(params[:referer])) unless params[:referer].nil? %>
 
     </label>
 
     <%= hidden_field_tag("referer", h(params[:referer])) unless params[:referer].nil? %>
 

-    <div class="buttons form-row inner20 clearfix">
-      <%= submit_tag(t('.agree'), :name => "agree", :id => "agree", disabled: true)  %>
-      <%= submit_tag(t('.decline'), :name => "decline", :id => "decline") %>
+    <div class="buttons standard-form-row py-3 clearfix">
+      <%= submit_tag("Continue", :name => "continue", :id => "continue", :disabled => true) %>
+      <%= submit_tag("Cancel", :name => "decline", :id => "decline") %>

     </div>
 
     <label for="user_consider_pd">
     </div>
 
     <label for="user_consider_pd">

-      <%= check_box('user', 'consider_pd') %>
-      <%= t '.consider_pd' %>
+      <%= check_box("user", "consider_pd") %>
+      <%= t ".consider_pd" %>

     </label>
     </label>

-    <span class="minorNote">(<%= link_to(t('.consider_pd_why'), t('.consider_pd_why_url'), :target => :new)%>)</span>
+    <span class="minorNote">(<%= link_to(t(".consider_pd_why"), t(".consider_pd_why_url"), :target => :new) %>)</span>

 
   </div>
 <% end %>
 
   </div>
 <% end %>