Disallow username changes to user_n if n isn't their id

[rails.git] / test / models / user_test.rb

diff --git a/test/models/user_test.rb b/test/models/user_test.rb
index 50615233f971098bb67f892569d099a0e0f45c17..c2571d0c0aaf785e64a522e98571af267ecc27bd 100644 (file)
--- a/test/models/user_test.rb
+++ b/test/models/user_test.rb
@@ -91,6 +91,28 @@ class UserTest < ActiveSupport::TestCase
     end
   end
 
     end
   end
 

+  def test_display_name_user_id_new
+    existing_user = create(:user)
+    user = build(:user)
+
+    user.display_name = "user_#{existing_user.id}"
+    assert_not user.valid?, "user_<id> name is valid for existing user id when it shouldn't be"
+
+    user.display_name = "user_#{existing_user.id + 1}"
+    assert_not user.valid?, "user_<id> name is valid for new user id when it shouldn't be"
+  end
+
+  def test_display_name_user_id_rename
+    existing_user = create(:user)
+    user = create(:user)
+
+    user.display_name = "user_#{existing_user.id}"
+    assert_not user.valid?, "user_<id> name is valid for existing user id when it shouldn't be"
+
+    user.display_name = "user_#{user.id}"
+    assert_predicate user, :valid?, "user_<id> name is invalid for own id, when it should be"
+  end
+

   def test_friends_with
     alice = create(:user, :active)
     bob = create(:user, :active)
   def test_friends_with
     alice = create(:user, :active)
     bob = create(:user, :active)


@@ -239,11 +261,11 @@ class UserTest < ActiveSupport::TestCase
     assert_predicate create(:administrator_user), :administrator?
   end
 
     assert_predicate create(:administrator_user), :administrator?
   end
 

-  def test_has_role?
-    assert_not create(:user).has_role?("administrator")
-    assert_not create(:user).has_role?("moderator")
-    assert create(:administrator_user).has_role?("administrator")
-    assert create(:moderator_user).has_role?("moderator")
+  def test_role?
+    assert_not create(:user).role?("administrator")
+    assert_not create(:user).role?("moderator")
+    assert create(:administrator_user).role?("administrator")
+    assert create(:moderator_user).role?("moderator")

   end
 
   def test_soft_destroy
   end
 
   def test_soft_destroy


@@ -259,7 +281,7 @@ class UserTest < ActiveSupport::TestCase
     assert_not user.active?
   end
 
     assert_not user.active?
   end
 

-  def test_soft_destroy_revokes_access_tokens
+  def test_soft_destroy_revokes_oauth1_tokens

     user = create(:user)
     access_token = create(:access_token, :user => user)
     assert_equal 1, user.oauth_tokens.authorized.count
     user = create(:user)
     access_token = create(:access_token, :user => user)
     assert_equal 1, user.oauth_tokens.authorized.count


@@ -271,7 +293,7 @@ class UserTest < ActiveSupport::TestCase
     assert_predicate access_token, :invalidated?
   end
 
     assert_predicate access_token, :invalidated?
   end
 

-  def test_soft_destroy_revokes_oauth_access_tokens
+  def test_soft_destroy_revokes_oauth2_tokens

     user = create(:user)
     oauth_access_token = create(:oauth_access_token, :resource_owner_id => user.id)
     assert_equal 1, user.access_tokens.not_expired.count
     user = create(:user)
     oauth_access_token = create(:oauth_access_token, :resource_owner_id => user.id)
     assert_equal 1, user.access_tokens.not_expired.count


@@ -282,4 +304,62 @@ class UserTest < ActiveSupport::TestCase
     oauth_access_token.reload
     assert_predicate oauth_access_token, :revoked?
   end
     oauth_access_token.reload
     assert_predicate oauth_access_token, :revoked?
   end

+
+  def test_deletion_allowed_when_no_changesets
+    with_user_account_deletion_delay(10000) do
+      user = create(:user)
+      assert_predicate user, :deletion_allowed?
+    end
+  end
+
+  def test_deletion_allowed_without_delay
+    with_user_account_deletion_delay(nil) do
+      user = create(:user)
+      create(:changeset, :user => user)
+      user.reload
+      assert_predicate user, :deletion_allowed?
+    end
+  end
+
+  def test_deletion_allowed_past_delay
+    with_user_account_deletion_delay(10) do
+      user = create(:user)
+      create(:changeset, :user => user, :created_at => Time.now.utc - 12.hours, :closed_at => Time.now.utc - 10.hours)
+      user.reload
+      assert_predicate user, :deletion_allowed?
+    end
+  end
+
+  def test_deletion_allowed_during_delay
+    with_user_account_deletion_delay(10) do
+      user = create(:user)
+      create(:changeset, :user => user, :created_at => Time.now.utc - 11.hours, :closed_at => Time.now.utc - 9.hours)
+      user.reload
+      assert_not_predicate user, :deletion_allowed?
+      assert_equal Time.now.utc + 1.hour, user.deletion_allowed_at
+    end
+  end
+
+  def test_deletion_allowed_past_zero_delay
+    with_user_account_deletion_delay(0) do
+      user = create(:user)
+      create(:changeset, :user => user, :created_at => Time.now.utc, :closed_at => Time.now.utc + 1.hour)
+      travel 90.minutes do
+        user.reload
+        assert_predicate user, :deletion_allowed?
+      end
+    end
+  end
+
+  def test_deletion_allowed_during_zero_delay
+    with_user_account_deletion_delay(0) do
+      user = create(:user)
+      create(:changeset, :user => user, :created_at => Time.now.utc, :closed_at => Time.now.utc + 1.hour)
+      travel 30.minutes do
+        user.reload
+        assert_not_predicate user, :deletion_allowed?
+        assert_equal Time.now.utc + 30.minutes, user.deletion_allowed_at
+      end
+    end
+  end

 end
 end