Merge pull request #3491 from tomhughes/legacy-trace

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index c1923e9829983578f92dee99beb8e7fd37cf7e86..8c1ce723c67b165f5c4c9dba4de51d2437358591 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,22 +1,44 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0.
+# on 2022-02-23 19:11:04 UTC using RuboCop version 1.25.1.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 

-# Offense count: 3338
+# Work around erblint issues.
+# https://github.com/openstreetmap/openstreetmap-website/issues/2472
+require:
+  - rubocop-minitest
+  - rubocop-performance
+  - rubocop-rails
+  - rubocop-rake
+
+# Offense count: 550

 # Cop supports --auto-correct.
 # Cop supports --auto-correct.

-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.

 # URISchemes: http, https
 Layout/LineLength:
 # URISchemes: http, https
 Layout/LineLength:

-  Max: 260
+  Max: 270
+
+# Offense count: 62
+# Cop supports --auto-correct.
+Lint/AmbiguousOperatorPrecedence:
+  Exclude:
+    - 'app/controllers/geocoder_controller.rb'
+    - 'app/models/user.rb'
+    - 'lib/bounding_box.rb'
+    - 'lib/osm.rb'
+    - 'lib/rich_text.rb'
+    - 'lib/short_link.rb'
+    - 'test/controllers/api/old_nodes_controller_test.rb'
+    - 'test/lib/short_link_test.rb'

 
 

-# Offense count: 35
+# Offense count: 34

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:

+    - 'app/controllers/accounts_controller.rb'

     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
     - 'app/controllers/application_controller.rb'


@@ -26,27 +48,20 @@ Lint/AssignmentInCondition:
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'app/helpers/browse_tags_helper.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'app/helpers/browse_tags_helper.rb'

-    - 'app/mailers/notifier.rb'
+    - 'app/mailers/user_mailer.rb'

     - 'app/models/client_application.rb'
     - 'lib/nominatim.rb'
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
     - 'app/models/client_application.rb'
     - 'lib/nominatim.rb'
     - 'lib/osm.rb'
     - 'script/deliver-message'
 

-# Offense count: 4
-# Configuration parameters: AllowComments.
-Lint/SuppressedException:
-  Exclude:
-    - 'app/controllers/api/amf_controller.rb'
-    - 'app/controllers/users_controller.rb'
-    - 'app/controllers/site_controller.rb'
-
-# Offense count: 701
+# Offense count: 665
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.

 Metrics/AbcSize:
   Max: 189
 
 Metrics/AbcSize:
   Max: 189
 

-# Offense count: 39
-# Configuration parameters: CountComments, ExcludedMethods.
-# ExcludedMethods: refine
+# Offense count: 73
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine

 Metrics/BlockLength:
   Max: 71
 
 Metrics/BlockLength:
   Max: 71
 


@@ -56,74 +71,56 @@ Metrics/BlockNesting:
   Max: 5
 
 # Offense count: 25
   Max: 5
 
 # Offense count: 25

-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.

 Metrics/ClassLength:
 Metrics/ClassLength:

-  Max: 645
+  Max: 313

 
 

-# Offense count: 74
+# Offense count: 58
+# Configuration parameters: IgnoredMethods.

 Metrics/CyclomaticComplexity:
 Metrics/CyclomaticComplexity:

-  Max: 22
+  Max: 25

 
 

-# Offense count: 722
-# Configuration parameters: CountComments, ExcludedMethods.
+# Offense count: 742
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.

 Metrics/MethodLength:
   Max: 179
 
 Metrics/MethodLength:
   Max: 179
 

-# Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/ModuleLength:
-  Max: 117
-
-# Offense count: 4
-# Configuration parameters: CountKeywordArgs.
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.

 Metrics/ParameterLists:
 Metrics/ParameterLists:

-  Max: 9
+  Max: 6

 
 

-# Offense count: 72
+# Offense count: 59
+# Configuration parameters: IgnoredMethods.

 Metrics/PerceivedComplexity:
 Metrics/PerceivedComplexity:

-  Max: 25
+  Max: 26

 
 

-# Offense count: 6
+# Offense count: 550
+Minitest/MultipleAssertions:
+  Max: 52
+
+# Offense count: 1

 Naming/AccessorMethodName:
   Exclude:
 Naming/AccessorMethodName:
   Exclude:

-    - 'app/controllers/application_controller.rb'

     - 'app/helpers/title_helper.rb'
     - 'app/helpers/title_helper.rb'

-    - 'app/models/old_way.rb'
-    - 'lib/osm.rb'
-    - 'lib/potlatch.rb'

 
 # Offense count: 8
 
 # Offense count: 8

-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.

 # NamePrefix: is_, has_, have_
 # NamePrefix: is_, has_, have_

-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?

 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:

-    - 'spec/**/*'
-    - 'app/models/changeset.rb'
-    - 'app/models/old_node.rb'
-    - 'app/models/old_relation.rb'
-    - 'app/models/old_way.rb'

     - 'app/models/user.rb'
     - 'app/models/user.rb'

-    - 'lib/classic_pagination/pagination.rb'

 
 # Offense count: 5
 
 # Offense count: 5

-# Cop supports --auto-correct.
-Performance/RegexpMatch:
-  Exclude:
-    - 'app/helpers/browse_tags_helper.rb'
-    - 'app/validators/characters_validator.rb'
-    - 'app/validators/whitespace_validator.rb'
-
-# Offense count: 6

 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql
 # Include: db/migrate/*.rb
 Rails/BulkChangeTable:
   Exclude:
     - 'db/migrate/20111116184519_update_oauth.rb'
 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql
 # Include: db/migrate/*.rb
 Rails/BulkChangeTable:
   Exclude:
     - 'db/migrate/20111116184519_update_oauth.rb'

-    - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb'

     - 'db/migrate/20120208194454_add_domain_to_acl.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
     - 'db/migrate/20120208194454_add_domain_to_acl.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 


@@ -135,14 +132,33 @@ Rails/HasAndBelongsToMany:
     - 'app/models/changeset.rb'
     - 'app/models/user.rb'
 
     - 'app/models/changeset.rb'
     - 'app/models/user.rb'
 

-# Offense count: 11
+# Offense count: 3

 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
   Exclude:
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
   Exclude:

-    - 'app/helpers/application_helper.rb'

     - 'app/helpers/title_helper.rb'
     - 'app/helpers/title_helper.rb'

-    - 'app/helpers/trace_helper.rb'
+
+# Offense count: 16
+# Configuration parameters: IgnoreScopes, Include.
+# Include: app/models/**/*.rb
+Rails/InverseOf:
+  Exclude:
+    - 'app/models/changeset.rb'
+    - 'app/models/diary_entry.rb'
+    - 'app/models/friendship.rb'
+    - 'app/models/issue.rb'
+    - 'app/models/message.rb'
+    - 'app/models/note.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: app/controllers/**/*.rb
+Rails/LexicallyScopedActionFilter:
+  Exclude:
+    - 'app/controllers/oauth2_applications_controller.rb'
+    - 'app/controllers/oauth2_authorizations_controller.rb'

 
 # Offense count: 5
 # Configuration parameters: Include.
 
 # Offense count: 5
 # Configuration parameters: Include.


@@ -155,60 +171,33 @@ Rails/NotNullColumn:
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 

-# Offense count: 18
+# Offense count: 9

 Rails/OutputSafety:
   Exclude:
 Rails/OutputSafety:
   Exclude:

+    - 'app/controllers/sessions_controller.rb'

     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'

-    - 'app/helpers/changesets_helper.rb'
-    - 'app/helpers/geocoder_helper.rb'
-    - 'app/helpers/note_helper.rb'
-    - 'app/helpers/open_graph_helper.rb'
-    - 'app/helpers/user_blocks_helper.rb'

     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 

-# Offense count: 94
+# Offense count: 6

 # Cop supports --auto-correct.
 # Cop supports --auto-correct.

-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: AllowedChars.
-Style/AsciiComments:
+Rake/Desc:

   Exclude:
   Exclude:

-    - 'test/models/message_test.rb'
+    - 'lib/tasks/auto_annotate_models.rake'
+    - 'lib/tasks/eslint.rake'
+    - 'lib/tasks/subscribe_diary_authors.rake'
+    - 'lib/tasks/subscribe_old_changesets.rake'

 
 

-# Offense count: 27
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: annotated, template, unannotated
-Style/FormatStringToken:
-  Exclude:
-    - 'app/models/concerns/geo_record.rb'
-    - 'app/views/api/map/_bounds.xml.builder'
-    - 'lib/bounding_box.rb'
-    - 'test/controllers/api/map_controller_test.rb'
-    - 'test/controllers/api/relations_controller_test.rb'
-    - 'test/controllers/api/ways_controller_test.rb'
-    - 'test/lib/bounding_box_test.rb'
-
-# Offense count: 539
+# Offense count: 617

 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.

-# SupportedStyles: always, never
+# SupportedStyles: always, always_true, never

 Style/FrozenStringLiteralComment:
   Enabled: false
 
 Style/FrozenStringLiteralComment:
   Enabled: false
 

-# Offense count: 2
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'app/controllers/api/ways_controller.rb'
-
-# Offense count: 70
+# Offense count: 72

 # Cop supports --auto-correct.
 # Cop supports --auto-correct.

-# Configuration parameters: Strict.
+# Configuration parameters: Strict, AllowedNumbers.

 Style/NumericLiterals:
 Style/NumericLiterals:

-  MinDigits: 11
+  MinDigits: 15